diff options
author | Christian Kandeler <christian.kandeler@qt.io> | 2018-08-09 13:53:53 +0200 |
---|---|---|
committer | Christian Kandeler <christian.kandeler@qt.io> | 2018-08-10 07:51:07 +0000 |
commit | 349baf79883a96fdd85325a2900997fbf574f9a8 (patch) | |
tree | 583af5ffaf4df48fa7a7a355eb3b91b461d28cab /tests/auto/blackbox/tst_blackbox.h | |
parent | 1e9c7c948c8c8b896434484d047d12efc93a2342 (diff) |
Fix potential false caching of module prototypes
Our code assumed that products with the same profile and the same
multiplex configuration would also evaluate a module's condition to the
same value, which is not true: Properties such as qbs.architecture,
which are commonly checked in module conditions, can be set in a product
item independently of multiplexing.
We now evaluate the module condition for every product. According to our
benchmarker, the slowdown is a very modest 2% and does not appear to
increase for larger projects.
This patch amends 08ce978733, which tried to address the same problem,
but succeeded only for a subset of the possible cases.
Change-Id: I992e0f0d5cf207949cf5d863f242b9476ecdfc05
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Diffstat (limited to 'tests/auto/blackbox/tst_blackbox.h')
-rw-r--r-- | tests/auto/blackbox/tst_blackbox.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/auto/blackbox/tst_blackbox.h b/tests/auto/blackbox/tst_blackbox.h index 87a6b1006..0dcfc5b31 100644 --- a/tests/auto/blackbox/tst_blackbox.h +++ b/tests/auto/blackbox/tst_blackbox.h @@ -170,6 +170,7 @@ private slots: void missingDependency(); void missingProjectFile(); void missingOverridePrefix(); + void moduleConditions(); void movedFileDependency(); void multipleChanges(); void multipleConfigurations(); |