diff options
author | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-02-20 09:39:09 +0100 |
---|---|---|
committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-02-21 15:32:32 +0000 |
commit | 1d479510cae797f875b53e6a3d11af94de675ab8 (patch) | |
tree | a0b465dbe1641593cc2511aad2d37b6e9f0302d2 /tests/benchmarker | |
parent | 4146f1067905c3718b0504b510367bb4349b4622 (diff) |
Replace non-const calls to temporaries with const
This fixes -Wclazy-detaching-temporary
Change-Id: I3c866c29c05f16e93eb86551efb21ccf9dc120b9
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'tests/benchmarker')
-rw-r--r-- | tests/benchmarker/commandlineparser.cpp | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/tests/benchmarker/commandlineparser.cpp b/tests/benchmarker/commandlineparser.cpp index 97b127d94..7c7e1a9c7 100644 --- a/tests/benchmarker/commandlineparser.cpp +++ b/tests/benchmarker/commandlineparser.cpp @@ -78,9 +78,9 @@ void CommandLineParser::parse() << oldCommitOption << newCommitOption << testProjectOption << qbsRepoOption; for (const QCommandLineOption &o : mandatoryOptions) { if (!parser.isSet(o)) - throwException(o.names().front(), parser.helpText()); + throwException(o.names().constFirst(), parser.helpText()); if (parser.value(o).isEmpty()) - throwException(o.names().front(), QString(), parser.helpText()); + throwException(o.names().constFirst(), QString(), parser.helpText()); } m_oldCommit = parser.value(oldCommitOption); m_newCommit = parser.value(newCommitOption); @@ -99,7 +99,9 @@ void CommandLineParser::parse() } else if (activityString == nullBuildActivity()) { m_activities |= ActivityNullBuild; } else { - throwException(activitiesOption.names().front(), activityString, parser.helpText()); + throwException(activitiesOption.names().constFirst(), + activityString, + parser.helpText()); } } m_regressionThreshold = 5; @@ -108,7 +110,9 @@ void CommandLineParser::parse() const QString rawThresholdValue = parser.value(thresholdOption); m_regressionThreshold = rawThresholdValue.toInt(&ok); if (!ok) - throwException(thresholdOption.names().first(), rawThresholdValue, parser.helpText()); + throwException(thresholdOption.names().constFirst(), + rawThresholdValue, + parser.helpText()); } } |