diff options
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/corelib/buildgraph/projectbuilddata.cpp | 4 | ||||
| -rw-r--r-- | src/lib/corelib/language/moduleloader.cpp | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/lib/corelib/buildgraph/projectbuilddata.cpp b/src/lib/corelib/buildgraph/projectbuilddata.cpp index ccb6c5123..dcb10b45b 100644 --- a/src/lib/corelib/buildgraph/projectbuilddata.cpp +++ b/src/lib/corelib/buildgraph/projectbuilddata.cpp @@ -280,7 +280,7 @@ void BuildDataResolver::resolveBuildData(const TopLevelProjectPtr &resolvedProje const std::vector<ResolvedProductPtr> &allProducts = resolvedProject->allProducts(); evalContext->initializeObserver(Tr::tr("Setting up build graph for configuration %1") .arg(resolvedProject->id()), int(allProducts.size()) + 1); - for (ResolvedProductPtr rProduct : allProducts) { + for (const auto &rProduct : allProducts) { if (rProduct->enabled) resolveProductBuildData(rProduct); evalContext->incrementProgressValue(); @@ -392,7 +392,7 @@ void BuildDataResolver::resolveProductBuildData(const ResolvedProductPtr &produc product->buildData.reset(new ProductBuildData); ArtifactSetByFileTag artifactsPerFileTag; - for (ResolvedProductPtr dependency : qAsConst(product->dependencies)) { + for (const auto &dependency : qAsConst(product->dependencies)) { QBS_CHECK(dependency->enabled); resolveProductBuildData(dependency); } diff --git a/src/lib/corelib/language/moduleloader.cpp b/src/lib/corelib/language/moduleloader.cpp index 74d62c818..882ac7061 100644 --- a/src/lib/corelib/language/moduleloader.cpp +++ b/src/lib/corelib/language/moduleloader.cpp @@ -599,7 +599,7 @@ void ModuleLoader::handleTopLevelProject(ModuleLoaderResult *loadResult, Item *p for (Item * const exportItem : m_exportsWithDeferredDependsItems) normalizeDependencies(nullptr, DeferredDependsContext(nullptr, exportItem)); - for (const auto deferredDependsData : m_productsWithDeferredDependsItems) { + for (const auto &deferredDependsData : m_productsWithDeferredDependsItems) { ProductContext * const productContext = deferredDependsData.first; m_reader->setExtraSearchPathsStack(productContext->project->searchPathsStack); try { @@ -1877,7 +1877,7 @@ static void adjustParametersScopes(Item *item, Item *scope) return; } - for (auto value : item->properties()) { + for (const auto &value : item->properties()) { if (value->type() != Value::ItemValueType) continue; adjustParametersScopes(std::static_pointer_cast<ItemValue>(value)->item(), scope); @@ -3415,7 +3415,7 @@ void ModuleLoader::instantiateModule(ProductContext *productContext, Item *expor } // For foo.bar in modulePrototype create an item foo in moduleInstance. - for (auto iip : instanceItemProperties(modulePrototype)) { + for (const auto &iip : instanceItemProperties(modulePrototype)) { if (iip.second->item()->properties().empty()) continue; qCDebug(lcModuleLoader) << "The prototype of " << moduleName |