| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
These must not be searched for recursively. For instance, if such a
property is set to different values in different instantiating modules,
there is no sensible heuristic which value should be used. The current
implementation just takes the one found first, which is just as wrong as
any other solution that looks beyond what is set directly in the product
or artifact.
Change-Id: I65c29538a437872e2d1e1c4043f2c5cfa301ebb9
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
| |
Task-number: QBS-442
Change-Id: I6f08ca595665fca35451027c79be99f5ebcefb9f
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
|
|
| |
The lib version number must be taken into account.
Change-Id: Ic97dc43ef526e8f528c94ed15d92e498b143fc7d
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
| |
Change-Id: Idd750eca86e123e01a61b68046115b54e951ae40
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
| |
Change-Id: I2a8ebd755ab2c12c0b0f3ca97a5ee48184674e8d
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
The "raw backslash" case does not add anything of use, and most likely
produces invalid C++.
Change-Id: I6d86d2e3a9a4cb3ff7682c5e97475c3e7d5a1c6b
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
| |
Task-number: QBS-203
Change-Id: I1f0bd6b3861e3887a21088f0dea4d24b83c0736e
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
|
|
|
|
| |
These missing descriptions are the cause for weird empty lines appearing
in Qt Creator's compile output.
Change-Id: I67af9adf816496595d5fd3d8bdb372e06aa7c8b1
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
Such files should be considered C++, not C.
Change-Id: Ifc9608eb5196b250694f0dec2a769a1f65c11a79
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
When first creating a FileTagger object, we implicitly set the pattern
syntax to "RegExp". On restoring, we set it to "WildCard".
We now use wildcards always, as the documentation says.
Note that the only reason the bug has not manifested itself yet is that
the shortcut in FileInfo::globMatches() catches all our existing file
tags.
Change-Id: Ibedb54fb3a890ae6ab35a8f073d85cc4ebfc36bc
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
Currently compiles without, but that's a coincidence.
Change-Id: Ifc48a2bdef3b71ab49771678ba1c1aa0a152c03a
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
| |
Change-Id: I1a1e68e1e866bde33e6002125eb79eff20e52c88
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
|
| |
Change-Id: Iba2a19d182da70b761f33532d47b0c43dfbf6ae5
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
|
|
|
|
|
|
|
|
|
| |
Turn some manual tests that add coverage of a feature into autotests.
Turn some manual tests that demonstrate a feature into examples.
Remove some manual tests that do neither.
Change-Id: Ie54005e1ba5aad07319eb864cc5ad70e26308080
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
|
| |
The old name is grammatically incorrect and also not descriptive enough.
The new one is also consistent with the project and product
properties that amend the respective setting.
Change-Id: I7be6b3d986fdb1f232623bf9b471ab21e04ed9f2
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
The current code is too simplistic in that it just pretends the whole
configuration was explicitly set on the command line. This can lead to
precedence problems regarding module properties set in project files and
profiles.
Change-Id: I50113486159308a9660be7b86d2e2240527df73e
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
The build config we serialized did not contain overridden values.
Change-Id: Ie2841466dc49ad67e7b8f397398533e0e13df207
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
|
|
|
|
| |
There were two bugs:
- For a static build, the library was not installed.
- For a shared build, the symlinks were not installed.
Change-Id: Ib34b733ca59d6ad27b91663ed0527ed50ef6aa99
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
"property path" is wrong for these; they're just strings.
Change-Id: I050b937ee213441a1d19e48a60eef58cfa6b3ba7
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
| |
Change-Id: Ia06fdf283b74d3d1b5418d1752a0fa717fca08d4
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
|
|
|
|
| |
Now it's an error to pass nonsense like project.blubb:1
on the command line.
Task-number: QBS-431
Change-Id: I1e2128bce953b7acef4abe0fd09808ba1f71d1f9
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
cpp.platformDefines is dependent on properties that are set in the
product's or a group's instance of cpp. Therefore we must not combine
the values of this property from the input and its dependencies.
Task-number: QBS-433
Change-Id: Id90ffc9d8193d8425e62ffc3d0b1d3cca83f8dff
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
|
|
| |
Change-Id: I57fbbd66e500a8172346acf45f84350c7ebb394c
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
| |
Change-Id: I6a5d57b2ec0cfb5ca3eaf0e261a1b60f90c08258
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
| |
Change-Id: I5c27ee33bf022784da88dbfc55045621be78c68c
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
|
| |
That's what the documentation claims and it reduces the need for
undefined-checks in code that uses this property.
Task-number: QBS-429
Change-Id: Iee65c4bf5b772bc235d185c91cc478f96d7def91
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
When not doing that, the number of redundant linker arguments can reach
enormous values rather quickly. For instance, the size of Qt Creator's
build graph on Linux goes down by 10 per cent due to this change.
Task-number: QBS-435
Change-Id: I772fc6a6c90696b5d0a3e0ebd65315cf0773552f
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
| |
Change-Id: I217eac496994fdddf6a4577bddd79f3d76bba450
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
These are mostly former manual tests that seem useful for
demonstrating some feature to learners.
Change-Id: I06d895ebdee1280699416cf4930a08602951aaf7
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
Don't let QProcess::waitForFinished() time out. We cannot know how long
the invoked application will run.
Change-Id: Ibfe6fdf86beb45ff5f551537c614b8cb2a6d8407
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
The current code calls into the Qt event system from the interrupt
handler, which will lead to a deadlock if the interrupt came in during
event handling. Change to an approach that does only minimal work in the
interrupt handler.
Change-Id: Ic4e615939305390efd819b47fa02c7fadb6acf16
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
|
| |
The file system access is expensive. As a result, the "UiImport" visitor
function showed up prominently on callgrind's heat map. Now it doesn't.
Change-Id: I3a37fa2b6d4abc29bb9c25776b86a485f647afce
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
Strangely, no such check exists currently. Instead, one will typically
get an internal error on the artifact level later on.
Change-Id: Id9cd749a70564100bd7286b896f64cafbe9bfb73
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
| |
s/throw/return, which the author obviously intended to write.
Change-Id: I3093352adecd6e1d7bda52c89d02c57e7dac3b58
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
| |
Change-Id: I6a1194981bf6f679ac931a9871281c4866f3bd20
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
| |
Makes it less abstract.
Change-Id: I1ba0636afd5454ad58099e7be868f2968d338f74
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
| |
Change-Id: I3eea1f0ef0da789550fba046e1f806b29bae3a6d
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
| |
They are currently ignored.
Change-Id: I94b89f9b7c6838106670d553429b297823ac861f
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
| |
Task-number: QBS-409
Change-Id: I7cd6942626e2543e8e4f75ee10f499d8f1f25e81
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
When setting VERSION, qmake adds the major version number to the lib
name on Windows. We need to take this into account in use.pri.
Change-Id: I45ed925cb6b0de8528ab3c025da7b3d269651d8c
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
| |
Change-Id: I6374e4d8153e2de390f408454c650c21de57a175
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
Currently, the project version has no effect on the
library name on Unix systems.
Change-Id: I7a76a0d127fc47170cf05c888cc3ee92e5c44395
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
|
| |
The current implementation is bogus, and the "correct-looking way"
(using product.moduleProperty) does not work either.
This is another victim of QBS-370.
Change-Id: I5d7fa13def32ee4a8aee73755552505b1e9ab28d
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
| |
Change-Id: I96728e0919e596cb08da0eda4643c0894750fe9f
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
Now lists the recognized qmake CONFIG options.
Change-Id: I183f97624566870e6b4d59d0c9e7f4fcb266e54f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
|
|
|
| |
The fewer false positives are reported by tools like valgrind, the
easier it gets to spot actual leaks.
Change-Id: Ic7c73d48715d0899ad910088d44825988fa5b34a
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
We must check the product's condition after the modules are loaded,
because the condition might depend on module properties.
Change-Id: I5b6dbe1d20f823ba0ab259e66744c4d4b25f1a96
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
|
|
|
|
| |
Currently, removing a directory specified as "dir/" fails, because the
file name is empty according to Qt logic. Therefore, remove such
trailing slashes first.
Change-Id: I3e5e3c9536dbdf9d20d56f9b19b4d30473161cb7
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
|
|
|
|
|
|
|
|
| |
Special base module properties like hostOS were not available in
Module.validate.
Change-Id: I14f506dea2eb10edc726dd5a789e04e97f06f9a5
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|
|
|
|
|
|
|
| |
Also, do the setup only once and not for cache hits.
Change-Id: I784d5127a3a7a89f605b18c697ce8a53f11171b9
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
|