From 7ac5675cf6d1e9f20f115bc5b1f66fb64f46d087 Mon Sep 17 00:00:00 2001
From: Ivan Komissarov <ABBAPOH@gmail.com>
Date: Sat, 20 Aug 2022 17:03:54 +0200
Subject: clang-tidy: fix 'performance-implicit-conversion-in-loop'

Change-Id: I7ca65f27fb30326e6013925a23e0a78ef1de7a5e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
---
 src/app/qbs/session.cpp                | 6 +++---
 src/lib/corelib/tools/buildoptions.cpp | 4 ++--
 src/lib/corelib/tools/msvcinfo.cpp     | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/app/qbs/session.cpp b/src/app/qbs/session.cpp
index 5a1fe145d..c958c88b6 100644
--- a/src/app/qbs/session.cpp
+++ b/src/app/qbs/session.cpp
@@ -554,7 +554,7 @@ void Session::getGeneratedFilesForSources(const QJsonObject &request)
     reply.insert(StringConstants::type(), QLatin1String(replyType));
     const QJsonArray specs = request.value(StringConstants::productsKey()).toArray();
     QJsonArray resultProducts;
-    for (const QJsonValue &p : specs) {
+    for (const auto &p : specs) {
         const QJsonObject productObject = p.toObject();
         const ProductData product = getProductByName(
                     productObject.value(StringConstants::fullDisplayNameKey()).toString());
@@ -564,7 +564,7 @@ void Session::getGeneratedFilesForSources(const QJsonObject &request)
         resultProduct.insert(StringConstants::fullDisplayNameKey(), product.fullDisplayName());
         QJsonArray results;
         const QJsonArray requests = productObject.value(QLatin1String("requests")).toArray();
-        for (const QJsonValue &r : requests) {
+        for (const auto &r : requests) {
             const QJsonObject request = r.toObject();
             const QString filePath = request.value(QLatin1String("source-file")).toString();
             const QStringList tags = fromJson<QStringList>(request.value(QLatin1String("tags")));
@@ -646,7 +646,7 @@ Session::FileUpdateData Session::prepareFileUpdate(const QJsonObject &request)
         data.error = tr("Product '%1' not found in project.").arg(productName);
     }
     const QJsonArray filesArray = request.value(QLatin1String("files")).toArray();
-    for (const QJsonValue &v : filesArray)
+    for (const auto &v : filesArray)
         data.filePaths << v.toString();
     if (m_currentJob)
         data.error = tr("Cannot update the list of source files while a job is running.");
diff --git a/src/lib/corelib/tools/buildoptions.cpp b/src/lib/corelib/tools/buildoptions.cpp
index e4e9ba17f..cc3ef7557 100644
--- a/src/lib/corelib/tools/buildoptions.cpp
+++ b/src/lib/corelib/tools/buildoptions.cpp
@@ -413,8 +413,8 @@ template<> JobLimits fromJson(const QJsonValue &limitsData)
 {
     JobLimits limits;
     const QJsonArray &limitsArray = limitsData.toArray();
-    for (const QJsonValue &v : limitsArray) {
-        const QJsonObject limitData = v.toObject();
+    for (const auto &value : limitsArray) {
+        const QJsonObject limitData = value.toObject();
         QString pool;
         int limit = 0;
         setValueFromJson(pool, limitData, "pool");
diff --git a/src/lib/corelib/tools/msvcinfo.cpp b/src/lib/corelib/tools/msvcinfo.cpp
index b770b6f46..973284b2b 100644
--- a/src/lib/corelib/tools/msvcinfo.cpp
+++ b/src/lib/corelib/tools/msvcinfo.cpp
@@ -356,8 +356,8 @@ static std::vector<MSVCInstallInfo> retrieveInstancesFromVSWhere(
         return result;
     }
     const auto jsonArray = jsonOutput.array();
-    for (const QJsonValue &v : jsonArray) {
-        const QJsonObject o = v.toObject();
+    for (const auto &value : jsonArray) {
+        const QJsonObject o = value.toObject();
         MSVCInstallInfo info;
         info.version = o.value(QStringLiteral("installationVersion")).toString();
         if (productType == ProductType::BuildTools) {
-- 
cgit v1.2.3