From 94a097d95e9bfe485cebd7a5a9acd56301c54f04 Mon Sep 17 00:00:00 2001 From: hjk Date: Mon, 29 Jul 2019 14:37:58 +0200 Subject: Avoid uses of Java-style iterators Change-Id: I90cece156033b5d223a86016401a2199f5b6c11e Reviewed-by: Christian Kandeler --- src/lib/corelib/generators/generatordata.h | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/src/lib/corelib/generators/generatordata.h b/src/lib/corelib/generators/generatordata.h index b6200339e..da65815ad 100644 --- a/src/lib/corelib/generators/generatordata.h +++ b/src/lib/corelib/generators/generatordata.h @@ -72,21 +72,15 @@ template struct IMultiplexableContainer { void forEach(const std::function &func) const { - QMapIterator it(data); - while (it.hasNext()) { - it.next(); + for (auto it = data.cbegin(), end = data.cend(); it != end; ++it) func(it.key(), it.value()); - } } void forEach(const std::function &func) const { - QMapIterator it(data); - while (it.hasNext()) { - it.next(); + for (auto it = data.cbegin(), end = data.cend(); it != end; ++it) func(it.key().toStdString(), it.value()); - } } const U operator[](const QString &configurationName) const @@ -147,21 +141,15 @@ struct QBS_EXPORT GeneratableProject : public GeneratableProjectData { void forEach(const std::function &func) const { - QMapIterator it(projects); - while (it.hasNext()) { - it.next(); + for (auto it = projects.cbegin(), end = projects.cend(); it != end; ++it) func(it.key(), it.value()); - } } void forEach(const std::function &func) const { - QMapIterator it(projects); - while (it.hasNext()) { - it.next(); + for (auto it = projects.cbegin(), end = projects.cend(); it != end; ++it) func(it.key().toStdString(), it.value()); - } } const Project operator[](const QString &configurationName) const -- cgit v1.2.3