From 9d859d78bdf4b07ac78782ddcd1905ebf5e49605 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 20 Jun 2018 11:27:16 +0200 Subject: Consider Transformer::explicitlyDependsOn when disconnecting artifacts This was forgotten in d0e8197bbf. As a result, transformers could hold references to invalid artifacts, resulting in a crash when storing the build graph. Change-Id: I6af0d15d0c0ad44f1f9011c88e413f327a05943d Reviewed-by: Joerg Bornemann --- src/lib/corelib/buildgraph/projectbuilddata.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/corelib/buildgraph/projectbuilddata.cpp b/src/lib/corelib/buildgraph/projectbuilddata.cpp index 67228d35d..87e79c7b9 100644 --- a/src/lib/corelib/buildgraph/projectbuilddata.cpp +++ b/src/lib/corelib/buildgraph/projectbuilddata.cpp @@ -171,6 +171,7 @@ static void disconnectArtifactParents(Artifact *artifact) QBS_CHECK(parentArtifact->transformer); parentArtifact->childrenAddedByScanner.remove(artifact); parentArtifact->transformer->inputs.remove(artifact); + parentArtifact->transformer->explicitlyDependsOn.remove(artifact); parentArtifact->product->registerArtifactWithChangedInputs(parentArtifact); } -- cgit v1.2.3