From a63f034c73bc7534c31fdfd892a9b666e96e2cdb Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Tue, 10 Oct 2017 14:35:16 +0200 Subject: Do not reset the "canceled" state when initializing an observer We never re-use a canceled observer, and resetting can lead to race conditions in build jobs. Task-number: QBS-1210 Change-Id: Ifab79b614c448d2fffc20395934405711524a30f Reviewed-by: Jake Petroules --- src/lib/corelib/api/internaljobs.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lib/corelib/api/internaljobs.cpp b/src/lib/corelib/api/internaljobs.cpp index fc5efc1da..f6bcba765 100644 --- a/src/lib/corelib/api/internaljobs.cpp +++ b/src/lib/corelib/api/internaljobs.cpp @@ -82,7 +82,6 @@ private: m_timedLogger = new TimedActivityLogger(m_job->logger(), task, true); m_value = 0; m_maximum = maximum; - m_canceled = false; emit m_job->newTaskStarted(task, maximum, m_job); } -- cgit v1.2.3