From 861c81ab8603a01c23e97543837670503538119e Mon Sep 17 00:00:00 2001 From: Ivan Komissarov Date: Sun, 24 Nov 2019 16:14:53 +0900 Subject: Fix 'performance-unnecessary-value-param' warnings Use more pass-by-const-ref since there is no point in passing objects by value in these cases Also, treat this warning as error Change-Id: I5382dcd56639f535cf240205cc5c3ac667c4ece3 Reviewed-by: Christian Kandeler --- examples/grpc/client.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'examples') diff --git a/examples/grpc/client.cpp b/examples/grpc/client.cpp index 55bcd866d..8fee915fb 100644 --- a/examples/grpc/client.cpp +++ b/examples/grpc/client.cpp @@ -51,7 +51,7 @@ class Client { public: - Client(std::shared_ptr channel) + Client(const std::shared_ptr &channel) : m_stub(PP::MyApi::NewStub(channel)) {} int ping(int count) { -- cgit v1.2.3