From 800f4287193aa76e0735051a38cf226244a31e5c Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Mon, 19 Dec 2016 18:44:15 +0100 Subject: Artifact scanning: Do not store pointers to temporary data Change-Id: I4f1fddd578c94318c0d2a0465221d8ce557d5e91 Reviewed-by: Joerg Bornemann --- src/lib/corelib/buildgraph/inputartifactscanner.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/lib/corelib/buildgraph/inputartifactscanner.cpp') diff --git a/src/lib/corelib/buildgraph/inputartifactscanner.cpp b/src/lib/corelib/buildgraph/inputartifactscanner.cpp index 882b9627c..cdf38b247 100644 --- a/src/lib/corelib/buildgraph/inputartifactscanner.cpp +++ b/src/lib/corelib/buildgraph/inputartifactscanner.cpp @@ -168,8 +168,8 @@ void InputArtifactScanner::scanForFileDependencies(Artifact *inputArtifact) const QSet scanners = scannersForArtifact(inputArtifact); if (scanners.isEmpty()) return; - m_fileTagsForScanner = inputArtifact->fileTags().toStringList().join(QLatin1Char(',')) - .toLatin1().constData(); + m_fileTagsForScanner + = inputArtifact->fileTags().toStringList().join(QLatin1Char(',')).toLatin1(); while (!filesToScan.isEmpty()) { FileResourceBase *fileToBeScanned = filesToScan.takeFirst(); const QString &filePathToBeScanned = fileToBeScanned->filePath(); @@ -363,7 +363,7 @@ void InputArtifactScanner::scanWithScannerPlugin(DependencyScanner *scanner, ScanResultCache::Result *scanResult) { const QStringList &dependencies - = scanner->collectDependencies(fileToBeScanned, m_fileTagsForScanner); + = scanner->collectDependencies(fileToBeScanned, m_fileTagsForScanner.constData()); for (const QString &s : dependencies) scanResult->deps += ScanResultCache::Dependency(s); scanResult->valid = true; -- cgit v1.2.3