| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was reproduced when you had 5 items (2 pages)
and removed one item from the first page. Not sure the exact
source of the problem but it seems to be Qt5-related (I'll try
to reduce into a small test case). As this bug is critical, it's
better to land as is and figure out the bug later.
The fix is to change our Repeater to load the maximum number of
pages, rather than creating as we need. I've also removed the
previous behavior of empty slots and now all the pages are created
once with empty slots and this layer is put behind the occupied slots.
Reviewed-by: Marcelo Lira
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixed the BookmarkModel, that was failing in two of the existing
tests.
BookmarkModel::insert method now also saves the timestamp of the
saved bookmark.
I'll not even talk about BookmarkModel::update method, it was missing
everything. See the diff.
Reviewed-by: Hugo Parente Lima
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling "beginRemoveRows(...)" and "endRemoveRows()" methods should've been
enough for the view to adapt to removal changes, instead of having to emit a
"dataChanged(...)" signal as well. Nevertheless, The combined use of a QML Repeater
item with RowsRangeFilter, our custom QSortFilterProxyModel, has showed unable to
tackle the changes to the model, resulting in strange UI behavior.
This may have something to do with QQuickRepeater::setModel() not connecting
the model (our RowsRangeFilter) to the "destroyingItem(...)" signal, whose lines
where commented out in qt5/qtdeclarative/src/quick/items/qquickrepeater.cpp
since time immemorial (not shows on the git history).
For now I just fixed the index of the last item in the range of altered items.
Reviewed-by: Hugo Parente Lima
|
|
|
|
|
|
|
|
|
|
|
|
| |
A dataChanged signal is not meant to be used when removing a row,
because the inner workings of a model expect to operate over a
still existing row, and insert it back on the model.
Without this patch you can see Snowshoe crashing by opening 5 tabs
(or any number whose modulo by 4 is 1; 4 is not magical, just the
number of tabs per page on the paged grid) and closing one.
Reviewed-by: Rafael Brandão
|
|
|
|
| |
Reviewed-by: Trust me. No, seriously.
|
|
|
|
| |
Reviewed-by: Trust me
|
|
|
|
|
|
|
|
| |
Before this fix an empty paged grid would show empty slots to the
left, as if it was a previous empty page, and the slots in the
central page would appear slightly unaligned.
Reviewed-by: Rafael Brandão
|
|
|
|
|
|
|
|
|
|
| |
At the moment it only returns a placeholder image, since we can't
get web page thumbnails yet.
Also changed the usage of "screenshot" in TabsModel to the more
specific "thumbnail" term.
Reviewed-by: Hugo Parente Lima
|
|
|
|
|
| |
Reviewed-by: Hugo Parente Lima
Rafael Brandão
|
|
|
|
|
|
|
|
| |
This makes things more regular and easy to change. Besides, seems
aesthetically pleasant, and that's worth something.
Reviewed-by: Hugo Parente Lima
Rafael Brandão
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the code for the open tabs pager was sparsely found
inside the NavigationPanel, this code was moved to a TabsPanel
component, in an imitation of the TopSitesPanel component.
The TabsPanel is now instantiated on Main, as a sibling of
NavigationPanel, instead of residing inside it.
Reviewed-by: Hugo Parente Lima
Rafael Brandão
|
|
|
|
|
|
| |
That's for the sake of clarity.
Reviewed-by: Trust me
|
|
|
|
|
|
|
|
|
|
| |
The transition dealt with the panel toggle and the plus button,
they would slide out of the screen when not needed anymore.
The transition lacked grace, and was there just because (not on
any design spec), so it was removed in favor of the opacity fade
already used everywhere else.
Reviewed-by: Anderson Schimuneck
|
|
|
|
| |
Reviewed-by: Hugo Parente Lima
|
|
|
|
|
|
|
| |
These will be used while thumbnails of websites can not be used.
Also removed assets obsoleted by these new ones.
Reviewed-by: Hugo Parente Lima
|
|
|
|
| |
Reviewed-by: Hugo Parente Lima
|
|
|
|
|
|
| |
That's just polite, being it a model.
Reviewed-by: Luciano Wolf
|
|
|
|
|
|
|
|
|
|
|
|
| |
So says the Qt documentation, plus one less warning from
QSortFilterProxyModel.
For the healthly curious the warning was:
"inconsistent changes reported by source model".
And it happened when removing from top sites one item that
was not the last.
Reviewed-by: Luciano Wolf
|
|
|
|
|
|
|
| |
With this fix our UI can respond to removal events in the bookmark
storage.
Reviewed-by: Rafael Brandão
|
|
|
|
|
|
| |
page load" state.
Reviewed-by: Marcelo Lira
|
|
|
|
|
|
|
|
| |
When the tabs pager has more than one page and the user closes
all the tabs there, the pager should automatically scroll to the
last page.
Reviewed-by: Rafael Brandão
|
|
|
|
| |
Reviewed-by: Luciano Wolf
|
|
|
|
|
|
|
| |
Now using a smaller overlay since we don't have pin buttons
any more on "Tabs" screen, just on "My Sites".
Reviewed by: Marcelo Lira
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously there was three states for the navigation toolbar in the
bottom of the screen:
1. Only the tab indicators (the little circles).
2. The tab indicators and the url entry.
3. The tab indicators, the url entry and option buttons.
The state #2 was removed for the sake of simplicity.
Reviewed-by: Luciano Wolf
|
|
|
|
| |
Reviewed-by: Rafael Brandão
|
|
|
|
|
|
|
| |
It was complaining about a "Binding loop detected for property "visible""
on line 66. Now we use a property to link both components.
Reviewed by: Hugo Parente
|
|
|
|
|
|
|
|
| |
The new toolbar goes below navigation bar.
Buttons added: "Share" and "Settings"
Buttons modified: "Favorite" becomes "Pin"
Reviewed by: Rafael Brandao
|
|
|
|
|
|
|
|
| |
Put a page with empty slots behind the last page with actual items
and also display a new one (also filled with empty slots) to the right
of the last page when we didn't reach the limit of pages yet.
Reviewed-by: Hugo Parente Lima
|
|
|
|
| |
Reviewed-by: Trust me
|
|
|
|
|
|
|
|
|
|
| |
Swipe left and right to move through open tabs, click in the
SwipeArea to go back to fullscreen view.
The SwipeArea is in fact transparent, so the user will be under
the impression of interacting with the WebView.
Reviewed-by: Hugo Parente Lima
|
|
|
|
| |
Reviewed-by: Hugo Parente Lima
|
|
|
|
| |
Reviewed-by: Marcelo Lira
|
|
|
|
| |
Reviewed-by: Marcelo Lira
|
|
|
|
| |
Reviewed-by: Rafael Brandão
|
|
|
|
|
|
|
|
| |
This way we could use the same mechanism to display thumbs
for both favorites (aka topsites) and opened tabs.
Reviewed-by: Caio Oliveira
Hugo Parente Lima
|
|
|
|
|
|
|
|
| |
Now we need a QAbstractItemModel to fill the PagedGrid so the previous
model in javascript needed to be implemented like the rest of our models.
Reviewed-by: Caio Oliveira
Hugo Parente Lima
|
|
|
|
|
|
|
|
| |
When the status is invalid no matter if the item is active or not, this
is used to show in the UI how many items he could have, so the non-used
slots are marked as invalid.
Reviewed-by: Rafael Brandão
|
|
|
|
|
|
|
|
|
|
|
| |
According to Qt documentation the default value of
preferredMinimumContentsWidth is now zero, not suitable for mobile
screens, 980 is a magical number that proved to work great on the
majority of websites.
The default value of devicePixelRatio is 1, but 1.5 show better
results on N9 screen.
Reviewed-by: Jesus Sanchez-Palencia
|
|
|
|
| |
Reviewed-by: Trust me
|
|
|
|
| |
Reviewed-by: Trust me
|
|
|
|
| |
Reviewed-by: Trust me.
|
|
|
|
|
|
|
|
|
|
|
| |
reportContentOrientationChange has no effect when running
on the desktop, so moving it to the harmattan-specific portion.
Also there were some problems with the bottom ToolBar appearing
at the first screen (only and randomly) when reportContent...
is called *after* loading the QML sources.
Reviewed-by: Alexis Menard
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The content's orientation was fixed on qtbase but
it still does not show when not swiping on portrait mode,
appearing just its empty black space. When swiping the
system status bar appears correctly.
Reverting the hack at least fixes the screen dimension
problems that appeared when it was hidden.
Also updated BrowserWindowMobile to report its orientation
following the new orientation API.
Reviewed-by: Rafael Brandão
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix Snowshoe for the recent Qt5 / WK update.
The :/ syntax is for file names not URLs, and functions that take urls
expect the qrc:/// syntax. This is documented in
http://doc-snapshot.qt-project.org/5.0/qml-url.html
This patch makes all the references to Qt resource files to use
qrc:/// syntax.
Reviewed-by: Jesus Sanchez-Palencia
|
|
|
|
| |
Reviewed-by: Hugo Parente Lima
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QtComponents for QtQuick2 uses QWindow->reportContentOrientationChange
to tell the system that its contents will be on a different
orientation. It'll call QPlatformWindow->handleContentOrientationChange
which is a placeholder function. Until it is properly handled the
status bar will be being drawn twice for portrait apps as the system
will think the application is still in landscape mode.
There is a tentative fix at the link below
https://codereview.qt-project.org/#change,24423
Reviewed-by: Luciano Wolf
|
|
|
|
|
|
|
| |
This bug could be reproduced if you start to press cancel
and plus button alternately very fast.
Reviewed-by: Alexis Menard
|
|
|
|
|
|
|
|
|
| |
Not perfect yet, but more stable. After this change
I couldn't reproduce the "black keyboard" bug anymore.
Now, we wait for the keyboard to show to make further
animations (fading elements).
Reviewed-by: Alexis Menard
|
|
|
|
| |
Reviewed-by: Trust Me
|