diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2017-08-18 14:05:10 +0200 |
|---|---|---|
| committer | Mark Wielaard <mark@klomp.org> | 2017-09-20 21:40:31 +0200 |
| commit | 17d7194d291bf91d130b78e06cbe27b290e0376d (patch) | |
| tree | 6197e445e38169e4672b80072dccabcca8d54dde /backends | |
| parent | b10d7eb74064c5906f031cd17c0f82041c6a4ca1 (diff) | |
Make sure packed structs follow the gcc memory layout
gcc defaults to using struct layouts that follow the native conventions,
even if __attribute__((packed)) is given. In order to get the layout we
expect, we need to tell gcc to always use the gcc struct layout, at
least for packed structs. To do this, we can use the gcc_struct
attribute.
This is important, not only for porting to windows, but also potentially
for other platforms, as the bugs resulting from struct layout
differences are rather subtle and hard to find.
Signed-off-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'backends')
| -rw-r--r-- | backends/ChangeLog | 4 | ||||
| -rw-r--r-- | backends/linux-core-note.c | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/backends/ChangeLog b/backends/ChangeLog index 79b50ebf..8c3f42c6 100644 --- a/backends/ChangeLog +++ b/backends/ChangeLog @@ -1,3 +1,7 @@ +2017-08-18 Ulf Hermann <ulf.hermann@qt.io> + + * linux-core-note.c: Use attribute_packed. + 2017-04-27 Ulf Hermann <ulf.hermann@qt.io> * Makefile.am: Use dso_LDFLAGS. diff --git a/backends/linux-core-note.c b/backends/linux-core-note.c index 67638d70..08282ba4 100644 --- a/backends/linux-core-note.c +++ b/backends/linux-core-note.c @@ -111,7 +111,7 @@ struct EBLHOOK(prstatus) FIELD (INT, pr_fpvalid); } #ifdef ALIGN_PRSTATUS - __attribute__ ((packed, aligned (ALIGN_PRSTATUS))) + attribute_packed __attribute__ ((aligned (ALIGN_PRSTATUS))) #endif ; |