diff options
author | Steven Chamberlain <steven@pyro.eu.org> | 2016-03-01 13:32:37 +0000 |
---|---|---|
committer | Mark Wielaard <mjw@redhat.com> | 2016-03-02 16:04:50 +0100 |
commit | 128947e6c3ccf8b975c50bae8b3772d19ab1420f (patch) | |
tree | 257907701ccb9f6cae0d4738360b54ab2a1b1b12 /libdwfl | |
parent | f6d080336caaf3894ff0583c277588a3a234c4ec (diff) |
libdwfl: clean up non-Linux GNU platforms code
For non-Linux GNU platforms (like kFreeBSD, Hurd), linux-pid-attach.c
had some stub functions that are not used or exported. Since gcc-6,
having these caused compiler errors due to -Wall -Werror:
linux-pid-attach.c:479:36: error: 'pid_thread_callbacks' defined but not used [-Werror=unused-const-variable=]
linux-pid-attach.c:474:1: error: 'pid_thread_detach' defined but not used [-Werror=unused-function]
linux-pid-attach.c:461:1: error: 'pid_detach' defined but not used [-Werror=unused-function]
linux-pid-attach.c:452:1: error: 'pid_set_initial_registers' defined but not used [-Werror=unused-function]
linux-pid-attach.c:441:1: error: 'pid_memory_read' defined but not used [-Werror=unused-function]
linux-pid-attach.c:420:1: error: 'pid_getthread' defined but not used [-Werror=unused-function]
linux-pid-attach.c:410:1: error: 'pid_next_thread' defined but not used [-Werror=unused-function]
This part of the source file is guarded by #ifndef __linux__
Signed-off-by: Steven Chamberlain <steven@pyro.eu.org>
Diffstat (limited to 'libdwfl')
-rw-r--r-- | libdwfl/ChangeLog | 7 | ||||
-rw-r--r-- | libdwfl/linux-pid-attach.c | 63 |
2 files changed, 7 insertions, 63 deletions
diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog index 462a61d0..5d400bb1 100644 --- a/libdwfl/ChangeLog +++ b/libdwfl/ChangeLog @@ -1,3 +1,10 @@ +2016-03-01 Steven Chamberlain <steven@pyro.eu.org> + + * linux-pid-attach.c: Removed unused pid_thread_callbacks, + pid_thread_detach, pid_detach, pid_set_initial_registers, + pid_memory_read, pid_getthread, pid_next_thread in #ifndef + __linux__ code. + 2016-02-22 Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> Mark Wielaard <mjw@redhat.com> diff --git a/libdwfl/linux-pid-attach.c b/libdwfl/linux-pid-attach.c index 4c0f42d8..c13f2b62 100644 --- a/libdwfl/linux-pid-attach.c +++ b/libdwfl/linux-pid-attach.c @@ -406,27 +406,6 @@ __libdwfl_get_pid_arg (Dwfl *dwfl) #else /* __linux__ */ -static pid_t -pid_next_thread (Dwfl *dwfl __attribute__ ((unused)), - void *dwfl_arg __attribute__ ((unused)), - void **thread_argp __attribute__ ((unused))) -{ - errno = ENOSYS; - __libdwfl_seterrno (DWFL_E_ERRNO); - return -1; -} - -static bool -pid_getthread (Dwfl *dwfl __attribute__ ((unused)), - pid_t tid __attribute__ ((unused)), - void *dwfl_arg __attribute__ ((unused)), - void **thread_argp __attribute__ ((unused))) -{ - errno = ENOSYS; - __libdwfl_seterrno (DWFL_E_ERRNO); - return false; -} - bool internal_function __libdwfl_ptrace_attach (pid_t tid __attribute__ ((unused)), @@ -437,32 +416,6 @@ __libdwfl_ptrace_attach (pid_t tid __attribute__ ((unused)), return false; } -static bool -pid_memory_read (Dwfl *dwfl __attribute__ ((unused)), - Dwarf_Addr addr __attribute__ ((unused)), - Dwarf_Word *result __attribute__ ((unused)), - void *arg __attribute__ ((unused))) -{ - errno = ENOSYS; - __libdwfl_seterrno (DWFL_E_ERRNO); - return false; -} - -static bool -pid_set_initial_registers (Dwfl_Thread *thread __attribute__ ((unused)), - void *thread_arg __attribute__ ((unused))) -{ - errno = ENOSYS; - __libdwfl_seterrno (DWFL_E_ERRNO); - return false; -} - -static void -pid_detach (Dwfl *dwfl __attribute__ ((unused)), - void *dwfl_arg __attribute__ ((unused))) -{ -} - void internal_function __libdwfl_ptrace_detach (pid_t tid __attribute__ ((unused)), @@ -470,22 +423,6 @@ __libdwfl_ptrace_detach (pid_t tid __attribute__ ((unused)), { } -static void -pid_thread_detach (Dwfl_Thread *thread __attribute__ ((unused)), - void *thread_arg __attribute__ ((unused))) -{ -} - -static const Dwfl_Thread_Callbacks pid_thread_callbacks = -{ - pid_next_thread, - pid_getthread, - pid_memory_read, - pid_set_initial_registers, - pid_detach, - pid_thread_detach, -}; - int dwfl_linux_proc_attach (Dwfl *dwfl __attribute__ ((unused)), pid_t pid __attribute__ ((unused)), |