summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMilian Wolff <milian.wolff@kdab.com>2022-12-04 20:52:40 +0100
committerMilian Wolff <milian.wolff@kdab.com>2022-12-05 10:08:14 +0000
commit3d71259edbd46051d1eb942cc923eab0b2439528 (patch)
tree2e630e6cf2245b0209f6e52006ca003147ab08f2
parentc53d4fcb7edd24f55b1287e38e7fee3692445403 (diff)
Fix -Wclazy-function-args-by-value
Change-Id: I2739795321b880e5d6abf87a563a0a026bcfc461 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
-rw-r--r--app/perfaddresscache.cpp2
-rw-r--r--app/perfaddresscache.h2
-rw-r--r--app/perfdwarfdiecache.h2
-rw-r--r--app/perffeatures.cpp4
-rw-r--r--app/perffeatures.h4
5 files changed, 7 insertions, 7 deletions
diff --git a/app/perfaddresscache.cpp b/app/perfaddresscache.cpp
index 278ea2f..8ff26d0 100644
--- a/app/perfaddresscache.cpp
+++ b/app/perfaddresscache.cpp
@@ -44,7 +44,7 @@ PerfAddressCache::AddressCacheEntry PerfAddressCache::find(const PerfElfMap::Elf
}
void PerfAddressCache::cache(const PerfElfMap::ElfInfo& elf, quint64 addr,
- const PerfAddressCache::AddressCacheEntry& entry,
+ PerfAddressCache::AddressCacheEntry entry,
OffsetAddressCache *invalidAddressCache)
{
if (elf.isValid())
diff --git a/app/perfaddresscache.h b/app/perfaddresscache.h
index fd978bd..2ab6323 100644
--- a/app/perfaddresscache.h
+++ b/app/perfaddresscache.h
@@ -78,7 +78,7 @@ public:
AddressCacheEntry find(const PerfElfMap::ElfInfo& elf, quint64 addr,
OffsetAddressCache *invalidAddressCache) const;
void cache(const PerfElfMap::ElfInfo& elf, quint64 addr,
- const AddressCacheEntry& entry, OffsetAddressCache *invalidAddressCache);
+ AddressCacheEntry entry, OffsetAddressCache *invalidAddressCache);
/// check if @c setSymbolCache was called for @p filePath already
bool hasSymbolCache(const QByteArray &filePath) const;
diff --git a/app/perfdwarfdiecache.h b/app/perfdwarfdiecache.h
index 1839872..3c410b9 100644
--- a/app/perfdwarfdiecache.h
+++ b/app/perfdwarfdiecache.h
@@ -48,7 +48,7 @@ struct DieRanges
bool contains(Dwarf_Addr addr) const
{
- return std::any_of(ranges.begin(), ranges.end(), [addr](const DwarfRange &range) {
+ return std::any_of(ranges.begin(), ranges.end(), [addr](DwarfRange range) {
return range.contains(addr);
});
}
diff --git a/app/perffeatures.cpp b/app/perffeatures.cpp
index 9a34b5d..f636011 100644
--- a/app/perffeatures.cpp
+++ b/app/perffeatures.cpp
@@ -36,7 +36,7 @@ static void removeTrailingZeros(QByteArray *string)
}
void PerfFeatures::createFeature(QIODevice *device, QDataStream::ByteOrder byteOrder,
- const PerfFileSection &section, PerfHeader::Feature featureId)
+ PerfFileSection section, PerfHeader::Feature featureId)
{
device->seek(section.offset);
QDataStream stream(device);
@@ -210,7 +210,7 @@ QDataStream &operator>>(QDataStream &stream, PerfNrCpus &nrCpus)
return stream >> nrCpus.online >> nrCpus.available;
}
-QDataStream &operator<<(QDataStream &stream, const PerfNrCpus &nrCpus)
+QDataStream &operator<<(QDataStream &stream, PerfNrCpus nrCpus)
{
return stream << nrCpus.online << nrCpus.available;
}
diff --git a/app/perffeatures.h b/app/perffeatures.h
index 2e07b99..a946e2f 100644
--- a/app/perffeatures.h
+++ b/app/perffeatures.h
@@ -70,7 +70,7 @@ struct PerfNrCpus {
};
QDataStream &operator>>(QDataStream &stream, PerfNrCpus &numCpus);
-QDataStream &operator<<(QDataStream &stream, const PerfNrCpus &numCpus);
+QDataStream &operator<<(QDataStream &stream, PerfNrCpus numCpus);
struct PerfTotalMem {
quint64 totalMem;
@@ -194,7 +194,7 @@ public:
private:
void createFeature(QIODevice *device, QDataStream::ByteOrder byteOrder,
- const PerfFileSection &section, PerfHeader::Feature featureId);
+ PerfFileSection section, PerfHeader::Feature featureId);
PerfTracingData m_tracingData;
PerfBuildId m_buildId;