diff options
| author | Milian Wolff <milian.wolff@kdab.com> | 2022-12-03 12:49:23 +0100 |
|---|---|---|
| committer | Milian Wolff <milian.wolff@kdab.com> | 2022-12-05 10:03:06 +0000 |
| commit | b9e84bc80284aac1c1f916773694e0cc24fc18be (patch) | |
| tree | 9bc7601a642b70275d97c299688183aa9c3941cf | |
| parent | d93d1e1b6b0aa24d4134de164a46555291407b2f (diff) | |
Fix clazy-use-static-qregularexpression
Fixes:
```
perfparser/app/perfregisterinfo.cpp:155:16: warning:
Don't create temporary QRegularExpression objects. Use a static QRegularExpression object instead [-Wclazy-use-static-qregularexpression]
|| QRegularExpression("^i[3-7]86$").match(name).hasMatch()
^
```
Change-Id: I308d5d9d54297061c0218fdbf45651c409cb25e7
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
| -rw-r--r-- | app/perfregisterinfo.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/app/perfregisterinfo.cpp b/app/perfregisterinfo.cpp index bc0831d..7a4dcc7 100644 --- a/app/perfregisterinfo.cpp +++ b/app/perfregisterinfo.cpp @@ -151,8 +151,9 @@ PerfRegisterInfo::Architecture PerfRegisterInfo::archByName(const QByteArray &na if (name.startsWith("sparc")) return ARCH_SPARC; + static const auto iX86pattern = QRegularExpression(QStringLiteral("^i[3-7]86$")); if (name.startsWith("x86") - || QRegularExpression("^i[3-7]86$").match(name).hasMatch() + || iX86pattern.match(name).hasMatch() || name == "amd64") return ARCH_X86; |