diff options
| author | Ulf Hermann <ulf.hermann@theqtcompany.com> | 2015-10-30 13:01:40 +0100 |
|---|---|---|
| committer | Ulf Hermann <ulf.hermann@theqtcompany.com> | 2015-11-10 08:55:38 +0000 |
| commit | 5f823442f9e655768622b226ec63056068852a55 (patch) | |
| tree | e2fdd7d736383d36be4edd85bcfdd531695c01d5 | |
| parent | 3673dce5cea1127ab01931cbe77ac8cd1b166bb1 (diff) | |
Remove overly verbose warnings
Change-Id: I4a122c3168df05476ca91d0b99f0f9cfae077ef0
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
| -rw-r--r-- | app/perfdata.cpp | 9 | ||||
| -rw-r--r-- | app/perfunwind.cpp | 11 |
2 files changed, 2 insertions, 18 deletions
diff --git a/app/perfdata.cpp b/app/perfdata.cpp index 87a5fed..5b498c3 100644 --- a/app/perfdata.cpp +++ b/app/perfdata.cpp @@ -254,15 +254,6 @@ QDataStream &PerfRecordMmap::readFilename(QDataStream &stream, quint64 filenameL QDataStream &PerfRecordMmap::readSampleId(QDataStream &stream) { stream >> m_sampleId; - - if (m_sampleId.sampleType() & - (PerfEventAttributes::SAMPLE_ID_ALL | PerfEventAttributes::SAMPLE_TID)) { - if (m_sampleId.pid() != m_pid) - qWarning() << "ambiguous pids in mmap event" << m_sampleId.pid() << m_pid; - if (m_sampleId.tid() != m_tid) - qWarning() << "ambiguous tids in mmap event" << m_sampleId.tid() << m_tid; - } - return stream; } diff --git a/app/perfunwind.cpp b/app/perfunwind.cpp index 0ac4d25..f8c8bf3 100644 --- a/app/perfunwind.cpp +++ b/app/perfunwind.cpp @@ -149,10 +149,9 @@ void PerfUnwind::comm(PerfRecordComm &comm) Dwfl_Module *PerfUnwind::reportElf(quint64 ip, quint32 pid, const ElfInfo **info) const { QHash<quint32, QMap<quint64, ElfInfo> >::ConstIterator elfsIt = elfs.find(pid); - if (elfsIt == elfs.end()) { - qWarning() << "Process" << pid << "has no elfs"; + if (elfsIt == elfs.end()) return 0; - } + const QMap<quint64, ElfInfo> &procElfs = elfsIt.value(); QMap<quint64, ElfInfo>::ConstIterator i = procElfs.upperBound(ip); if (i == procElfs.end() || i.key() != ip) { @@ -253,11 +252,6 @@ static bool memoryRead(Dwfl *dwfl, Dwarf_Addr addr, Dwarf_Word *result, void *ar if (addr < start || addr + sizeof(Dwarf_Word) > end) { // not stack, try reading from ELF if (!accessDsoMem(dwfl, ui, addr, result)) { - qWarning() << QString::fromLatin1("Cannot read memory at 0x%1").arg(addr, 0, 16); - qWarning() << QString::fromLatin1( - "dwfl should only read stack state (0x%1 to 0x%2) with memoryRead().") - .arg(start, 0, 16).arg(end, 0, 16); - ui->broken = true; return false; } @@ -425,7 +419,6 @@ void PerfUnwind::analyze(const PerfRecordSample &sample) return; } if (!dwfl_attach_state(dwfl, 0, sample.pid(), &callbacks, ¤tUnwind)) { - qWarning() << "failed to attach state:" << dwfl_errmsg(dwfl_errno()); lastPid = -1; return; } |