diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2018-01-23 14:41:20 +0100 |
|---|---|---|
| committer | Ulf Hermann <ulf.hermann@qt.io> | 2018-01-23 14:29:19 +0000 |
| commit | f5ed424f58b2b2e22dd6da2d9fdbf8d36c5764f3 (patch) | |
| tree | 7a2e6d89607b334c6bc3433c07138a48d8b4df3a | |
| parent | a375707bf7b65658e9277476d2cf22c17854617a (diff) | |
Improve error messages for failures to register ELFs
We only need the address once, it should be in hex, and we don't need
the trailing comma.
Change-Id: Icdb8fcd546a0d643ff3875e8e7ca68382fc03a49
Reviewed-by: Milian Wolff <milian.wolff@kdab.com>
| -rw-r--r-- | app/perfelfmap.cpp | 4 | ||||
| -rw-r--r-- | app/perfsymboltable.cpp | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/app/perfelfmap.cpp b/app/perfelfmap.cpp index c3d43e5..3e0a6b4 100644 --- a/app/perfelfmap.cpp +++ b/app/perfelfmap.cpp @@ -30,9 +30,9 @@ QDebug operator<<(QDebug stream, const PerfElfMap::ElfInfo& info) << "isFile=" << info.isFile() << ", " << "originalFileName=" << info.originalFileName << ", " << "originalPath=" << info.originalPath << ", " - << "addr=" << info.addr << ", " + << "addr=" << hex << info.addr << dec << ", " << "len=" << info.length << ", " - << "pgoff=" << info.pgoff << ", " + << "pgoff=" << info.pgoff << "}"; return stream.space(); } diff --git a/app/perfsymboltable.cpp b/app/perfsymboltable.cpp index 2c2791f..3a1b451 100644 --- a/app/perfsymboltable.cpp +++ b/app/perfsymboltable.cpp @@ -471,8 +471,7 @@ void PerfSymbolTable::parseDwarf(Dwarf_Die *cudie, Dwarf_Addr bias, qint32 binar static void reportError(const PerfElfMap::ElfInfo& info, const char *message) { - qWarning() << "failed to report" << info << "for" - << hex << info.addr << dec << ":" << message; + qWarning() << "failed to report" << info << ":" << message; } Dwfl_Module *PerfSymbolTable::reportElf(const PerfElfMap::ElfInfo& info) |