aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTobias Hunger <tobias.hunger@theqtcompany.com>2015-11-20 14:11:26 +0100
committerTobias Hunger <tobias.hunger@theqtcompany.com>2015-11-24 12:59:51 +0000
commit8345ba2d2d450b2143a51e0afafdc46782b1825e (patch)
treebfb4196d10b5f7a90e70961a435d04dffd135a12
parentbdf66b0a3fa549302b8a7a6586e907b323f81b22 (diff)
Android: Set JDK path for buildsv3.6.0-rc1
Without it the build may fail. Task-number: QTCREATORBUG-15382 Change-Id: Ie7f823746516d17e8e32a367953cf491378f00c1 Reviewed-by: BogDan Vatra <bogdan@kdab.com> Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
-rw-r--r--src/plugins/android/androidtoolchain.cpp13
1 files changed, 9 insertions, 4 deletions
diff --git a/src/plugins/android/androidtoolchain.cpp b/src/plugins/android/androidtoolchain.cpp
index 1b4177a0b6..5f3b0f0a8c 100644
--- a/src/plugins/android/androidtoolchain.cpp
+++ b/src/plugins/android/androidtoolchain.cpp
@@ -106,7 +106,6 @@ bool AndroidToolChain::isValid() const
void AndroidToolChain::addToEnvironment(Environment &env) const
{
-
// TODO this vars should be configurable in projects -> build tab
// TODO invalidate all .pro files !!!
@@ -114,9 +113,15 @@ void AndroidToolChain::addToEnvironment(Environment &env) const
env.set(QLatin1String("ANDROID_NDK_TOOLCHAIN_PREFIX"), AndroidConfig::toolchainPrefix(targetAbi()));
env.set(QLatin1String("ANDROID_NDK_TOOLS_PREFIX"), AndroidConfig::toolsPrefix(targetAbi()));
env.set(QLatin1String("ANDROID_NDK_TOOLCHAIN_VERSION"), m_ndkToolChainVersion);
- QString javaHome = AndroidConfigurations::currentConfig().openJDKLocation().toString();
- if (!javaHome.isEmpty() && QFileInfo::exists(javaHome))
- env.set(QLatin1String("JAVA_HOME"), javaHome);
+ const Utils::FileName javaHome = AndroidConfigurations::currentConfig().openJDKLocation();
+ if (!javaHome.isEmpty() && javaHome.toFileInfo().exists()) {
+ env.set(QLatin1String("JAVA_HOME"), javaHome.toString());
+ Utils::FileName javaBin = javaHome;
+ javaBin.appendPath(QLatin1String("bin"));
+ const QString jb = javaBin.toUserOutput();
+ if (!Utils::contains(env.path(), [&jb](const QString &p) { return p == jb; }))
+ env.prependOrSetPath(jb);
+ }
env.set(QLatin1String("ANDROID_HOME"), AndroidConfigurations::currentConfig().sdkLocation().toString());
env.set(QLatin1String("ANDROID_SDK_ROOT"), AndroidConfigurations::currentConfig().sdkLocation().toString());
}