aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHannes Domani <ssbssa@yahoo.de>2018-09-24 17:41:27 +0200
committerHannes Domani <ssbssa@yahoo.de>2018-09-25 14:58:16 +0000
commit8768e39d3c8e74e583eca3897cc6de53a99c3dde (patch)
treed1d277828ef1638045d59d78eaa38756769d1304
parentad8098b372d19c5b7d517230566fc549ff001045 (diff)
Valgrind: Add target executable suffix to heob command line
The suffix is needed in case the executable name contains a dot, because then the .exe suffix is not added automatically by CreateProcess(). Change-Id: Ief2cfeaa8dd8ebbfb71f69575ee9574a4f2156d3 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
-rw-r--r--src/plugins/valgrind/memchecktool.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/plugins/valgrind/memchecktool.cpp b/src/plugins/valgrind/memchecktool.cpp
index 6078cd240c..e67c1b3762 100644
--- a/src/plugins/valgrind/memchecktool.cpp
+++ b/src/plugins/valgrind/memchecktool.cpp
@@ -780,8 +780,9 @@ void MemcheckTool::heobAction()
TaskHub::requestPopup();
return;
}
- if (!QFile::exists(executable)
- && !QFile::exists(Utils::HostOsInfo::withExecutableSuffix(executable))) {
+ if (!QFile::exists(executable))
+ executable = Utils::HostOsInfo::withExecutableSuffix(executable);
+ if (!QFile::exists(executable)) {
const QString msg = tr("Heob: Cannot find %1.").arg(executable);
TaskHub::addTask(Task::Error, msg, Debugger::Constants::ANALYZERTASK_ID);
TaskHub::requestPopup();