From 9eceb46739803bb7482e9017cd79df92203ecbad Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Thu, 19 Mar 2020 16:02:44 +0100 Subject: Fix link on commit sha in about dialog Passing a URL via defines breaks when trying to "stringify" it. It would always stop at the first slash. Instead use a qmake variable directly. That has the additional advantage that the value isn't passed on each and every compiler command line. Change-Id: I97a297fbcdee5ea03eb6fa08181c95b1ad2de767 Reviewed-by: Cristian Adam --- .github/workflows/build_cmake.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github') diff --git a/.github/workflows/build_cmake.yml b/.github/workflows/build_cmake.yml index 5722143c04..f409216afb 100644 --- a/.github/workflows/build_cmake.yml +++ b/.github/workflows/build_cmake.yml @@ -333,7 +333,7 @@ jobs: -D WITH_TESTS=ON -D IDE_REVISION=TRUE -D IDE_REVISION_STR=$ENV{GITHUB_SHA} - -D IDE_REVISION_URL_STR=https://github.com/$ENV{GITHUB_REPOSITORY}/commits/$ENV{GITHUB_SHA} + -D IDE_REVISION_URL=https://github.com/$ENV{GITHUB_REPOSITORY}/commits/$ENV{GITHUB_SHA} RESULT_VARIABLE result COMMAND_ECHO STDOUT ) -- cgit v1.2.3