From 11f29677503ea72057caf82634d5880c19161afe Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 16 Jan 2019 15:14:29 +0100 Subject: ProjectExplorer: Fix SelectableFilesModel::applyFilter() The "checked" state of file nodes was never re-calculated during the filter operation. Fixes: QTCREATORBUG-16237 Change-Id: I3586be8329007f526292ddafbd4a436a91d12cb9 Reviewed-by: hjk --- src/plugins/projectexplorer/selectablefilesmodel.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plugins/projectexplorer/selectablefilesmodel.cpp b/src/plugins/projectexplorer/selectablefilesmodel.cpp index f31049b0ea..051a6e089b 100644 --- a/src/plugins/projectexplorer/selectablefilesmodel.cpp +++ b/src/plugins/projectexplorer/selectablefilesmodel.cpp @@ -493,7 +493,9 @@ Qt::CheckState SelectableFilesModel::applyFilter(const QModelIndex &idx) } for (int i=0; i < t->visibleFiles.size(); ++i) { - if (t->visibleFiles.at(i)->checked == Qt::Checked) + Tree * const fileNode = t->visibleFiles.at(i); + fileNode->checked = filter(fileNode) == FilterState::CHECKED ? Qt::Checked : Qt::Unchecked; + if (fileNode->checked) allUnchecked = false; else allChecked = false; -- cgit v1.2.3