From 1b134a69090c7326554157494f89271a5c088ae2 Mon Sep 17 00:00:00 2001 From: Fawzi Mohamed Date: Tue, 29 Sep 2020 10:04:26 +0200 Subject: QmlJS: accept import without version Since Qt 6 import without version are accepted and should import the latest version. Change-Id: Id98bd0f7664dd77b30b9c91ee153fccc4160fc6d Fixes: QTCREATORBUG-24533 Reviewed-by: Ulf Hermann --- src/libs/qmljs/qmljsbind.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/libs/qmljs/qmljsbind.cpp b/src/libs/qmljs/qmljsbind.cpp index 5e47353dd8..e405fd3ab5 100644 --- a/src/libs/qmljs/qmljsbind.cpp +++ b/src/libs/qmljs/qmljsbind.cpp @@ -29,6 +29,9 @@ #include "qmljsdocument.h" #include "qmljsmodelmanagerinterface.h" +#include +#include + #include using namespace LanguageUtils; @@ -203,7 +206,12 @@ bool Bind::visit(UiImport *ast) version = ComponentVersion(ast->version->majorVersion, ast->version->minorVersion); if (ast->importUri) { - if (!version.isValid()) { + QVersionNumber qtVersion = QLibraryInfo::version(); + if (ModelManagerInterface *model = ModelManagerInterface::instance()) { + ModelManagerInterface::ProjectInfo pInfo = model->projectInfoForPath(_doc->fileName()); + qtVersion = QVersionNumber::fromString(pInfo.qtVersionString); + } + if (!version.isValid() && qtVersion.majorVersion() < 6) { _diagnosticMessages->append( errorMessage(ast, tr("package import requires a version number"))); } -- cgit v1.2.3