From 3c00715c8e90c57953ec4a8716110f6954e524e4 Mon Sep 17 00:00:00 2001 From: Oswald Buddenhagen Date: Wed, 22 Sep 2010 20:05:03 +0200 Subject: fix security hole: don't add an empty element to LD_LIBRARY_PATH if LD_LIBRARY_PATH was empty, the wrapper script would add the empty element to the path. > The trailing colon is treated by ld.so as another item on the list, > and empty items are treated as '.' (CWD). Therefore, if a user > executes qtcreator from a directory where there's a library that would > have normally been loaded from the standard library paths the local > library would be loaded instead. > This has the potential effect of arbitrary code execution. Reviewed-by: thiago Task-number: CVE-2010-3374 --- bin/qtcreator | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/qtcreator b/bin/qtcreator index dc154aa199..6da961a927 100755 --- a/bin/qtcreator +++ b/bin/qtcreator @@ -31,6 +31,6 @@ fi bindir=`dirname "$me"` libdir=`cd "${bindir}/../lib" ; pwd` -LD_LIBRARY_PATH="${libdir}/qtcreator:${LD_LIBRARY_PATH}" +LD_LIBRARY_PATH="${libdir}/qtcreator${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" export LD_LIBRARY_PATH exec "${bindir}/qtcreator.bin" ${1+"$@"} -- cgit v1.2.3