From 56a4865b2f37e810f656f1f79ea416cac5109d49 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Tue, 12 May 2020 12:32:54 +0200 Subject: QbsProjectManager: Fix potential null pointer access We retrieved the watcher result from the wrong pointer. Fixes: QTCREATORBUG-23924 Change-Id: I876d8adc0aef011deb3f5827f3e50c43a8d92dfc Reviewed-by: Ivan Komissarov Reviewed-by: Christian Stenger --- src/plugins/qbsprojectmanager/qbsproject.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/qbsprojectmanager/qbsproject.cpp b/src/plugins/qbsprojectmanager/qbsproject.cpp index b3264dfb59..96efcd1d6b 100644 --- a/src/plugins/qbsprojectmanager/qbsproject.cpp +++ b/src/plugins/qbsprojectmanager/qbsproject.cpp @@ -480,7 +480,7 @@ void QbsBuildSystem::updateProjectNodes(const std::function &continuati m_treeCreationWatcher = new TreeCreationWatcher(this); connect(m_treeCreationWatcher, &TreeCreationWatcher::finished, this, [this, watcher = m_treeCreationWatcher, continuation] { - std::unique_ptr rootNode(m_treeCreationWatcher->result()); + std::unique_ptr rootNode(watcher->result()); if (watcher != m_treeCreationWatcher) { watcher->deleteLater(); return; -- cgit v1.2.3