From 5b1a7f37560d24821e9bea705aaba26f71b604ab Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 4 Mar 2015 17:33:06 +0100 Subject: Use new AnalyzerUtils::logToIssuesPane(). Change-Id: I9820a81f67c06b7bb54720772467263bfa9fc8f3 Reviewed-by: Andre Poenitz --- .../clangstaticanalyzerruncontrol.cpp | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp b/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp index e0576299e46..c99060d13c2 100644 --- a/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp +++ b/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp @@ -23,8 +23,8 @@ #include "clangstaticanalyzersettings.h" #include "clangstaticanalyzerutils.h" -#include #include +#include #include @@ -53,14 +53,6 @@ static Q_LOGGING_CATEGORY(LOG, "qtc.clangstaticanalyzer.runcontrol") namespace ClangStaticAnalyzer { namespace Internal { -static void logToIssuesPane(Task::TaskType type, const QString &message) -{ - TaskHub::addTask(type, message, Analyzer::Constants::ANALYZERTASK_ID); - if (type == Task::Error) - TaskHub::requestPopup(); -} - - ClangStaticAnalyzerRunControl::ClangStaticAnalyzerRunControl( const Analyzer::AnalyzerStartParameters &startParams, ProjectExplorer::RunConfiguration *runConfiguration, @@ -204,7 +196,7 @@ bool ClangStaticAnalyzerRunControl::startEngine() const QString errorMessage = tr("Clang Static Analyzer: Invalid executable \"%1\", stop.") .arg(executable); appendMessage(errorMessage + QLatin1Char('\n'), Utils::ErrorMessageFormat); - logToIssuesPane(Task::Error, errorMessage); + AnalyzerUtils::logToIssuesPane(Task::Error, errorMessage); emit finished(); return false; } @@ -217,7 +209,7 @@ bool ClangStaticAnalyzerRunControl::startEngine() const QString errorMessage = tr("Clang Static Analyzer: Failed to create temporary dir, stop."); appendMessage(errorMessage + QLatin1Char('\n'), Utils::ErrorMessageFormat); - logToIssuesPane(Task::Error, errorMessage); + AnalyzerUtils::logToIssuesPane(Task::Error, errorMessage); emit finished(); return false; } @@ -287,8 +279,8 @@ void ClangStaticAnalyzerRunControl::analyzeNextFile() + QLatin1Char('\n'), Utils::NormalMessageFormat); if (m_filesAnalyzed == 0 && m_filesNotAnalyzed != 0) { - logToIssuesPane(Task::Error, - tr("Clang Static Analyzer: Failed to analyze any files.")); + AnalyzerUtils::logToIssuesPane(Task::Error, + tr("Clang Static Analyzer: Failed to analyze any files.")); } m_progress.reportFinished(); emit finished(); @@ -353,8 +345,8 @@ void ClangStaticAnalyzerRunControl::onRunnerFinishedWithFailure(const QString &e + QLatin1Char('\n') , Utils::StdErrFormat); appendMessage(errorDetails, Utils::StdErrFormat); - logToIssuesPane(Task::Warning, errorMessage); - logToIssuesPane(Task::Warning, errorDetails); + AnalyzerUtils::logToIssuesPane(Task::Warning, errorMessage); + AnalyzerUtils::logToIssuesPane(Task::Warning, errorDetails); handleFinished(); } -- cgit v1.2.3