From 041a86c8c7d8a7e563655c5ae4dae08752ceaad8 Mon Sep 17 00:00:00 2001 From: hjk Date: Mon, 9 Dec 2019 12:59:38 +0100 Subject: ProjectExplorer: Use function object for special build config init Change-Id: I5da0f28ee1a64f8d9a3145f059019be702bee463 Reviewed-by: Christian Kandeler --- .../autotoolsbuildconfiguration.cpp | 37 +++++++++++----------- .../autotoolsbuildconfiguration.h | 2 -- 2 files changed, 18 insertions(+), 21 deletions(-) (limited to 'src/plugins/autotoolsprojectmanager') diff --git a/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.cpp b/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.cpp index 0950ae46bca..406347aba0d 100644 --- a/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.cpp +++ b/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.cpp @@ -53,26 +53,25 @@ AutotoolsBuildConfiguration::AutotoolsBuildConfiguration(Target *parent, Core::I setBuildDirectory(Utils::FilePath::fromString("/")); setBuildDirectoryHistoryCompleter("AutoTools.BuildDir.History"); setConfigWidgetDisplayName(tr("Autotools Manager")); -} -void AutotoolsBuildConfiguration::initialize() -{ - // ### Build Steps Build ### - // autogen.sh or autoreconf - QFile autogenFile(target()->project()->projectDirectory().toString() + "/autogen.sh"); - if (autogenFile.exists()) - buildSteps()->appendStep(Constants::AUTOGEN_STEP_ID); - else - buildSteps()->appendStep(Constants::AUTORECONF_STEP_ID); - - // ./configure. - buildSteps()->appendStep(Constants::CONFIGURE_STEP_ID); - - // make - buildSteps()->appendStep(Constants::MAKE_STEP_ID); - - // ### Build Steps Clean ### - cleanSteps()->appendStep(Constants::MAKE_STEP_ID); + setInitializer([this] { + // ### Build Steps Build ### + // autogen.sh or autoreconf + QFile autogenFile(target()->project()->projectDirectory().toString() + "/autogen.sh"); + if (autogenFile.exists()) + buildSteps()->appendStep(Constants::AUTOGEN_STEP_ID); + else + buildSteps()->appendStep(Constants::AUTORECONF_STEP_ID); + + // ./configure. + buildSteps()->appendStep(Constants::CONFIGURE_STEP_ID); + + // make + buildSteps()->appendStep(Constants::MAKE_STEP_ID); + + // ### Build Steps Clean ### + cleanSteps()->appendStep(Constants::MAKE_STEP_ID); + }); } diff --git a/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.h b/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.h index 1b2bcf80214..d3c89c9d590 100644 --- a/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.h +++ b/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.h @@ -38,8 +38,6 @@ class AutotoolsBuildConfiguration : public ProjectExplorer::BuildConfiguration friend class ProjectExplorer::BuildConfigurationFactory; AutotoolsBuildConfiguration(ProjectExplorer::Target *parent, Core::Id id); - - void initialize() override; }; class AutotoolsBuildConfigurationFactory : public ProjectExplorer::BuildConfigurationFactory -- cgit v1.2.3