From 8bde432dfe40ff9b9491acd62a7854c060cad01d Mon Sep 17 00:00:00 2001 From: David Schulz Date: Thu, 26 Mar 2020 09:21:57 +0100 Subject: CodeAssist: Fix leaking asynchronous processors Currently the ownership of the processor is unknown to the codeassist when running an async operation. Move the ownership of the processor to the assist and delete the processor after the proposal was completed. Change-Id: I6a2e023c47cbc876669dba866bee12b481447cb7 Reviewed-by: Christian Stenger --- src/plugins/clangcodemodel/clangbackendreceiver.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/plugins/clangcodemodel') diff --git a/src/plugins/clangcodemodel/clangbackendreceiver.cpp b/src/plugins/clangcodemodel/clangbackendreceiver.cpp index 39edf46c447..a0fac088541 100644 --- a/src/plugins/clangcodemodel/clangbackendreceiver.cpp +++ b/src/plugins/clangcodemodel/clangbackendreceiver.cpp @@ -190,8 +190,7 @@ void BackendReceiver::completions(const CompletionsMessage &message) << "items"; const quint64 ticket = message.ticketNumber; - QScopedPointer processor(m_assistProcessorsTable.take(ticket)); - if (processor) + if (ClangCompletionAssistProcessor *processor = m_assistProcessorsTable.take(ticket)) processor->handleAvailableCompletions(message.codeCompletions); } -- cgit v1.2.3