From ce088cb754331104b07f16020abcb99172b01f55 Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Mon, 6 Feb 2017 12:25:15 +0100 Subject: Call QPainter::end() prior to QPixmapCache::insert() Inserting a QPixmap with active painters on it causes it to do a deep copy of it, which is unnecessary. Task-number: QTBUG-58653 Change-Id: I49123ffcec2e12a01c87974b7a513d68a11185d4 Reviewed-by: Eike Ziller --- src/plugins/coreplugin/fancyactionbar.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'src/plugins/coreplugin/fancyactionbar.cpp') diff --git a/src/plugins/coreplugin/fancyactionbar.cpp b/src/plugins/coreplugin/fancyactionbar.cpp index e6ad99bc1b..f5588a99b2 100644 --- a/src/plugins/coreplugin/fancyactionbar.cpp +++ b/src/plugins/coreplugin/fancyactionbar.cpp @@ -326,6 +326,7 @@ void FancyToolButton::hoverOverlay(QPainter *painter, const QRect &spanRect) p.setPen(QPen(grad, 1.0)); p.drawLine(borderRect.topLeft(), borderRect.topRight()); p.drawLine(borderRect.bottomLeft(), borderRect.bottomRight()); + p.end(); QPixmapCache::insert(cacheKey, overlay); } -- cgit v1.2.3