From cf6bd7e0124f31374f3a4abd05d14199d201961b Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Thu, 22 Jun 2023 14:58:11 +0200 Subject: Fix occurrences of the contains/insert anti-pattern Introduce and make use of Utils::insert() for QSet with a return value that indicates whether insertion actually happened. Change-Id: I655e4bc3553b74fea5ae8956205e4d8070118d63 Reviewed-by: hjk Reviewed-by: Eike Ziller --- src/plugins/cppeditor/cppchecksymbols.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'src/plugins/cppeditor/cppchecksymbols.cpp') diff --git a/src/plugins/cppeditor/cppchecksymbols.cpp b/src/plugins/cppeditor/cppchecksymbols.cpp index 7728ea308c..e9334b0db2 100644 --- a/src/plugins/cppeditor/cppchecksymbols.cpp +++ b/src/plugins/cppeditor/cppchecksymbols.cpp @@ -73,9 +73,7 @@ protected: { if (!doc) return; - if (!processed->contains(doc->globalNamespace())) { - processed->insert(doc->globalNamespace()); - + if (Utils::insert(*processed, doc->globalNamespace())) { const QList includes = doc->resolvedIncludes(); for (const Document::Include &i : includes) process(_snapshot.document(i.resolvedFileName()), processed); @@ -806,8 +804,7 @@ bool CheckSymbols::hasVirtualDestructor(ClassOrNamespace *binding) const while (!todo.isEmpty()) { ClassOrNamespace *b = todo.takeFirst(); - if (b && !processed.contains(b)) { - processed.insert(b); + if (b && Utils::insert(processed, b)) { const QList symbols = b->symbols(); for (Symbol *s : symbols) { if (Class *k = s->asClass()) { -- cgit v1.2.3