From 41191817629cb447a70497c9f3b4da6d7513c92c Mon Sep 17 00:00:00 2001
From: Christian Kandeler <christian.kandeler@qt.io>
Date: Mon, 12 Sep 2022 17:36:52 +0200
Subject: CppEditor: Make value vs const ref return type configurable

... in the quickfix settings.
Also change the default: With mandatory RVO and move semantics, value
return types are the right choice most of the time.

Fixes: QTCREATORBUG-25790
Change-Id: I68fc6c616358478ba893101b3e04aa6bbbe79348
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
---
 src/plugins/cppeditor/cppquickfixsettingswidget.ui | 24 ++++++++++------------
 1 file changed, 11 insertions(+), 13 deletions(-)

(limited to 'src/plugins/cppeditor/cppquickfixsettingswidget.ui')

diff --git a/src/plugins/cppeditor/cppquickfixsettingswidget.ui b/src/plugins/cppeditor/cppquickfixsettingswidget.ui
index 44ad80f9180..692eddda9bc 100644
--- a/src/plugins/cppeditor/cppquickfixsettingswidget.ui
+++ b/src/plugins/cppeditor/cppquickfixsettingswidget.ui
@@ -7,7 +7,7 @@
     <x>0</x>
     <y>0</y>
     <width>641</width>
-    <height>1074</height>
+    <height>1141</height>
    </rect>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_3">
@@ -25,9 +25,6 @@
         <property name="text">
          <string>Default</string>
         </property>
-        <property name="alignment">
-         <set>Qt::AlignCenter</set>
-        </property>
        </widget>
       </item>
       <item row="4" column="1" alignment="Qt::AlignHCenter">
@@ -329,9 +326,6 @@
         <property name="text">
          <string>Default</string>
         </property>
-        <property name="alignment">
-         <set>Qt::AlignCenter</set>
-        </property>
        </widget>
       </item>
       <item row="0" column="2">
@@ -350,9 +344,6 @@
         <property name="text">
          <string>Generate Getters</string>
         </property>
-        <property name="alignment">
-         <set>Qt::AlignCenter</set>
-        </property>
        </widget>
       </item>
       <item row="0" column="1">
@@ -371,9 +362,6 @@
         <property name="text">
          <string>Generate Setters</string>
         </property>
-        <property name="alignment">
-         <set>Qt::AlignCenter</set>
-        </property>
        </widget>
       </item>
       <item row="5" column="0">
@@ -886,6 +874,16 @@
      </item>
     </layout>
    </item>
+   <item>
+    <widget class="QCheckBox" name="returnByConstRefCheckBox">
+     <property name="text">
+      <string>Return non-value types by const reference</string>
+     </property>
+     <property name="checked">
+      <bool>false</bool>
+     </property>
+    </widget>
+   </item>
   </layout>
  </widget>
  <resources/>
-- 
cgit v1.2.3