From 7275402ce9ac56d7a208aaea1fe1e99ca01c43a2 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Fri, 28 May 2021 13:12:00 +0200 Subject: ClangCodeModel: Fix links for virtual overrides For some reason, clangd returns the declaration instead of the definition position in the "Goto Implementation" result, so we have to do another look-up for each override. Change-Id: I2a99eb0dacdea07d5882087445dc2b2d61b24e58 Reviewed-by: David Schulz --- src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp') diff --git a/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp b/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp index 32c0f27186b..75f70497472 100644 --- a/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp +++ b/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp @@ -516,14 +516,8 @@ F2TestCase::F2TestCase(CppEditorAction action, if (useClangd) QEXPECT_FAIL("allOverrides from base declaration", "FIXME: check why this fails", Abort); QCOMPARE(finalVirtualSymbolResults.size(), expectedVirtualFunctionProposal.size()); - if (useClangd) { - QEXPECT_FAIL("allOverrides", "FIXME: clangd sometimes goes to decl instead of def", Abort); - QEXPECT_FAIL("possibleOverrides1", "FIXME: clangd sometimes goes to decl instead of def", - Abort); - QEXPECT_FAIL("possibleOverrides2", "FIXME: clangd sometimes goes to decl instead of def", - Abort); + if (useClangd) QEXPECT_FAIL("itemOrder", "FIXME: sort items", Abort); - } QCOMPARE(finalVirtualSymbolResults, expectedVirtualFunctionProposal); } -- cgit v1.2.3