From e9df7825fa8a8714c3623154f1fc3cf13066a9a4 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Wed, 17 Jun 2020 23:34:16 +0300 Subject: IVersionControl: Change vcsAnnotate return type to void MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All implementations return true unconditionally, and the return value is never read anyway. + Remove superfluous function with the same name in Perforce. Change-Id: I83f361ec7fd8be3177cb4be52e6276e295cd4279 Reviewed-by: André Hartmann Reviewed-by: hjk --- src/plugins/mercurial/mercurialplugin.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/plugins/mercurial') diff --git a/src/plugins/mercurial/mercurialplugin.cpp b/src/plugins/mercurial/mercurialplugin.cpp index 533d08f4e9e..9727167847f 100644 --- a/src/plugins/mercurial/mercurialplugin.cpp +++ b/src/plugins/mercurial/mercurialplugin.cpp @@ -144,7 +144,7 @@ public: bool vcsDelete(const QString &filename) final; bool vcsMove(const QString &from, const QString &to) final; bool vcsCreateRepository(const QString &directory) final; - bool vcsAnnotate(const QString &file, int line) final; + void vcsAnnotate(const QString &file, int line) final; Core::ShellCommand *createInitialCheckoutCommand(const QString &url, const Utils::FilePath &baseDirectory, @@ -826,11 +826,10 @@ bool MercurialPluginPrivate::vcsCreateRepository(const QString &directory) return m_client.synchronousCreateRepository(directory); } -bool MercurialPluginPrivate::vcsAnnotate(const QString &file, int line) +void MercurialPluginPrivate::vcsAnnotate(const QString &file, int line) { const QFileInfo fi(file); m_client.annotate(fi.absolutePath(), fi.fileName(), QString(), line); - return true; } Core::ShellCommand *MercurialPluginPrivate::createInitialCheckoutCommand(const QString &url, -- cgit v1.2.3