From 1714ecf8092533eaba196212d4f0feb581449ecf Mon Sep 17 00:00:00 2001 From: hjk Date: Thu, 20 Feb 2020 18:13:48 +0100 Subject: ProjectExplorer: Remove Task::buildConfigurationMissingTask() It should not be possible to trigger the condition. Except for MakeStep the function is only called from real BuildSteps, that always live in a BuildConfiguration. A MakeStep could live in a DeployConfiguration, but that belongs to a Target. That target always has a BuildConfiguration in case the project type requires one. So not having a BuildConfiguration can only happen when the project type doesn't require one, but then the situation is not an error that should be notified as a Task. Change-Id: I2a5d90fdadd3916d3dae6a0fdc6e6ab2010a8111 Reviewed-by: Christian Kandeler --- src/plugins/projectexplorer/makestep.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'src/plugins/projectexplorer/makestep.cpp') diff --git a/src/plugins/projectexplorer/makestep.cpp b/src/plugins/projectexplorer/makestep.cpp index 5a3cf226d2..ea327fe303 100644 --- a/src/plugins/projectexplorer/makestep.cpp +++ b/src/plugins/projectexplorer/makestep.cpp @@ -81,15 +81,11 @@ void MakeStep::setAvailableBuildTargets(const QStringList &buildTargets) bool MakeStep::init() { - BuildConfiguration *bc = buildConfiguration(); - if (!bc) - emit addTask(Task::buildConfigurationMissingTask()); - const CommandLine make = effectiveMakeCommand(Execution); if (make.executable().isEmpty()) emit addTask(makeCommandMissingTask()); - if (!bc || make.executable().isEmpty()) { + if (make.executable().isEmpty()) { emitFaultyConfigurationMessage(); return false; } -- cgit v1.2.3