From 2c0554c187adb4ef886affd193b8149afa199d13 Mon Sep 17 00:00:00 2001 From: Ivan Donchevskii Date: Wed, 11 Jul 2018 08:25:07 +0200 Subject: ProjectExplorer: Fix memory leaks in tree models Fix widgets being leaked by the ToolChainOptionsPage. This page created widgets and stored them in the tree node and never deleted them. The fix is to put all the widgets into one QStackedWidget, so that this will clean up once the page is destroyed. Change-Id: Ic02824a4c52771d8962dc594176077c2e139fb84 Reviewed-by: Tobias Hunger --- src/plugins/projectexplorer/toolchain.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/plugins/projectexplorer/toolchain.h') diff --git a/src/plugins/projectexplorer/toolchain.h b/src/plugins/projectexplorer/toolchain.h index 0f463bf801..7b41968d06 100644 --- a/src/plugins/projectexplorer/toolchain.h +++ b/src/plugins/projectexplorer/toolchain.h @@ -146,7 +146,7 @@ public: virtual bool operator ==(const ToolChain &) const; - virtual ToolChainConfigWidget *configurationWidget() = 0; + virtual std::unique_ptr createConfigurationWidget() = 0; virtual bool canClone() const; virtual ToolChain *clone() const = 0; -- cgit v1.2.3