From 54cf91b45b592fb5cd863747036abc438f09fb46 Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Thu, 12 Jan 2017 10:31:44 +0100 Subject: QtVersionManager: Remove QtVersionManager::versions(...) This call used to return a sorted list of BaseQtVersion *, which is expensive as sorting might imply running qmake for all Qt versions. This also makes BaseQtVersion::validVersions(...) return an unsorted list, so go over all usages of validVersions(...) and use QtVersionManager::sortVersions(...) where that is necessary. Change-Id: I8f5dda20fc0819134c64f6a1ca32512500f71710 Reviewed-by: Tim Jenssen --- src/plugins/qtsupport/qtversionmanager.h | 1 - 1 file changed, 1 deletion(-) (limited to 'src/plugins/qtsupport/qtversionmanager.h') diff --git a/src/plugins/qtsupport/qtversionmanager.h b/src/plugins/qtsupport/qtversionmanager.h index 38d26b3075..66fe047fbb 100644 --- a/src/plugins/qtsupport/qtversionmanager.h +++ b/src/plugins/qtsupport/qtversionmanager.h @@ -47,7 +47,6 @@ public: // This will *always* return at least one (Qt in Path), even if that is // unconfigured. // Sorting is slow due to needing to potentially run qmake --query for each version - static QList versions(const BaseQtVersion::Predicate &predicate = BaseQtVersion::Predicate()); static QList validVersions(const BaseQtVersion::Predicate &predicate = BaseQtVersion::Predicate()); static QList unsortedVersions(const BaseQtVersion::Predicate &predicate = BaseQtVersion::Predicate()); -- cgit v1.2.3