From 251287f0d35dd82e68dabed8214ef8af893aff91 Mon Sep 17 00:00:00 2001 From: hjk Date: Tue, 23 Jul 2019 10:58:00 +0200 Subject: Avoid warning on empty expressions For some reason, Q_UNUSED includes already a semicolon, adding one on the user side creates an additional empty statement. Change-Id: I9c5e8fac381345a60792cb75e2938fd53958d3b0 Reviewed-by: Christian Stenger --- src/plugins/valgrind/callgrind/callgrindcontroller.cpp | 2 +- src/plugins/valgrind/memchecktool.cpp | 2 +- src/plugins/valgrind/suppressiondialog.cpp | 2 +- src/plugins/valgrind/valgrindmemcheckparsertest.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/plugins/valgrind') diff --git a/src/plugins/valgrind/callgrind/callgrindcontroller.cpp b/src/plugins/valgrind/callgrind/callgrindcontroller.cpp index 7260f0090fe..f195d2e3742 100644 --- a/src/plugins/valgrind/callgrind/callgrindcontroller.cpp +++ b/src/plugins/valgrind/callgrind/callgrindcontroller.cpp @@ -187,7 +187,7 @@ void CallgrindController::controllerProcessFinished(int rc, QProcess::ExitStatus void CallgrindController::controllerProcessClosed(bool success) { - Q_UNUSED(success); + Q_UNUSED(success) // QTC_ASSERT(m_remote.m_process, return); // m_remote.m_errorString = m_remote.m_process->errorString(); diff --git a/src/plugins/valgrind/memchecktool.cpp b/src/plugins/valgrind/memchecktool.cpp index 6a699c46860..ed194129e97 100644 --- a/src/plugins/valgrind/memchecktool.cpp +++ b/src/plugins/valgrind/memchecktool.cpp @@ -818,7 +818,7 @@ void MemcheckToolPrivate::heobAction() // process environment QByteArray env; void *envPtr = nullptr; - Q_UNUSED(envPtr); + Q_UNUSED(envPtr) if (!envStrings.isEmpty()) { uint pos = 0; for (const QString &par : envStrings) { diff --git a/src/plugins/valgrind/suppressiondialog.cpp b/src/plugins/valgrind/suppressiondialog.cpp index fbd2b217260..e853791f8ca 100644 --- a/src/plugins/valgrind/suppressiondialog.cpp +++ b/src/plugins/valgrind/suppressiondialog.cpp @@ -227,7 +227,7 @@ void SuppressionDialog::accept() foreach (const QModelIndex &index, indices) { bool removed = model->removeRow(index.row()); QTC_ASSERT(removed, qt_noop()); - Q_UNUSED(removed); + Q_UNUSED(removed) } // One suppression might hide multiple rows, care for that. diff --git a/src/plugins/valgrind/valgrindmemcheckparsertest.h b/src/plugins/valgrind/valgrindmemcheckparsertest.h index 71da4cc3028..6dff0aef57d 100644 --- a/src/plugins/valgrind/valgrindmemcheckparsertest.h +++ b/src/plugins/valgrind/valgrindmemcheckparsertest.h @@ -123,7 +123,7 @@ public: } void processErrorReceived(const QString &s) { - Q_UNUSED(s); + Q_UNUSED(s) // qDebug() << "error received:" << s; // this can be a lot of text m_errorReceived = true; } -- cgit v1.2.3