From 957035155dcb5aaaca9b0d0db56431899dabfe98 Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Wed, 22 Aug 2018 12:02:08 +0200 Subject: QmlDesigner: Fix infinite loop if no prefix for id is provided If the prefix was empty the id would never become valid. Use "element" as a default prefix. Task-number: QDS-204 Change-Id: I01e4afd1e0da7bcada69a0c621bbe483f4098b90 Reviewed-by: Vikas Pachdha --- src/plugins/qmldesigner/designercore/model/abstractview.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src') diff --git a/src/plugins/qmldesigner/designercore/model/abstractview.cpp b/src/plugins/qmldesigner/designercore/model/abstractview.cpp index 9c4b768535f..413492a1211 100644 --- a/src/plugins/qmldesigner/designercore/model/abstractview.cpp +++ b/src/plugins/qmldesigner/designercore/model/abstractview.cpp @@ -489,6 +489,8 @@ QString firstCharToLower(const QString &string) QString AbstractView::generateNewId(const QString &prefixName) const { + if (ModelNode::isValidId(prefixName)) + return generateNewId("element"); int counter = 1; /* First try just the prefixName without number as postfix, then continue with 2 and further as postfix -- cgit v1.2.3