/**************************************************************************** ** ** Copyright (C) 2016 The Qt Company Ltd. ** Author: Milian Wolff, KDAB (milian.wolff@kdab.com) ** Contact: https://www.qt.io/licensing/ ** ** This file is part of Qt Creator. ** ** Commercial License Usage ** Licensees holding valid commercial Qt licenses may use this file in ** accordance with the commercial license agreement provided with the ** Software or, alternatively, in accordance with the terms contained in ** a written agreement between you and The Qt Company. For licensing terms ** and conditions see https://www.qt.io/terms-conditions. For further ** information use the contact form at https://www.qt.io/contact-us. ** ** GNU General Public License Usage ** Alternatively, this file may be used under the terms of the GNU ** General Public License version 3 as published by the Free Software ** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT ** included in the packaging of this file. Please review the following ** information to ensure the GNU General Public License requirements will ** be met: https://www.gnu.org/licenses/gpl-3.0.html. ** ****************************************************************************/ #include "suppressiondialog.h" #include "memcheckerrorview.h" #include "valgrindsettings.h" #include "xmlprotocol/suppression.h" #include "xmlprotocol/errorlistmodel.h" #include "xmlprotocol/stack.h" #include "xmlprotocol/frame.h" #include #include #include #include #include #include #include #include #include #include #include #include #include #include using namespace Valgrind::XmlProtocol; namespace Valgrind { namespace Internal { static QString suppressionText(const Error &error) { Suppression sup(error.suppression()); // workaround: https://bugs.kde.org/show_bug.cgi?id=255822 if (sup.frames().size() >= 24) sup.setFrames(sup.frames().mid(0, 23)); QTC_ASSERT(sup.frames().size() < 24, /**/); // try to set some useful name automatically, instead of "insert_name_here" // we take the last stack frame and append the suppression kind, e.g.: // QDebug::operator<<(bool) [Memcheck:Cond] if (!error.stacks().isEmpty() && !error.stacks().constFirst().frames().isEmpty()) { const Frame frame = error.stacks().constFirst().frames().constFirst(); QString newName; if (!frame.functionName().isEmpty()) newName = frame.functionName(); else if (!frame.object().isEmpty()) newName = frame.object(); if (!newName.isEmpty()) sup.setName(newName + '[' + sup.kind() + ']'); } return sup.toString(); } /// @p error input error, which might get hidden when it has the same stack /// @p suppressed the error that got suppressed already static bool equalSuppression(const Error &error, const Error &suppressed) { if (error.kind() != suppressed.kind() || error.suppression().isNull()) return false; const SuppressionFrames errorFrames = error.suppression().frames(); const SuppressionFrames suppressedFrames = suppressed.suppression().frames(); // limit to 23 frames, see: https://bugs.kde.org/show_bug.cgi?id=255822 if (qMin(23, suppressedFrames.size()) > errorFrames.size()) return false; int frames = 23; if (errorFrames.size() < frames) frames = errorFrames.size(); if (suppressedFrames.size() < frames) frames = suppressedFrames.size(); for (int i = 0; i < frames; ++i) if (errorFrames.at(i) != suppressedFrames.at(i)) return false; return true; } SuppressionDialog::SuppressionDialog(MemcheckErrorView *view, const QList &errors) : m_view(view), m_settings(view->settings()), m_cleanupIfCanceled(false), m_errors(errors), m_fileChooser(new Utils::PathChooser(this)), m_suppressionEdit(new QPlainTextEdit(this)) { setWindowTitle(tr("Save Suppression")); auto fileLabel = new QLabel(tr("Suppression File:"), this); auto suppressionsLabel = new QLabel(tr("Suppression:"), this); suppressionsLabel->setBuddy(m_suppressionEdit); QFont font; font.setFamily("Monospace"); m_suppressionEdit->setFont(font); m_buttonBox = new QDialogButtonBox(this); m_buttonBox->setStandardButtons(QDialogButtonBox::Cancel|QDialogButtonBox::Save); auto formLayout = new QFormLayout(this); formLayout->addRow(fileLabel, m_fileChooser); formLayout->addRow(suppressionsLabel); formLayout->addRow(m_suppressionEdit); formLayout->addRow(m_buttonBox); QFile defaultSuppFile(view->defaultSuppressionFile()); if (!defaultSuppFile.exists()) { if (defaultSuppFile.open(QIODevice::WriteOnly)) { defaultSuppFile.close(); m_cleanupIfCanceled = true; } } m_fileChooser->setExpectedKind(Utils::PathChooser::File); m_fileChooser->setHistoryCompleter("Valgrind.Suppression.History"); m_fileChooser->setPath(defaultSuppFile.fileName()); m_fileChooser->setPromptDialogFilter("*.supp"); m_fileChooser->setPromptDialogTitle(tr("Select Suppression File")); QString suppressions; foreach (const Error &error, m_errors) suppressions += suppressionText(error); m_suppressionEdit->setPlainText(suppressions); connect(m_fileChooser, &Utils::PathChooser::validChanged, this, &SuppressionDialog::validate); connect(m_suppressionEdit->document(), &QTextDocument::contentsChanged, this, &SuppressionDialog::validate); connect(m_buttonBox, &QDialogButtonBox::accepted, this, &SuppressionDialog::accept); connect(m_buttonBox, &QDialogButtonBox::rejected, this, &SuppressionDialog::reject); } void SuppressionDialog::maybeShow(MemcheckErrorView *view) { QModelIndexList indices = view->selectionModel()->selectedRows(); // Can happen when using arrow keys to navigate and shortcut to trigger suppression: if (indices.isEmpty() && view->selectionModel()->currentIndex().isValid()) indices.append(view->selectionModel()->currentIndex()); QList errors; foreach (const QModelIndex &index, indices) { Error error = view->model()->data(index, ErrorListModel::ErrorRole).value(); if (!error.suppression().isNull()) errors.append(error); } if (errors.isEmpty()) return; SuppressionDialog dialog(view, errors); dialog.exec(); } void SuppressionDialog::accept() { const QString path = m_fileChooser->filePath().toString(); QTC_ASSERT(!path.isEmpty(), return); QTC_ASSERT(!m_suppressionEdit->toPlainText().trimmed().isEmpty(), return); Utils::FileSaver saver(path, QIODevice::Append); if (!saver.hasError()) { QTextStream stream(saver.file()); stream << m_suppressionEdit->toPlainText(); saver.setResult(&stream); } if (!saver.finalize(this)) return; // Add file to project if there is a project containing this file on the file system. if (!ProjectExplorer::SessionManager::projectForFile(Utils::FilePath::fromString(path))) { for (ProjectExplorer::Project *p : ProjectExplorer::SessionManager::projects()) { if (path.startsWith(p->projectDirectory().toString())) { p->rootProjectNode()->addFiles(QStringList() << path); break; } } } m_settings->addSuppressionFiles(QStringList(path)); QModelIndexList indices = m_view->selectionModel()->selectedRows(); Utils::sort(indices, [](const QModelIndex &l, const QModelIndex &r) { return l.row() > r.row(); }); QAbstractItemModel *model = m_view->model(); foreach (const QModelIndex &index, indices) { bool removed = model->removeRow(index.row()); QTC_ASSERT(removed, qt_noop()); Q_UNUSED(removed) } // One suppression might hide multiple rows, care for that. for (int row = 0; row < model->rowCount(); ++row ) { const Error rowError = model->data( model->index(row, 0), ErrorListModel::ErrorRole).value(); foreach (const Error &error, m_errors) { if (equalSuppression(rowError, error)) { bool removed = model->removeRow(row); QTC_CHECK(removed); // Gets incremented in the for loop again. --row; break; } } } // Select a new item. m_view->setCurrentIndex(indices.first()); QDialog::accept(); } void SuppressionDialog::reject() { if (m_cleanupIfCanceled) QFile::remove(m_view->defaultSuppressionFile()); QDialog::reject(); } void SuppressionDialog::validate() { bool valid = m_fileChooser->isValid() && !m_suppressionEdit->toPlainText().trimmed().isEmpty(); m_buttonBox->button(QDialogButtonBox::Save)->setEnabled(valid); } } // namespace Internal } // namespace Valgrind