diff options
author | Joerg Bornemann <joerg.bornemann@qt.io> | 2016-11-11 10:33:57 +0100 |
---|---|---|
committer | Joerg Bornemann <joerg.bornemann@qt.io> | 2016-11-11 12:13:50 +0000 |
commit | 3cb1b0636e5aceb3c884364bf2589d8754965b5f (patch) | |
tree | cabfb83f402f7c6eb64e0257336743930545147c | |
parent | ea5e15fb0fc4cc8d7fdc4b970e3166da460d7116 (diff) |
Remove usages of qFind
Both occurrences were used to remove one element from a container.
Replace with removeOne to simplify the code.
Change-Id: I8010acd3b461a04a7d5c72ed2ba9b1aee45c883d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
-rw-r--r-- | src/jomlib/dependencygraph.cpp | 4 | ||||
-rw-r--r-- | src/jomlib/makefile.cpp | 6 |
2 files changed, 2 insertions, 8 deletions
diff --git a/src/jomlib/dependencygraph.cpp b/src/jomlib/dependencygraph.cpp index 3d3ddb9..382a13b 100644 --- a/src/jomlib/dependencygraph.cpp +++ b/src/jomlib/dependencygraph.cpp @@ -269,10 +269,8 @@ void DependencyGraph::removeLeaf(Node* node) m_leaves.removeAll(node); - QList<Node*>::iterator it; foreach (Node* parent, node->parents) { - it = qFind(parent->children.begin(), parent->children.end(), node); - parent->children.erase(it); + parent->children.removeOne(node); if (parent->children.isEmpty()) { m_bDirtyLeaves = true; m_leaves.append(parent); diff --git a/src/jomlib/makefile.cpp b/src/jomlib/makefile.cpp index 78b11a5..c550f1d 100644 --- a/src/jomlib/makefile.cpp +++ b/src/jomlib/makefile.cpp @@ -546,11 +546,7 @@ static bool infRulesPriorityGreaterThan(const InferenceRule *lhs, const Inferenc void Makefile::addInferenceRule(InferenceRule *rule) { - QVector<InferenceRule *>::iterator it = qFind(m_inferenceRules.begin(), - m_inferenceRules.end(), - rule); - if (it != m_inferenceRules.end()) - m_inferenceRules.erase(it); + m_inferenceRules.removeOne(rule); m_inferenceRules.append(rule); } |