From 3cb1b0636e5aceb3c884364bf2589d8754965b5f Mon Sep 17 00:00:00 2001 From: Joerg Bornemann Date: Fri, 11 Nov 2016 10:33:57 +0100 Subject: Remove usages of qFind Both occurrences were used to remove one element from a container. Replace with removeOne to simplify the code. Change-Id: I8010acd3b461a04a7d5c72ed2ba9b1aee45c883d Reviewed-by: Christian Kandeler --- src/jomlib/dependencygraph.cpp | 4 +--- src/jomlib/makefile.cpp | 6 +----- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/jomlib/dependencygraph.cpp b/src/jomlib/dependencygraph.cpp index 3d3ddb9..382a13b 100644 --- a/src/jomlib/dependencygraph.cpp +++ b/src/jomlib/dependencygraph.cpp @@ -269,10 +269,8 @@ void DependencyGraph::removeLeaf(Node* node) m_leaves.removeAll(node); - QList::iterator it; foreach (Node* parent, node->parents) { - it = qFind(parent->children.begin(), parent->children.end(), node); - parent->children.erase(it); + parent->children.removeOne(node); if (parent->children.isEmpty()) { m_bDirtyLeaves = true; m_leaves.append(parent); diff --git a/src/jomlib/makefile.cpp b/src/jomlib/makefile.cpp index 78b11a5..c550f1d 100644 --- a/src/jomlib/makefile.cpp +++ b/src/jomlib/makefile.cpp @@ -546,11 +546,7 @@ static bool infRulesPriorityGreaterThan(const InferenceRule *lhs, const Inferenc void Makefile::addInferenceRule(InferenceRule *rule) { - QVector::iterator it = qFind(m_inferenceRules.begin(), - m_inferenceRules.end(), - rule); - if (it != m_inferenceRules.end()) - m_inferenceRules.erase(it); + m_inferenceRules.removeOne(rule); m_inferenceRules.append(rule); } -- cgit v1.2.3