From 0d532f42f7dd223483a1304b3b0ee13bd26be734 Mon Sep 17 00:00:00 2001
From: Frederik Gladhorn <frederik.gladhorn@digia.com>
Date: Fri, 17 Oct 2014 17:45:20 +0200
Subject: Use const refs
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Change-Id: Id9c662aa553a453bf0510ca12e0ef2126896433d
Reviewed-by: Jan Arve Sæther <jan-arve.saether@theqtcompany.com>
Reviewed-by: Caroline Chao <caroline.chao@theqtcompany.com>
---
 src/cities.cpp   |  2 +-
 src/cities.h     |  2 +-
 src/daymodel.cpp |  6 +++---
 src/daymodel.h   | 10 +++++-----
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/cities.cpp b/src/cities.cpp
index 0294d64..a256cc2 100644
--- a/src/cities.cpp
+++ b/src/cities.cpp
@@ -109,7 +109,7 @@ void Cities::readCities()
     file.close();
 }
 
-int Cities::processSourceXml(const QString sourceXml)
+int Cities::processSourceXml(const QString &sourceXml)
 {
     // Dont add save town/identical sourceXml twice
     for (int i = 0; i <m_cityMap.count(); i++) {
diff --git a/src/cities.h b/src/cities.h
index ee0e0bd..51c48ec 100644
--- a/src/cities.h
+++ b/src/cities.h
@@ -65,7 +65,7 @@ public:
     Q_INVOKABLE CityModel* getCityModel(const int index);
     Q_INVOKABLE void removeCityModel(const int index);
     int addCityModel(CityModel *model);
-    Q_INVOKABLE int processSourceXml(const QString sourceXml);
+    Q_INVOKABLE int processSourceXml(const QString &sourceXml);
 
     QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const;
     QHash<int, QByteArray> roleNames() const;
diff --git a/src/daymodel.cpp b/src/daymodel.cpp
index 82aa022..412ba94 100644
--- a/src/daymodel.cpp
+++ b/src/daymodel.cpp
@@ -94,7 +94,7 @@ void DayModel::clear()
     m_data.clear();
 }
 
-void DayModel::addRow(QString weatherUrl, QString from, QString to, QString temperature, QString windSpeed, QString windDirectionName, QString windUrl, QString rain) {
+void DayModel::addRow(const QString &weatherUrl, const QString &from, const QString &to, const QString &temperature, const QString &windSpeed, const QString &windDirectionName, const QString &windUrl, const QString &rain) {
     QStringList m_images;
     DayModelStructure temp;
     temp.from = from;
@@ -113,7 +113,7 @@ void DayModel::addRow(QString weatherUrl, QString from, QString to, QString temp
     emit addedImages(m_images);
 }
 
-QUrl DayModel::getCachedImageFile(const QString url)
+QUrl DayModel::getCachedImageFile(const QString &url)
 {
     bool isLargeImage = url.contains("b200");
     QString baseFilename = url.right(url.length() - url.lastIndexOf("/") - 1);
@@ -135,7 +135,7 @@ QUrl DayModel::getCachedImageFile(const QString url)
     }
 }
 
-QString DayModel::getDayDetails(int index, QString prop) const
+QString DayModel::getDayDetails(int index, const QString &prop) const
 {
     if (index == -1)
         index = 0;
diff --git a/src/daymodel.h b/src/daymodel.h
index 13291b9..c5bbfc8 100644
--- a/src/daymodel.h
+++ b/src/daymodel.h
@@ -85,7 +85,7 @@ public:
     DayModel();
 
     QString getDate() const { return m_date;}
-    void setDate(QString date) { m_date = date; }
+    void setDate(const QString &date) { m_date = date; }
 
     int getAfternoonIndex() const { return m_afternoonindex;}
     void setAfternoonIndex(int index) { m_afternoonindex = index; }
@@ -95,16 +95,16 @@ public:
     QVariant data(const QModelIndex &index, int role) const;
     QHash<int, QByteArray> roleNames() const;
 
-    Q_INVOKABLE void addRow(QString weatherUrl, QString from, QString to, QString temperature, QString windSpeed, QString windDirectionName, QString windUrl, QString rain);
-    Q_INVOKABLE QString getDayDetails(int index, QString prop) const;
+    Q_INVOKABLE void addRow(const QString &weatherUrl, const QString &from, const QString &to, const QString &temperature, const QString &windSpeed, const QString &windDirectionName, const QString &windUrl, const QString &rain);
+    Q_INVOKABLE QString getDayDetails(int index, const QString &prop) const;
     Q_INVOKABLE int periodCount() const { return m_data.count(); }
 
-    Q_INVOKABLE QUrl getCachedImageFile(const QString url);
+    Q_INVOKABLE QUrl getCachedImageFile(const QString &url);
 
 Q_SIGNALS:
     void dateChanged();
     void afternoonIndexChanged();
-    void addedImages(const QStringList images);
+    void addedImages(const QStringList &images);
 
 private:
     QString m_date;
-- 
cgit v1.2.3