diff options
| author | David Faure <faure@kde.org> | 2009-06-18 08:27:37 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@nokia.com> | 2009-06-18 08:27:37 +0200 |
| commit | 7e8008cdd707d4ea3504df4ad02a4589c7b16510 (patch) | |
| tree | 8ee79814606469897c6e6ed0d1cfb4dcd6a3e401 /tools/qtconfig | |
| parent | 7d6da125cb94f70f2b14b60c87ded71876e28149 (diff) | |
Fix nasty qt3-qt4 porting trap: for a QStringList, lst.remove(lst.at(idx)) used to only remove one item in Qt3, while it removes all occurrences of the item in Qt4 (remove==removeAll). To catch it I commented out remove(T) in my qlist.h, which caught this.
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Diffstat (limited to 'tools/qtconfig')
| -rw-r--r-- | tools/qtconfig/mainwindow.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/qtconfig/mainwindow.cpp b/tools/qtconfig/mainwindow.cpp index eabaec6cca..a59f7905e9 100644 --- a/tools/qtconfig/mainwindow.cpp +++ b/tools/qtconfig/mainwindow.cpp @@ -829,7 +829,7 @@ void MainWindow::removeSubstitute() int item = sublistbox->currentItem(); QStringList subs = QFont::substitutes(familysubcombo->currentText()); - subs.remove(subs.at(sublistbox->currentItem())); + subs.removeAt(sublistbox->currentItem()); sublistbox->clear(); sublistbox->insertStringList(subs); if (uint(item) > sublistbox->count()) @@ -909,7 +909,7 @@ void MainWindow::removeFontpath() return; int item = fontpathlistbox->currentItem(); - fontpaths.remove(fontpaths.at(fontpathlistbox->currentItem())); + fontpaths.removeAt(fontpathlistbox->currentItem()); fontpathlistbox->clear(); fontpathlistbox->insertStringList(fontpaths); if (uint(item) > fontpathlistbox->count()) |