diff options
Diffstat (limited to 'src/3rdparty/webkit/WebCore/ChangeLog')
| -rw-r--r-- | src/3rdparty/webkit/WebCore/ChangeLog | 13502 |
1 files changed, 13474 insertions, 28 deletions
diff --git a/src/3rdparty/webkit/WebCore/ChangeLog b/src/3rdparty/webkit/WebCore/ChangeLog index 493a64d1e5..1dfc2f97fe 100644 --- a/src/3rdparty/webkit/WebCore/ChangeLog +++ b/src/3rdparty/webkit/WebCore/ChangeLog @@ -1,3 +1,8488 @@ +2009-11-03 Simon Hausmann <hausmann@webkit.org> + + Unreviewed build fix for WebInspector with Qt build. + + Simply re-generate the Qt resource file by running + WebKitTools/Scripts/generate-qt-inspector-resource + + * inspector/front-end/WebKit.qrc: + +2009-11-03 Simon Hausmann <hausmann@webkit.org> + + Reviewed by Tor Arne Vestbø. + + Make QWebPluginDatabase private API for now. + + https://bugs.webkit.org/show_bug.cgi?id=30775 + + * WebCore.pro: + +2009-11-03 Simon Hausmann <hausmann@webkit.org> + + Reviewed by Tor Arne Vestbø. + + Extended the conversion of the WebCore ResourceRequest to the + QNetworkRequest with a mandatory originating object argument, + which is meant to be the QWebFrame the request belongs to. + + https://bugs.webkit.org/show_bug.cgi?id=29975 + + * platform/network/qt/QNetworkReplyHandler.cpp: + (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): + (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): + (WebCore::QNetworkReplyHandler::start): + * platform/network/qt/ResourceRequest.h: + * platform/network/qt/ResourceRequestQt.cpp: + (WebCore::ResourceRequest::toNetworkRequest): + +2009-11-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> + + Reviewed by Adam Barth. + + QWebView crash fix. + + The QWebView should not crash if the stop() method is called from + a function triggered by the loadProgress signal. + + A null pointer protection was added in the ProgressTracker::incrementProgress. + + New autotest was created. + + https://bugs.webkit.org/show_bug.cgi?id=29425 + + * loader/ProgressTracker.cpp: + (WebCore::ProgressTracker::incrementProgress): + +2009-11-02 Kai Koehne <kai.koehne@nokia.com> + + Reviewed by Holger Freyther. + + Remove implementation of ImageDecocerQt::clearFrameBufferCache. + The implementation was buggy, and will visually break repeating + animations anyway. + + https://bugs.webkit.org/show_bug.cgi?id=31009 + + * platform/graphics/qt/ImageDecoderQt.cpp: + (WebCore::ImageDecoderQt::clearFrameBufferCache): + +2009-11-01 Yael Aharon <yael.aharon@nokia.com> + + Reviewed by Darin Adler. + + Don't add '/' to the URL path if the it does not include '/' after the protocol component + https://bugs.webkit.org/show_bug.cgi?id=30971 + + Match IE8 behaviour, that does not add '/' if there is none after the protocol component. + + * platform/KURL.cpp: + (WebCore::KURL::parse): + +2009-10-30 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Holger Hans Peter Freyther. + + If the owner widget of the page has a palette set, we + should use that one. This was only working when the + owner was a QWebView. This patch fixes that. + + * platform/qt/RenderThemeQt.cpp: + (WebCore::RenderThemeQt::applyTheme): + +2009-10-29 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Tor Arne Vestbø. + + [Qt] Implement DELETE HTTP method for XmlHttpRequest + https://bugs.webkit.org/show_bug.cgi?id=30894 + + No new tests as this functionality is already tested by the + xmlhttprequest LayoutTests. As this patch depends on an unreleased + version of the dependent QtNetwork library and the tests will be + enabled later once the dependent library is released (and the + buildbot is updated). + + * platform/network/qt/QNetworkReplyHandler.cpp: + (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): + (WebCore::QNetworkReplyHandler::start): + +2009-11-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Rubber-stamped by Antti Koivisto. + + [Qt] Build fix for Windows CE + + * plugins/PluginDatabase.cpp: + +2009-11-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Tor Arne Vestbø. + + [Qt] Fix Qt build on Windows. + https://bugs.webkit.org/show_bug.cgi?id=30905 + + * WebCore.pro: + * platform/graphics/BitmapImage.h: + * platform/graphics/qt/ImageQt.cpp: + (WebCore::BitmapImage::BitmapImage): + (WebCore::BitmapImage::create): + +2009-10-28 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Don't run JavaScript URLs in view source mode + https://bugs.webkit.org/show_bug.cgi?id=30881 + + Just say no. + + Test: http/tests/security/view-source-no-javascript-url.html + + * bindings/ScriptControllerBase.cpp: + (WebCore::ScriptController::executeIfJavaScriptURL): + +2009-10-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Unreviewed. Fixes style problems pointed out by Evan Martin. + + * platform/gtk/Language.cpp: + (WebCore::defaultLanguage): + +2009-10-29 Dan Bernstein <mitz@apple.com> + + Rubber-stamped by Mark Rowe. + + 64-bit Leopard build fix after r50259 + + * platform/graphics/mac/ComplexTextControllerATSUI.cpp: + Declared ATSUTextInserted in 64-bit. + (WebCore::fontHasMirroringInfo): Use %d format and cast to int. + (WebCore::disableLigatures): Ditto. + (WebCore::initializeATSUStyle): Ditto. + (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Ditto. + +2009-10-29 Dan Bernstein <mitz@apple.com> + + Tiger build fix after r50259 + + * platform/graphics/mac/ComplexTextController.h: + * platform/graphics/mac/ComplexTextControllerATSUI.cpp: + +2009-10-29 Dan Bernstein <mitz@apple.com> + + Attempted Tiger build fix after r50259 + + * platform/graphics/mac/ComplexTextControllerATSUI.cpp: + +2009-10-28 Steve Falkenburg <sfalken@apple.com> + + Rubber stamped by Mark Rowe. + + https://bugs.webkit.org/show_bug.cgi?id=30899 + WebKit fails to build release on 32-bit Windows systems + + * WebCore.vcproj/WebCore.vcproj: Excluded files from project. + * bindings/js/JSBindingsAllInOne.cpp: Added. + +2009-10-28 Dan Bernstein <mitz@apple.com> + + Reviewed by Jon Honeycutt. + + Fixed typos in color names. + + * inspector/front-end/Color.js: + +2009-10-28 Dan Bernstein <mitz@apple.com> + + Reviewed by Sam Weinig. + + Share code between the ATSUI- and Core Text-based Font implementations by doing the + following: + - Generalize CoreTextController as ComplexTextController, keeping the Core Text-specific + parts in ComplexTextControllerCoreText.cpp. + - Generalize FontMacCoreText as FontComplexTextMac using ComplexTextController + - Implement ATSUI-specific parts of ComplexTextController in ComplexTextControllerATSUI. + - Remove FontMacATSUI. + + * WebCore.xcodeproj/project.pbxproj: Removed CoreTextController.{cpp,h}, FontMacATSUI.mm, + and FontMacCoreText.cpp, and added ComplexTextController.{cpp,h}, + ComplexTextControllerATSUI.cpp, ComplexTextControllerCoreText.cpp, and + FontComplexTextMac.cpp. + + * platform/graphics/mac/ComplexTextController.cpp: Copied from CoreTextController.cpp and + kept the non-Core Text-specific bits. + (WebCore::ComplexTextController::ComplexTextController): Updated for renames, including + its own. + (WebCore::ComplexTextController::offsetForPosition): Updated for renames and for + m_complexTextRuns holding references instead of objects. + (WebCore::ComplexTextController::collectComplexTextRuns): Updated for renames, including + its own. + (WebCore::ComplexTextController::advance): Updated for renames. + (WebCore::ComplexTextController::adjustGlyphsAndAdvances): Updated for renames and for + m_complexTextRuns holding references instead of objects, and changed to use the glyphs() + and advances() accessors. + + * platform/graphics/mac/ComplexTextController.h: Copied from CoreTextController.h and + renamed CoreTextController to ComplexTextController and CoreTextRun to ComplexTextRun. Made + the latter RefCounted, added ATSUI-specific members to it, and made some other members + Core Text-specific. Renamed m_coreTextRuns to m_complexTextRuns and made it hold references + rather than objects. + (WebCore::ComplexTextController::ComplexTextRun::create): + (WebCore::ComplexTextController::ComplexTextRun::glyphs): + (WebCore::ComplexTextController::ComplexTextRun::advances): + + * platform/graphics/mac/ComplexTextControllerATSUI.cpp: Added. Includes ATSUI-specific + parts of the ComplexTextController implementation. + (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): This ATSUI + callback populates the ComplexTextRun’s glyphs, advances and indices vectors. It is invoked + when the ComplexTextRun constructor calls ATSUGetGlyphBounds(). + (WebCore::isArabicLamWithAlefLigature): Helper function, copied from FontMacATSUI.mm. + (WebCore::shapeArabic): Helper function, adapted from FontMacATSUI.mm. + (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Sets up the + ATSUTextLayout, substituting the text buffer if necessary for things like shaping Arabic, + mirroring glyphs or directionality overrides, then calls ATSUGetGlyphBounds() in order to + get the glyphs, advances and indices vectors populated. + (WebCore::fontHasMirroringInfo): Helper function, copied from FontMacATSUI.mm. + (WebCore::disableLigatures): Ditto. + (WebCore::initializeATSUStyle): Ditto, somewhat cleaned up and simplified. + (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Constructs + ComplexTextRuns, either missing-glyphs ones or ATSUTextLayout-based ones. + + * platform/graphics/mac/ComplexTextControllerCoreText.cpp: Copied from + CoreTextController.cpp and kept the Core Text-specific bits. + (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Updated for renames, + including its own, and moved the code to initialize m_glyphs and m_advances here. Previously + this was done in adjustGlyphsAndAdvances(). + (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Updated for renames, + including its own. + * platform/graphics/mac/CoreTextController.cpp: Removed. + * platform/graphics/mac/CoreTextController.h: Removed. + * platform/graphics/mac/FontComplexTextMac.cpp: Renamed FontMacCoreText.cpp to this. + (WebCore::Font::selectionRectForComplexText): Changed to use ComplexTextController instead + of CoreTextController. + (WebCore::Font::drawComplexText): Ditto. + (WebCore::Font::floatWidthForComplexText): Ditto. + (WebCore::Font::offsetForPositionForComplexText): Ditto. + * platform/graphics/mac/FontMacATSUI.mm: Removed. + * platform/graphics/mac/FontMacCoreText.cpp: Removed. + +2009-10-27 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Darin Adler. + + WAI-ARIA: add support for 'option' role + https://bugs.webkit.org/show_bug.cgi?id=30843 + + Test: accessibility/aria-option-role.html + + * accessibility/AccessibilityListBoxOption.h: + (WebCore::AccessibilityListBoxOption::canHaveChildren): + * accessibility/AccessibilityRenderObject.cpp: + (WebCore::RoleEntry::): + (WebCore::AccessibilityRenderObject::canHaveChildren): + +2009-10-28 Jens Alfke <snej@chromium.org> + + Reviewed by Eric Seidel. + + Fix GCC compiler warnings in WebCore, and enable -Wall and -Werror for Chromium build. + https://bugs.webkit.org/show_bug.cgi?id=30716 + + * WebCore.gyp/WebCore.gyp: Enable "chromium_code" flag, just on Mac build for now. + * accessibility/AccessibilityRenderObject.cpp: + (WebCore::createARIARoleMap): Fix struct visibiity warning. + * bindings/v8/ScriptCallStack.h: Fix out-of-order member initialization warning. + * bindings/v8/V8Collection.h: + (WebCore::getV8Object): Function in header should not be 'static' (fixes unused-static warning.) + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::convertNewNodeToV8Object): Fix signed/unsigned comparison warning. + * bindings/v8/V8GCController.cpp: + (WebCore::ObjectGrouperVisitor::applyGrouping): Fix unused-variable warning. + * css/CSSPrimitiveValueMappings.h: + (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Enable ListButtonPart case to avoid + warning about missing cases in 'switch' statement. + * editing/EditorCommand.cpp: + (WebCore::createCommandMap): Fix struct visibiity warning. + * platform/graphics/skia/PlatformContextSkia.cpp: + (PlatformContextSkia::State::State): Fix out-of-order member initialization warning. + * rendering/RenderMediaControlsChromium.cpp: + (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Add empty 'default' case in + 'switch' statement to avoid missing-case warning. + (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Ditto. + * xml/XPathFunctions.cpp: + (WebCore::XPath::createFunctionMap): Fix struct visibiity warning. + +2009-10-29 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + REGRESSION: crashes in WebCore::RedirectScheduler::timerFired(WebCore::Timer<WebCore::RedirectScheduler>*) + https://bugs.webkit.org/show_bug.cgi?id=30839 + + Added null check for the case when the frame is detached from the page. + + * loader/RedirectScheduler.cpp: + (WebCore::RedirectScheduler::timerFired): + +2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Xan Lopez. + + https://bugs.webkit.org/show_bug.cgi?id=30817 + Use parentObjectUnignored instead of parentObject in webkit_accessible_get_parent + + Also removes the hack I had originally added to solve bug 25411, because + the fix here is what I should have done in the first place. + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (webkit_accessible_get_parent): + +2009-10-28 Dmitry Titov <dimich@chromium.org> + + Reviewed by David Levin. + + https://bugs.webkit.org/show_bug.cgi?id=30805 + Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue. + Existing Database tests cover this, no change in functionality. + + * storage/DatabaseThread.cpp: + (WebCore::SameDatabasePredicate::SameDatabasePredicate): Added predicate that flags the tasks belonging to a specified database. + (WebCore::SameDatabasePredicate::operator()): + (WebCore::DatabaseThread::unscheduleDatabaseTasks): changed to use the new removeIf method. + +2009-10-28 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Glue subsequent timeline records with same category + and title together. + + https://bugs.webkit.org/show_bug.cgi?id=30885 + + * English.lproj/localizedStrings.js: + * inspector/front-end/TimelinePanel.js: + (WebInspector.TimelinePanel.prototype.addRecordToTimeline): + (WebInspector.TimelinePanel.prototype._formatRecord): + (WebInspector.TimelineRecordTreeElement.prototype.onattach): + (WebInspector.TimelineRecordTreeElement.prototype.refresh): + +2009-10-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Reviewed by Xan Lopez. + + [GTK] Fails new test fast/js/navigator-language.html + https://bugs.webkit.org/show_bug.cgi?id=30440 + + Reimplement WebCore::defaultLanguage to account for changes in + locale done by setLocale. + + Already existing test: fast/js/navigator-language.html + + * platform/gtk/Language.cpp: + (WebCore::defaultLanguage): + +2009-10-28 Eric Carlson <eric.carlson@apple.com> + + Reviewed by Simon Fraser. + + <rdar://problem/7303145> + Can't exit full screen mode or restart movie after pressing command -R. + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::removedFromDocument): + (WebCore::HTMLMediaElement::documentWillBecomeInactive): + Exit from fullscreen if necessary. + * html/HTMLMediaElement.h: + +2009-10-28 Alexey Proskuryakov <ap@apple.com> + + Unreviewed - a trivial fix to get Windows bots running. + + https://bugs.webkit.org/show_bug.cgi?id=30841 + <rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site + + * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): Don't try to + access empty vector's data. + +2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Xan Lopez. + + https://bugs.webkit.org/show_bug.cgi?id=25897 + [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries + + Remove the extraneous object of ROLE_PANEL. + + * accessibility/gtk/AccessibilityObjectAtk.cpp: + (AccessibilityObject::accessibilityPlatformIncludesObject): + +2009-10-28 Jonathan Dixon <joth@chromium.org> + + Reviewed by Eric Seidel. + + Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius + https://bugs.webkit.org/show_bug.cgi?id=30547 + + Test: fast/css/text-input-with-webkit-border-radius.html + + * rendering/RenderThemeChromiumWin.cpp: + (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): + Implemented rounded border rendering in Chromium Windows theme renderer. + +2009-10-28 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Pull items collections from resources panel and + timeline panel into AbstractTimelinePanel. + + https://bugs.webkit.org/show_bug.cgi?id=30875 + + * inspector/front-end/AbstractTimelinePanel.js: + (WebInspector.AbstractTimelinePanel): + (WebInspector.AbstractTimelinePanel.prototype.populateSidebar): + (WebInspector.AbstractTimelinePanel.prototype.createItemTreeElement): + (WebInspector.AbstractTimelinePanel.prototype.createItemGraph): + (WebInspector.AbstractTimelinePanel.prototype._showCategory): + (WebInspector.AbstractTimelinePanel.prototype._hideCategory): + (WebInspector.AbstractTimelinePanel.prototype.filter): + (WebInspector.AbstractTimelinePanel.prototype._createGraph): + (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): + (WebInspector.AbstractTimelinePanel.prototype.refresh): + (WebInspector.AbstractTimelinePanel.prototype.reset): + (WebInspector.AbstractTimelinePanel.prototype.get calculator): + (WebInspector.AbstractTimelinePanel.prototype.set calculator): + (WebInspector.AbstractTimelinePanel.prototype.addItem): + (WebInspector.AbstractTimelinePanel.prototype.removeItem): + (WebInspector.AbstractTimelinePanel.prototype.refreshItem): + (WebInspector.AbstractTimelinePanel.prototype.revealAndSelectItem): + (WebInspector.AbstractTimelinePanel.prototype.sortItems): + (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition): + (WebInspector.AbstractTimelineCategory): + (WebInspector.AbstractTimelineCategory.prototype.toString): + * inspector/front-end/ResourceCategory.js: + (WebInspector.ResourceCategory): + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel): + (WebInspector.ResourcesPanel.prototype.createItemTreeElement): + (WebInspector.ResourcesPanel.prototype.createItemGraph): + (WebInspector.ResourcesPanel.prototype.isCategoryVisible): + (WebInspector.ResourcesPanel.prototype.populateSidebar): + (WebInspector.ResourcesPanel.prototype.get searchableViews): + (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction.sortFuction): + (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction): + (WebInspector.ResourcesPanel.prototype.searchMatchFound): + (WebInspector.ResourcesPanel.prototype.searchCanceled): + (WebInspector.ResourcesPanel.prototype.performSearch): + (WebInspector.ResourcesPanel.prototype.refresh): + (WebInspector.ResourcesPanel.prototype.reset): + (WebInspector.ResourcesPanel.prototype.removeResource): + (WebInspector.ResourcesPanel.prototype.addMessageToResource): + (WebInspector.ResourcesPanel.prototype.clearMessages): + (WebInspector.ResourcesPanel.prototype.refreshResource): + (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): + (WebInspector.ResourcesPanel.prototype.showResource): + (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): + (WebInspector.ResourcesPanel.prototype._toggleLargerResources): + (WebInspector.ResourcesPanel.prototype._toggleResourceTracking): + (WebInspector.ResourcesPanel.prototype.get _resources): + (WebInspector.ResourceTimeCalculator.prototype._upperBound): + * inspector/front-end/TimelinePanel.js: + (WebInspector.TimelinePanel): + (WebInspector.TimelinePanel.prototype.get categories): + (WebInspector.TimelinePanel.prototype.populateSidebar): + (WebInspector.TimelinePanel.prototype.addRecordToTimeline): + (WebInspector.TimelinePanel.prototype.createItemTreeElement): + (WebInspector.TimelinePanel.prototype.createItemGraph): + (WebInspector.TimelinePanel.prototype._formatRecord): + (WebInspector.TimelineCategory): + * inspector/front-end/inspector.css: + * inspector/front-end/inspector.html: + +2009-10-28 Kelly Norton <knorton@google.com> + + Reviewed by Pavel Feldman. + + Resets InspectorFrontend in InspectorTimelineAgent instead of removing it so + that it remains active on refreshs and page transitions. + https://bugs.webkit.org/show_bug.cgi?id=30874 + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::setFrontendProxyObject): + * inspector/InspectorTimelineAgent.cpp: + (WebCore::InspectorTimelineAgent::resetFrontendProxyObject): + * inspector/InspectorTimelineAgent.h: + +2009-10-27 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by Darin Adler. + + Provide a way to get counter values with layoutTestContoller + https://bugs.webkit.org/show_bug.cgi?id=30555 + + Expose WebCore::counterValueForElement as a WebCore API. + + * WebCore.base.exp: + * rendering/RenderTreeAsText.cpp: + (WebCore::writeCounterValuesFromChildren): + (WebCore::counterValueForElement): + * rendering/RenderTreeAsText.h: + +2009-10-28 Nate Chapin <japhet@chromium.org> + + Unreviewed, Chromium build fix for r50225. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::defaultObjectContentType): + +2009-10-28 Eric Z. Ayers <zundel@google.com> + + Reviewed by Pavel Feldman. + + Adds InspectorTimelineAgent instrumentation for encountering a + <SCRIPT> tag when parsing an HTML document. + + https://bugs.webkit.org/show_bug.cgi?id=30861 + + * bindings/js/ScriptSourceCode.h: + (WebCore::ScriptSourceCode::ScriptSourceCode): + (WebCore::ScriptSourceCode::startLine): + (WebCore::ScriptSourceCode::url): + * html/HTMLTokenizer.cpp: + (WebCore::HTMLTokenizer::scriptHandler): + (WebCore::HTMLTokenizer::scriptExecution): + * inspector/InspectorTimelineAgent.cpp: + (WebCore::InspectorTimelineAgent::willLoadXHR): + (WebCore::InspectorTimelineAgent::willScriptTag): + (WebCore::InspectorTimelineAgent::didScriptTag): + * inspector/InspectorTimelineAgent.h: + (WebCore::): + * inspector/TimelineRecordFactory.cpp: + (WebCore::TimelineRecordFactory::createScriptTagTimelineRecord): + * inspector/TimelineRecordFactory.h: + * inspector/front-end/TimelineAgent.js: + +2009-10-28 Steve Block <steveblock@google.com> + + Reviewed by Darin Adler. + + Makes sure that Geolocation watch IDs remain positive on overflow. + https://bugs.webkit.org/show_bug.cgi?id=30122 + + No new tests possible. + + * page/Geolocation.cpp: Modified. + (WebCore::Geolocation::watchPosition): Modified. Reset the watch ID to 1 on overflow. + +2009-10-28 George Staikos <george.staikos@torchmobile.com> + + Attempt to fix the Mac debug build after 50225. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::defaultObjectContentType): + +2009-10-28 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=30841 + <rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site + + Tests: http/tests/ssl/referer-301.html + http/tests/ssl/referer-303.html + + * platform/network/mac/ResourceHandleMac.mm: + (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): + Remove Referer header if redirecting from https to another protocol. + + * platform/network/ResourceRequestBase.cpp: + (WebCore::ResourceRequestBase::clearHTTPReferrer): Update request counterparts, as it is + always done when changing or adding header fields. + (WebCore::ResourceRequestBase::clearHTTPOrigin): Ditto. + + * platform/network/ResourceRequestBase.h: clearHTTPReferrer() and clearHTTPOrigin() are + no longer inline, since they have non-trivial implementations. + + * platform/network/mac/ResourceRequestMac.mm: + (WebCore::ResourceRequest::doUpdatePlatformRequest): Fixed to synchronize header field removals. + (WebCore::ResourceRequest::doUpdateResourceRequest): Ditto. + + * platform/network/cf/ResourceHandleCFNet.cpp: + (WebCore::willSendRequest): + * platform/network/cf/ResourceRequestCFNet.cpp: + (WebCore::setHeaderFields): + (WebCore::ResourceRequest::doUpdatePlatformRequest): + (WebCore::ResourceRequest::doUpdateResourceRequest): + Match Mac changes. + +2009-10-28 Joe Mason <jmason@rim.com> + + Reviewed by Adam Treat. + + Add FrameLoader::defaultObjectContentType, containing common code for + implementing FrameLoaderClient::objectContentType. (Currently the gtk + and win ports have copied this code, and the qt port uses similar code + with a few extra clauses. Moving this to a utility function cuts down + on copied code.) This causes no behavioural change. + + https://bugs.webkit.org/show_bug.cgi?id=30868 + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::defaultObjectContentType): + * loader/FrameLoader.h: + +2009-10-28 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Tor Arne Vestbø. + + [Qt] QWebHistory::saveState() is inconsistent with the Qt API + https://bugs.webkit.org/show_bug.cgi?id=30710 + + Enforce the versioning, by ignoring any version different + from 1. + + * history/qt/HistoryItemQt.cpp: + (WebCore::HistoryItem::restoreState): + (WebCore::HistoryItem::saveState): + +2009-10-28 Pavel Feldman <pfeldman@chromium.org> + + Not reviewed: follow up fix to InspectorControllerStub. + Define it after inspector.js due to namespace + + https://bugs.webkit.org/show_bug.cgi?id=30866 + + * inspector/front-end/inspector.html: + +2009-10-28 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Add InspectorController stub in order to + support opening in standalone mode. + + https://bugs.webkit.org/show_bug.cgi?id=30866 + + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * inspector/front-end/InspectorControllerStub.js: Added. + (.WebInspector.InspectorControllerStub): + (.WebInspector.InspectorControllerStub.prototype.wrapCallback): + (.WebInspector.InspectorControllerStub.prototype.isWindowVisible): + (.WebInspector.InspectorControllerStub.prototype.platform): + (.WebInspector.InspectorControllerStub.prototype.closeWindow): + (.WebInspector.InspectorControllerStub.prototype.attach): + (.WebInspector.InspectorControllerStub.prototype.detach): + (.WebInspector.InspectorControllerStub.prototype.storeLastActivePanel): + (.WebInspector.InspectorControllerStub.prototype.clearMessages): + (.WebInspector.InspectorControllerStub.prototype.searchingForNode): + (.WebInspector.InspectorControllerStub.prototype.search): + (.WebInspector.InspectorControllerStub.prototype.toggleNodeSearch): + (.WebInspector.InspectorControllerStub.prototype.setAttachedWindowHeight): + (.WebInspector.InspectorControllerStub.prototype.moveByUnrestricted): + (.WebInspector.InspectorControllerStub.prototype.addResourceSourceToFrame): + (.WebInspector.InspectorControllerStub.prototype.addSourceToFrame): + (.WebInspector.InspectorControllerStub.prototype.getResourceDocumentNode): + (.WebInspector.InspectorControllerStub.prototype.highlightDOMNode): + (.WebInspector.InspectorControllerStub.prototype.hideDOMNodeHighlight): + (.WebInspector.InspectorControllerStub.prototype.inspectedWindow): + (.WebInspector.InspectorControllerStub.prototype.loaded): + (.WebInspector.InspectorControllerStub.prototype.localizedStringsURL): + (.WebInspector.InspectorControllerStub.prototype.windowUnloading): + (.WebInspector.InspectorControllerStub.prototype.hiddenPanels): + (.WebInspector.InspectorControllerStub.prototype.debuggerEnabled): + (.WebInspector.InspectorControllerStub.prototype.enableResourceTracking): + (.WebInspector.InspectorControllerStub.prototype.disableResourceTracking): + (.WebInspector.InspectorControllerStub.prototype.resourceTrackingEnabled): + (.WebInspector.InspectorControllerStub.prototype.enableDebugger): + (.WebInspector.InspectorControllerStub.prototype.disableDebugger): + (.WebInspector.InspectorControllerStub.prototype.addBreakpoint): + (.WebInspector.InspectorControllerStub.prototype.removeBreakpoint): + (.WebInspector.InspectorControllerStub.prototype.updateBreakpoint): + (.WebInspector.InspectorControllerStub.prototype.pauseInDebugger): + (.WebInspector.InspectorControllerStub.prototype.pauseOnExceptions): + (.WebInspector.InspectorControllerStub.prototype.setPauseOnExceptions): + (.WebInspector.InspectorControllerStub.prototype.resumeDebugger): + (.WebInspector.InspectorControllerStub.prototype.profilerEnabled): + (.WebInspector.InspectorControllerStub.prototype.enableProfiler): + (.WebInspector.InspectorControllerStub.prototype.disableProfiler): + (.WebInspector.InspectorControllerStub.prototype.startProfiling): + (.WebInspector.InspectorControllerStub.prototype.stopProfiling): + (.WebInspector.InspectorControllerStub.prototype.getProfileHeaders): + (.WebInspector.InspectorControllerStub.prototype.getProfile): + (.WebInspector.InspectorControllerStub.prototype.takeHeapSnapshot): + (.WebInspector.InspectorControllerStub.prototype.databaseTableNames): + (.WebInspector.InspectorControllerStub.prototype.stepIntoStatementInDebugger): + (.WebInspector.InspectorControllerStub.prototype.stepOutOfFunctionInDebugger): + (.WebInspector.InspectorControllerStub.prototype.stepOverStatementInDebugger): + (.WebInspector.InspectorControllerStub.prototype.setSetting): + (.WebInspector.InspectorControllerStub.prototype.dispatchOnInjectedScript): + (.WebInspector.InspectorControllerStub.prototype.releaseWrapperObjectGroup): + (.WebInspector.InspectorControllerStub.prototype.setting): + * inspector/front-end/inspector.html: + * inspector/front-end/inspector.js: + (WebInspector.UIString): + +2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Jan Alonzo. + + https://bugs.webkit.org/show_bug.cgi?id=25897 + [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries + + Expands upon the new funtionality which allows platforms to indicate + that a particular object should not be ignored, so that they can + specify that an object should be ignored or that it should be left up + to the default handling to decide. + + * accessibility/AccessibilityObject.h: + * accessibility/chromium/AccessibilityObjectChromium.cpp: + * accessibility/gtk/AccessibilityObjectAtk.cpp: + * accessibility/mac/AccessibilityObjectMac.mm: + * accessibility/qt/AccessibilityObjectQt.cpp: + * accessibility/win/AccessibilityObjectWin.cpp: + * accessibility/wx/AccessibilityObjectWx.cpp: + (AccessibilityObject::accessibilityPlatformIncludesObject): + * accessibility/AccessibilityRenderObject.cpp: + (AccessibilityRenderObject::accessibilityIsIgnored): + + +2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Jan Alonzo. + + https://bugs.webkit.org/show_bug.cgi?id=25534 + [GTK] Objects of ROLE_TABLE should implement the accessible table interface + + Expose the table summary as the accessible description because there is no summary object. + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (webkit_accessible_get_description): + +2009-10-28 Steve Block <steveblock@google.com> + + Reviewed by Eric Seidel. + + Adds ScriptController::intializeThreading(), with both JSC and V8 implementations. + https://bugs.webkit.org/show_bug.cgi?id=30678 + + This new method is used from common code, rather than calling JSC::initializeThreading() (or the V8 equivalent) directly. + + Build fix, no new tests required. + + * bindings/js/ScriptController.cpp: Modified. + (WebCore::ScriptController::initializeThreading): Added. + * bindings/js/ScriptController.h: Modified. Adds ScriptController::initializeThreading(). + * bindings/v8/ScriptController.cpp: Modified. + (WebCore::ScriptController::initializeThreading): Added. + * bindings/v8/ScriptController.h: Modified. Adds ScriptController::initializeThreading(). + * loader/icon/IconDatabase.cpp: Modified. + (WebCore::iconDatabase): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading(). + * storage/Database.cpp: Modified. + (WebCore::Database::Database): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading(). + +2009-10-26 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Darin Adler. + + Document a feature of the m_liveDecodedResources list. + https://bugs.webkit.org/show_bug.cgi?id=30209 + + The code made the assumption that the list is sorted by + the m_lastDecodedAccessTime property of the CachedResource. + The above is not true when CachedResource::setDecodedSize + is called and the item is inserted the first time. In this + case the m_lastDecodedAccessTime is still zero and the + m_liveDecodedResources list becomes unsorted. + + It is impossible that Cache::pruneLiveResources will + stop to process the list too early due this feature and + the alternatives of updating m_lastDecodedAccessTime in + CachedResource::setDecodedSize or changing the insert + to search the right position have a negative impact on + performance. The best solution for now is to document + this feature. + + * loader/Cache.cpp: + (WebCore::Cache::pruneLiveResources): + * loader/CachedResource.cpp: + (WebCore::CachedResource::setDecodedSize): + +2009-10-28 Xan Lopez <xlopez@igalia.com> + + Reviewed by Jan Alonzo. + + [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries + https://bugs.webkit.org/show_bug.cgi?id=25897 + + Make text controls always implement the text interface, and the + editable text interface when they are not read only. This is what + ATK-users expect. + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (getInterfaceMaskFromObject): + +2009-10-27 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Simon Fraser. + + Change HitTestResult methods to use (3d) transformation aware methods + https://bugs.webkit.org/show_bug.cgi?id=27347 + + The current HitTestResult methods are not using the (3d) + transformation aware routines. This can lead to an assertion + SVGRenderBase::mapLocalToContainer method. + + Change HitTestResult::imageRect to use the (3d) transformation + aware RenderBox::absoluteContentQuad to avoid running into + an assertion with SVG content. + + Remove HitTestResult::boundingBox() as it is only used in + two places and conceptually doesn't belong into a HitTest + which is operating on points. + + A classic test case is not possible as the methods are not excercised + from within HTML/SVG but from the WebKit API Layer. A unittest + for Qt/Gtk+/Mac would need to be written but Qt/Gtk+ currently + do not support 3d transformations making it impossible to write + a reliable test case and the Mac port is currently not doing + unit testing. + + + * rendering/HitTestResult.cpp: Remove boundingBox() method + (WebCore::HitTestResult::imageRect): Use transformation aware method + * rendering/HitTestResult.h: Remove boundingBox() + +2009-10-26 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Eric Seidel. + + [Qt] Custom Cursor doesn't use hotspot. + https://bugs.webkit.org/show_bug.cgi?id=30820 + + Cursors loaded from a QPixmap didn't specifiy the + hotspot. Take the hotspot values from the mac + implementation. + + * platform/qt/CursorQt.cpp: + +2009-10-27 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Initial revision of the Timeline grid. + + https://bugs.webkit.org/show_bug.cgi?id=30834 + + * English.lproj/localizedStrings.js: + * WebCore.gypi: + * inspector/front-end/AbstractTimelinePanel.js: + (WebInspector.AbstractTimelinePanel.prototype.populateSidebar): + (WebInspector.AbstractTimelinePanel.prototype.refresh): + (WebInspector.AbstractTimelineCalculator): + * inspector/front-end/Images/timelineBarBlue.png: Added. + * inspector/front-end/Images/timelineBarGray.png: Added. + * inspector/front-end/Images/timelineBarGreen.png: Added. + * inspector/front-end/Images/timelineBarOrange.png: Added. + * inspector/front-end/Images/timelineBarPurple.png: Added. + * inspector/front-end/Images/timelineBarRed.png: Added. + * inspector/front-end/Images/timelineBarYellow.png: Added. + * inspector/front-end/Images/timelineCheckmarks.png: Added. + * inspector/front-end/Images/timelineDots.png: Added. + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourceTimeCalculator): + (WebInspector.ResourceTransferSizeCalculator): + * inspector/front-end/TimelineAgent.js: + * inspector/front-end/TimelinePanel.js: + (WebInspector.TimelinePanel): + (WebInspector.TimelinePanel.prototype.get statusBarItems): + (WebInspector.TimelinePanel.prototype.get categories): + (WebInspector.TimelinePanel.prototype.populateSidebar): + (WebInspector.TimelinePanel.prototype._createStatusbarButtons): + (WebInspector.TimelinePanel.prototype.addItemToTimeline): + (WebInspector.TimelinePanel.prototype.refresh): + (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClick): + (WebInspector.TimelinePanel.prototype.reset): + (WebInspector.TimelinePanel.prototype._formatRecord): + (WebInspector.TimelinePanel.prototype.showCategory): + (WebInspector.TimelinePanel.prototype.hideCategory): + (WebInspector.TimelineRecordTreeElement): + (WebInspector.TimelineRecordTreeElement.prototype.onattach): + (WebInspector.TimelineCalculator): + (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): + (WebInspector.TimelineCalculator.prototype.computePercentageFromEventTime): + (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels): + (WebInspector.TimelineCalculator.prototype.updateBoundaries): + (WebInspector.TimelineCalculator.prototype.formatValue): + (WebInspector.TimelineGraph): + (WebInspector.TimelineGraph.prototype.get graphElement): + (WebInspector.TimelineGraph.prototype.refreshLabelPositions): + (WebInspector.TimelineGraph.prototype.refresh): + * inspector/front-end/inspector.css: + * inspector/front-end/inspector.js: + (WebInspector._createPanels): + +2009-10-27 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Pavel Feldman. + + Web Inspector: Move runAfterPendingDispatches to TestController for Clarity + https://bugs.webkit.org/show_bug.cgi?id=30844 + + * inspector/front-end/TestController.js: + (WebInspector.TestController.prototype.runAfterPendingDispatches): + * inspector/front-end/inspector.js: moved runAfterPendingDispatches + +2009-10-27 Darin Fisher <darin@chromium.org> + + Reviewed by Dimitri Glazkov. + + Add missing forward declaration of FramelessScrollView. + https://bugs.webkit.org/show_bug.cgi?id=30824 + + * platform/chromium/FramelessScrollViewClient.h: + +2009-10-27 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Adele Peterson. + + WAI-ARIA: add support for 'presentation' role + https://bugs.webkit.org/show_bug.cgi?id=30806 + + Test: accessibility/aria-presentational-role.html + + * accessibility/AccessibilityObject.h: + (WebCore::): + * accessibility/AccessibilityRenderObject.cpp: + (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): + (WebCore::RoleEntry::): + +2009-10-27 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Darin Adler. + + ARIA menu/menu item need AXRoleDescription + https://bugs.webkit.org/show_bug.cgi?id=30804 + + Make sure that role descriptions will default to the system's first, before + returning an unknown role. + + Test: platform/mac/accessibility/aria-menu-role-descriptions.html + + * accessibility/mac/AccessibilityObjectWrapper.mm: + (-[AccessibilityObjectWrapper roleDescription]): + +2009-10-27 Geoffrey Garen <ggaren@apple.com> + + Qt build fix: migrated away from API that no longer exists. + + * bridge/qt/qt_runtime.cpp: + (JSC::Bindings::convertQVariantToValue): + +2009-10-27 Geoffrey Garen <ggaren@apple.com> + + Qt build fix: migrated away from API that no longer exists. + + * bridge/qt/qt_runtime.cpp: + (JSC::Bindings::convertValueToQVariant): + +2009-10-27 Oliver Hunt <oliver@apple.com> + + Fix wording in comment. + + * bridge/objc/objc_instance.mm: + (allocateAutoReleasePool): + +2009-10-27 Oliver Hunt <oliver@apple.com> + + Reviewed by Darin Adler. + + Crash occurs after launching Newsfire 1.6 for the first time + https://bugs.webkit.org/show_bug.cgi?id=30807 + + We allocate an autorelease pool but then store it off the stack. In a + GC environment this led to it being collected, and thus caused badness + to ensue. To work around this we simply avoid using a pool at all in + a GC environment as it would be a no-op anyway. + + * bridge/objc/objc_instance.mm: + (allocateAutoReleasePool): + (ObjcInstance::virtualBegin): + +2009-10-27 Steve Block <steveblock@google.com> + + Reviewed by Darin Adler. + + When a Geolocation method is called, immediately calls the error calback asynchronously if permissions + have already been denied. + https://bugs.webkit.org/show_bug.cgi?id=27944. + + Tests: fast/dom/Geolocation/permission-denied-already-error.html + fast/dom/Geolocation/permission-denied-already-success.html + + * page/Geolocation.cpp: Modified. + (WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. GeoNotifier takes Geolocation object as constructor argument. + (WebCore::Geolocation::GeoNotifier::setFatalError): Added. Sets a fatal error for this notifier, causing it to terminate immediately and call the error callback asynchronously. + (WebCore::Geolocation::GeoNotifier::timerFired): Added. Used to call the error callback asynchronously on fatal error. + (WebCore::Geolocation::getCurrentPosition): Modified. Calls startRequest. + (WebCore::Geolocation::watchPosition): Modified. Calls startRequest. + (WebCore::Geolocation::startRequest): Added. Common functionality for starting a one-shot or watch request. Sets a fatal error on the notifier if permissions have already been denied. + (WebCore::Geolocation::fatalErrorOccurred): Added. Registers that a notifier has encountered a fatal error and should be destroyed. + (WebCore::Geolocation::setIsAllowed): Modified. Uses a standard error message for the error callback when permissions are denied. + * page/Geolocation.h: Modified. + (WebCore::Geolocation::isDenied): Added. Determines whether permissions have been denied. + +2009-10-27 Chris Marrin <cmarrin@apple.com> + + Reviewed by Oliver Hunt. + + Fixed a bug where I was using the wrong Canvas pointer to do a cross-domain check + https://bugs.webkit.org/show_bug.cgi?id=30840 + + * html/canvas/CanvasRenderingContext2D.cpp: + (WebCore::CanvasRenderingContext2D::drawImage): + +2009-10-27 Eric Seidel <eric@webkit.org> + + Reviewed by Nikolas Zimmermann. + + SVGStyledElement::getPresentationAttribute() can return a shared CSSValue (some SVG tests randomly fail on the bot, and in release builds) + https://bugs.webkit.org/show_bug.cgi?id=29620 + + SVG was modifying CSSValues cached of off CSSMappedAttributeDeclarations. + This patch fixes the check to make sure that a new CSSMappedAttributeDeclaration is + created before returning a CSSValue that JavaScript can modify. + + Test: svg/dom/getPresentationAttribute-cache-corruption.svg + + * svg/SVGStyledElement.cpp: + (WebCore::SVGStyledElement::getPresentationAttribute): + +2009-10-27 Dan Bernstein <mitz@apple.com> + + Reviewed by Simon Fraser. + + Incomplete repaint of text field in relative positioned inline at imdb.com + https://bugs.webkit.org/show_bug.cgi?id=30047 + + Test: fast/repaint/inline-relative-positioned.html + + Implemented offsetFromContainer(), mapLocalToContainer() and + mapAbsoluteToLocalPoint() in RenderInline. + + * rendering/RenderBox.h: Fixed argument names in the declaration of + mapLocalToContainer(). + * rendering/RenderInline.cpp: + (WebCore::RenderInline::offsetFromContainer): + (WebCore::RenderInline::mapLocalToContainer): + (WebCore::RenderInline::mapAbsoluteToLocalPoint): + * rendering/RenderInline.h: + +2009-10-27 Jeremy Orlow <jorlow@chromium.org> + + Speculative build fix for Chromium. + + * platform/graphics/GraphicsContext3D.h: + +2009-10-27 Chris Marrin <cmarrin@apple.com> + + Reviewed by Simon Fraser. + + Make WebGL context failure more robust and make it succeed in more cases + https://bugs.webkit.org/show_bug.cgi?id=30349 + + Bubble a failure to get a CGLContext up to HTMLContextElement so it can + return null from getContext. Also added a more robust pixel format choosing + mechanism and can render correctly when a SW renderer is chosen. + + * html/HTMLCanvasElement.cpp: + (WebCore::HTMLCanvasElement::getContext): + * html/canvas/CanvasRenderingContext.h: + * html/canvas/CanvasRenderingContext2D.cpp: + * html/canvas/CanvasRenderingContext3D.cpp: + * html/canvas/CanvasRenderingContext3D.h: + (WebCore::CanvasRenderingContext3D::graphicsContext3D): + (WebCore::CanvasRenderingContext3D::cleanupAfterGraphicsCall): + * platform/graphics/GraphicsContext3D.h: + * platform/graphics/mac/Canvas3DLayer.mm: + (-[Canvas3DLayer copyCGLPixelFormatForDisplayMask:]): + * platform/graphics/mac/GraphicsContext3DMac.cpp: + (WebCore::setPixelFormat): + (WebCore::GraphicsContext3D::create): + (WebCore::GraphicsContext3D::GraphicsContext3D): + (WebCore::GraphicsContext3D::~GraphicsContext3D): + (WebCore::GraphicsContext3D::reshape): + (WebCore::ensureContext): + +2009-10-27 Geoffrey Garen <ggaren@apple.com> + + Mac build fix: a forwarding header. + + * ForwardingHeaders/wtf/DateInstanceCache.h: Added. + +2009-10-27 Ryosuke Niwa <rniwa@webkit.org> + + No Review. + + Making fontWeightIsBold static to fix Snow Leopard build. + + * editing/ApplyStyleCommand.cpp: + (WebCore::fontWeightIsBold): + +2009-10-27 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Eric Seidel. + + WebKit cannot remove nested bold tags + https://bugs.webkit.org/show_bug.cgi?id=30784 + + This patch modifies getPropertiesNotInComputedStyle so that it compares font-weight + more flexibly. Instead of comparing cssText, it uses fontWeightIsBold which converts + all font weights to either bold or unbold state. + + * editing/ApplyStyleCommand.cpp: + (WebCore::fontWeightIsBold): + (WebCore::getPropertiesNotInComputedStyle): Removes font-weight property + if two style have the same value under getFontWeightValue + +2009-10-27 Carol Szabo <carol.szabo@nokia.com> + + Reviewed by Darin Adler. + + Give an ability to WebKit to free statically allocated pointers + before quit. + https://bugs.webkit.org/show_bug.cgi?id=27980 + + No new tests for this as the change does not affect WebKit + functionality, but only memory usage. + + * JavaScriptCore/wtf/StdLibExtras.h: + Allowed for the override of DEFINE_STATIC_LOCAL via compiler + commandline options or elsewhere in the code. Useful for + implementing custom builds that free resources allocated via + DEFINE_STATIC_LOCAL. + +2009-10-27 Dumitru Daniliuc <dumi@chromium.org> + + Build fix, no review needed. + + Fixing the BUILD. m_estimatedSize in Database.h should be of type + 'unsigned long' instead of 'unsigned long long'. + + No tests required. + + * storage/Database.h: + +2009-10-27 Dumitru Daniliuc <dumi@chromium.org> + + Reviewed by Adam Barth. + + Refactoring the Database class to not depend on + OriginQuotaManager. Also, adding a SecurityOrigin copy to each + Database instance, that is safe to use on the file + thread. Finally, adding new simple fields and getters to the + Database object for storing/getting the display name and estimated + size specified by the user in the openDatabase() call. + + https://bugs.webkit.org/show_bug.cgi?id=30548 + + * page/SecurityOrigin.h: + * storage/Database.cpp: + (WebCore::Database::openDatabase): Storing the display name and + the estimated size in the Database object. + (WebCore::Database::Database): Storing the display name and the + estimated size in the Database object, as well as a SecurityOrigin + instance that is safe to use on the DB thread. + (WebCore::Database::maximumSize): Delegate the call to + DatabaseTracker::getMaxSizeForDatabase(). + (WebCore::Database::databaseThreadSecurityOrigin): Return the + SecurityOrigin instance that's safe to use on the DB thread. + (WebCore::Database::threadSafeSecurityOrigin): Return the + SecurityOrigin instance that's safe to use on the current thread. + (WebCore::Database::displayName): Return the display name + specified by the user in the openDatabase() call. + (WebCore::Database::estimatedSize): Return the estimated size + specified by the user in the openDatabase() call. + (WebCore::Database::fileName): Return the name of the file where + the current Database is tored. + * storage/Database.h: + * storage/DatabaseTracker.cpp: + (WebCore::DatabaseTracker::getMaxSizeForDatabase): Returns the + maximum size for a DB file based on the current size of that file + and the space available for that origin. + * storage/DatabaseTracker.h: + * storage/SQLTransaction.cpp: + * storage/SQLTransactionClient.cpp: + (WebCore::SQLTransactionClient::didCommitTransaction): Use the + correct SecurityOrigin instance. + +2009-10-27 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Pretty Print all HTML Collection Types like we do for NodeList + https://bugs.webkit.org/show_bug.cgi?id=30709 + + Test: inspector/console-format-collections.html + + * inspector/front-end/InjectedScript.js: + (Object.type): check for instances of HTMLCollection like we do for NodeList + * inspector/front-end/inspector.js: added WebInspector.pendingDispatches counter + (WebInspector.dispatch): increment and decrement dispatch counter + (WebInspector.runAfterPendingDispatches): run when there are no more dispatches + +2009-10-27 Kelly Norton <knorton@google.com> + + Reviewed by Timothy Hatcher. + + Adds XMLHttpRequest support to InspectorTimelineAgent. + https://bugs.webkit.org/show_bug.cgi?id=30578 + + * inspector/InspectorTimelineAgent.cpp: + (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): + (WebCore::InspectorTimelineAgent::didChangeXHRReadyState): + (WebCore::InspectorTimelineAgent::willLoadXHR): + (WebCore::InspectorTimelineAgent::didLoadXHR): + * inspector/InspectorTimelineAgent.h: + (WebCore::): + * inspector/TimelineRecordFactory.cpp: + (WebCore::TimelineRecordFactory::createXHRReadyStateChangeTimelineRecord): + (WebCore::TimelineRecordFactory::createXHRLoadTimelineRecord): + * inspector/TimelineRecordFactory.h: + * inspector/front-end/TimelineAgent.js: + * xml/XMLHttpRequest.cpp: + (WebCore::XMLHttpRequest::callReadyStateChangeListener): + +2009-10-27 Enrica Casucci <enrica@apple.com> + + Reviewed by Adele Peterson. + + REGRESSION (Safari 4.0.3-ToT): After pressing Shift-PageDown, pressing Shift-Up + extends the top of the selection upwards (but should shrink the selection instead) + <rdar://problem/7269075> + https://bugs.webkit.org/show_bug.cgi?id=29981 + + * editing/SelectionController.cpp: + (WebCore::SelectionController::modify): Added setting m_lastChangeWasHorizontalExtension. + +2009-10-27 Brian Weinstein <bweinstein@apple.com> + + Rubber-stamped by Tim Hatcher. + + Removed an extra console.log from ElementsTreeOutline. + + * inspector/front-end/ElementsTreeOutline.js: + +2009-10-27 Keishi Hattori <casey.hattori@gmail.com> + + Reviewed by Timothy Hatcher. + + Rewrote JavaScriptSourceSyntaxHighlighter to be more accurate + https://bugs.webkit.org/show_bug.cgi?id=27147 + + Tests: LayoutTests/inspector/javascript-syntax-highlight.html + + * inspector/front-end/ElementsTreeOutline.js: + * inspector/front-end/SourceFrame.js: + (WebInspector.JavaScriptSourceSyntaxHighlighter.process): Added. Processes 100 tokens at a time. + (WebInspector.JavaScriptSourceSyntaxHighlighter.lex): Added. Scans for a token. + (WebInspector.JavaScriptSourceSyntaxHighlighter.appendNonToken): Added. Appends the non-token characters that lex ignored. + (WebInspector.JavaScriptSourceSyntaxHighlighter.syntaxHighlightNode): Added. To syntax highlight node in ElementsTreeOutline. + +2009-10-27 Mads Ager <ager@chromium.org> + + Reviewed by Adam Barth. + + [V8] Missing null check after string conversion in error reporting + https://bugs.webkit.org/show_bug.cgi?id=30774 + + Add null check after string conversion in error reporting code. + ToString conversion can fail for instance when an exception is + thrown during conversion. + + Test: fast/dom/error-to-string-stack-overflow.html + + * bindings/v8/V8Utilities.cpp: + (WebCore::reportException): + +2009-10-27 Steve Block <steveblock@google.com> + + Reviewed by Darin Adler. + + Use a pair of maps to store Geolocation watchers. + https://bugs.webkit.org/show_bug.cgi?id=29178 + + The pair of maps allows us to look up a watcher either by its ID or by its GeoNotifier object. + The ability to look up by a watcher by its GeoNotifier object will be required when implementing + Geolocation::fatalErrorOccurred. See https://bugs.webkit.org/show_bug.cgi?id=27944 + + * page/Geolocation.cpp: Modified. + (WebCore::Geolocation::Watchers::set): Added. Adds a watcher with the given ID. + (WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by ID. + (WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by GeoNotifier object. + (WebCore::Geolocation::Watchers::clear): Added. Removes all watchers. + (WebCore::Geolocation::Watchers::isEmpty): Added. Determines if there are no watchers. + (WebCore::Geolocation::Watchers::getNotifiersVector): Added. Gets a vector of the GeoNotifier objects. + (WebCore::Geolocation::watchPosition): Modified. Rename watcher identifier static variable. + (WebCore::Geolocation::stopTimersForWatchers): Modified. Use Watchers::getNotifiersVector. + (WebCore::Geolocation::handleError): Modified. Use Watchers::getNotifiersVector. + (WebCore::Geolocation::makeSuccessCallbacks): Modified. Use Watchers::getNotifiersVector. + * page/Geolocation.h: Modified. Adds Geolocation::Watchers class. + +2009-10-27 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Dimitri Glazkov. + + [V8] DOM Storage runtime flag should default to on + https://bugs.webkit.org/show_bug.cgi?id=30828 + + The DOM Storage runtime flag was supposed to default to on. I accidentally + changed the logic to default to false when I moved the flag. + + * bindings/v8/RuntimeEnabledFeatures.cpp: + +2009-10-27 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by Dimitri Glazkov. + + Fix crash found in chromium test_shell. + https://bugs.webkit.org/show_bug.cgi?id=30808 + + When WebSocket is deleted without close, webkit would crash + when it handles didClose. + + Check scriptExecutionContext before post task for event. + Use WebSocketChannel::disconnect() instead of close() in WebSocket + destructor, so that WebSocketChannel should not call deleted WebSocket + back in didClose(). + To make sure WebSocketChannel alive while it is processing WebSocket + protocol over SocketStreamHandle, ref() in connect() and deref() in + didClose(). + + * websockets/WebSocket.cpp: + (WebCore::WebSocket::~WebSocket): + (WebCore::WebSocket::didConnect): + (WebCore::WebSocket::didReceiveMessage): + (WebCore::WebSocket::didClose): + * websockets/WebSocketChannel.cpp: + (WebCore::WebSocketChannel::connect): + (WebCore::WebSocketChannel::disconnect): + (WebCore::WebSocketChannel::didClose): + (WebCore::WebSocketChannel::didReceiveData): + * websockets/WebSocketChannel.h: + +2009-10-27 Dan Bernstein <mitz@apple.com> + + Reviewed by Darin Adler. + + Updated Apple license + + * LICENSE-APPLE: + +2009-10-27 Brady Eidson <beidson@apple.com> + + Rubberstamped by Sam Weinig. + + Re-enable the check that disallows pages with unload handlers in the page cache. + + <rdar://problem/7196485> and http://webkit.org/b/29021 + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::canCachePageContainingThisFrame): + (WebCore::FrameLoader::logCanCacheFrameDecision): + +2009-10-27 Timothy Hatcher <timothy@apple.com> + + Remove more empty files that didn't get removed earlier. + + * inspector/DOMDispatchTimelineItem.cpp: Removed. + * inspector/DOMDispatchTimelineItem.h: Removed. + +2009-10-27 Andras Becsi <becsi.andras@stud.u-szeged.hu> + + Reviewed by Tor Arne Vestbø. + + [Qt] Fix assertion crashes introduced by changes made in r50110. + + * dom/XMLTokenizerQt.cpp: + (WebCore::XMLTokenizer::parseEndElement): only call popCurrentNode() if there are nodes left in the stack. + +2009-10-27 Timothy Hatcher <timothy@apple.com> + + Remove empty files that didn't get removed earlier. + + * inspector/TimelineItem.cpp: Removed. + * inspector/TimelineItem.h: Removed. + +2009-10-27 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Xan Lopez. + + https://bugs.webkit.org/show_bug.cgi?id=25534 + [GTK] Objects of ROLE_TABLE should implement the accessible table interface + + First part of the implementation of AtkTable. + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (getCell): + (getCellIndex): + (webkit_accessible_table_ref_at): + (webkit_accessible_table_get_index_at): + (webkit_accessible_table_get_n_columns): + (webkit_accessible_table_get_n_rows): + (webkit_accessible_table_get_column_extent_at): + (webkit_accessible_table_get_row_extent_at): + (webkit_accessible_table_get_row_header): + (atk_table_interface_init): + (AtkInterfacesInitFunctions): + (GetAtkInterfaceTypeFromWAIType): + +2009-10-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Lars Knoll. + + [Qt] Don't lose remainder when computing wheel event deltas + + * platform/qt/WheelEventQt.cpp: + +2009-10-27 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Antti Koivisto. + + Fix QtWebKit build for WIN_OS if Netscape plug-in support + is turned off and refactor some related code + https://bugs.webkit.org/show_bug.cgi?id=30786 + + No new tests as there is no new functionality introduced. + + * platform/FileSystem.h: Refactor to make sure that each different + type definition is only repeated once. + + * plugins/PluginPackage.cpp: + (WebCore::PluginPackage::compareFileVersion): Move it out from the + ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH guard and combine it with the + function body from PluginPackageWin. + + * plugins/win/PluginPackageWin.cpp: Remove compareFileVersion as + it is now in PluginPackage.cpp. + +2009-10-26 Xan Lopez <xlopez@igalia.com> + + Reviewed by Gustavo Noronha. + + https://bugs.webkit.org/show_bug.cgi?id=27011 + [Gtk] Implement support for get_index_in_parent + + Implement atk_object_get_index_in_parent. + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (webkit_accessible_get_index_in_parent): + +2009-10-27 Eric Seidel <eric@webkit.org> + + No review, rolling out r50131. + http://trac.webkit.org/changeset/50131 + + * bridge/objc/objc_instance.h: + * bridge/objc/objc_instance.mm: + (ObjcInstance::ObjcInstance): + (ObjcInstance::virtualEnd): + +2009-10-26 Daniel Bates <dbates@webkit.org> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=30491 + + Fixes an issue where pressing return/enter on the keyboard + in <isindex> does not submit it if is not within a <form>. + + According to the HTML 2.0 thru HTML 4.01 spec + (http://www.w3.org/MarkUp/html-spec/html-spec_7.html#SEC7.5), the + <isindex> element does not need to be within a <form> element in + order to submit it. It can submitted on its own. Also, if present, + the href property of the <base> element will dictate where to submit + the value of the <isindex> element (this is analogous to the action + property of the <form> element). + + Tests: http/tests/misc/isindex-with-no-form-base-href.html + http/tests/misc/isindex-with-no-form.html + + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::defaultEventHandler): Calls createTemporaryFormForIsIndex() + to create a <form> if none is present and we are an <isindex> element. + (WebCore::HTMLInputElement::createTemporaryFormForIsIndex): Added. + * html/HTMLInputElement.h: + +2009-10-26 Oliver Hunt <oliver@apple.com> + + Reviewed by Maciej Stachowiak. + + Crash occurs after launching Newsfire 1.6 for the first time + https://bugs.webkit.org/show_bug.cgi?id=30807 + + Use a RetainPtr in ObjcBinding to ensure that we adequately + protect the autorelease pool from GC in GC'd applications. + + * bridge/objc/objc_instance.h: + * bridge/objc/objc_instance.mm: + (ObjcInstance::ObjcInstance): + (ObjcInstance::virtualEnd): + +2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Unreviewed. + + [Qt] Build fix for QtWebKit after r50125. + + * WebCore.pro: Rename TimelineItem to TimelineRecord. + +2009-10-26 Matt Mueller <mattm@chromium.org> + + Reviewed by Darin Adler. + + Refactor synchronizable property handling to store one shouldSynchronize flag per set of properties rather than one per property. + + Fixes reading uninitialized memory in SynchronizableProperty hash function as well as simplifying the code. + + https://bugs.webkit.org/show_bug.cgi?id=30658 + + Covered by running various svg tests under valgrind, ex: + LayoutTests/svg/custom/js-late-mask-and-object-creation.svg + + * svg/SynchronizablePropertyController.cpp: + (WebCore::SynchronizableProperties::addProperty): + (WebCore::SynchronizableProperties::synchronize): + (WebCore::SynchronizableProperties::startAnimation): + (WebCore::SynchronizableProperties::stopAnimation): + (WebCore::SynchronizablePropertyController::registerProperty): + (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): + (WebCore::SynchronizablePropertyController::synchronizeProperty): + (WebCore::SynchronizablePropertyController::synchronizeAllProperties): + (WebCore::SynchronizablePropertyController::startAnimation): + (WebCore::SynchronizablePropertyController::stopAnimation): + * svg/SynchronizablePropertyController.h: + (WebCore::SynchronizableProperties::SynchronizableProperties): + (WebCore::SynchronizableProperties::setNeedsSynchronization): + +2009-10-26 Kelly Norton <knorton@google.com> + + Reviewed by Timothy Hatcher. + + Renames TimelineItem to TimelineRecord and updates all call sites. + https://bugs.webkit.org/show_bug.cgi?id=30785 + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::addRecordToTimeline): + * inspector/InspectorFrontend.h: + * inspector/InspectorTimelineAgent.cpp: + (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): + (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): + (WebCore::InspectorTimelineAgent::willLayout): + (WebCore::InspectorTimelineAgent::didLayout): + (WebCore::InspectorTimelineAgent::willRecalculateStyle): + (WebCore::InspectorTimelineAgent::didRecalculateStyle): + (WebCore::InspectorTimelineAgent::willPaint): + (WebCore::InspectorTimelineAgent::didPaint): + (WebCore::InspectorTimelineAgent::willWriteHTML): + (WebCore::InspectorTimelineAgent::didWriteHTML): + (WebCore::InspectorTimelineAgent::didInstallTimer): + (WebCore::InspectorTimelineAgent::didRemoveTimer): + (WebCore::InspectorTimelineAgent::willFireTimer): + (WebCore::InspectorTimelineAgent::didFireTimer): + (WebCore::InspectorTimelineAgent::reset): + (WebCore::InspectorTimelineAgent::addRecordToTimeline): + (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): + (WebCore::InspectorTimelineAgent::pushCurrentRecord): + * inspector/InspectorTimelineAgent.h: + (WebCore::): + (WebCore::InspectorTimelineAgent::RecordEntry::RecordEntry): + * inspector/TimelineItemFactory.cpp: Removed. + * inspector/TimelineItemFactory.h: Removed. + * inspector/TimelineRecordFactory.cpp: Added. + (WebCore::TimelineRecordFactory::createGenericRecord): + (WebCore::TimelineRecordFactory::createDOMDispatchRecord): + (WebCore::TimelineRecordFactory::createGenericTimerRecord): + (WebCore::TimelineRecordFactory::createTimerInstallRecord): + * inspector/TimelineRecordFactory.h: Added. + (WebCore::TimelineRecordFactory::TimelineRecordFactory): + * inspector/front-end/TimelineAgent.js: + (WebInspector.addRecordToTimeline): + * inspector/front-end/TimelinePanel.js: + (WebInspector.TimelinePanel.prototype.addRecordToTimeline): + (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): + (WebInspector.TimelinePanel.prototype.getRecordTypeName): + (WebInspector.TimelineRecordTreeElement.prototype.onattach): + +2009-10-26 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Antti Koivisto. + + [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled + + When printing, QPrinter's preview mode uses a QPicture to capture the output. The + QPicture holds a reference to the X Pixmap. As a result, the print preview would + update itself when the X Pixmap changes. To prevent the print preview from updating + whenever m_drawable is updated (i.e when the view updates), we create a copy. + + We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap + regardless of the graphicssystem. This is taken care of by + commit d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6) + + The beauty of this patch is that the newly created X Pixmap is managed by Qt and + it will free the Pixmap whenever the user closes the print preview dialog and + handles the case of displaying multiple preview dialogs nicely. + + All credit to Samuel Rødal for suggesting usage of QPixmap::copy(). + + https://bugs.webkit.org/show_bug.cgi?id=30714 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::paint): + +2009-10-26 Benjamin Otte <otte@gnome.org> + + Reviewed by Gustavo Noronha. + + Don't store properties in the MediaPlayerPrivate class + + Access them via the MediaPlayer class instead. + https://bugs.webkit.org/show_bug.cgi?id=30462 + + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): + (WebCore::MediaPlayerPrivate::seek): + (WebCore::MediaPlayerPrivate::setVolume): + (WebCore::MediaPlayerPrivate::setRate): + (WebCore::MediaPlayerPrivate::setVisible): + (WebCore::MediaPlayerPrivate::paint): + (WebCore::MediaPlayerPrivate::createGSTPlayBin): + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: + +2009-10-26 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <http://webkit.org/b/30801>. + Web Inspector: Control + ]/[ on Windows doesn't change Panels. + + In my testing, Windows uses "U+00DB" and "U+00DD" to represent + [ and ], so we should honor those as well. + + * inspector/front-end/inspector.js: + (WebInspector.documentKeyDown): + +2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Darin Adler. + + Make .rc files compile on Windows without depending on MFC headers + https://bugs.webkit.org/show_bug.cgi?id=30750 + + * WebCore.vcproj/QTMovieWin.rc: Use winresrc.h because it exists + even when MFC is not installed, and is all that's needed here. + +2009-10-26 Brent Fulgham <bfulgham@webkit.org> + + Reviewed by Darin Adler. + + Build corrections for ENABLE_FILTERS in Windows. + https://bugs.webkit.org/show_bug.cgi?id=30797 + + Build correction for ENABLE_FILTERS feature. No new tests needed. + + * platform/graphics/filters/FEColorMatrix.cpp: Use MathExtras.h and + its piDouble constant. + * platform/graphics/filters/FEGaussianBlur.cpp: Use MathExtras.h and + its piDouble constant. Remove unnecessary call to floor used in + the division of an unsigned, converting to int. + * platform/graphics/win/SimpleFontDataCairoWin.cpp: Correct include + style for MathExtras.h. + +2009-10-26 Brady Eidson <beidson@apple.com> + + Reviewed by Darin Adler. + + <rdar://problem/7289467> and http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load. + + Test: fast/loader/grandparent-completion-starts-redirect.html + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children. + +2009-10-26 Dan Bernstein <mitz@apple.com> + + Reviewed by Beth Dakin. + + Re-add CSSPropertyWebkitBackgroundSize in one more place + + Fixes transitions/multiple-background-size-transitions.html, transitions/background-transitions.html + + * page/animation/AnimationBase.cpp: + (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper): + +2009-10-26 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Dimitri Glazkov. + + [V8] Tidy up the DOM Storage runtime flag stuff + https://bugs.webkit.org/show_bug.cgi?id=30794 + + Clean up the DOM Storage runtime flag stuff to match the new way of doing + things. No behavioral changes. + + * bindings/v8/RuntimeEnabledFeatures.cpp: + * bindings/v8/RuntimeEnabledFeatures.h: + (WebCore::RuntimeEnabledFeatures::setDatabaseEnabled): + (WebCore::RuntimeEnabledFeatures::databaseEnabled): + (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled): + (WebCore::RuntimeEnabledFeatures::localStorageEnabled): + (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled): + (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled): + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::ACCESSOR_RUNTIME_ENABLER): + * storage/Storage.cpp: + * storage/Storage.h: + +2009-10-26 Brady Eidson <beidson@apple.com> + + Reviewed by Darin Adler. + + <rdar://problem/7308952> and http://webkit.org/b/30424 - REGRESSION (r48687): Pages on ucas.com appear blank. + + Test: fast/loader/history-forward-in-head.html + + * loader/RedirectScheduler.cpp: + (WebCore::RedirectScheduler::scheduleHistoryNavigation): Restore the moved canGoBackOrForward() check. + This restores the side effect of an invalid history navigation canceling previous scheduled redirects + and also fixes the bug of scheduling an invalid history navigation canceling parsing of the current document. + (WebCore::RedirectScheduler::timerFired): Removed the canGoBackOrForward() check as it is now made before + the redirect is scheduled. + +2009-10-26 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=30049 + <rdar://problem/7286002> Manipulating DOM from a script while parsing XHTML can cause a crash + + Tests: fast/parser/remove-current-node-parent-x-2.xhtml + fast/parser/remove-current-node-parent-x.xhtml + + * dom/XMLTokenizer.h: Store the whole stack of parent nodes - element.parentNode() is + unreliable after DOM manipulation. + + * dom/XMLTokenizer.cpp: + (WebCore::XMLTokenizer::pushCurrentNode): Push the new node onto stack. + (WebCore::XMLTokenizer::popCurrentNode): This is now called instead of setCurrentNode when + exiting a node. + (WebCore::XMLTokenizer::clearCurrentNodeStack): We're aborting; or just done parsing. This + replaces setCurrentNode(0). + (WebCore::XMLTokenizer::enterText): Call pushCurrentNode(). + (WebCore::XMLTokenizer::exitText): Call popCurrentNode(), removing a long-standing FIXME + (not sure if it was ever practical though - how can a parent become null while adding text?) + + * dom/XMLTokenizerLibxml2.cpp: + (WebCore::XMLTokenizer::~XMLTokenizer): Call clearCurrentNodeStack(). + (WebCore::XMLTokenizer::startElementNs): Call pushCurrentNode(). + (WebCore::XMLTokenizer::endElementNs): Call popCurrentNode() to safely get to a parent. Also + added a check fo script element still being in document - Firefox parses those that aren't, + but doesn't execute them. + + * dom/XMLTokenizerQt.cpp: + (WebCore::XMLTokenizer::~XMLTokenizer): + (WebCore::XMLTokenizer::parseStartElement): + (WebCore::XMLTokenizer::parseEndElement): + Match libxml2 version changes. + +2009-10-26 Dan Bernstein <mitz@apple.com> + + Reviewed by Beth Dakin. + + background-size: X treated as background-size: X X, not background-size: X auto + https://bugs.webkit.org/show_bug.cgi?id=28440 + + Updated fast/backgrounds/size/resources/parsing-background-size-values.js + and fast/backgrounds/size/resources/parsing-inherit.js + + Reinstated -webkit-background-size and kept its behavior of filling in + the second value with the first one; and changed background-size to have + the behavior of filling in the second value with 'auto'. + + * css/CSSComputedStyleDeclaration.cpp: + (computedProperties): Re-added CSSPropertyWebkitBackgroundSize. + (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto. + * css/CSSParser.cpp: + (WebCore::CSSParser::parseValue): Ditto. + (WebCore::CSSParser::parseFillSize): Adapted for the new parsing rule. + (WebCore::CSSParser::parseFillProperty): Re-added + CSSPropertyWebkitBackgroundSize. + (WebCore::cssPropertyID): Removed mapping of -webkit-background-size to + background-size. + * css/CSSParser.h: + * css/CSSPropertyNames.in: Re-added -webkit-background-size. + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::applyProperty): Re-added + CSSPropertyWebkitBackgroundSize. + +2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Eric Seidel. + + [Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash + https://bugs.webkit.org/show_bug.cgi?id=30777 + + No new tests as the crash can be reproduced by existing storage + LayoutTests (by hitting an assert in debug mode Webkit on WIN_OS). + + * platform/text/String.cpp: + (WebCore::String::number): Qt's QString::vsprintf does not + understand the "%I64u" format string. Always use the "%lli" + format string for Qt port. + +2009-10-26 Tony Chang <tony@chromium.org> + + Reviewed by Eric Seidel. + + Roll back r50073 because r50041-50043 were reverted. r50073 was + a chromium side fix for r50041. + https://bugs.webkit.org/show_bug.cgi?id=30789 + + * bindings/v8/V8Collection.h: + * bindings/v8/custom/V8CustomBinding.h: + * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: + (WebCore::getNamedItems): + (WebCore::getItem): + (WebCore::NAMED_PROPERTY_GETTER): + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8HTMLCollectionCustom.cpp: + (WebCore::getNamedItems): + (WebCore::getItem): + (WebCore::NAMED_PROPERTY_GETTER): + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: + +2009-10-26 Geoffrey Garen <ggaren@apple.com> + + Reviewed by Dimitri Glazkov. + + Fixed https://bugs.webkit.org/show_bug.cgi?id=30765 + REGRESSION (r48701): Removing an event listener causes the one added just after it not to fire + + and related bugs. + + If the event listener being removed is prior to the current firing event + iterator, we need to decrement the current firing event iterator in + addition to the endpoint. (Otherwise, shrinking the event listener vector + by one implicity moves the current firing event iterator forward by one. + It's like relativity, only without the planets.) + + Also took the opportunity to change some pointers to references, since + they can't be null. + + * dom/EventTarget.cpp: + (WebCore::EventTarget::removeEventListener): + (WebCore::EventTarget::removeAllEventListeners): Update iterator in addition + to end, if need be. + (WebCore::EventTarget::fireEventListeners): Updated for interface changes. + Added a comment to explain a behavior that was implicit enough to be + confusing. + + * dom/EventTarget.h: + (WebCore::FiringEventIterator::FiringEventIterator): + (WebCore::EventTarget::isFiringEventListeners): Updated for interface changes. + +2009-10-26 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <http://webkit.org/b/30792>. + Web Inspector: When changing resource scope, resource graph can get in weird state. + + If the user was scrolled down while looking at All resources, and then just + selects Fonts, or something that doesn't have many resources, then the graph + will stay scrolled down, even when there is no content there. + + When the filter is updated, scroll to the top of the graph view, so this won't + happen. + + * inspector/front-end/AbstractTimelinePanel.js: + (WebInspector.AbstractTimelinePanel.prototype._updateFilter): + +2009-10-26 Sam Weinig <sam@webkit.org> + + Fix mac clean build. + + * html/HTMLOptionsCollection.idl: + +2009-10-26 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Extract AbstractTimelinePanel that will be a base + class for ResourcesPanel and TimelinePanel. + + https://bugs.webkit.org/show_bug.cgi?id=30776 + + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * inspector/front-end/AbstractTimelinePanel.js: Added. + (WebInspector.AbstractTimelinePanel): + (WebInspector.AbstractTimelinePanel.prototype.get categories): + (WebInspector.AbstractTimelinePanel.prototype.showCategory): + (WebInspector.AbstractTimelinePanel.prototype.hideCategory): + (WebInspector.AbstractTimelinePanel.prototype.createTimelinePanels): + (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel.createFilterElement): + (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel): + (WebInspector.AbstractTimelinePanel.prototype.filter): + (WebInspector.AbstractTimelinePanel.prototype._updateFilter): + (WebInspector.AbstractTimelinePanel.prototype._createGraph): + (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded): + (WebInspector.AbstractTimelinePanel.prototype._updateSummaryGraph): + (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition): + (WebInspector.AbstractTimelinePanel.prototype.get needsRefresh): + (WebInspector.AbstractTimelinePanel.prototype.set needsRefresh): + (WebInspector.AbstractTimelinePanel.prototype.refreshIfNeeded): + (WebInspector.AbstractTimelinePanel.prototype.show): + (WebInspector.AbstractTimelinePanel.prototype.resize): + (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): + (WebInspector.TimelineCalculator): + (WebInspector.TimelineCalculator.prototype.computeSummaryValues): + (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): + (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels): + (WebInspector.TimelineCalculator.prototype.get boundarySpan): + (WebInspector.TimelineCalculator.prototype.updateBoundaries): + (WebInspector.TimelineCalculator.prototype.reset): + (WebInspector.TimelineCalculator.prototype._value): + (WebInspector.TimelineCalculator.prototype.formatValue): + * inspector/front-end/ResourceCategory.js: + (WebInspector.ResourceCategory): + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel): + (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get toolbarItemLabel): + (WebInspector.ResourcesPanel.prototype.get statusBarItems): + (WebInspector.ResourcesPanel.prototype.get categories): + (WebInspector.ResourcesPanel.prototype.showCategory): + (WebInspector.ResourcesPanel.prototype.hideCategory): + (WebInspector.ResourcesPanel.prototype.isCategoryVisible): + (WebInspector.ResourcesPanel.prototype.populateSidebar): + (WebInspector.ResourcesPanel.prototype.createPanelEnabler): + (WebInspector.ResourcesPanel.prototype.createStatusbarButtons): + (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): + (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): + (WebInspector.ResourcesPanel.prototype.show): + (WebInspector.ResourcesPanel.prototype.resize): + (WebInspector.ResourcesPanel.prototype.reset): + (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): + (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): + (WebInspector.ResourceTimeCalculator): + (WebInspector.ResourceTransferSizeCalculator): + (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels): + * inspector/front-end/SummaryBar.js: + (WebInspector.SummaryBar.prototype.update): + * inspector/front-end/WebKit.qrc: + * inspector/front-end/inspector.html: + * inspector/front-end/inspector.js: + (WebInspector.loaded): + +2009-10-26 Avi Drissman <avi@google.com> + + Reviewed by Darin Adler. + + Use Helvetica in the Inspector as intended. + https://bugs.webkit.org/show_bug.cgi?id=30787 + + * inspector/front-end/inspector.css: + +2009-10-26 Nate Chapin <japhet@chromium.org> + + Reviewed by Alexey Proskuryakov. + + Don't set window.opener to 0 for the current FrameLoader if a noreferrer link was clicked, only suppress opener in a new frame. + https://bugs.webkit.org/show_bug.cgi?id=30781 + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::urlSelected): Don't suppress opener in the current frame for noreferrer navigations. + +2009-10-26 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Eric Seidel. + + Data loss occurs when unbolding nested bold tags. + https://bugs.webkit.org/show_bug.cgi?id=30083 + + Fixes the loop in swapInNodePreservingAttributesAndChildren by saving nextSibling() of child + to a temporary valuable. It was originally calling nextSibling() after appending the child + to new parent, in which case, nextSibling is always 0. + + Test: editing/style/unbolding-nested-b.html + + * editing/ReplaceNodeWithSpanCommand.cpp: + (WebCore::swapInNodePreservingAttributesAndChildren): + +2009-10-21 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Darin Adler. + + Storage events should use Document::url() rather than documentURI() + https://bugs.webkit.org/show_bug.cgi?id=30535 + + Storage events should use Document::url() rather than Document::documentURI() + per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html + + Test: storage/domstorage/documentURI.html + + * storage/StorageEventDispatcher.cpp: + (WebCore::StorageEventDispatcher::dispatch): + +2009-10-26 Sam Weinig <sam@webkit.org> + + Rubber-stamped by Darin Adler. + + Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection + inherit from HTMLCollection. + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * bindings/js/JSHTMLAllCollectionCustom.cpp: + (WebCore::getNamedItems): + (WebCore::callHTMLAllCollection): + (WebCore::JSHTMLAllCollection::nameGetter): + (WebCore::JSHTMLAllCollection::item): + (WebCore::JSHTMLAllCollection::namedItem): + * bindings/js/JSHTMLCollectionCustom.cpp: + (WebCore::getNamedItems): + (WebCore::callHTMLCollection): + (WebCore::JSHTMLCollection::nameGetter): + (WebCore::JSHTMLCollection::item): + (WebCore::JSHTMLCollection::namedItem): + (WebCore::toJS): + * bindings/js/JSHTMLCollectionFunctions.h: Removed. + * bindings/js/JSHTMLDocumentCustom.cpp: + * bindings/js/JSHTMLOptionsCollectionCustom.cpp: + (WebCore::JSHTMLOptionsCollection::length): + (WebCore::JSHTMLOptionsCollection::indexSetter): + * bindings/objc/DOMHTML.mm: + (kitClass): + * bindings/objc/DOMUtility.mm: + (JSC::createDOMWrapper): + * bindings/scripts/CodeGeneratorJS.pm: + * html/HTMLCollection.idl: + * html/HTMLOptionsCollection.idl: + +2009-10-26 Brent Fulgham <bfulgham@webkit.org> + + Reviewed by Adam Roben. + + Build fix for ENABLE_FILTERS under Windows. + https://bugs.webkit.org/show_bug.cgi?id=30762 + + Build correction for ENABLE_FILTERS feature. No new tests needed. + + * WebCore.vcproj/WebCore.vcproj: Make the following changes: + (1) Create a new 'filters' sub-folder of the platform/graphics + folder to properly show the sources held in this directory. + (2) Move the files that are currently shown in svn/graphics/filters + to platform/graphics/filters (where they actually live on disk). + (3) Add the missing SVGFilter, SVGFilterBuilder, and SVGFETile to + the project so they are built. + (4) Remove SVGFEFloodElement.cpp from the build, since it is already + being compiled by SVGAllInOne.cpp. Its presence as a separate + entity is causing a linker warning for duplicate symbols. + (5) Add ImageBuffer.cpp to the build to support color space + calculations for non-CG builds. + * WebCore.vcproj/WebCoreCommon.vsprops: Add the platform/graphics/filters + path to the search paths in the project. + +2009-10-26 Keishi Hattori <casey.hattori@gmail.com> + + Reviewed by Timothy Hatcher. + + console.assert should prefix messages with "Assertion failed: " + https://bugs.webkit.org/show_bug.cgi?id=19135 + + * English.lproj/localizedStrings.js: + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType. + (WebInspector.ConsoleMessage.prototype.toString): + * page/Console.cpp: + (WebCore::Console::assertCondition): Use AssertMessageType. + * page/Console.h: + (WebCore::MessageType): Added AssertMessageType. + +2009-10-26 Rahul Kuchhal <kuchhal@chromium.org> + + Reviewed by Eric Seidel. + + Prevent crash when optgroup element is empty by adding a NULL check. + + https://bugs.webkit.org/show_bug.cgi?id=30365 + + Test: fast/forms/select-empty-optgroup.html + + * dom/SelectElement.cpp: + (WebCore::SelectElement::appendFormData): + +2009-10-21 Steven Knight <sgk@chromium.org> + + Reviewed by David Levin. + + Refactor gyp for separate webcore_bindings{,_sources} targets. + + https://bugs.webkit.org/show_bug.cgi?id=30447 + + Handle long link lines by building .idl-generated bindings in a + separate webcore_bindings library target. Avoid Visual Studio + dependency issues by building additional generated .cpp and .h files + in a separate webcore_bindings_sources target. + + Chrome should still build and test successfully. + + * WebCore.gyp/WebCore.gyp: + * WebCore.gypi: + +2009-10-26 Mike Belshe <mike@belshe.com> + + Reviewed by Darin Fisher. + + Make the number of connections for chromium controlled by + chromium rather than by ResourceRequestBase. + https://bugs.webkit.org/show_bug.cgi?id=30661 + + * platform/network/ResourceRequestBase.cpp: + * platform/network/chromium/ResourceRequest.cpp: + +2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Unreviewed. make distcheck build fixes. + + * GNUmakefile.am: + +2009-10-26 Anton Muhin <antonm@chromium.org> + + Reviewed by Dimitri Glazkov. + + Unbreak Chromium build: that requires adding custom implementations + for HTMLOptionsCollection's item and namedItem. Keep v8 binding + close to JSC bindings as well. + https://bugs.webkit.org/show_bug.cgi?id=30780 + + * bindings/v8/V8Collection.h: + (WebCore::getNamedItemsFromCollection): + (WebCore::getItemFromCollection): + * bindings/v8/custom/V8CustomBinding.h: + * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: + (WebCore::NAMED_PROPERTY_GETTER): + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8HTMLCollectionCustom.cpp: + (WebCore::NAMED_PROPERTY_GETTER): + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + +2009-10-23 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Adam Barth and Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=30723 + <rdar://problem/6189415> Input names added to multipart/form-data headers need to be escaped. + + Test: http/tests/security/escape-form-data-field-names.html + + * platform/network/FormDataBuilder.cpp: + (WebCore::appendQuotedString): + (WebCore::FormDataBuilder::beginMultiPartHeader): + (WebCore::FormDataBuilder::addFilenameToMultiPartHeader): + Percent-escape line breaks and quotation marks. + +2009-10-26 Kelly Norton <knorton@google.com> + + Reviewed by Pavel Feldman. + + Adds DOMTimer support to InspectorTimelineAgent. + https://bugs.webkit.org/show_bug.cgi?id=30467 + + * inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names. + (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): + (WebCore::InspectorTimelineAgent::didLayout): + (WebCore::InspectorTimelineAgent::didRecalculateStyle): + (WebCore::InspectorTimelineAgent::didPaint): + (WebCore::InspectorTimelineAgent::didWriteHTML): + (WebCore::InspectorTimelineAgent::didInstallTimer): Added. + (WebCore::InspectorTimelineAgent::didRemoveTimer): Added. + (WebCore::InspectorTimelineAgent::willFireTimer): Added. + (WebCore::InspectorTimelineAgent::didFireTimer): Added. + (WebCore::InspectorTimelineAgent::addItemToTimeline): Added. + (WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed. + * inspector/InspectorTimelineAgent.h: + (WebCore::): + * inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects. + (WebCore::TimelineItemFactory::createGenericTimerTimelineItem): + (WebCore::TimelineItemFactory::createTimerInstallTimelineItem): + * inspector/TimelineItemFactory.h: + * page/DOMTimer.cpp: Added instrumentation points. + (WebCore::DOMTimer::install): + (WebCore::DOMTimer::removeById): + (WebCore::DOMTimer::fired): + +2009-10-26 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Sam Weinig. + + <rdar://problem/6988966> Hardware layers do not show up in page snapshots + + Add a method that gets called when snapshotting Canvas3DLayers for page snapshots, + that allows the layer to return a CGImageRef of its contents. + + * platform/graphics/mac/Canvas3DLayer.h: + * platform/graphics/mac/Canvas3DLayer.mm: + (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]): + +2009-10-26 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Pavel Feldman. + + Pass "console" as object group when evaluating selection. + + https://bugs.webkit.org/show_bug.cgi?id=30738 + + * inspector/front-end/SourceFrame.js: + (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame): + +2009-10-26 Keishi Hattori <casey.hattori@gmail.com> + + Reviewed by Pavel Feldman. + + Fix for Console not showing repeat count when repeatedly logging an Event + https://bugs.webkit.org/show_bug.cgi?id=30324 + + * inspector/ConsoleMessage.cpp: + (WebCore::ConsoleMessage::addToConsole): + (WebCore::ConsoleMessage::updateRepeatCountInConsole): Added. + * inspector/ConsoleMessage.h: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message. + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole + (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented. + * inspector/InspectorFrontend.h: + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual. + (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added. + (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count. + (WebInspector.ConsoleView.prototype.clearMessages): + (WebInspector.ConsoleMessage): + (WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount + (WebInspector.ConsoleMessage.prototype._updateRepeatCount): + * inspector/front-end/inspector.js: + (WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole. + (WebInspector.updateConsoleMessageRepeatCount): Added. + +2009-10-26 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Darin Adler. + + crash with AX on when an image map contains an anchor tag + https://bugs.webkit.org/show_bug.cgi?id=30739 + + Tests: accessibility/crashing-a-tag-in-map.html + + * accessibility/AccessibilityRenderObject.cpp: + (WebCore::AccessibilityRenderObject::addChildren): + +2009-10-26 Steve Block <steveblock@google.com> + + Reviewed by Eric Seidel. + + Adds feature ENABLE guards to V8 bindings. + https://bugs.webkit.org/show_bug.cgi?id=30697 + + This adds guards for the following features to the V8 bindings, + to allow builds with V8 to succeed when these features are not enabled. + - DATABASE + - WORKERS + - SHARED_WORKERS + - SVG + - XPATH + - XSLT + - INSPECTOR + + This is a build fix only, no new tests required. + + * bindings/v8/DOMObjectsInclude.h: Modified. + * bindings/v8/DerivedSourcesAllInOne.cpp: Modified. + * bindings/v8/V8Index.cpp: Modified. + * bindings/v8/V8Index.h: Modified. + +2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Xan Lopez. + + https://bugs.webkit.org/show_bug.cgi?id=25679 + [Gtk] Improve accessibility of focusable lists + + Fixes the issues with the Atk states exposed for ListBoxOption + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (setAtkStateSetFromCoreObject): + +2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Xan Lopez. + + https://bugs.webkit.org/show_bug.cgi?id=27085 + [Gtk] Incorrect rendering of list + + Adds a way for platforms to indicate that a particular object + should not be ignored. + + * accessibility/AccessibilityObject.h: + * accessibility/chromium/AccessibilityObjectChromium.cpp: + * accessibility/gtk/AccessibilityObjectAtk.cpp: + * accessibility/mac/AccessibilityObjectMac.mm: + * accessibility/qt/AccessibilityObjectQt.cpp: + * accessibility/win/AccessibilityObjectWin.cpp: + * accessibility/wx/AccessibilityObjectWx.cpp: + (AccessibilityObject::accessibilityPlatformIncludesObject): + * accessibility/AccessibilityRenderObject.cpp: + (AccessibilityRenderObject::accessibilityIsIgnored): + +2009-10-26 Kinuko Yasuda <kinuko@google.com> + + Reviewed by Jan Alonzo. + + Bug 30619: [Linux] Menu key doesn't work + https://bugs.webkit.org/show_bug.cgi?id=30619 + + Test: manual-tests/keyboard-menukey-event.html + No new layout tests: testing this will require changes in the test + controller in a platform-specific way. + + * platform/chromium/KeyCodeConversionGtk.cpp: + (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for + GDK_Menu to return VKEY_APPS instead of VKEY_MENU. + * platform/gtk/KeyEventGtk.cpp: + (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for + GDK_Menu to return V_APPS instead of VK_MENU. + +2009-10-25 Anton Muhin <antonm@chromium.org> + + Reviewed by Adam Barth. + + Reuse already fetched proxy. + https://bugs.webkit.org/show_bug.cgi?id=30747 + + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::convertNewNodeToV8Object): + +2009-10-25 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Unreviewed build fix. + + Build fix for WIN_OS if Netscape plugin support is turned off + https://bugs.webkit.org/show_bug.cgi?id=30753 + + * plugins/PluginDatabase.cpp: + +2009-10-25 Hironori Bono <hbono@chromium.org> + + Reviewed by Darin Adler. + + A quick fix for Bug 29103. + Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string + and the option string before calling String::startsWith(). + https://bugs.webkit.org/show_bug.cgi?id=29103 + + Tests: fast/forms/listbox-typeahead-cyrillic.html + fast/forms/listbox-typeahead-greek.html + + * dom/SelectElement.cpp: + (WebCore::SelectElement::typeAheadFind): + +2009-10-25 Keishi Hattori <casey.hattori@gmail.com> + + Reviewed by Timothy Hatcher. + + Web Inspector: Expanding a node in the Console should not show the element in Elements panel + https://bugs.webkit.org/show_bug.cgi?id=30749 + + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeElement.prototype.onmousedown): Check if inside disclosure triangle. + +2009-10-25 Sam Weinig <sam@webkit.org> + + Reviewed by Dan Bernstein. + + Fix for https://bugs.webkit.org/show_bug.cgi?id=30751 + HTMLOptionsCollection should not inherit from HTMLCollection + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + Added JSHTMLCollectionFunctions.h + + * bindings/js/JSHTMLAllCollectionCustom.cpp: + (WebCore::callHTMLAllCollection): + (WebCore::JSHTMLAllCollection::nameGetter): + (WebCore::JSHTMLAllCollection::item): + (WebCore::JSHTMLAllCollection::namedItem): + * bindings/js/JSHTMLCollectionCustom.cpp: + (WebCore::callHTMLCollection): + (WebCore::JSHTMLCollection::nameGetter): + (WebCore::JSHTMLCollection::item): + (WebCore::JSHTMLCollection::namedItem): + * bindings/js/JSHTMLOptionsCollectionCustom.cpp: + (WebCore::callHTMLCollection): + (WebCore::JSHTMLOptionsCollection::getCallData): + (WebCore::JSHTMLOptionsCollection::canGetItemsForName): + (WebCore::JSHTMLOptionsCollection::nameGetter): + (WebCore::JSHTMLOptionsCollection::indexSetter): + (WebCore::JSHTMLOptionsCollection::item): + (WebCore::JSHTMLOptionsCollection::namedItem): + Refactor to use generic implementation of HTMLCollection bindings functions + from JSHTMLCollectionFunctions.h + + * bindings/js/JSHTMLCollectionFunctions.h: Added. + (WebCore::getCollectionNamedItems): + (WebCore::getCollectionItems): + (WebCore::callHTMLCollectionGeneric): + Added generic functions that JSHTMLCollection, JSHTMLAllCollection and + JSHTMLOptionsCollection can all use. + + * bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h + for toJS on document.all. + + * bindings/objc/DOMHTML.mm: + * bindings/objc/DOMUtility.mm: + (JSC::createDOMWrapper): + Remove special cases for HTMLOptionsCollection. + + * bindings/scripts/CodeGeneratorJS.pm: + * html/HTMLAllCollection.idl: + * html/HTMLCollection.idl: + * html/HTMLOptionsCollection.idl: + +2009-10-24 Keishi Hattori <casey.hattori@gmail.com> + + Reviewed by Timothy Hatcher. + + WebInspector: Fixed issue with IME inside console + https://bugs.webkit.org/show_bug.cgi?id=30660 + + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView.prototype._promptKeyDown): + * inspector/front-end/DatabaseQueryView.js: + (WebInspector.DatabaseQueryView.prototype._promptKeyDown): + * inspector/front-end/inspector.js: + (WebInspector.loaded): + (WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp. + (WebInspector.startEditing.element.handleKeyEvent): + (WebInspector.startEditing): + * inspector/front-end/utilities.js: + (isEnterKey): Added. Check if in IME. + +2009-10-24 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <https://bugs.webkit.org/show_bug.cgi?id=30752>. + Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX. + + Have the scope bars select one scope by default, but if the multiple selection key + is pressed, allow for multiple selection. + + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView): + (WebInspector.ConsoleView.prototype._updateFilter): + (WebInspector.ConsoleView.prototype.filter): + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel): + (WebInspector.ResourcesPanel.prototype.filter): + (WebInspector.ResourcesPanel.prototype._updateFilter): + +2009-10-24 Timothy Hatcher <timothy@apple.com> + + Make the scope bars in the Web Inspector match other scope bars in Mac OS X. + Also cleans up the CSS to use classes instead of ID selectors. + + https://bugs.webkit.org/show_bug.cgi?id=28186 + + Reviewed by Dan Bernstein. + + * inspector/front-end/ResourcesPanel.js: Add the scope-bar class. + * inspector/front-end/inspector.css: Lots of changes to make it look right. + * inspector/front-end/inspector.html: Add the scope-bar class. + +2009-10-24 Timothy Hatcher <timothy@apple.com> + + Fix selecting Resources in the Web Inspector's Resources panel. + + https://bugs.webkit.org/show_bug.cgi?id=30743 + + Reviewed by Pavel Feldman. + + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added. + (WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call + isCategoryVisible on the ResourcesPanel. + +2009-10-24 Timothy Hatcher <timothy@apple.com> + + Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting + All will deselect the other filters. + + https://bugs.webkit.org/show_bug.cgi?id=30744 + + Reviewed by Pavel Feldman. + + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel.createFilterElement): Better syntax. + (WebInspector.ResourcesPanel): + (WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop, + and the child variable instead of target in the loop. Other clean up. + +2009-10-24 Timothy Hatcher <timothy@apple.com> + + Make resizing the Web Inspector's Elements panel sidebar work again. + Also makes Resources panel use the sidebar code in Panel. + + https://bugs.webkit.org/show_bug.cgi?id=30742 + + Reviewed by Pavel Feldman. + + * inspector/front-end/Panel.js: + (WebInspector.Panel): Don't create the sidebar with an argument. + (WebInspector.Panel.prototype.show): Call updateSidebarWidth. + (WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent. + (WebInspector.Panel.prototype.handleSidebarKeyEvent): Added. + (WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar. + (WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth. + (WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth. + (WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth. + (WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth. + * inspector/front-end/ProfilesPanel.js: + (WebInspector.ProfilesPanel): Call createSidebar. + (WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth. + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth. + (WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth + (WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto. + (WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added. + (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added. + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel): Call createSidebar. + (WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth. + * inspector/front-end/TimelinePanel.js: + (WebInspector.TimelinePanel): Call createSidebar. + (WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth. + +2009-10-24 Timothy Hatcher <timothy@apple.com> + + Call updateSelection() in a few places so hovering in the Web Inspector's + Elements panel always has the correct row selection height. + + https://bugs.webkit.org/show_bug.cgi?id=30735 + + Reviewed by Pavel Feldman. + + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection(). + (WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto. + * inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text. + +2009-10-24 Timothy Hatcher <timothy@apple.com> + + Remove the re-root tree feature from the Web Inspector's + Elements panel. This feature wasn't super useful and gets + in the way of double-click to edit. + + https://bugs.webkit.org/show_bug.cgi?id=30736 + + Reviewed by Pavel Feldman. + + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeElement.prototype.ondblclick): + +2009-10-24 Anton Muhin <antonm@chromium.org> + + Reviewed by Adam Barth. + + Implements ReturnsNew hint for V8 bindings generation code. + https://bugs.webkit.org/show_bug.cgi?id=30745 + + * bindings/scripts/CodeGeneratorV8.pm: + * bindings/v8/V8DOMWrapper.h: + (WebCore::V8DOMWrapper::convertNewNodeToV8Object): + +2009-10-24 Dan Bernstein <mitz@apple.com> + + Reviewed by Sam Weinig. + + Missing images at 350.org due to wrong URLs + https://bugs.webkit.org/show_bug.cgi?id=30748 + + Test: fast/dom/HTMLImageElement/parse-src.html + + * dom/Element.cpp: + (WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL(). + This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI() + and SVGImageLoader::sourceURI() do. + +2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Unreviewed. + + [Qt] Build fix for QtWebKit after r50013. + + * WebCore.pro: + +2009-10-24 Dimitri Glazkov <dglazkov@chromium.org> + + Unreviewed, build fix. + + [V8] Fix up to accommodate for HTMLAllCollection changes in + http://trac.webkit.org/changeset/49998. + + * WebCore.gypi: + * bindings/scripts/CodeGeneratorV8.pm: + * bindings/v8/custom/V8CustomBinding.h: + * bindings/v8/custom/V8HTMLDocumentCustom.cpp: + +2009-10-23 Dan Bernstein <mitz@apple.com> + + Reviewed by Alexey Proskuryakov. + + <rdar://problem/7294131> Assertion failure in AuthenticationMac at + mac(const Credential&) after authenticating to MobileMe Gallery movie + + * platform/network/Credential.cpp: + (WebCore::Credential::Credential): Initialize m_persistence. + (WebCore::Credential::isEmpty): Made this method const. + * platform/network/Credential.h: + * platform/network/mac/AuthenticationMac.mm: + (WebCore::mac): Return nil if the Credential is empty. + +2009-10-23 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <https://bugs.webkit.org/show_bug.cgi?id=30617>. + Web Inspector: Resources Scope Bar Should Allow Combinations. + + Refactor the filtering in ResourcePanel to make it match ConsoleView, + and add a divider between All, and the other choices of Resource types. + + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel): + (WebInspector.ResourcesPanel.prototype.filter): + (WebInspector.ResourcesPanel.prototype._updateFilter): + * inspector/front-end/inspector.css: + +2009-10-23 Chris Evans <cevans@chromium.org> + + Reviewed by Adam Barth. + + Ignore the Refresh header if we're in view source mode. + + https://bugs.webkit.org/show_bug.cgi?id=27239 + + Test: http/tests/security/view-source-no-refresh.html + + * loader/FrameLoader.cpp: ignore Refresh in view-source mode. + +2009-10-23 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Sam Weinig. + + https://bugs.webkit.org/show_bug.cgi?id=30734 + Remove XMLTokenizer::m_currentNodeIsReferenced + + No change in behavior, no tests. + + * dom/XMLTokenizer.cpp: + (WebCore::XMLTokenizer::setCurrentNode): + * dom/XMLTokenizer.h: + Don't store a boolean for the current node being the document - we can always check for that. + + * dom/XMLTokenizerLibxml2.cpp: + (WebCore::XMLTokenizer::XMLTokenizer): + * dom/XMLTokenizerQt.cpp: + (WebCore::XMLTokenizer::XMLTokenizer): + A fragment passed to XMLTokenizer is never null - in fact, the first thing we do is dereference + it unconditionally, and then begin checking it for null, as if it could help. + +2009-10-23 Beth Dakin <bdakin@apple.com> + + No review since this is a build fix. + + Build fix for the Mac. (Build is only broken when SVG filters are + enabled.) + + Labelled these function static. + * platform/graphics/filters/FEComponentTransfer.cpp: + (WebCore::identity): + (WebCore::table): + (WebCore::discrete): + (WebCore::linear): + (WebCore::gamma): + * platform/graphics/filters/FEGaussianBlur.cpp: + (WebCore::boxBlur): + +2009-10-23 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Implement a Timeline panel. + + https://bugs.webkit.org/show_bug.cgi?id=30725 + + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * inspector/front-end/Images/timelineIcon.png: Added. + * inspector/front-end/TimelineAgent.js: + (WebInspector.addItemToTimeline): + (WebInspector.timelineProfilerWasStarted): + (WebInspector.timelineProfilerWasStopped): + * inspector/front-end/TimelinePanel.js: Added. + (WebInspector.TimelinePanel): + (WebInspector.TimelinePanel.prototype.toolbarItemClass.get toolbarItemLabel): + (WebInspector.TimelinePanel.prototype.get statusBarItems): + (WebInspector.TimelinePanel.prototype.handleKeyEvent): + (WebInspector.TimelinePanel.prototype.timelineWasStarted): + (WebInspector.TimelinePanel.prototype.timelineWasStopped): + (WebInspector.TimelinePanel.prototype.addItemToTimeline): + (WebInspector.TimelinePanel.prototype._innerAddItemToTimeline): + (WebInspector.TimelinePanel.prototype._toggleTimelineButton): + (WebInspector.TimelinePanel.prototype.setMainViewWidth): + (WebInspector.TimelinePanel.prototype.getItemTypeName): + (WebInspector.TimelineRecordTreeElement): + (WebInspector.TimelineRecordTreeElement.prototype.onattach): + * inspector/front-end/WebKit.qrc: + * inspector/front-end/inspector.css: + * inspector/front-end/inspector.html: + * inspector/front-end/inspector.js: + (WebInspector._createPanels): + +2009-10-23 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Clash Between Search's onkeyup and incremental search events + https://bugs.webkit.org/show_bug.cgi?id=30731 + + * inspector/front-end/inspector.js: + (WebInspector.performSearch): prevent incremental search event from clobbering a forced search + +2009-10-23 Kelly Norton <knorton@google.com> + + Reviewed by Pavel Feldman. + + Removes the need for C++ Timeline types in InspectorTimelineAgent in favor + of ScriptObjects. + https://bugs.webkit.org/show_bug.cgi?id=30707 + + * GNUmakefile.am: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * inspector/DOMDispatchTimelineItem.cpp: Removed. + * inspector/DOMDispatchTimelineItem.h: Removed. + * inspector/InspectorTimelineAgent.cpp: + (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): + (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): + (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): + (WebCore::InspectorTimelineAgent::willLayout): + (WebCore::InspectorTimelineAgent::didLayout): + (WebCore::InspectorTimelineAgent::willRecalculateStyle): + (WebCore::InspectorTimelineAgent::didRecalculateStyle): + (WebCore::InspectorTimelineAgent::willPaint): + (WebCore::InspectorTimelineAgent::didPaint): + (WebCore::InspectorTimelineAgent::willWriteHTML): + (WebCore::InspectorTimelineAgent::didWriteHTML): + (WebCore::InspectorTimelineAgent::reset): + (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): + (WebCore::InspectorTimelineAgent::pushCurrentTimelineItem): + * inspector/InspectorTimelineAgent.h: + (WebCore::InspectorTimelineAgent::TimelineItemEntry::TimelineItemEntry): + * inspector/TimelineItem.cpp: Removed. + * inspector/TimelineItem.h: Removed. + * inspector/TimelineItemFactory.cpp: Added. + (WebCore::TimelineItemFactory::createGenericTimelineItem): + (WebCore::TimelineItemFactory::createDOMDispatchTimelineItem): + * inspector/TimelineItemFactory.h: Added. + (WebCore::): + (WebCore::TimelineItemFactory::TimelineItemFactory): + +2009-10-23 Gavin Barraclough <barraclough@apple.com> + + Reviewed by Geoff Garen. + + https://bugs.webkit.org/show_bug.cgi?id=30729 + Provide private API to request the global context for a specific world. + Used to initialize parameters on the global object. + + * bindings/js/ScriptController.cpp: + (WebCore::ScriptController::globalObject): + * bindings/js/ScriptController.h: + +2009-10-23 Steve Block <steveblock@google.com> + + Reviewed by Eric Seidel. + + Fixes style problems in Android-specific files. + https://bugs.webkit.org/show_bug.cgi?id=30717 + + Style changes only, no new tests possible. + + * page/android/EventHandlerAndroid.cpp: Modified. + (WebCore::EventHandler::passMouseDownEventToWidget): Fixes whitespace in method signature. + (WebCore::EventHandler::passSubframeEventToSubframe): Fixes whitespace in method signature. + (WebCore::EventHandler::passWheelEventToWidget): Fixes whitespace in method signature. + (WebCore::EventHandler::passMouseMoveEventToSubframe): Fixes whitespace in method signature. + * platform/android/ClipboardAndroid.h: Modified. Fixes header include order and indenting. + * platform/android/CursorAndroid.cpp: Modified. + (WebCore::grabCursor): Fixes function braces. + (WebCore::grabbingCursor): Fixes function braces. + * platform/android/FileChooserAndroid.cpp: Modified. + (WebCore::FileChooser::basenameForWidth): Fixes braces on while statement, and updates String::copy to String::threadsafeCopy. + * platform/android/FileSystemAndroid.cpp: Modified. Fixes header include order. + (WebCore::unloadModule): Fixes zero test. + (WebCore::writeToFile): Fixes if statement structure. + * platform/android/KeyEventAndroid.cpp: Modified. + (WebCore::windowsKeyCodeForKeyEvent): Fixes switch statement indenting. + (WebCore::keyIdentifierForAndroidKeyCode): Fixes switch statement indenting. + * platform/android/ScreenAndroid.cpp: Modified. Fixes header include order and switch statement indenting. + * platform/android/TemporaryLinkStubs.cpp: Modified. Fixes header include order. + +2009-10-23 Sam Weinig <sam@webkit.org> + + Another shot at a fixed build. + + * DerivedSources.cpp: + +2009-10-23 Sam Weinig <sam@webkit.org> + + Another shot at a fixed build. + + * html/HTMLOptionsCollection.idl: + +2009-10-23 Brady Eidson <beidson@apple.com> + + 50,000! + + * ChangeLog: Point out revision 50,000. + +2009-10-23 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + Fix for https://bugs.webkit.org/show_bug.cgi?id=30695 + Drop .tags() support from HTMLCollection + + - Make .tags() only work for HTMLAllCollections in JS. .tags() is still + available for all HTMLCollection like objects in Objective-C since that + is API. + - Auto-generate HTMLAllCollection. + + Test: fast/dom/HTMLDocument/document-all.html + + * DerivedSources.make: + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * bindings/js/JSHTMLAllCollection.cpp: Removed. + * bindings/js/JSHTMLAllCollection.h: Removed. + * bindings/js/JSHTMLAllCollectionCustom.cpp: Added. + (WebCore::getNamedItems): + (WebCore::callHTMLAllCollection): + (WebCore::JSHTMLAllCollection::getCallData): + (WebCore::JSHTMLAllCollection::canGetItemsForName): + (WebCore::JSHTMLAllCollection::nameGetter): + (WebCore::JSHTMLAllCollection::item): + (WebCore::JSHTMLAllCollection::namedItem): + * bindings/js/JSHTMLCollectionCustom.cpp: + (WebCore::toJS): + * bindings/js/JSHTMLDocumentCustom.cpp: + * bindings/scripts/CodeGeneratorJS.pm: + * dom/Document.cpp: + (WebCore::Document::all): + * dom/Document.h: + * dom/HTMLAllCollection.idl: Removed. + * html/HTMLAllCollection.cpp: Added. + (WebCore::HTMLAllCollection::create): + (WebCore::HTMLAllCollection::HTMLAllCollection): + (WebCore::HTMLAllCollection::~HTMLAllCollection): + * html/HTMLAllCollection.h: Added. + * html/HTMLAllCollection.idl: Added. + * html/HTMLCollection.h: + * html/HTMLCollection.idl: + * html/HTMLDocument.idl: + * page/DOMWindow.idl: + +2009-10-23 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: pull basic sidebar implementation into the Panel. + + https://bugs.webkit.org/show_bug.cgi?id=30720 + + * inspector/front-end/Panel.js: + (WebInspector.Panel): + (WebInspector.Panel.prototype.jumpToPreviousSearchResult): + (WebInspector.Panel.prototype.handleKeyEvent): + (WebInspector.Panel.prototype._createSidebar): + (WebInspector.Panel.prototype._startSidebarDragging): + (WebInspector.Panel.prototype._sidebarDragging): + (WebInspector.Panel.prototype._endSidebarDragging): + (WebInspector.Panel.prototype._updateSidebarWidth): + (WebInspector.Panel.prototype.setCenterViewWidth): + * inspector/front-end/ProfilesPanel.js: + (WebInspector.ProfilesPanel): + (WebInspector.ProfilesPanel.prototype.setCenterViewWidth): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel): + (WebInspector.StoragePanel.prototype.setCenterViewWidth): + +2009-10-23 Jens Alfke <snej@chromium.org> + + Reviewed by Dimitri Glazkov. + + Slight optimizations to object returning and exception handling in generated V8 bindings. + https://bugs.webkit.org/show_bug.cgi?id=30599 + + * bindings/scripts/CodeGeneratorV8.pm: Generate better code + * bindings/v8/V8DOMWrapper.h: + (WebCore::V8DOMWrapper::convertToV8Object): Added overload that takes a Ref<> + * bindings/v8/custom/V8InspectorBackendCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): Remove unnecessary template param to prevent compile error + +2009-10-23 Alpha Lam <hclam@chromium.org> + + Reviewed by Eric Carlson. + + Volume slider always starts at half volume + https://bugs.webkit.org/show_bug.cgi?id=28322 + + Sets the value attribute of volume slider to the volume attribute + of the media element. Also update the value attribute of the + input element for the volume slider when the volume attribute + of the media element is updated. + + Test: media/video-volume-slider.html + + * rendering/MediaControlElements.cpp: + (WebCore::MediaControlVolumeSliderElement::update): + Set the value attribute of the input element for the volume slider + using the current volume of the media element. + * rendering/MediaControlElements.h: + Add method definition of update(). + * rendering/RenderMedia.cpp: + (WebCore::RenderMedia::createVolumeSlider): + Creates a volume slider with value attribute equals to the current + volume attribute of the media element. + +2009-10-23 Evan Martin <evan@chromium.org> + + Reviewed by Eric Seidel. + + Chrome Linux: fix caret positioning in LTR complex languages + The caret is positioned off by one in languages like Thai. + + https://bugs.webkit.org/show_bug.cgi?id=28284 + + A group of us spent a while trying various approaches to write a test + for this; however, since it is only that the blinking cursor is + displayed incorrectly, we concluded it can not be tested. + + (Patch by Hironori Bono.) + + * platform/graphics/chromium/FontLinux.cpp: + (WebCore::Font::selectionRectForComplexText): + +2009-10-23 Tony Chang <tony@chromium.org> + + Reviewed by David Levin. + + Fix Chromium build after IsoldatedWorld change (r49963). + https://bugs.webkit.org/show_bug.cgi?id=30719 + + * bindings/ScriptControllerBase.cpp: + * bindings/js/ScriptController.cpp: + (WebCore::ScriptController::executeScriptInIsolatedWorld): + * bindings/v8/ScriptController.cpp: + (WebCore::mainThreadNormalWorld): + * bindings/v8/ScriptController.h: + (WebCore::ScriptController::windowShell): + (WebCore::ScriptController::existingWindowShell): + * dom/Document.cpp: + (WebCore::Document::createWrapperCache): + * dom/ScriptExecutionContext.cpp: + * dom/ScriptExecutionContext.h: + * xml/XMLHttpRequest.cpp: + * xml/XMLHttpRequest.h: + +2009-10-23 Xiaomei Ji <xji@chromium.org> + + Reviewed by Sam Weinig. + + Fix caretRangeFromPoint()/elementFromPoint() returns wrong result + for a zoomed and scrolled page. + https://bugs.webkit.org/show_bug.cgi?id=30689. + + The real cause is the wrong calculation of event.clientX/Y when + page is zoomed and scolled. + After Sam fixed the event.clientX/Y in r49551, the hit test point + should be recalculated (revert r49490). + + Test: fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html + + * dom/Document.cpp: + (WebCore::Document::elementFromPoint): calculate the correct point + relative to document when page is zoomed and scrolled. + (WebCore::Document::caretRangeFromPoint): calculate the correct point + relative to document when page is zoomed and scrolled. + +2009-10-22 Dumitru Daniliuc <dumi@chromium.org> + + Reviewed by Dmitry Titov. + + Adding a class that allows us to enable/disable features at + runtime. Adding a flag to enable database support. + + https://bugs.webkit.org/show_bug.cgi?id=30653 + + * WebCore.gypi: + * bindings/v8/RuntimeEnabledFeatures.cpp: Added. + * bindings/v8/RuntimeEnabledFeatures.h: Added. + (WebCore::RuntimeEnabledFeatures::setDatabaseEnabled): + (WebCore::RuntimeEnabledFeatures::databaseEnabled): + (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures): + * bindings/v8/custom/V8CustomBinding.h: + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::ACCESSOR_RUNTIME_ENABLER): + * page/DOMWindow.idl: + +2009-10-23 Keishi Hattori <casey.hattori@gmail.com> + + Reviewed by Timothy Hatcher. + + Inspector injects _inspectorCommandLineAPI into global object when opened + https://bugs.webkit.org/show_bug.cgi?id=30675 + + * inspector/front-end/InjectedScript.js: + (InjectedScript.getCompletions): + (InjectedScript._evaluateOn): + (InjectedScript.addInspectedNode): + (InjectedScript._ensureCommandLineAPIInstalled): Moved _inspectorCommandLineAPI from window to console. + +2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com> + + Reviewed by Tor Arne Vestbø. + + [Qt] don't undef NULL in Symbian emulator + + npapi.h way of defining mwerks compiler,__intel__ + and win32 are all true for Symbian emulator. + Changed the definions so that NULL won't be undefined + when compiling for Symbian emulator nor target HW. + + * bridge/npapi.h: + +2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com> + + Reviewed by Tor Arne Vestbø. + + [Qt] Correct linking of sqlite3 for Symbian + https://bugs.webkit.org/show_bug.cgi?id=30569 + + ".lib" will try to include library as static library + causing the library to be searched from wrong directory and if found + will be statically linked instead of the inteded dynamic linking. + + * WebCore.pro: + +2009-10-23 Enrica Casucci <enrica@apple.com> + + Reviewed by Adele Peterson. + + REGRESSION: Copy is copying incorrect background-color + <rdar://problem/7248529> + https://bugs.webkit.org/show_bug.cgi?id=29697 + + Test: editing/execCommand/indent-paragraphs.html + + This change removes the BackgroundColor from the list + of inheritable CSS properties and changes significantly + the way we perform indentation. + The new implementation of IndentOutdentCommand uses a new method + defined in CompositeEditCommand called moveParagraphWithClones. + This is an improved version of the original moveParagraph that + is aimed at preserving the original markup of the paragraph being + moved. + + * editing/ApplyStyleCommand.cpp: + (WebCore::): removed CSSPropertyBackgroundColor from editingStyleProperties. + * editing/CompositeEditCommand.cpp: + (WebCore::CompositeEditCommand::CompositeEditCommand): Removed trailing blanks. + (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Removed trailing blanks. + (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added. + (WebCore::CompositeEditCommand::cleanupAfterDeletion): Added. + (WebCore::CompositeEditCommand::moveParagraphWithClones): Added. + (WebCore::CompositeEditCommand::moveParagraphs): Modified to use cleanupAfterDeletion. + (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Removed trailing blanks. + (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Removed trailing blanks. + (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Removed trailing blanks. + * editing/CompositeEditCommand.h: Added three new methods. + * editing/IndentOutdentCommand.cpp: + (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Changed to use moveParagraphWithClones. + (WebCore::IndentOutdentCommand::indentIntoBlockquote): Changed to use moveParagraphWithClones. + (WebCore::IndentOutdentCommand::indentRegion): Removed comment. + * editing/IndentOutdentCommand.h: Removed prepareBlockquoteLevelForInsertion method. + +2009-10-23 Steve Block <steveblock@google.com> + + Reviewed by Eric Seidel. + + Adds missing UnusedParam.h includes, required when INSPECTOR is not enabled. + https://bugs.webkit.org/show_bug.cgi?id=30677 + + Build fix, no new tests required. + + * page/Console.cpp: Modified. Added UnusedParam.h include. + * workers/WorkerContext.cpp: Modified. Added UnusedParam.h include. + +2009-10-23 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Holger Freyther. + + [Qt] Plugins : Use window's winId() instead of the widget's. + + As per, https://developer.mozilla.org/en/NPN_GetValue + NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the + plug-in is displayed; returns Window". + + The issue was found because NPNVNetscapeWindow winId() ends up creating + a native window resulting in flicker. + + https://bugs.webkit.org/show_bug.cgi?id=30706 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::getValue): + +2009-10-23 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Holger Freyther. + + [Qt] Windowless Plugins : Don't use m_clipRect when painting. + + Though it works, it is not correct to use m_clipRect for painting + in Windowless mode. Instead, the rect paramater that is passed + as a part of PluginView::paint() must be used. This change will + also result in some speedup since previously we used to paint all + the visible parts of a windowless plugin (even if those parts were + not dirty). + + Also, fix invalidateRect() to compute the correct width and height. + + https://bugs.webkit.org/show_bug.cgi?id=30711 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::paint): + (WebCore::PluginView::invalidateRect): + +2009-10-21 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Holger Freyther. + + Plugins : Use test.swf in the plugins manual tests. + + They previously referenced youtube videos which among other things are + cumbersome to use without internet connection. The old youtube link is + just commented out so that testing with youtube can be done with + little effort. + + https://bugs.webkit.org/show_bug.cgi?id=30662 + + * manual-tests/plugins/test.swf: Copied from LayoutTests/fast/replaced/resources/test.swf. + * manual-tests/plugins/windowed.html: + * manual-tests/plugins/windowless.html: + * manual-tests/qt/plugin-sibling-frame-include.html: + +2009-10-23 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Jon Honeycutt. + + Fix the Windows Release build by moving Accessibility files + into all-in-one file and excluding them from the build. + + * WebCore.vcproj/WebCore.vcproj: + * accessibility/AccessibilityAllInOne.cpp: Added. + +2009-10-16 Gavin Barraclough <barraclough@apple.com> + + Reviewed by Sam Weinig & Geoff Garen. + + https://bugs.webkit.org/show_bug.cgi?id=30696 + Add support for IsolatedWorlds to JSC bindings. + + An IsolatedWorld is basically a parallel, separate copy of the window shells and DOM wrapper objects for + a given document. To support isolation this patch: + + * Adds support to the ScriptController to track multiple window shells, one per world. + * Adds support to Document to support multiple separate wrapper-maps, one per world. + * Replaces the single global DOM wrapper map (on the WebCoreJSClientData) with separate maps, + stored on the (new) IsolatedWorld objects. + + In addition to supporting separate copies of these objects, two other features are supported: + + * It is necessary to track the current world on entry into JSC, so that within callbacks out to WebCore + we can determine which world (and as such, set of DOM bindings) we should be operating on. + * EventListeners & Callbacks are run in the world they were registered in. + This requires the handler to retain a reference to the world. + + No new tests. (Enabled existing isolated world layout tests.) + + * WebCore.base.exp: + * bindings/js/JSAbstractWorkerCustom.cpp: + (WebCore::JSAbstractWorker::addEventListener): + (WebCore::JSAbstractWorker::removeEventListener): + * bindings/js/JSCallbackData.cpp: + (WebCore::JSCallbackData::invokeCallback): + * bindings/js/JSCallbackData.h: + (WebCore::JSCallbackData::JSCallbackData): + * bindings/js/JSCustomXPathNSResolver.cpp: + (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI): + * bindings/js/JSDOMApplicationCacheCustom.cpp: + (WebCore::JSDOMApplicationCache::addEventListener): + (WebCore::JSDOMApplicationCache::removeEventListener): + * bindings/js/JSDOMBinding.cpp: + (WebCore::removeWrappers): + (WebCore::DOMObjectWrapperMap::get): + (WebCore::DOMObjectWrapperMap::set): + (WebCore::DOMObjectWrapperMap::remove): + (WebCore::DOMObjectWrapperMap::take): + (WebCore::IsolatedWorld::IsolatedWorld): + (WebCore::IsolatedWorld::~IsolatedWorld): + (WebCore::EnterIsolatedWorld::EnterIsolatedWorld): + (WebCore::EnterIsolatedWorld::~EnterIsolatedWorld): + (WebCore::JSGlobalDataWorldIterator::JSGlobalDataWorldIterator): + (WebCore::JSGlobalDataWorldIterator::operator bool): + (WebCore::JSGlobalDataWorldIterator::operator*): + (WebCore::JSGlobalDataWorldIterator::operator->): + (WebCore::JSGlobalDataWorldIterator::operator++): + (WebCore::getCurrentWorld): + (WebCore::getNormalWorld): + (WebCore::commonNormalWorld): + (WebCore::commonCurrentWorld): + (WebCore::DOMObjectHashTableMap::mapFor): + (WebCore::DOMObjectWrapperMap::mapFor): + (WebCore::forgetDOMObject): + (WebCore::getCachedDOMNodeWrapper): + (WebCore::forgetDOMNode): + (WebCore::cacheDOMNodeWrapper): + (WebCore::forgetAllDOMNodesForDocument): + (WebCore::forgetWorldOfDOMNodesForDocument): + (WebCore::isObservableThroughDOM): + (WebCore::markDOMNodesForDocument): + (WebCore::markActiveObjectsForContext): + (WebCore::takeWrappers): + (WebCore::updateDOMNodeDocument): + (WebCore::markDOMObjectWrapper): + (WebCore::allowsAccessFromFrame): + (WebCore::printErrorMessageForFrame): + (WebCore::JSC_DebuggerCallFrame_evaluateInWorld): + (WebCore::JSC_callInWorld): + (WebCore::JSC_constructInWorld): + (WebCore::JSC_evaluateInWorld): + * bindings/js/JSDOMBinding.h: + (WebCore::IsolatedWorld::rememberDocument): + (WebCore::IsolatedWorld::forgetDocument): + (WebCore::IsolatedWorld::rememberScriptController): + (WebCore::IsolatedWorld::forgetScriptController): + (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap): + (WebCore::DOMObjectHashTableMap::get): + (WebCore::WebCoreJSClientData::WebCoreJSClientData): + (WebCore::WebCoreJSClientData::currentWorld): + (WebCore::WebCoreJSClientData::normalWorld): + (WebCore::WebCoreJSClientData::rememberWorld): + (WebCore::WebCoreJSClientData::forgetWorld): + (WebCore::debuggerWorld): + (WebCore::pluginWorld): + * bindings/js/JSDOMGlobalObject.cpp: + (WebCore::JSDOMGlobalObject::createJSAttributeEventListener): + (WebCore::toJSDOMGlobalObject): + * bindings/js/JSDOMGlobalObject.h: + * bindings/js/JSDOMWindowBase.cpp: + (WebCore::JSDOMWindowBase::printErrorMessage): + (WebCore::JSDOMWindowBase::commonJSGlobalData): + (WebCore::toJS): + (WebCore::toJSDOMWindow): + * bindings/js/JSDOMWindowBase.h: + * bindings/js/JSDOMWindowCustom.cpp: + (WebCore::createWindow): + (WebCore::JSDOMWindow::open): + (WebCore::JSDOMWindow::showModalDialog): + (WebCore::JSDOMWindow::setTimeout): + (WebCore::JSDOMWindow::setInterval): + (WebCore::JSDOMWindow::addEventListener): + (WebCore::JSDOMWindow::removeEventListener): + * bindings/js/JSDOMWindowShell.cpp: + (WebCore::toJS): + (WebCore::toJSDOMWindowShell): + * bindings/js/JSDOMWindowShell.h: + * bindings/js/JSDesktopNotificationsCustom.cpp: + (WebCore::JSNotification::addEventListener): + (WebCore::): + * bindings/js/JSEventListener.cpp: + (WebCore::JSEventListener::JSEventListener): + (WebCore::JSEventListener::handleEvent): + (WebCore::JSEventListener::reportError): + * bindings/js/JSEventListener.h: + (WebCore::JSEventListener::create): + * bindings/js/JSEventSourceCustom.cpp: + (WebCore::JSEventSource::addEventListener): + (WebCore::JSEventSource::removeEventListener): + * bindings/js/JSEventTarget.cpp: + (WebCore::toJS): + * bindings/js/JSHTMLDocumentCustom.cpp: + (WebCore::JSHTMLDocument::open): + * bindings/js/JSHTMLFrameSetElementCustom.cpp: + (WebCore::JSHTMLFrameSetElement::nameGetter): + * bindings/js/JSInspectorBackendCustom.cpp: + (WebCore::JSInspectorBackend::databaseForId): + (WebCore::JSInspectorBackend::inspectedWindow): + (WebCore::JSInspectorBackend::nodeForId): + * bindings/js/JSLazyEventListener.cpp: + (WebCore::JSLazyEventListener::JSLazyEventListener): + (WebCore::JSLazyEventListener::parseCode): + * bindings/js/JSLazyEventListener.h: + (WebCore::JSLazyEventListener::create): + * bindings/js/JSMessageChannelCustom.cpp: + (WebCore::JSMessageChannel::markChildren): + * bindings/js/JSMessagePortCustom.cpp: + (WebCore::JSMessagePort::markChildren): + (WebCore::JSMessagePort::addEventListener): + (WebCore::JSMessagePort::removeEventListener): + * bindings/js/JSNodeCustom.cpp: + (WebCore::JSNode::addEventListener): + (WebCore::JSNode::removeEventListener): + (WebCore::JSNode::markChildren): + * bindings/js/JSNodeFilterCondition.cpp: + (WebCore::JSNodeFilterCondition::acceptNode): + * bindings/js/JSQuarantinedObjectWrapper.cpp: + (WebCore::JSQuarantinedObjectWrapper::construct): + (WebCore::JSQuarantinedObjectWrapper::call): + * bindings/js/JSSVGElementInstanceCustom.cpp: + (WebCore::JSSVGElementInstance::addEventListener): + (WebCore::JSSVGElementInstance::removeEventListener): + * bindings/js/JSSharedWorkerCustom.cpp: + (WebCore::JSSharedWorker::markChildren): + * bindings/js/JSWebSocketCustom.cpp: + (WebCore::JSWebSocket::addEventListener): + (WebCore::JSWebSocket::removeEventListener): + * bindings/js/JSWorkerContextCustom.cpp: + (WebCore::JSWorkerContext::addEventListener): + (WebCore::JSWorkerContext::removeEventListener): + (WebCore::JSWorkerContext::setTimeout): + (WebCore::JSWorkerContext::setInterval): + * bindings/js/JSXMLHttpRequestConstructor.cpp: + (WebCore::constructXMLHttpRequest): + * bindings/js/JSXMLHttpRequestCustom.cpp: + (WebCore::JSXMLHttpRequest::markChildren): + (WebCore::JSXMLHttpRequest::addEventListener): + (WebCore::JSXMLHttpRequest::removeEventListener): + * bindings/js/JSXMLHttpRequestUploadCustom.cpp: + (WebCore::JSXMLHttpRequestUpload::markChildren): + (WebCore::JSXMLHttpRequestUpload::addEventListener): + (WebCore::JSXMLHttpRequestUpload::removeEventListener): + * bindings/js/ScheduledAction.cpp: + (WebCore::ScheduledAction::create): + (WebCore::ScheduledAction::ScheduledAction): + (WebCore::ScheduledAction::executeFunctionInContext): + (WebCore::ScheduledAction::execute): + * bindings/js/ScheduledAction.h: + (WebCore::ScheduledAction::ScheduledAction): + * bindings/js/ScriptCachedFrameData.cpp: + (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): + (WebCore::ScriptCachedFrameData::restore): + * bindings/js/ScriptController.cpp: + (WebCore::ScriptController::~ScriptController): + (WebCore::ScriptController::evaluateInWorld): + (WebCore::ScriptController::evaluate): + (WebCore::ScriptController::evaluateInIsolatedWorld): + (WebCore::ScriptController::clearWindowShell): + (WebCore::ScriptController::initScript): + (WebCore::ScriptController::processingUserGestureEvent): + (WebCore::ScriptController::attachDebugger): + (WebCore::ScriptController::updateDocument): + (WebCore::ScriptController::bindingRootObject): + (WebCore::ScriptController::createRootObject): + (WebCore::ScriptController::windowScriptNPObject): + (WebCore::ScriptController::jsObjectForPluginElement): + * bindings/js/ScriptController.h: + (WebCore::ScriptController::windowShell): + (WebCore::ScriptController::existingWindowShell): + (WebCore::ScriptController::globalObject): + (WebCore::ScriptController::forgetWorld): + * bindings/js/ScriptControllerMac.mm: + (WebCore::ScriptController::windowScriptObject): + * bindings/js/ScriptEventListener.cpp: + (WebCore::createAttributeEventListener): + * bindings/js/ScriptFunctionCall.cpp: + (WebCore::ScriptFunctionCall::call): + (WebCore::ScriptFunctionCall::construct): + * bindings/js/ScriptObjectQuarantine.cpp: + (WebCore::getQuarantinedScriptObject): + * bindings/js/ScriptState.cpp: + (WebCore::scriptStateFromNode): + (WebCore::scriptStateFromPage): + * bindings/js/ScriptState.h: + * bindings/js/WorkerScriptController.cpp: + (WebCore::WorkerScriptController::WorkerScriptController): + (WebCore::WorkerScriptController::evaluate): + * bindings/objc/DOMInternal.mm: + (-[WebScriptObject _initializeScriptDOMNodeImp]): + * bindings/objc/WebScriptObject.mm: + (-[WebScriptObject callWebScriptMethod:withArguments:]): + (-[WebScriptObject evaluateWebScript:]): + * bindings/scripts/CodeGeneratorJS.pm: + * bridge/NP_jsobject.cpp: + (_NPN_InvokeDefault): + (_NPN_Invoke): + (_NPN_Evaluate): + (_NPN_Construct): + * bridge/jni/jni_jsobject.mm: + (JavaJSObject::call): + (JavaJSObject::eval): + * dom/Document.cpp: + (WebCore::Document::createWrapperCache): + * dom/Document.h: + (WebCore::Document::wrapperCacheMap): + (WebCore::Document::getWrapperCache): + * inspector/InspectorController.cpp: + (WebCore::InspectorController::startUserInitiatedProfiling): + (WebCore::InspectorController::stopUserInitiatedProfiling): + * inspector/JavaScriptCallFrame.cpp: + (WebCore::JavaScriptCallFrame::evaluate): + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::dispatchWindowObjectAvailable): + * platform/network/mac/AuthenticationMac.mm: + * xml/XMLHttpRequest.cpp: + (WebCore::XMLHttpRequest::XMLHttpRequest): + (WebCore::XMLHttpRequest::dropProtection): + * xml/XMLHttpRequest.h: + (WebCore::XMLHttpRequest::create): + +2009-10-22 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: EventListenersSidebarPane TODO No Longer Needed + https://bugs.webkit.org/show_bug.cgi?id=30705 + + * inspector/front-end/EventListenersSidebarPane.js: + +2009-10-22 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Tim Hatcher. + + https://bugs.webkit.org/show_bug.cgi?id=30506 + <rdar://problem/7319845> Resources that the server sent as 304 not modified are not shown + in the inspectors resource pane + + I don't know how to make a test for this. + + The issue here was that preloaded resources weren't added to DocLoader document resource set, + but Web Inspector asked DocLoader to fetch data from CachedResource. Even when (if) document + parser eventually requested the same resource for real and it got added to resource set, it + was too late - the Inspector wasn't updated. + + * inspector/InspectorResource.cpp: + (WebCore::InspectorResource::cachedResource): + (WebCore::InspectorResource::type): + (WebCore::InspectorResource::resourceData): + * inspector/InspectorResource.h: + Fix the issue by trying to fetch corresponding CachedResource harder - also look in global + cache. This seems safe, and easier than updating the Inspector on transitions between + resource states (revalidate vs. revalidate done and preload vs. non-preload). + +2009-10-22 Beth Dakin <bdakin@apple.com> + + Reviewed by Dan Bernstein. + + Fix for <rdar://problem/6942706> ER: Add a CSS property that allows + shadows to work for SVG content + -and corresponding- + https://bugs.webkit.org/show_bug.cgi?id=30479 + + This patch adds a new SVG-specific CSS property called -webkit- + shadow that has the same syntax as -webkit-box-shadow + + Add CSSPropertyWebkitShadow to the list of SVG CSS properties, and + make valueForShadow a member function rather than a static function + * css/CSSComputedStyleDeclaration.cpp: + (WebCore::): + (WebCore::CSSComputedStyleDeclaration::valueForShadow): + (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): + * css/CSSComputedStyleDeclaration.h: + + Call valueForShadow for CSSPropertyWebkitShadow + * css/SVGCSSComputedStyleDeclaration.cpp: + (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): + + Do standard CSS stuff for CSSPropertyWebkitShadow + * css/SVGCSSParser.cpp: + (WebCore::CSSParser::parseSVGValue): + * css/SVGCSSPropertyNames.in: + * css/SVGCSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::applySVGProperty): + + Set the appropriate shadow on the paint context if we have one. + This seems to be all we have to do to have an SVG-shaped shadow. + * rendering/SVGRenderSupport.cpp: + (WebCore::SVGRenderBase::prepareToRenderSVGContent): + + Add shadow to SVGRenderStyle. I added a new macro that I don't like + just because that's the way things are done here right now. + * rendering/style/SVGRenderStyle.cpp: + (WebCore::SVGRenderStyle::SVGRenderStyle): + (WebCore::SVGRenderStyle::operator==): + * rendering/style/SVGRenderStyle.h: + * rendering/style/SVGRenderStyleDefs.cpp: + (StyleShadowSVGData::StyleShadowSVGData): + (StyleShadowSVGData::operator==): + * rendering/style/SVGRenderStyleDefs.h: + (WebCore::StyleShadowSVGData::create): + (WebCore::StyleShadowSVGData::copy): + (WebCore::StyleShadowSVGData::operator!=): + +2009-10-22 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Xan Lopez. + + https://bugs.webkit.org/show_bug.cgi?id=25530 + [Gtk] Implement LABEL_FOR/LABELLED_BY relationship pair for labels + + Implements atk_object_ref_relation_set and LABEL_FOR/LABELLED_BY. + Also causes the accessible name for labeled controls to be based on + the label as expected, rather than based on the contents. + + * accessibility/AccessibilityRenderObject.h: + * accessibility/AccessibilityRenderObject.cpp: + (correspondingLabelForControlElement): + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (setAtkRelationSetFromCoreObject): + (webkit_accessible_ref_relation_set): + (webkit_accessible_class_init): + (webkit_accessible_get_name): + +2009-10-22 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: windowFocused and windowBlured Fail to Clear/Mark Inspector as "inactive" + https://bugs.webkit.org/show_bug.cgi?id=30663 + + Correctly handle focusing/blurring on inner <iframe>'s such as Source Frames. + + * inspector/front-end/inspector.js: + (WebInspector.windowFocused): fix for inner iframes + (WebInspector.windowBlurred): fix for inner iframes + (WebInspector.addMainEventListeners): change useCapture to false + +2009-10-22 Jaime Yap <jaimeyap@google.com> + + Reviewed by Timothy Hatcher. + + Makes a page reload optional when activating resource monitoring in + InspectorController. It leaves the default behavior as performing the reload. + Reload is an optional param so callsites do not have to change. + + https://bugs.webkit.org/show_bug.cgi?id=30684 + + No new tests added. + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::enableResourceTracking): + * inspector/InspectorController.h: + +2009-10-22 Shu Chang <Chang.Shu@nokia.com> + + Reviewed by Eric Seidel. + + [Qt] Fix memory leak in QNetworkReplyHandler::abort(). + In QNetworkReplyHandler::release(), m_reply should no longer point to its parent + after being released. + https://bugs.webkit.org/show_bug.cgi?id=30167 + + No layout test available as a non-functional fix. + + * platform/network/qt/QNetworkReplyHandler.cpp: + (WebCore::QNetworkReplyHandler::abort): + (WebCore::QNetworkReplyHandler::release): + +2009-10-22 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Fix DOMAgent leak. + + https://bugs.webkit.org/show_bug.cgi?id=30615 + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::~InspectorController): + (WebCore::InspectorController::setFrontendProxyObject): + (WebCore::InspectorController::close): + (WebCore::InspectorController::releaseDOMAgent): + * inspector/InspectorController.h: + * inspector/InspectorDOMAgent.h: + (WebCore::InspectorDOMAgent::create): + +2009-10-22 Dimitri Glazkov <dglazkov@chromium.org> + + Reviewed by Adam Barth. + + [V8] Rework event listeners to not hold references to frame or V8 context. + + https://bugs.webkit.org/show_bug.cgi?id=30648 + + Covered by existing layout tests: fast/events/attribute-listener* + + * bindings/scripts/CodeGeneratorV8.pm: Added passing ScriptExecutionContext* + to event listener handling code. + * bindings/v8/DateExtension.cpp: + (WebCore::DateExtension::setAllowSleep): Changed to use currentContext(). + * bindings/v8/ScriptEventListener.cpp: + (WebCore::createAttributeEventListener): Reworked to match JSC logic. + (WebCore::getEventListenerHandlerBody): Added ScriptExecutionContext* param. + * bindings/v8/V8AbstractEventListener.cpp: + (WebCore::V8AbstractEventListener::V8AbstractEventListener): Removed Frame* param + and usage. + (WebCore::V8AbstractEventListener::handleEvent): Chaged to use ScriptExecutionContext*. + (WebCore::V8AbstractEventListener::invokeEventHandler): Ditto. + * bindings/v8/V8AbstractEventListener.h: + (WebCore::V8AbstractEventListener::getListenerObject): Ditto. + (WebCore::V8AbstractEventListener::prepareListenerObject): Ditto. + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Added ScriptExecutionContext* param. + (WebCore::V8DOMWrapper::getEventListener): Ditto. + * bindings/v8/V8DOMWrapper.h: + (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Ditto. + * bindings/v8/V8EventListenerList.h: + (WebCore::V8EventListenerList::findOrCreateWrapper): Removed ContextType* template param, + because it's no longer needed. + * bindings/v8/V8IsolatedWorld.h: + (WebCore::V8IsolatedWorld::sharedContext): Renamed from shared_context. + * bindings/v8/V8LazyEventListener.cpp: + (WebCore::V8LazyEventListener::V8LazyEventListener): Removed Frame* param and usage. + (WebCore::V8LazyEventListener::callListenerFunction): Added ScriptExecutionContext* param. + (WebCore::V8LazyEventListener::prepareListenerObject): Ditto. + * bindings/v8/V8LazyEventListener.h: + (WebCore::V8LazyEventListener::create): Reordered params to match JSC impl. + * bindings/v8/V8Proxy.cpp: + (WebCore::V8Proxy::V8Proxy): Adjusted formatting to match WebKit style. + (WebCore::V8Proxy::evaluateInNewContext): Changed to use m_context directly. + (WebCore::V8Proxy::setInjectedScriptContextDebugId): Ditto. + (WebCore::V8Proxy::createWrapperFromCacheSlowCase): Ditto. + (WebCore::V8Proxy::isContextInitialized): Ditto. + (WebCore::V8Proxy::updateDocumentWrapperCache): Ditto. + (WebCore::V8Proxy::clearDocumentWrapperCache): Ditto. + (WebCore::V8Proxy::disposeContextHandles): Added explicit disposing of m_context. + (WebCore::V8Proxy::clearForClose): Changed to use m_context directly. + (WebCore::V8Proxy::clearForNavigation): Ditto. + (WebCore::V8Proxy::setSecurityToken): Ditto. + (WebCore::V8Proxy::updateDocument): Ditto. + (WebCore::V8Proxy::initContextIfNeeded): Ditto. + (WebCore::V8Proxy::context): Changed to use v8::Local. + (WebCore::V8Proxy::mainWorldContext): Changed to use m_context directly. + (WebCore::V8Proxy::setContextDebugId): Ditto. + (WebCore::toV8Context): + * bindings/v8/V8Proxy.h: Removed shared_context decl, changed to use straight + v8::Persistent for m_context. + * bindings/v8/V8WorkerContextEventListener.cpp: + (WebCore::workerProxy): Added. + (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Removed + WorkerContextExecutionProxy* param. + (WebCore::V8WorkerContextEventListener::handleEvent): Started using ScriptExecutionContext*. + (WebCore::V8WorkerContextEventListener::reportError): Ditto. + (WebCore::V8WorkerContextEventListener::callListenerFunction): Ditto. + (WebCore::V8WorkerContextEventListener::getReceiverObject): Ditto. + * bindings/v8/V8WorkerContextEventListener.h: + (WebCore::V8WorkerContextEventListener::create): Removed + WorkerContextExecutionProxy* param. + * bindings/v8/WorkerContextExecutionProxy.cpp: + (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener): Removed ContextType* + template param. + * bindings/v8/custom/V8CustomEventListener.cpp: + (WebCore::V8EventListener::V8EventListener): Removed Frame* param. + (WebCore::V8EventListener::getListenerFunction): Started using ScriptExecutionContext*. + (WebCore::V8EventListener::callListenerFunction): Ditto. + * bindings/v8/custom/V8CustomEventListener.h: + (WebCore::V8EventListener::create): Removed Frame* param. + +2009-10-14 Gaurav Shah <gauravsh@google.com> + + Reviewed by Darin Fisher. + + Replaces temporary link stub for <keygen> tag handler for the Chromium + browser with a call via the Chromium Bridge. + + https://bugs.webkit.org/show_bug.cgi?id=30360 + + * platform/SSLKeyGenerator.h: + * platform/chromium/ChromiumBridge.h: + * platform/chromium/SSLKeyGeneratorChromium.cpp: + (WebCore::getSupportedKeySizes): + (WebCore::signedPublicKeyAndChallengeString): + * platform/chromium/TemporaryLinkStubs.cpp: + (WebCore::KURL::fileSystemPath): + (WebCore::SharedBuffer::createWithContentsOfFile): + +2009-10-22 Avi Drissman <avi@chromium.org> + + Reviewed by Eric Seidel. + + Fixes Chromium Mac pasteboard handling to flow through the same code paths as other platforms. + + https://bugs.webkit.org/show_bug.cgi?id=30591 + + * platform/chromium/ChromiumBridge.h: + * platform/chromium/PasteboardChromium.cpp: + (WebCore::Pasteboard::writeImage): + +2009-10-20 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Darin Adler. + + Make accelerated compositing debug indicators work in release builds + https://bugs.webkit.org/show_bug.cgi?id=30588 + + Allow some debug indicators, that show which page elements go into compositing layers, + to work in release builds, when the runtime prefs are set. + + * platform/graphics/GraphicsLayer.cpp: + (WebCore::GraphicsLayer::GraphicsLayer): + (WebCore::GraphicsLayer::setZPosition): + * platform/graphics/GraphicsLayer.h: + * platform/graphics/mac/GraphicsLayerCA.h: + * platform/graphics/mac/GraphicsLayerCA.mm: + (WebCore::clearBorderColor): + (WebCore::GraphicsLayer::showRepaintCounter): + (WebCore::GraphicsLayerCA::GraphicsLayerCA): + (WebCore::GraphicsLayerCA::updateMasksToBounds): + (WebCore::GraphicsLayerCA::updateLayerDrawsContent): + (WebCore::GraphicsLayerCA::setDebugBorder): + (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): + (WebCore::GraphicsLayerCA::setupContentsLayer): + * platform/graphics/mac/WebLayer.mm: + +2009-10-22 Keishi Hattori <casey.hattori@gmail.com> + + Reviewed by Pavel Feldman. + + Inspector should support monitorEvents/un monitorEvents() in the command line + https://bugs.webkit.org/show_bug.cgi?id=19879 + + * inspector/front-end/EventListenersSidebarPane.js: + (WebInspector.EventListenersSidebarPane.prototype.update.callback): Ignores event listeners generated by monitorEvent + * inspector/front-end/InjectedScript.js: + (InjectedScript._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI._logEvent, _allEventTypes, + _normalizeEventTypes, monitorEvent, unmonitorEvent. + +2009-10-21 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Pavel Feldman. + + Web Inspector: windowFocused and windowBlurred Fail to Clear/Mark Inspector as "inactive" + https://bugs.webkit.org/show_bug.cgi?id=30663 + + * inspector/front-end/inspector.js: + (WebInspector.windowFocused): + (WebInspector.windowBlurred): + +2009-10-22 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Pavel Feldman. + + Web Inspector: Error - requestContentType [undefined] is not an object + https://bugs.webkit.org/show_bug.cgi?id=30666 + + * inspector/front-end/ResourceView.js: + (WebInspector.ResourceView.prototype._refreshFormData): + +2009-10-22 Maxime Simon <simon.maxime@gmail.com> + + Reviewed by Holger Freyther. + + [Haiku] Correction of the accented letter width (they were 2 characters long). + https://bugs.webkit.org/show_bug.cgi?id=30629 + + * platform/graphics/haiku/SimpleFontDataHaiku.cpp: + (WebCore::SimpleFontData::platformWidthForGlyph): + +2009-10-21 Jon Honeycutt <jhoneycutt@apple.com> + + <rdar://problem/7270320> Screenshots of off-screen plug-ins are blank + <rdar://problem/7270314> After halting a transparent PluginView on + Windows, the transparency is applied twice + + Replace use of Frame::nodeImage() with a function that takes a snapshot + of a PluginView. + + Reviewed by Dan Bernstein. + + * plugins/PluginView.h: + Made paintWindowedPluginIntoContext() non-const, as it now calls + paintIntoTransformedContext(). Declare paintIntoTransformedContext() + and snapshot() for Windows platforms. + + * plugins/win/PluginViewWin.cpp: + (WebCore::PluginView::paintIntoTransformedContext): + Paints into the passed HDC without applying any coordinate translations. + Code moved from paintWindowedPluginIntoContext() and paint(). Removed + the memset() of windowpos in lieu of assignment. + (WebCore::PluginView::paintWindowedPluginIntoContext): + Code moved to paintIntoTransformedContext(). + (WebCore::PluginView::paint): + Ditto. + (WebCore::PluginView::snapshot): + Create a context, and if the plug-in is windowless, translate it so the + plug-in will draw at the correct location. Create a bitmap, and select + it into the context. Paint the plug-in, and create a BitmapImage from + the bitmap. + (WebCore::PluginView::halt): + Use snapshot(). + +2009-10-22 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by Alexey Proskuryakov. + + Fix calculation of length in WebSocketChannel.cpp + https://bugs.webkit.org/show_bug.cgi?id=30656 + + * websockets/WebSocketChannel.cpp: + (WebCore::WebSocketChannel::didReceiveData): + +2009-10-21 Dumitru Daniliuc <dumi@chromium.org> + + Reviewed by Dimitri Glazkov. + + Adding the ability to enable/disable functions in V8 at runtime. + + https://bugs.webkit.org/show_bug.cgi?id=30650 + + * bindings/scripts/CodeGeneratorV8.pm: + +2009-10-21 Darin Adler <darin@apple.com> + + Swedish search (and other languages as well) is broken while fixing Japanese search + https://bugs.webkit.org/show_bug.cgi?id=30646 + + Rolled Japanese tailoring out that was done to fix + https://bugs.webkit.org/show_bug.cgi?id=30437 earlier. + It was overriding the locale-specific tailoring. + We'll land a fix once we figure out how to add the + Japanese tailoring without removing anything. + + * editing/TextIterator.cpp: Rolled out r49924. + +2009-10-21 Pavel Feldman <pfeldman@chromium.org> + + Not reviewed: chromium build fix - add missing image to gypi. + + * WebCore.gypi: + +2009-10-21 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Eric Seidel. + + Fixes part of <http://webkit.org/b/30522>. + Web Inspector: DOM Exceptions throughout the Inspector should be more human readable. + + Expose the description attribute that is now a member of + ExceptionBase as of r49723, so when a user logs an exception, they + can see the description in the Web Inspector. + + Test: fast/dom/dom-exception-description.html + + * dom/DOMCoreException.idl: + * dom/EventException.idl: + * dom/RangeException.idl: + * svg/SVGException.idl: + * xml/XMLHttpRequestException.idl: + * xml/XPathException.idl: + +2009-10-21 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <https://bugs.webkit.org/show_bug.cgi?id=30616>. + REGRESSION (r49036): Web Inspector: Summary graph no longer switching to size summary. + + Add a check to make sure a function we need to calculate percentages is + defined before we use it. + + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): + +2009-10-21 Keishi Hattori <casey.hattori@gmail.com> + + Reviewed by Timothy Hatcher. + + REGRESSION: Clicking on nodes in the console should take you to the element in the DOM + https://bugs.webkit.org/show_bug.cgi?id=27231 + + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView.prototype._formatnode): Turns on ElementsTreeOutline.showInElementsPanelEnabled + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeOutline): Added ElementsTreeOutline.showInElementsPanelEnabled + (WebInspector.ElementsTreeElement.prototype.onmousedown): Reveals the node in the Elements panel if + treeOutline.showInElementsPanelEnabled is true. + +2009-10-21 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=30637 + Fix a compiler warning in windows. + + * loader/ResourceLoadNotifier.h: + +2009-10-21 Dmitry Titov <dimich@chromium.org> + + Reviewed by Darin Adler. + + Fix the crash when a node not in a document receives dispatchEvent. + https://bugs.webkit.org/show_bug.cgi?id=30611 + + Test: fast/events/dispatch-event-no-document.html + + * dom/EventTarget.cpp: Check for scriptExecutionContext() at the moment of dispatchEvent; do nothing if no context. + (WebCore::EventTarget::dispatchEvent): + +2009-10-21 Adam Langley <agl@google.com> + + Reviewed by Eric Seidel. + + Chromium Linux: disable subpixel text on layers. + + https://bugs.webkit.org/show_bug.cgi?id=30635 + http://code.google.com/p/chromium/issues/detail?id=25365 + + With the addition of layers for drawing rounded corners in r49641, + subpixel text on rounded rectangles broke. This is because the layer + only contains a single alpha channel and this is insufficient to + compose subpixel text correctly. + + On Windows, a large body of code in TransparencyWin.cpp exists to try + to deal with this. Even then, in some cases, it downgrades to + anti-aliased text. We need a fix for the grevious effects quickly thus + this patch disables subpixel text when rendering into a layer. + + This would be covered by existing tests except that subpixel text is + disabled for pixel tests on Chromium Linux. + + * platform/graphics/chromium/FontLinux.cpp: + (WebCore::isCanvasMultiLayered): + (WebCore::adjustTextRenderMode): + (WebCore::Font::drawGlyphs): + (WebCore::Font::drawComplexText): + +2009-10-21 Kevin Ollivier <kevino@theolliviers.com> + + wxMac 10.4 build fix, make sure we specify the Sqlite3 dependency correctly as otherwise + it will use the sqlite3 system library rather than WebCoreSQLite3. + + * wscript: + +2009-10-21 Dan Bernstein <mitz@apple.com> + + Reviewed by Sam Weinig. + + Fixed background-clip parsing regressions introduced in r46240. + + Test: fast/css/background-clip-text.html + + * css/CSSParser.cpp: + (WebCore::parseBackgroundClip): Added this helper method. + (WebCore::CSSParser::parseFillShorthand): Use parseBackgroundClip() to + reparse the value. The old code called parseFillProperty() again, which + didn’t work, because parseFillProperty() advances the value list. + (WebCore::CSSParser::parseFillProperty): Changed to use + parseBackgroundClip(). + * css/CSSPrimitiveValueMappings.h: + (WebCore::CSSPrimitiveValue::operator EFillBox): Added a case for + CSSValueWebkitText. + +2009-10-21 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Timothy Hatcher. + + Enable creation of custom SidebarTreeElements for different ProfileTypes + + ProfileTypes can now create sidebar tree elements of custom types. + https://bugs.webkit.org/show_bug.cgi?id=30520 + + * inspector/front-end/ProfileView.js: + (WebInspector.CPUProfileType.prototype.setRecordingProfile): + (WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile): + (WebInspector.CPUProfileType.prototype.createView): + (WebInspector.CPUProfile.prototype.get head): + * inspector/front-end/ProfilesPanel.js: + (WebInspector.ProfileType.prototype.buttonClicked): + (WebInspector.ProfileType.prototype.viewForProfile): + (WebInspector.ProfileType.prototype.createView): + (WebInspector.ProfileType.prototype.createSidebarTreeElementForProfile): + (WebInspector.ProfilesPanel.prototype.addProfileHeader): + (WebInspector.ProfilesPanel.prototype.showProfile): + +2009-10-20 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Selectors in the Styles pane should trigger a search for that selector when clicked + https://bugs.webkit.org/show_bug.cgi?id=17126 + + * inspector/front-end/ElementsPanel.js: + (WebInspector.ElementsPanel.prototype.addNodesToSearchResult): only change focusedDOMNode on a manual search + * inspector/front-end/StylesSidebarPane.js: + (WebInspector.StylePropertiesSection.prototype._clickSelector): trigger a search + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeElement.prototype._startEditing): correctly start editing attribute value instead of name + +2009-10-20 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Fix DOM Agent leak. + + https://bugs.webkit.org/show_bug.cgi?id=30615 + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::~InspectorController): + +2009-10-21 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Holger Freyther. + + Plugins: Create manual tests for testing plugins + + Create two test files: + 1. windowed.html - Test plugin in windowed mode. + 2. windowless.html - Test plugin in windowless mode. + + https://bugs.webkit.org/show_bug.cgi?id=30503 + + * manual-tests/plugins/windowed.html: Added. + * manual-tests/plugins/windowless.html: Added. + +2009-10-21 Satoshi Nakagawa <psychs@limechat.net> + + Reviewed by Darin Adler. + + Fixed Japanese text search problems. + Treat small kana letters and kana letters as different characters in search. + Do not ignore diacritic marks in search for Japanese texts. + + https://bugs.webkit.org/show_bug.cgi?id=30437 + + Test: fast/text/international/japanese-kana-letters.html + + * editing/TextIterator.cpp: + (WebCore::createCollator): + (WebCore::collator): + (WebCore::createSearcher): + +2009-10-20 Eric Z. Ayers <zundel@google.com> + + Reviewed by Timothy Hatcher. + + Changes TimelineItems to be created with raw timestamps as opposed + to a time relative to a start of session. Normalized timestamps cause + problems when monitoring a browsing session across multiple page + transitions. + + * inspector/InspectorTimelineAgent.cpp: + (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): + (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): + (WebCore::InspectorTimelineAgent::willLayout): + (WebCore::InspectorTimelineAgent::willRecalculateStyle): + (WebCore::InspectorTimelineAgent::willPaint): + (WebCore::InspectorTimelineAgent::willWriteHTML): + (WebCore::InspectorTimelineAgent::reset): + (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): + * inspector/InspectorTimelineAgent.h: + +2009-10-20 Mark Rowe <mrowe@apple.com> + + Reviewed by Oliver Hunt. + + Fix leak of WebSocketChannel by adopting the newly-created reference. + + * websockets/WebSocketChannel.h: + (WebCore::WebSocketChannel::create): + +2009-10-20 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Adam Barth. + + DOM Storage runtime flag changes + https://bugs.webkit.org/show_bug.cgi?id=30602 + + Part 1/2. Removing sessionStorageEnabled in next patch after the + Chromium side of the changes lands. + + Revert my changes to Settings and instead implement DOM Storage enabling via + the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240 + + This stuff was (intentionally) never exposed to web pages or DRT, so there's no + LayoutTest visible changes and thus no tests. + + * bindings/v8/custom/V8CustomBinding.h: + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::ACCESSOR_RUNTIME_ENABLER): + * page/DOMWindow.idl: + * storage/Storage.cpp: + (WebCore::Storage::setLocalStorageAvailable): + (WebCore::Storage::localStorageAvailable): + (WebCore::Storage::setSessionStorageAvailable): + (WebCore::Storage::sessionStorageAvailable): + * storage/Storage.h: + +2009-10-20 John Gregg <johnnyg@google.com> + + Reviewed by David Levin. + + Need to turn off notifications properly at runtime + https://bugs.webkit.org/show_bug.cgi?id=30409 + + This code only affects chromium, and is all behind a compile time + flag current turned off, so no new tests. + + * bindings/v8/custom/V8CustomBinding.h: + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::ACCESSOR_RUNTIME_ENABLER): + * bindings/v8/custom/V8WorkerContextCustom.cpp: + (WebCore::ACCESSOR_RUNTIME_ENABLER): + * notifications/NotificationCenter.cpp: + (WebCore::NotificationCenter::setIsAvailable): + (WebCore::NotificationCenter::isAvailable): + * notifications/NotificationCenter.h: + * page/DOMWindow.idl: + * workers/WorkerContext.idl: + +2009-10-20 James Robinson <jamesr@chromium.org> + + Reviewed by Adam Barth. + + Fixes RefPtr initialization in the V8 implementation of WebCore::ScriptString to use the ::create() idiom and + use adoptRef() properly. I failed to read the RefPtr docs the first time through :( + + No new tests, error was caught by valgrind on the Chromium builders. + + * bindings/v8/ScriptString.h: + (WebCore::ScriptString::ScriptString): + (WebCore::ScriptString::operator=): + * bindings/v8/ScriptStringImpl.h: + (WebCore::ScriptStringImpl::create): + +2009-10-20 Mikhail Naganov <mnaganov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: populate child nodes before sorting them. + + https://bugs.webkit.org/show_bug.cgi?id=29673 + + * inspector/front-end/BottomUpProfileDataGridTree.js: + (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode. + (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): + (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): + (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): + (WebInspector.BottomUpProfileDataGridNode.prototype._merge): + (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): + (WebInspector.BottomUpProfileDataGridTree.prototype.exclude): + * inspector/front-end/ProfileDataGridTree.js: + (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses. + (WebInspector.ProfileDataGridNode.prototype.get _parent): + (WebInspector.ProfileDataGridNode.prototype._populate): + * inspector/front-end/TopDownProfileDataGridTree.js: + (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate): + +2009-10-20 Jens Alfke <snej@chromium.org> + + Reviewed by Eric Seidel. + + Remove redundant String ref/deref calls in generated V8 bindings. + https://bugs.webkit.org/show_bug.cgi?id=30579 + + * bindings/v8/V8Binding.h: + (WebCore::toString): Fix return type of 'toString' to make it truly a no-op + instead of constructing/destructing a String. + +2009-10-20 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Xan Lopez. + + https://bugs.webkit.org/show_bug.cgi?id=25411 + [GTK] ATK accessible ancestry broken + + Work around for the problem of bogus additional objects in the ancestry. + We now set the parent when we ref the child, then ask the Atk child if + it knows its parent. This solves the bulk of the cases. For those it + doesn't, fall back to the existing logic. + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (webkit_accessible_get_parent): + (webkit_accessible_ref_child): + +2009-10-20 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Alice Liu. + + Fixes <http://webkit.org/b/30421>. + Web Inpsector: Local Files can show up on Cookies List with Cookies from other Domain. + + When a page like Google generates an about:blank, it shows up as a local file on + the list of Cookie domains, but has all of the cookies of Google. When we are adding + cookie domains to the inspector, we should only add the domain is the URL of the resource + is in the HTTP protocol family or a file URL. + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::populateScriptObjects): + (WebCore::InspectorController::didFinishLoading): + +2009-10-20 Mark Mentovai <mark@chromium.org> + + Reviewed by Darin Fisher. + + Use a version of libWebKitSystemInterface with global symbols marked + private_extern for Chromium Mac. + + https://bugs.webkit.org/show_bug.cgi?id=30590 + + * WebCore.gyp/WebCore.gyp: + * WebCore.gyp/mac: Added. + * WebCore.gyp/mac/Empty.cpp: Added. + * WebCore.gyp/mac/adjust_visibility.sh: Added. + +2009-10-20 Zoltan Horvath <zoltan@webkit.org> + + Reviewed by Eric Seidel. + + Allow custom memory allocation control for WebCore's CSSProperty + https://bugs.webkit.org/show_bug.cgi?id=30564 + + Inherits CSSProperty class from FastAllocBase because it has been + instantiated by 'new' in WebCore/css/CSSParser.cpp:367. + + * css/CSSProperty.h: + +2009-10-20 Andrew Scherkus <scherkus@chromium.org> + + Reviewed by Eric Seidel. + + Hide Chromium's media slider thumb if no source has been loaded. + + https://bugs.webkit.org/show_bug.cgi?id=30529 + + Covered by existing layout tests, notably: + LayoutTests/media/controls-rendering.html + LayoutTests/media/unsupported-tracks.html + LayoutTests/media/video-src-none.html + + * rendering/RenderMediaControlsChromium.cpp: + (WebCore::hasSource): Returns true if an HTMLMediaElement has a valid source set. + (WebCore::paintMediaMuteButton): Refactored to use hasSource(). + (WebCore::paintMediaPlayButton): Ditto. + (WebCore::paintMediaSliderThumb): Add call to hasSource() to determine if we should paint the thumb. + +2009-10-20 Nate Chapin <japhet@chromium.org> + + Reviewed by Adam Barth. + + Added getter for FrameLoader:m_suppressOpenerInNewFrame. + This will allow Chromium to more intelligently detect + noreferrer links and therefore open them in a new process. + + https://bugs.webkit.org/show_bug.cgi?id=30581 + + * loader/FrameLoader.h: + (WebCore::FrameLoader::suppressOpenerInNewFrame): Added. + +2009-10-20 Zoltan Horvath <zoltan@webkit.org> + + Reviewed by Darin Adler. + + Allow custom memory allocation control for WebCore's CSSParserFunction + https://bugs.webkit.org/show_bug.cgi?id=30563 + + Inherits CSSParserFunction struct from FastAllocBase because it has been + instantiated by 'new' in WebCore/css/CSSParser.cpp:4827. + + * css/CSSProperty.h: + +2009-10-20 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Watched Expressions Buttons Do Not Match Inspector Styles + https://bugs.webkit.org/show_bug.cgi?id=30554 + + * inspector/front-end/inspector.css: added style to pane buttons + +2009-10-20 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Pavel Feldman. + + Set debug id for contexts of isolated worlds to distinguish them in debugger. + + https://bugs.webkit.org/show_bug.cgi?id=30559 + + * bindings/v8/V8Proxy.cpp: + (WebCore::V8Proxy::evaluateInIsolatedWorld): + (WebCore::V8Proxy::evaluateInNewContext): + (WebCore::V8Proxy::setInjectedScriptContextDebugId): + * bindings/v8/V8Proxy.h: + +2009-10-20 Andras Becsi <becsi.andras@stud.u-szeged.hu> + + Unreviewed buildfix. + [Qt] Add FEGaussianBlur.h and FEGaussianBlur.cpp which were refactored in r49778 to WebCore.pro. + + * WebCore.pro: + +2009-10-20 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by David Levin. + + Set EnabledAtRuntime for WebSocket in DOMWindow + https://bugs.webkit.org/show_bug.cgi?id=29896 + + Supported by chromium/v8 only. + Add WebSocket::isAvailable()/setIsAvailable(bool) to control v8 + bindings. + Remove Settings::experimentalWebSocketsEnabled() and + setExperimentalWebSocketsEnabled(bool). + + * WebCore.base.exp: + * bindings/js/JSDOMWindowCustom.cpp: + (WebCore::JSDOMWindow::webSocket): + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::getConstructor): + * bindings/v8/custom/V8CustomBinding.h: + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::ACCESSOR_RUNTIME_ENABLER): + * page/DOMWindow.idl: + * page/Settings.cpp: + (WebCore::Settings::Settings): + * page/Settings.h: + * websockets/WebSocket.cpp: + (WebCore::WebSocket::setIsAvailable): + (WebCore::WebSocket::isAvailable): + * websockets/WebSocket.h: + +2009-10-19 Oliver Hunt <oliver@apple.com> + + Reviewed by Sam Weinig. + + REGRESSION: Dromaeo DOM test is 14% slower + https://bugs.webkit.org/show_bug.cgi?id=30273 + + Whoops, make prototype bindings actually use the StructureFlags. + + * bindings/scripts/CodeGeneratorJS.pm: + +2009-10-19 James Robinson <jamesr@chromium.org> + + Reviewed by Adam Barth. + + Better implementation of WebCore::ScriptString for the V8 bindings. + + https://bugs.webkit.org/show_bug.cgi?id=29909 + + WebCore::ScriptString is used for XMLHttpRequest's responseText attribute which is + shared with JavaScript. Thus, simply using a WebCore::String and copying the value + is pretty inefficient, especially since responseText is built up with a sequence of + operator+= calls. JSC builds use a JSC::UString to share the buffer when possible, + this patch adopts a similar approach for V8. + + No new tests, behavior is unchanged and covered by LayoutTests/http/tests/xmlhttprequest + + * WebCore.gypi: + * bindings/v8/ScriptString.h: + (WebCore::ScriptString::ScriptString): + (WebCore::ScriptString::operator String): + (WebCore::ScriptString::isNull): + (WebCore::ScriptString::size): + (WebCore::ScriptString::operator=): + (WebCore::ScriptString::operator+=): + (WebCore::ScriptString::v8StringOrNull): + * bindings/v8/ScriptStringImpl.cpp: Added. + (WebCore::ScriptStringImpl::ScriptStringImpl): + (WebCore::ScriptStringImpl::~ScriptStringImpl): + (WebCore::ScriptStringImpl::toString): + (WebCore::ScriptStringImpl::isNull): + (WebCore::ScriptStringImpl::size): + (WebCore::ScriptStringImpl::append): + * bindings/v8/ScriptStringImpl.h: Added. + (WebCore::ScriptStringImpl::ScriptStringImpl): + (WebCore::ScriptStringImpl::v8StringHandle): + * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: + (WebCore::ACCESSOR_GETTER): + +2009-10-19 Adam Barth <abarth@webkit.org> + + No review, rolling out r49837. + http://trac.webkit.org/changeset/49837 + + * page/Settings.cpp: + (WebCore::Settings::setStandardFontFamily): + (WebCore::Settings::setFixedFontFamily): + (WebCore::Settings::setSerifFontFamily): + (WebCore::Settings::setSansSerifFontFamily): + (WebCore::Settings::setCursiveFontFamily): + (WebCore::Settings::setFantasyFontFamily): + * page/Settings.h: + (WebCore::Settings::standardFontFamily): + (WebCore::Settings::fixedFontFamily): + (WebCore::Settings::serifFontFamily): + (WebCore::Settings::sansSerifFontFamily): + (WebCore::Settings::cursiveFontFamily): + (WebCore::Settings::fantasyFontFamily): + * platform/text/UScriptCode.h: Removed. + +2009-10-19 Kwang Yul Seo <skyul@company100.net> + + Reviewed by Eric Seidel. + + Check COMPILER(MSVC) instead of PLATFORM(WIN_OS) to avoid the use of vasprintf. + https://bugs.webkit.org/show_bug.cgi?id=30473 + + vasprintf is missing in MSVC. Use COMPILER(MSVC) guards instead of + PLALTFORM(WIN_OS) guards. + + * dom/XMLTokenizerLibxml2.cpp: + (WebCore::XMLTokenizer::error): + +2009-10-19 Jungshik Shin <jshin@chromium.org> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=20797 + + Make generic font family getters/setters accept an additional + argument (script code). It has a default value so that if an embedder + does not have/want a per-script font family setting, call-sites + don't have to be changed. + This is to prepare for fixing bug 10874 (font selection is not + language-dependent) and bug 18085. + + There should be no change in layout and no new layout test + is added. + + * WebCore.base.exp: + * page/Settings.cpp: + * page/Settings.h: + * platform/text/UScriptCode.h: Added. This is for ports that + do not use ICU. the part of ICU's common/unicode/uscript.h + that defines script code enum was copied. To keep enums compatible + with those in ICU, we don't generate the list out of Scripts.txt + of the Unicode Data base or CLDR's data. + +2009-10-19 Evan Stade <estade@chromium.org> + + Reviewed by Darin Adler. + + Clarify usage of SuddenTermination API. No code change. + + * platform/SuddenTermination.h: + +2009-10-19 Oliver Hunt <oliver@apple.com> + + Reviewed by Gavin Barraclough. + + REGRESSION: Dromaeo DOM test is 14% slower + https://bugs.webkit.org/show_bug.cgi?id=30273 + + Make DOM bindings automatically inherit correct structure + flags rather than being needlessly conservative. This is + done by making the bindings generator use the same model + for TypeInfo flags that we now use in JSC. + + This gains us about 1% of this regression back. + + * bindings/js/JSDOMBinding.h: + (WebCore::DOMObjectWithGlobalPointer::createStructure): + (WebCore::DOMConstructorObject::createStructure): + * bindings/js/JSDOMWindowShell.h: + (WebCore::JSDOMWindowShell::createStructure): + * bindings/js/JSHTMLAllCollection.h: + (WebCore::JSHTMLAllCollection::createStructure): + * bindings/js/JSQuarantinedObjectWrapper.h: + (WebCore::JSQuarantinedObjectWrapper::createStructure): + * bindings/scripts/CodeGeneratorJS.pm: + * bridge/objc/objc_runtime.h: + (JSC::Bindings::ObjcFallbackObjectImp::createStructure): + * bridge/runtime_array.h: + (JSC::RuntimeArray::createStructure): + * bridge/runtime_method.h: + (JSC::RuntimeMethod::createStructure): + * bridge/runtime_object.h: + (JSC::RuntimeObjectImp::createStructure): + +2009-10-19 Robin Qiu <robin.qiu@torchmobile.com.cn> + + Reviewed by Nikolas Zimmermann. + + Fixed a bug on nested SVG <use> elements. + https://bugs.webkit.org/show_bug.cgi?id=26117 + When a <use> element refer to another <use> element which has + child/children, the instance tree built for this <use> element + is incorrect (more nodes than expected). + + Test: svg/dom/use-on-use-with-child.svg + + * svg/SVGUseElement.cpp: + (WebCore::SVGUseElement::buildInstanceTree): + +2009-10-19 Oliver Hunt <oliver@apple.com> + + Small changes to fully invalidate and update the JavaScriptCallFrame. + + <rdar://problem/7020755> JSDebugger crashes after reloading from a breakpoint + https://bugs.webkit.org/show_bug.cgi?id=27146 + + Reviewed by Timothy Hatcher. + + * inspector/JavaScriptCallFrame.h: + (WebCore::JavaScriptCallFrame::invalidate): + (WebCore::JavaScriptCallFrame::update): + +2009-10-19 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Dmitri Titov. + + Remove "source" from storage events + https://bugs.webkit.org/show_bug.cgi?id=30536 + + Remove "source" from storage events per + http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html + + This was removed because it makes it introduces synchronous access that can + cross the event loop boundry (since a storage event can fire from one process + and be handled in another). + + * inspector/InspectorDOMStorageResource.cpp: + (WebCore::InspectorDOMStorageResource::handleEvent): + * storage/StorageEvent.cpp: + (WebCore::StorageEvent::create): + (WebCore::StorageEvent::StorageEvent): + (WebCore::StorageEvent::initStorageEvent): + * storage/StorageEvent.h: + (WebCore::StorageEvent::uri): + * storage/StorageEvent.idl: + * storage/StorageEventDispatcher.cpp: + (WebCore::StorageEventDispatcher::dispatch): + +2009-10-19 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Remove ResourceLoadNotifier::activeDocumentLoader + https://bugs.webkit.org/show_bug.cgi?id=30533 + + Removing this method from ResourceLoadNotifier better decouples the + notifier from FrameLoader. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): + (WebCore::FrameLoader::requestFromDelegate): + * loader/ResourceLoadNotifier.cpp: + (WebCore::ResourceLoadNotifier::didReceiveResponse): + * loader/ResourceLoadNotifier.h: + * loader/ResourceLoader.cpp: + (WebCore::ResourceLoader::willSendRequest): + +2009-10-19 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Move sendRemainingDelegateMessages to ResourceLoadNotifier + https://bugs.webkit.org/show_bug.cgi?id=30531 + + This method is about notifying folks and doesn't interact with the rest + of FrameLoader. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::willLoadMediaElementURL): + (WebCore::FrameLoader::commitProvisionalLoad): + (WebCore::FrameLoader::loadResourceSynchronously): + (WebCore::FrameLoader::loadedResourceFromMemoryCache): + * loader/FrameLoader.h: + * loader/ResourceLoadNotifier.cpp: + (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages): + * loader/ResourceLoadNotifier.h: + +2009-10-19 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Bypass popup blocker using click event + https://bugs.webkit.org/show_bug.cgi?id=21501 + + Keep track of which events were generated by JavaScript and use that + inforation when figuring out if we're processing a user gesture. + + Test: http/tests/security/popup-blocked-from-fake-event.html + + * bindings/js/ScriptController.cpp: + (WebCore::ScriptController::processingUserGestureEvent): + * bindings/v8/ScriptController.cpp: + (WebCore::ScriptController::processingUserGesture): + * dom/Document.cpp: + (WebCore::Document::createEvent): + * dom/Event.cpp: + (WebCore::Event::Event): + * dom/Event.h: + (WebCore::Event::createdByDOM): + (WebCore::Event::setCreatedByDOM): + +2009-10-19 Dumitru Daniliuc <dumi@chromium.org> + + Reviewed by Darin Adler. + + Fixing a typo. + + https://bugs.webkit.org/show_bug.cgi?id=30543 + + * platform/sql/SQLiteDatabase.h: + +2009-10-19 Dmitry Titov <dimich@chromium.org> + + Reviewed by Darin Adler. + + Manual Test for crash caused by JS accessing DOMWindow which is disconnected from the Frame. + https://bugs.webkit.org/show_bug.cgi?id=30544 + + * manual-tests/crash-on-accessing-domwindow-without-frame.html: Added. + +2009-10-19 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Darin Adler. + + Flash at end of opacity/transform transition sometimes + https://bugs.webkit.org/show_bug.cgi?id=30501 + + When a transition finishes, there window of time between when the animation is + removed, and the final style set on the GraphicsLayer. This caused the layer to revert + to its old appearance for one or two frames. To avoid this, we set the final + transform or opacity at the start of the transition; we know that the animation + will override the final value for as long as its running. + + No test because this is a very transient effect that can't be captured + in a test. + + * rendering/RenderLayerBacking.cpp: + (WebCore::RenderLayerBacking::createGraphicsLayer): + (WebCore::RenderLayerBacking::updateLayerOpacity): + (WebCore::RenderLayerBacking::updateLayerTransform): + (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): + (WebCore::RenderLayerBacking::startTransition): + * rendering/RenderLayerBacking.h: + +2009-10-19 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Add more stop characters into console completions. + + https://bugs.webkit.org/show_bug.cgi?id=30477 + + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView.prototype.completions): + (WebInspector.ConsoleView.prototype._reportCompletions): + +2009-10-19 Marshall Culpepper <mculpepper@appcelerator.com> + + Reviewed by Adam Roben. + + implemented ClipboardWin::files() + https://bugs.webkit.org/show_bug.cgi?id=29666 + + * platform/win/ClipboardWin.cpp: + (WebCore::ClipboardWin::files): + +2009-10-19 Nate Chapin <japhet@chromium.org> + + Reviewed by Alexey Proskuryakov. + + Add support for link relations in HTMLAnchorElement and implement rel="noreferrer". + + https://bugs.webkit.org/show_bug.cgi?id=28986 + + Tests: http/tests/navigation/no-referrer-reset.html + http/tests/navigation/no-referrer-same-window.html + http/tests/navigation/no-referrer-subframe.html + http/tests/navigation/no-referrer-target-blank.html + + * WebCore.base.exp: Update FrameLoader::loadFrameRequest export symbol + * html/HTMLAnchorElement.cpp: Add support for link relations and implement noreferrer + (WebCore::HTMLAnchorElement::HTMLAnchorElement): + (WebCore::HTMLAnchorElement::defaultEventHandler): + (WebCore::HTMLAnchorElement::parseMappedAttribute): + (WebCore::HTMLAnchorElement::hasRel): + (WebCore::HTMLAnchorElement::setRel): + * html/HTMLAnchorElement.h: Add support for link relations and implement noreferrer + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::FrameLoader): + (WebCore::FrameLoader::createWindow): + (WebCore::FrameLoader::changeLocation): + (WebCore::FrameLoader::urlSelected): Add parameter for referrer policy + (WebCore::FrameLoader::loadFrameRequest): Add parameter for referrer policy + (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Suppress opener if requested by ReferrerPolicy + * loader/FrameLoader.h: Update urlSelected and loadFrameRequest prototypes + * loader/FrameLoaderTypes.h: Add enum for referrer policy + * loader/RedirectScheduler.cpp: + (WebCore::RedirectScheduler::timerFired): + * page/ContextMenuController.cpp: + (WebCore::ContextMenuController::contextMenuItemSelected): Update call to urlSelected() + * svg/SVGAElement.cpp: + (WebCore::SVGAElement::defaultEventHandler): Update call to urlSelected() + + +2009-10-19 Alpha Lam <hclam@chromium.org> + + Reviewed by Dimitri Glazkov (dglazkov@chromium.org). + + [v8] typeof(HTMLMediaElement) should return undefined if media + engine is not available + https://bugs.webkit.org/show_bug.cgi?id=30343 + + Check for availability of the media engine to disable + HTMLMediaElement, HTMLAudioElement, HTMLVideoElement, MediaError + in runtime. + + Try runs and review in Chromium: + http://codereview.chromium.org/276011 + + Test: manual-tests/chromium/media-player-not-available.html + + The above test can work work in Chromium. Testing procedures: + 1. Remove all media support libraries in Chromium (e.g. ffmpeg libraries) + 2. Open Chromium with above test page + 3. Verify the test results according to the test page + + * bindings/v8/custom/V8CustomBinding.h: + Declare enabler methods. + * bindings/v8/custom/V8DOMWindowCustom.cpp: + Report enabled only if media player is available. + * manual-tests/chromium/media-player-not-available.html: Added. + Manual test, following instruction in this test for procedures. + * page/DOMWindow.idl: + Mark HTMLMediaElement, HTMLAudioElement, HTMLVideElement, MediaError + as enabled at runtime. + +2009-10-19 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by David Hyatt. + + Refactor out some of the code in paint() into paintPanScrollIcon() + and paintScrollbars() in preparation of some Qt API changes. + + * platform/ScrollView.cpp: + (WebCore::ScrollView::paint): + * platform/ScrollView.h: + +2009-10-19 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Adam Roben. + + Make the local static panScrollIcon into a Image* instead + of a RefPtr<Image>. + + * platform/ScrollView.cpp: + (WebCore::ScrollView::wheelEvent): + +2009-10-19 Andrew Scherkus <scherkus@chromium.org> + + Reviewed by David Levin. + + Forcefully set antialiasing for Chromium media controls. + + https://bugs.webkit.org/show_bug.cgi?id=30521 + + Before it was nondeterministiacally being enabled based on the previous state of GraphicsContext. + + Covered by existing layout tests. + + * rendering/RenderMediaControlsChromium.cpp: + (WebCore::paintMediaSlider): Added setShouldAntialias(true). + +2009-10-19 Jens Alfke <jens@mooseyard.com> + + Reviewed by Darin Adler. + + Optimize string upper/lowercasing + https://bugs.webkit.org/show_bug.cgi?id=30261 + + - Added AtomicString::upper() and lower() + - Further optimized StringImpl::lower() + - Removed StringImpl::isLower() + - Added QualifiedName::localNameUpper(), which is cached, thereby saving + thousands of upper() calls and string allocations. + + * dom/Element.cpp: + (WebCore::Element::setAttribute): Call AtomicString::lower() + * dom/QualifiedName.cpp: + (WebCore::QualifiedName::localNameUpper): New method + * dom/QualifiedName.h: Added localNameUpper() method + * dom/StyledElement.cpp: + (WebCore::StyledElement::parseMappedAttribute): Call AtomicString::lower() + * html/HTMLDocument.cpp: + (WebCore::HTMLDocument::createElement): Call AtomicString::lower() + * html/HTMLElement.cpp: + (WebCore::HTMLElement::nodeName): Call localNameUpper() + * platform/text/AtomicString.cpp: + (WebCore::AtomicString::lower): New method + (WebCore::AtomicString::upper): New method + * platform/text/AtomicString.h: Added lower() and upper() + * platform/text/StringImpl.cpp: Removed isLower() + (WebCore::StringImpl::lower): Further optimization of initial loop + * platform/text/StringImpl.h: Removed isLower() + +2009-10-19 Nate Chapin <japhet@chromium.org> + + Reviewed by Adam Barth. + + If a call to a plugin's invokeMethod, invokeDefault or construct + returns false, throw an exception into JS. + + https://bugs.webkit.org/show_bug.cgi?id=30239 + + Test: plugins/netscape-invoke-failure.html + + * bindings/v8/V8NPObject.cpp: Check return values of invokeMethod, invokeDefault and construct. + (npObjectInvokeImpl): + * bridge/c/c_instance.cpp: + (JSC::Bindings::CInstance::invokeMethod): Check return value + (JSC::Bindings::CInstance::invokeDefaultMethod): Check return value + (JSC::Bindings::CInstance::invokeConstruct): Check return value + +2009-10-16 Stephen White <senorblanco@chromium.org> + + Reviewed by Adam Barth. + + Fix for chromium/skia canvas arc start/end positions, when the arc is + >= 360 degrees. + https://bugs.webkit.org/show_bug.cgi?id=30449 + + Covered by new test: + LayoutTests/fast/canvas/arc360.html + + * platform/graphics/skia/PathSkia.cpp: + (WebCore::Path::addArc): + +2009-10-19 Kent Tamura <tkent@chromium.org> + + Reviewed by Alexey Proskuryakov. + + Fix uninitialized variable reference in Element::removeAttribute(). + https://bugs.webkit.org/show_bug.cgi?id=30502 + + * dom/Element.cpp: + (WebCore::Element::removeAttribute): + +2009-10-19 Eric Carlson <eric.carlson@apple.com> + + Reviewed by Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=30463 + Remove HTML5 media element 'loadend' event + + * dom/EventNames.h: + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::parseMappedAttribute): Remove 'loadend'. + (WebCore::HTMLMediaElement::loadInternal): Ditto. + (WebCore::HTMLMediaElement::noneSupported): Ditto. + (WebCore::HTMLMediaElement::mediaEngineError): Ditto. + (WebCore::HTMLMediaElement::setNetworkState): Ditto. + (WebCore::HTMLMediaElement::userCancelledLoad): Ditto. + +2009-10-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Adam Barth. + + [Qt] Remove deletion of outgoing FormData object when reply is finished. + The buffers will be destroyed a bit later, when the QNetworkReply is deleted. + Bug: https://bugs.webkit.org/show_bug.cgi?id=29551 + + * platform/network/qt/QNetworkReplyHandler.cpp: + * platform/network/qt/QNetworkReplyHandler.h: + +2009-10-19 Dimitri Glazkov <dglazkov@chromium.org> + + Reviewed by Darin Adler. + + Fix hard-to-reproduce crash in HTMLTokenizer by avoiding a rare + fastRealloc edge case. + https://bugs.webkit.org/show_bug.cgi?id=29313 + + No test, the crash shows up occasionally in crash dumps, we weren't able + to reproduce it locally. + + * html/HTMLTokenizer.cpp: + (WebCore::HTMLTokenizer::enlargeScriptBuffer): Added an early exit to + avoid calling fastRealloc with the size of 0. + +2009-10-19 Andrew Scherkus <scherkus@chromium.org> + + Reviewed by Eric Seidel. + + Use fillRect() instead of drawRect() to fix Chromium media controls rendering. + + https://bugs.webkit.org/show_bug.cgi?id=30371 + + Chromium Mac layout tests will need to be rebaselined. Existing layout tests for Linux/Win still pass. + + * rendering/RenderMediaControlsChromium.cpp: + (WebCore::paintMediaSlider): Use fillRect() instead of drawRect(). + +2009-10-19 Dmitry Titov <dimich@chromium.org> + + Reviewed by Adam Barth. + + Crash in DOMWindow::clearTimeout etc when DOMWindow is not connected to a frame. + https://bugs.webkit.org/show_bug.cgi?id=29832 + + Need to make sure the script caches are reset when frame gets disconnected from still-alive DOMWindow. + This will prevent JS from calling DOMWindow methods that can not be completed w/o the frame. + + I am not sure it's possible to test this since the only file that repros the problem need ~10 seconds to cause crash. + + * page/Frame.cpp: + (WebCore::Frame::~Frame): Right after frame disconnects from DOMWindow, clear WindowShell. + +2009-10-19 Csaba Osztrogonác <ossy@webkit.org> + + Unreviewed build warning fix. + [Qt] Apply changes to WebCore.pro introduced in r49778 + + * WebCore.pro: Removed svg/graphics/filters/SVGFEGaussianBlur.h from HEADERS + +2009-10-19 Dirk Schulze <krit@webkit.org> + + Reviewed by Darin Adler. + + Move feGaussianBlur from WebCore/svg to WebCore/platform + [https://bugs.webkit.org/show_bug.cgi?id=30495] + + This patch moves SVGFRGaussianBlur from svg/graphics/filters + to platform/graphics/filters/FEGaussianBlur. This is needed + for shadow support on Qt and Cairo. + No change in functionality, therfore no new test case needed. + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * platform/graphics/filters/FEGaussianBlur.cpp: Added. + * platform/graphics/filters/FEGaussianBlur.h: Added. + * svg/SVGFEGaussianBlurElement.h: + * svg/graphics/filters/SVGFEGaussianBlur.cpp: Removed. + * svg/graphics/filters/SVGFEGaussianBlur.h: Removed. + +2009-10-19 Yael Aharon <yael.aharon@nokia.com> + + Unreviewed. + + Added reviewer name to r49574. + +2009-10-19 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Xan Lopez. + + https://bugs.webkit.org/show_bug.cgi?id=30489 + [Gtk] The document frame/html container claims to be parentless + + Work around for the parentless claim made by the accessible associated + with the embedded WebView. When we identify this condition, get the + widget's parent, and then get the AtkObject from that. Admittedly an ugly + hack, but we'll need it for Yelp and other Gtk+/GNOME applications which + plan to switch over to WebKit. + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (webkit_accessible_get_parent): + +2009-10-19 Benjamin Otte <otte@gnome.org> + + Reviewed by Jan Alonzo. + + Handle duration queries properly + https://bugs.webkit.org/show_bug.cgi?id=29999 + + Previously duration queries failed to handle unknown duration + and didn't treat the returned duration as an unsigned. + + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::MediaPlayerPrivate::duration): + +2009-10-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Tor Arne Vestbø. + + [Qt] Fix build on Windows. + + * plugins/win/PluginViewWin.cpp: + (windowHandleForPageClient): + +2009-10-19 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Holger Freyther. + + [Qt] Windowed Plugins: Don't crash when client is 0. + + Client is 0 when we use QWebPage without a QWebView or QGraphicsWebView. + In addition, setFrameRect()/updatePluginWidget() is called even if the + plugin was not succesfully loaded. updatePluginWidget() updates the + window rect which is, in theory, useful to draw something that indicates + that we didn't load successfully. + + So, a status check is added to setNPWindowIfNeeded. + + https://bugs.webkit.org/show_bug.cgi?id=30380 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::setNPWindowIfNeeded): + (WebCore::PluginView::platformStart): + +2009-10-19 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Holger Freyther. + + [Qt] Windowed Plugins: Fix crash when QWebPage is deleted after QWebView. + + Fixes various sources of crashes: + 1. The PluginContainer is a child of QWebView. When the view gets deleted, + the PluginView is not notified about the deletion of PluginContainer. + 2. QWebView destructor does not set client to 0. + 3. Sometimes pending paint events are sent after the plugin has died, so add + a check in PluginView::setNPWindowIfNeeded. + + https://bugs.webkit.org/show_bug.cgi?id=30354 + + * plugins/qt/PluginContainerQt.cpp: + (PluginContainerQt::~PluginContainerQt): + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::setNPWindowIfNeeded): + +2009-10-19 Jakob Truelsen <antialize@gmail.com> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=29042 + Allow one to customize the minimal and maximal shrink factors used when printing. + + * page/PrintContext.cpp: + (WebCore::PrintContext::begin): + * page/Settings.cpp: + (WebCore::Settings::Settings): + (WebCore::Settings::setPrintingMinimumShrinkFactor): + (WebCore::Settings::setPrintingMaximumShrinkFactor): + * page/Settings.h: + (WebCore::Settings::printingMinimumShrinkFactor): + (WebCore::Settings::printingMaximumShrinkFactor): + +2009-10-18 Erik Arvidsson <arv@chromium.org> + + Reviewed by Adam Barth. + + Fixes issue where doubleclicking a word could select following adjacent newlines. + https://bugs.webkit.org/show_bug.cgi?id=30234 + + Tests: platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html + platform/mac/editing/selection/script-tests/TEMPLATE.html + platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html + platform/win/editing/selection/script-tests/TEMPLATE.html + + * editing/VisibleSelection.cpp: + (WebCore::VisibleSelection::appendTrailingWhitespace): + +2009-10-18 Kevin Ollivier <kevino@theolliviers.com> + + CURL build fix, use proper header name. + + * platform/network/curl/ResourceHandleManager.h: + +2009-10-18 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Properties on Arrays and NodeLists are not logged correctly. + + https://bugs.webkit.org/show_bug.cgi?id=30485 + + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView.prototype._formatarray): + (WebInspector.ConsoleView.prototype._printArray): + +2009-10-18 Pavel Feldman <pfeldman@chromium.org> + + Not reviewed: touching WebCore so that it + initiated inspector frontend deployment on Windows. + + Web Inspector: frontend files are not deployed in Windows + incremental build. + + * inspector/InspectorDOMAgent.cpp: + (WebCore::InspectorDOMAgent::unbind): + +2009-10-18 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Title of dir(["test", "test2"]) should be Array + + https://bugs.webkit.org/show_bug.cgi?id=30486 + + Test: inspector/console-tests.html + + * inspector/front-end/InjectedScript.js: + +2009-10-18 Dirk Schulze <krit@webkit.org> + + Reviewed by Nikolas Zimmermann. + + REGRESSION: SVG Mask doesn't work for maskContentUnits="objectBoundingBox" + [https://bugs.webkit.org/show_bug.cgi?id=30480] + + Patch for SVGMaskElement landed in r49598 should correct the location of + the mask image graphics context. It only corrects the location for userSpaceOnUse + mode in maskContentUnits but breaks objectBoundingBoxMode. + The maskDestRect shouldn't be moved. It is not responsible for the correct context + postioin but for the correct position of the mask image. + This patch calculates the context postion independently from the maskDestRect. + It also uses lineareRGB color space for masking on CG now. This is the default + color space for masking operations. + We already have tests for both maskContentUnits modes. + + *svg/W3C-SVG-1.1/masking-intro-01-f.svg + *svg/custom/mask-with-default-value.svg + + Some tests needed new pixel tests because of the new color space. + + * svg/SVGMaskElement.cpp: + (WebCore::SVGMaskElement::drawMaskerContent): + +2009-10-18 Anton Muhin <antonm@chromium.org> + + Reviewed by Adam Barth. + + Use v8::Integer::NewFromUnsigned when converting unsigneds into V8's numbers. + That is notably faster for small numbers (most common case). + https://bugs.webkit.org/show_bug.cgi?id=30493 + + * bindings/scripts/CodeGeneratorV8.pm: + +2009-10-18 Jan Michael Alonzo <jmalonzo@webkit.org> + + Reviewed by Holger Freyther. + + [GTK] Add MathML to the build system + https://bugs.webkit.org/show_bug.cgi?id=30487 + + Add MathML sources if MathML support is enabled. + + * GNUmakefile.am: + +2009-10-18 Kevin Ollivier <kevino@theolliviers.com> + + Non-PCH build fix. Added missing header. + + * bridge/runtime_root.h: + +2009-10-18 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dan Bernstein. + + Compositing layers not correctly updated after partial layout + https://bugs.webkit.org/show_bug.cgi?id=30425 + + When a partial layout happened, for example as the result of a postion-change-only + layout, then some compositing layer positions were not correctly updated. To fix + this, updateLayerPositions() now carries along a flag that is set at the rootmost + layer being updated, and used to determine when we hit the first compositing layer + in this update. RenderLayerBacking::updateAfterLayout() makes use of this information + to do a full geometry update on that layer, which is thus the rootmost compositing + layer that is being updated. + + Test: compositing/geometry/partial-layout-update.html + + * page/FrameView.cpp: + (WebCore::FrameView::layout): + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::updateLayerPositions): + (WebCore::RenderLayer::scrollToOffset): + * rendering/RenderLayer.h: + (WebCore::RenderLayer::): + * rendering/RenderLayerBacking.cpp: + (WebCore::RenderLayerBacking::updateAfterLayout): + * rendering/RenderLayerBacking.h: + +2009-09-13 Kevin Watters <kevinwatters@gmail.com> + + Reviewed by Kevin Ollivier. + + Add support for proxies in CURL. + + https://bugs.webkit.org/show_bug.cgi?id=30446 + + * platform/network/curl/ResourceHandleManager.cpp: + (WebCore::ResourceHandleManager::setProxyInfo): + (WebCore::ResourceHandleManager::initializeHandle): + * platform/network/curl/ResourceHandleManager.h: + (WebCore::ResourceHandleManager::): + +2009-10-18 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Xan Lopez + + https://bugs.webkit.org/show_bug.cgi?id=25901 + Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag + + Replaces the use of ATK_ROLE_PANEL with the expected accessible roles. + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (webkit_accessible_get_role): + +2009-10-17 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by George Staikos. + + Cleanup SVGElement code, preparing for animVal support + https://bugs.webkit.org/show_bug.cgi?id=30466 + + Add new SynchronizablePropertyController and move the code for SVG property <-> XML attribute synchronization + from SVGElement. This is a further preparation for animVal support, where SynchronizablePropertyController will + be used to control the start/end state of an animated property. + + We're currently tracking animated properties that need synchronization, generalize this concept and use + it to track their creation (bound to certain SVG*Element classes) as well as a flag determing the need + of synchronization (no SVG DOM object wrappers, no synchronization needed). + + No change in functionality, thus no tests. + + * GNUmakefile.am: Add 'SynchronizablePropertyController.cpp/h' to build + * WebCore.gypi: Ditto. + * WebCore.pro: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * svg/SVGAllInOne.cpp: Ditto. + * svg/SVGAnimatedProperty.h: Add registerProperty() function + (WebCore::::SVGAnimatedProperty): Call registerProperty() function + (WebCore::::registerProperty): Add new registerProperty() function, announcing new properties to SynchronizablePropertyController. + * svg/SVGAnimatedTemplate.h: Use propertyController() method, to access the new functions moved from SVGElement. + (WebCore::lookupOrCreateWrapper): + * svg/SVGElement.cpp: Adapt to code moving to SynchronizablePropertyController. + (WebCore::SVGElement::updateAnimatedSVGAttribute): + * svg/SVGElement.h: Move handling SVG property synchronization to SynchronizablePropertyController. + (WebCore::SVGElement::propertyController): Expose reference to SynchronizablePropertyController object. + * svg/SVGViewSpec.cpp: Reorder initialization order of contextElement, leading to possible crashes. + (WebCore::SVGViewSpec::SVGViewSpec): + (WebCore::SVGViewSpec::viewTarget): + * svg/SVGViewSpec.h: Ditto. + (WebCore::SVGViewSpec::contextElement): + * svg/SynchronizablePropertyController.cpp: Added. + (WebCore::SynchronizablePropertyController::SynchronizablePropertyController): + (WebCore::SynchronizablePropertyController::registerProperty): + (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): + (WebCore::SynchronizablePropertyController::synchronizeProperty): + (WebCore::SynchronizablePropertyController::synchronizeAllProperties): + (WebCore::SynchronizablePropertyController::startAnimation): + (WebCore::SynchronizablePropertyController::stopAnimation): + * svg/SynchronizablePropertyController.h: Added. + (WebCore::SynchronizableProperty::SynchronizableProperty): + (WebCore::SynchronizableProperty::isHashTableDeletedValue): + (WebCore::SynchronizableProperty::operator==): + (WebCore::SynchronizablePropertyHash::hash): + (WebCore::SynchronizablePropertyHash::equal): + (WebCore::SynchronizablePropertyHashTraits::constructDeletedValue): + (WebCore::SynchronizablePropertyHashTraits::isDeletedValue): + +2009-10-17 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Xan Lopez. + + https://bugs.webkit.org/show_bug.cgi?id=25413 + [GTK] Please expose the level of headings + + Exposes the heading level as an attribute of the AtkObject. + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (addAttributeToSet): + (webkit_accessible_get_attributes): + (webkit_accessible_class_init): + +2009-10-17 Kwang Yul Seo <skyul@company100.net> + + Reviewed by Eric Seidel. + + EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards + https://bugs.webkit.org/show_bug.cgi?id=30472 + + Put ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged + in EventHandler.cpp. MSVC fails to compile when DRAG_SUPPORT not enabled. + + * page/EventHandler.cpp: + +2009-10-17 Alpha Lam <hclam@chromium.org> + + Reviewed by Eric Seidel. + + [chromium] Video controls not zoomed / transformed correctly + https://bugs.webkit.org/show_bug.cgi?id=30461 + + Draw the images in the controls scaled. + + No new tests. With this change Chromium will pass the following tests: + LayoutTests/media/video-controls-zoomed.html + LayoutTests/media/video-controls-transformed.html + + * rendering/RenderMediaControlsChromium.cpp: + (WebCore::paintMediaButton): + Pass along the target rect directly. + (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize): + Adjust the thumb slide applied with the scale factor. + +2009-10-17 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Unreviewed. + + [Gtk] Build fix for WebKitGtk after r49723. + + Add bindings/js/JSExceptionBase.* to the build. + + * GNUmakefile.am: + +2009-10-17 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Unreviewed. + + [Qt] Build fix for QtWebKit after r49723. + + Add bindings/js/JSExceptionBase.cpp to the build. + + * WebCore.pro: + +2009-10-16 Steve Falkenburg <sfalken@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=30456 + Fixes for new Debug_All Windows build configuration. + + * platform/network/cf/ResourceRequestCFNet.cpp: + (WebCore::findCFNetworkModule): Ask for the correct library instead of guessing. + * platform/win/ScrollbarThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming. + * rendering/RenderMediaControls.cpp: Use new DEBUG_ALL preprocessor define for library naming. + * rendering/RenderThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming. + +2009-10-16 Jon Honeycutt <jhoneycutt@apple.com> + + Add SPI to determine whether a plug-in has ever been halted. + + Part of <rdar://problem/7312158>. + + Reviewed by Dan Bernstein. + + * plugins/PluginView.cpp: + (WebCore::PluginView::PluginView): + Initialize m_hasBeenHalted. + + * plugins/PluginView.h: + (WebCore::PluginView::hasBeenHalted): + Return m_hasBeenHalted. + + * plugins/win/PluginViewWin.cpp: + (WebCore::PluginView::halt): + Set m_hasBeenHalted. + +2009-10-16 Adam Barth <abarth@webkit.org> + + Reviewed by Alexey Proskuryakov. + + @charset rule after the first byte causes the rest of css to be ignored + https://bugs.webkit.org/show_bug.cgi?id=18265 + + Apparently we're supposed to tolerate whitespace before the charset + rule so folks can write code like this: + + <style> + @charset "utf-8" + ... + </style> + + I'm told this is one of the top compatability problems in China. + Tests: fast/css/comment-before-charset-external.html + fast/css/comment-before-charset.html + fast/css/many-spaces-before-charset.html + fast/css/space-before-charset-external.html + fast/css/space-before-charset.html + + * css/CSSGrammar.y: + +2009-10-16 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Darin Adler. + + Fixes part of <http://webkit.org/b/30412>. + Web Inspector should get human readable DOM Exceptions. + + Add a description field to ExceptionBase, and call it through + reportException which allows the user/developer to get a more detailed + and coherent error explanation through the Web Inspector. + + This only applies to exceptions that come from a script on the page when + it is run. DOM Exceptions that come from the code run in the console, or DOM + exceptions that are caught and logged will come in a future patch. + + Tests: inspector/uncaught-dom1-exception.html + inspector/uncaught-dom3-exception.html + inspector/uncaught-dom8-exception.html + + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * bindings/js/JSDOMBinding.cpp: + (WebCore::reportException): + * bindings/js/JSExceptionBase.cpp: Added. + (WebCore::toExceptionBase): + * bindings/js/JSExceptionBase.h: Added. + * dom/ExceptionBase.cpp: + (WebCore::ExceptionBase::ExceptionBase): + * dom/ExceptionBase.h: + (WebCore::ExceptionBase::description): + * dom/ExceptionCode.cpp: + (WebCore::): + (WebCore::getExceptionCodeDescription): + * dom/ExceptionCode.h: + +2009-10-16 Geoffrey Garen <ggaren@apple.com> + + Build fix: forgot to check in this #include. + + * bridge/runtime_root.h: + +2009-10-16 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dan Bernstein. + + Transform layer gets stuck with the wrong transform after an animation ends + <rdar://problem/7311662> + + Work around a CoreAnimation bug which causes an animated transform layer to + end up with a stale transform. + + Test: compositing/animation/state-at-end-event-transform-layer.html + + * platform/graphics/mac/GraphicsLayerCA.mm: + (WebCore::bug7311367Workaround): + (WebCore::GraphicsLayerCA::removeAnimationFromLayer): + +2009-10-16 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dan Bernstein. + + After running a transition with an end event listener, can't change the transform + https://bugs.webkit.org/show_bug.cgi?id=30454 + + Fix an issue where, if a document had any listener for webkitTransitionEnd or webkitAnimationEnd, + the animations would not get cleaned up correctly, which broke subsequent changes of transform. + + Now, we always clean up the animations right after queuing up the end events. + + Tests: animations/state-at-end-event.html + transitions/move-after-transition.html + + * page/animation/ImplicitAnimation.cpp: + (WebCore::ImplicitAnimation::onAnimationEnd): + * page/animation/KeyframeAnimation.cpp: + (WebCore::KeyframeAnimation::onAnimationEnd): + +2009-10-15 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Handle the Enter Key in the Elements Tree Hierarchy + https://bugs.webkit.org/show_bug.cgi?id=30428 + + TextNode => Edit Text Node + Has Attributes => Edit First Attribute + No Attributes => Start Editing New Attribute + + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): handle the "Enter" key + (WebInspector.ElementsTreeElement.prototype.set hovered): only add new attribute button on nodes with attributes + (WebInspector.ElementsTreeElement.prototype._addNewAttribute): prevent moving backwards where there are no attributes + (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): renamed to be clearer + (WebInspector.ElementsTreeElement.prototype._startEditing): transition to the appropriate edit state for a tree element + +2009-10-16 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Fix header indent style for FrameLoader and friends + https://bugs.webkit.org/show_bug.cgi?id=30430 + + * loader/FrameLoader.h: + (WebCore::FrameLoader::frame): + (WebCore::FrameLoader::policyChecker): + (WebCore::FrameLoader::history): + (WebCore::FrameLoader::notifier): + (WebCore::FrameLoader::isLoadingMainResource): + (WebCore::FrameLoader::documentLoader): + (WebCore::FrameLoader::policyDocumentLoader): + (WebCore::FrameLoader::provisionalDocumentLoader): + (WebCore::FrameLoader::state): + (WebCore::FrameLoader::client): + (WebCore::FrameLoader::url): + (WebCore::FrameLoader::isLoadingFromCachedPage): + (WebCore::FrameLoader::committingFirstRealLoad): + (WebCore::FrameLoader::committedFirstRealDocumentLoad): + (WebCore::FrameLoader::creatingInitialEmptyDocument): + * loader/HistoryController.h: + (WebCore::HistoryController::currentItem): + (WebCore::HistoryController::provisionalItem): + * loader/PolicyCallback.h: + (WebCore::PolicyCallback::request): + * loader/PolicyChecker.h: + (WebCore::PolicyChecker::loadType): + (WebCore::PolicyChecker::setLoadType): + (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy): + (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy): + * loader/RedirectScheduler.h: + * loader/ResourceLoadNotifier.h: + +2009-10-16 Steve Falkenburg <sfalken@apple.com> + + Reviewed by Adam Roben. + + Add a Debug_All configuration to build entire stack as debug. + Change Debug_Internal to: + - stop using _debug suffix for all WebKit/Safari binaries + - not use _debug as a DLL naming suffix + - use non-debug C runtime lib. + + * WebCore.vcproj/QTMovieWin.vcproj: Add Debug_All configuration. + * WebCore.vcproj/WebCore.make: Debug build in makefile should build Debug_All. + * WebCore.vcproj/WebCore.sln: Add Debug_All configuration. + * WebCore.vcproj/WebCore.submit.sln: Add Debug_All configuration. + * WebCore.vcproj/WebCore.vcproj: Add Debug_All configuration. + * WebCore.vcproj/WebCoreGenerated.vcproj: Renamed single configuration from "Release" to "all". + +2009-10-16 Dimitri Glazkov <dglazkov@chromium.org> + + No review, rolling out r49693, because it broke Chromium build. + http://trac.webkit.org/changeset/49693 + + * WebCore.gyp/WebCore.gyp: + * WebCore.gypi: + +2009-10-16 Andrew Scherkus <scherkus@chromium.org> + + Reviewed by Eric Carlson. + + Updated media resource selection algorithm to reflect latest HTML 5 specification. + + Noticable changes: + - Elements with no source should have their network state set to NETWORK_EMPTY as opposed to NETWORK_NO_SOURCE + - Empty string ("") is now considered a valid URL resolving to the current page and will be loaded + + Tests: media/video-src-empty.html + media/video-src-none.html + + https://bugs.webkit.org/show_bug.cgi?id=30407 + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::selectMediaResource): Updated code and comments to match spec. + +2009-10-16 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Insecure plug-ins don't trigger mixed content + https://bugs.webkit.org/show_bug.cgi?id=30431 + + Added the missing check. + + Test: http/tests/security/mixedContent/insecure-plugin-in-iframe.html + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::loadPlugin): + +2009-10-16 Andrew Scherkus <scherkus@chromium.org> + + Reviewed by Eric Carlson. + + Set autobuffer to true and schedule load in V8 audio element constructor. + + https://bugs.webkit.org/show_bug.cgi?id=30448 + + Covered by existing tests. + + * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: + (WebCore::CALLBACK_FUNC_DECL): Set autobuffer to true and schedule load. + +2009-10-16 Andrew Scherkus <scherkus@chromium.org> + + Reviewed by Eric Seidel. + + Remove FIXME in RenderMediaControlsChromium as bug was fixed upstream. + + https://bugs.webkit.org/show_bug.cgi?id=30422 + + Covered by existing media layout tests. + + * rendering/RenderMediaControlsChromium.cpp: + (WebCore::paintMediaSlider): Removed round() and FIXME. + +2009-10-16 Andrew Scherkus <scherkus@chromium.org> + + Reviewed by Eric Seidel. + + Fix Chromium media controls to render a disabled play button when the element is unintialized. + + https://bugs.webkit.org/show_bug.cgi?id=30410 + + Covered by existing layout tests. + + * rendering/RenderMediaControlsChromium.cpp: + (WebCore::paintMediaPlayButton): Include check for NETWORK_EMPTY to render disabled play button. + +2009-10-16 Oliver Hunt <oliver@apple.com> + + Reviewed by Gavin Barraclough. + + Make typeinfo flags default to false + https://bugs.webkit.org/show_bug.cgi?id=30372 + + Last part -- replace HasDefaultGetPropertyNames with OverridesGetPropertyNames + flag. + + * bindings/js/JSDOMWindowShell.h: + (WebCore::JSDOMWindowShell::createStructure): + * bindings/js/JSHTMLAllCollection.h: + (WebCore::JSHTMLAllCollection::createStructure): + * bindings/js/JSQuarantinedObjectWrapper.h: + (WebCore::JSQuarantinedObjectWrapper::createStructure): + * bindings/scripts/CodeGeneratorJS.pm: + * bridge/runtime_array.h: + (JSC::RuntimeArray::createStructure): + * bridge/runtime_object.h: + (JSC::RuntimeObjectImp::createStructure): + +2009-10-16 Steven Knight <sgk@chromium.org> + + Reviewed by David Levin. + + https://bugs.webkit.org/show_bug.cgi?id=30447 + Handle long link lines by building .idl-generated bindings in a + separate webcore_bindings library target. Avoid Visual Studio + dependency issues by building additional generated .cpp and .h files + in a separate webcore_bindings_sources target. + + Chrome should still build and test successfully. + + * WebCore.gyp/WebCore.gyp: + * WebCore.gypi: + +2009-10-16 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Eric Carlson. + + Transform transitions that used to be accelerated are no longer so + https://bugs.webkit.org/show_bug.cgi?id=30453 + + The change in r49633, to not run accelerated animations/transitions on layers that + are not attached, broke accelerated transitions/animations in many cases where they start + as soon as the page loads. This change reverts the code that tests for the GraphicsLayer being + attached. + + No test, because it's not possible from a test to know whether a transition is accelerated or not. + + * rendering/RenderLayerBacking.cpp: + (WebCore::RenderLayerBacking::startAnimation): + (WebCore::RenderLayerBacking::startTransition): + +2009-10-16 Kevin Ollivier <kevino@theolliviers.com> + + wxMSW build fix, build the MSW source to get methods that use the MSW version of + PlatformModuleVersion. + + * wscript: + +2009-10-16 Adam Barth <abarth@webkit.org> + + Unreviewed build fix. Add back MIMETypeRegistryChromium with the right + casing. + + * platform/chromium/MIMETypeRegistryChromium.cpp: Added. + (WebCore::MIMETypeRegistry::getMIMETypeForExtension): + (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): + (WebCore::MIMETypeRegistry::getMIMETypeForPath): + (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): + (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): + (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): + (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): + (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): + (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): + (WebCore::MIMETypeRegistry::isJavaAppletMIMEType): + (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): + (WebCore::dummyHashSet): + (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): + (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): + (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): + (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): + (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes): + +2009-10-16 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + MimeTypeRegistryChromium is mis-casen + https://bugs.webkit.org/show_bug.cgi?id=30441 + + Change the case of MimeTypeRegistryChromium to match other platforms. + + * WebCore.gypi: + * platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp. + * platform/chromium/MimeTypeRegistryChromium.cpp: Removed. + +2009-10-16 Dimitri Glazkov <dglazkov@chromium.org> + + Reviewed by Eric Seidel. + + Change EmptyPluginHalterClient in SVGImage to be non-static, to + match changes made http://trac.webkit.org/changeset/49385. + https://bugs.webkit.org/show_bug.cgi?id=30403 + + Run the following layout test sequence: + LayoutTests/svg/W3C-SVG-1.1/struct-image-01-t.svg + LayoutTests/svg/W3C-SVG-1.1/struct-image-03-t.svg + LayoutTests/svg/W3C-SVG-1.1/struct-image-04-t.svg + LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b.svg + LayoutTests/svg/W3C-SVG-1.1/struct-image-06-t.svg + LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg + LayoutTests/svg/W3C-SVG-1.1/struct-image-08-t.svg + LayoutTests/svg/W3C-SVG-1.1/struct-image-09-t.svg + LayoutTests/svg/W3C-SVG-1.1/struct-image-10-t.svg + LayoutTests/svg/carto.net/scrollbar.svg + LayoutTests/svg/carto.net/selectionlist.svg + + selectionlist.svg should not crash. + + * svg/graphics/SVGImage.cpp: + (WebCore::SVGImage::dataChanged): Made EmptyPluginHalterClient non-static. + +2009-10-16 Victor Wang <victorw@chromium.org> + + Reviewed by David Levin. + + Add beforeload event support to V8DOMWrapper + + https://bugs.webkit.org/show_bug.cgi?id=30413 + + LayoutTests/fast/dom/beforeload/frame-before-load.html + + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::convertEventToV8Object): + +2009-10-16 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + MimeTypeRegistryChromium is mis-casen + https://bugs.webkit.org/show_bug.cgi?id=30441 + + Change the case of MimeTypeRegistryChromium to match other platforms. + + * WebCore.gypi: + * platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp. + * platform/chromium/MimeTypeRegistryChromium.cpp: Removed. + +2009-10-16 Adam Barth <abarth@webkit.org> + + Reviewed by Mark Rowe. + + Chrome doesn't set Content-Type for file upload when the file extension + is not recognized + https://bugs.webkit.org/show_bug.cgi?id=30433 + + Apparently, getMIMETypeForPath is supposed to return + application/octet-stream when it doesn't have a better MIME type. + + * platform/chromium/MimeTypeRegistryChromium.cpp: + (WebCore::MIMETypeRegistry::getMIMETypeForPath): + +2009-10-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Pull out r49676 as it caused build breakges on Symbian + + * plugins/symbian/PluginViewSymbian.cpp: + +2009-10-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Ariya Hidayat. + + Crash fix when loading NPAPI plugins on Qt/Mac + + There's no guarantee that the plist will be valid even if we + ask the plugin to create it. Crash obverved with iGetter. + + * plugins/mac/PluginPackageMac.cpp: + +2009-10-15 Stephen White <senorblanco@chromium.org> + + Reviewed by David Levin. + + Fix for Chromium/skia's implementation of canvas's isPointInPath(). + https://bugs.webkit.org/show_bug.cgi?id=30402 + + Covered by LayoutTests/fast/canvas/pointInPath.html. + + * platform/graphics/skia/SkiaUtils.cpp: + (WebCore::SkPathContainsPoint): + +2009-10-15 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Factor ResourceLoadNotifier out of FrameLoader + https://bugs.webkit.org/show_bug.cgi?id=30379 + + These methods have virtually no interaction with the rest of + FrameLoader. + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * WebCoreSources.bkl: + * dom/Document.cpp: + (WebCore::Document::resourceRetrievedByXMLHttpRequest): + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::FrameLoader): + (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): + (WebCore::ResourceLoadNotifier::ResourceLoadNotifier): + (WebCore::ResourceLoadNotifier::activeDocumentLoader): + (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): + (WebCore::ResourceLoadNotifier::willSendRequest): + (WebCore::ResourceLoadNotifier::didReceiveResponse): + (WebCore::ResourceLoadNotifier::didReceiveData): + (WebCore::ResourceLoadNotifier::didFailToLoad): + (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest): + (WebCore::FrameLoader::sendRemainingDelegateMessages): + (WebCore::FrameLoader::requestFromDelegate): + (WebCore::ResourceLoadNotifier::didFinishLoad): + (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge): + (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): + (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest): + (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): + (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): + (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): + (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): + * loader/FrameLoader.h: + (WebCore::FrameLoader::notifier): + * loader/MainResourceLoader.cpp: + (WebCore::MainResourceLoader::receivedError): + * loader/ResourceLoadNotifier.cpp: Added. + (WebCore::ResourceLoadNotifier::ResourceLoadNotifier): + (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge): + (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): + (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): + (WebCore::ResourceLoadNotifier::willSendRequest): + (WebCore::ResourceLoadNotifier::didReceiveResponse): + (WebCore::ResourceLoadNotifier::didReceiveData): + (WebCore::ResourceLoadNotifier::didFinishLoad): + (WebCore::ResourceLoadNotifier::didFailToLoad): + (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest): + (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest): + (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): + (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): + (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): + (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): + (WebCore::ResourceLoadNotifier::activeDocumentLoader): + * loader/ResourceLoadNotifier.h: Added. + * loader/ResourceLoader.cpp: + (WebCore::ResourceLoader::willSendRequest): + (WebCore::ResourceLoader::didReceiveResponse): + (WebCore::ResourceLoader::didReceiveData): + (WebCore::ResourceLoader::didFinishLoadingOnePart): + (WebCore::ResourceLoader::didFail): + (WebCore::ResourceLoader::didCancel): + (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): + (WebCore::ResourceLoader::didCancelAuthenticationChallenge): + +2009-10-15 Roland Steiner <rolandsteiner@google.com> + + Reviewed by Darin Fisher. + + Bug 30427 - Remove unneeded methods in ChromiumDataObject + (https://bugs.webkit.org/show_bug.cgi?id=30427) + + Remove no longer needed methods from ChromiumDataObject. + + No new tests (no functional change) + + * platform/chromium/ChromiumDataObject.h: + +2009-10-16 Yael Aharon <yael.aharon@nokia.com> + + Reviewed by Tor Arne Vestbø. + + [Qt] Need a way to inform the application when a Netscape plugin is created or deleted + https://bugs.webkit.org/show_bug.cgi?id=30179 + + Inform the application when a plugin is created or destroyed, but only if the + application registered for these notifications. + + * plugins/symbian/PluginViewSymbian.cpp: + (WebCore::PluginView::platformStart): + (WebCore::PluginView::platformDestroy): + +2009-10-16 Shu Chang <Chang.Shu@nokia.com> + + Reviewed by Eric Seidel. + + Default language translation should be determined by locale settings, + e.g., "en-US". + https://bugs.webkit.org/show_bug.cgi?id=29653 + + Test: fast/js/navigator-language.html + + * platform/qt/Localizations.cpp: + (WebCore::defaultLanguage): + +2009-10-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Ariya Hidayat. + + Crash fix when loading NPAPI plugins on Qt/Mac + + There's no guarantee that the plist will be valid even if we + ask the plugin to create it. Crash obverved with iGetter. + + * plugins/mac/PluginPackageMac.cpp: + +2009-10-15 Stephen White <senorblanco@chromium.org> + + Reviewed by David Levin. + + Fix for Chromium/skia's implementation of canvas's isPointInPath(). + https://bugs.webkit.org/show_bug.cgi?id=30402 + + Covered by LayoutTests/fast/canvas/pointInPath.html. + + * platform/graphics/skia/SkiaUtils.cpp: + (WebCore::SkPathContainsPoint): + +2009-10-15 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Factor ResourceLoadNotifier out of FrameLoader + https://bugs.webkit.org/show_bug.cgi?id=30379 + + These methods have virtually no interaction with the rest of + FrameLoader. + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * WebCoreSources.bkl: + * dom/Document.cpp: + (WebCore::Document::resourceRetrievedByXMLHttpRequest): + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::FrameLoader): + (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): + (WebCore::ResourceLoadNotifier::ResourceLoadNotifier): + (WebCore::ResourceLoadNotifier::activeDocumentLoader): + (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): + (WebCore::ResourceLoadNotifier::willSendRequest): + (WebCore::ResourceLoadNotifier::didReceiveResponse): + (WebCore::ResourceLoadNotifier::didReceiveData): + (WebCore::ResourceLoadNotifier::didFailToLoad): + (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest): + (WebCore::FrameLoader::sendRemainingDelegateMessages): + (WebCore::FrameLoader::requestFromDelegate): + (WebCore::ResourceLoadNotifier::didFinishLoad): + (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge): + (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): + (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest): + (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): + (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): + (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): + (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): + * loader/FrameLoader.h: + (WebCore::FrameLoader::notifier): + * loader/MainResourceLoader.cpp: + (WebCore::MainResourceLoader::receivedError): + * loader/ResourceLoadNotifier.cpp: Added. + (WebCore::ResourceLoadNotifier::ResourceLoadNotifier): + (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge): + (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): + (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): + (WebCore::ResourceLoadNotifier::willSendRequest): + (WebCore::ResourceLoadNotifier::didReceiveResponse): + (WebCore::ResourceLoadNotifier::didReceiveData): + (WebCore::ResourceLoadNotifier::didFinishLoad): + (WebCore::ResourceLoadNotifier::didFailToLoad): + (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest): + (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest): + (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): + (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): + (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): + (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): + (WebCore::ResourceLoadNotifier::activeDocumentLoader): + * loader/ResourceLoadNotifier.h: Added. + * loader/ResourceLoader.cpp: + (WebCore::ResourceLoader::willSendRequest): + (WebCore::ResourceLoader::didReceiveResponse): + (WebCore::ResourceLoader::didReceiveData): + (WebCore::ResourceLoader::didFinishLoadingOnePart): + (WebCore::ResourceLoader::didFail): + (WebCore::ResourceLoader::didCancel): + (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): + (WebCore::ResourceLoader::didCancelAuthenticationChallenge): + +2009-10-15 Roland Steiner <rolandsteiner@google.com> + + Reviewed by Darin Fisher. + + Bug 30427 - Remove unneeded methods in ChromiumDataObject + (https://bugs.webkit.org/show_bug.cgi?id=30427) + + Remove no longer needed methods from ChromiumDataObject. + + No new tests (no functional change) + + * platform/chromium/ChromiumDataObject.h: + +2009-10-15 Daniel Bates <dbates@webkit.org> + + No review, rolling out r49644. + http://trac.webkit.org/changeset/49644 + + We need to think about this change some more. See bug #30418 + for more details. + + * page/XSSAuditor.cpp: + (WebCore::XSSAuditor::canEvaluate): + (WebCore::XSSAuditor::canEvaluateJavaScriptURL): + (WebCore::XSSAuditor::canCreateInlineEventListener): + (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): + (WebCore::XSSAuditor::canLoadObject): + (WebCore::XSSAuditor::canSetBaseElementURL): + (WebCore::XSSAuditor::findInRequest): + * page/XSSAuditor.h: + +2009-10-14 Jon Honeycutt <jhoneycutt@apple.com> + + Add SPI to determine whether a node is a halted plug-in. + + Part of <rdar://problem/7273354> Halted plug-ins should restart on + mouseover + + https://bugs.webkit.org/show_bug.cgi?id=30151 + + Reviewed by Darin Adler. + + * plugins/PluginView.cpp: + (WebCore::PluginView::PluginView): + Initialize m_isHalted. + + * plugins/PluginView.h: + (WebCore::PluginView::isHalted): + Return m_isHalted. + + * plugins/win/PluginViewWin.cpp: + (WebCore::PluginView::halt): + Set m_isHalted to true. + (WebCore::PluginView::restart): + clear m_isHalted. + +2009-10-15 Zoltan Horvath <zoltan@webkit.org> + + Reviewed by Oliver Hunt. + + [Qt] Build fix for QtWebKit after r49649. + + Change JSC::HasNonDefaultMark to OverridesMarkChildren in createStructure function. + + * bridge/qt/qt_runtime.h: + (JSC::Bindings::QtRuntimeMethod::createStructure): + +2009-10-15 Pavel Feldman <pfeldman@chromium.org> + + Not reviewed - build fix. + + Web Inspector: add file missing in r49648 + + * inspector/front-end/TestController.js: Added. + (WebInspector.TestController): + (WebInspector.TestController.prototype.waitUntilDone): + (WebInspector.TestController.prototype.notifyDone): + (WebInspector.evaluateForTestInFrontend): + +2009-10-15 Oliver Hunt <oliver@apple.com> + + Reviewed by Darin Adler. + + Make typeinfo flags default to false + https://bugs.webkit.org/show_bug.cgi?id=30372 + + Part 2 -- Reverse the TypeInfo HasDefaultMark flag to OverridesMarkChildren, etc + + * bindings/js/JSDOMBinding.h: + (WebCore::DOMObjectWithGlobalPointer::createStructure): + (WebCore::DOMConstructorObject::createStructure): + * bindings/js/JSDOMWindowShell.h: + (WebCore::JSDOMWindowShell::createStructure): + * bindings/js/JSHTMLAllCollection.h: + (WebCore::JSHTMLAllCollection::createStructure): + * bindings/js/JSQuarantinedObjectWrapper.h: + (WebCore::JSQuarantinedObjectWrapper::createStructure): + * bindings/scripts/CodeGeneratorJS.pm: + * bridge/qt/qt_runtime.h: + (JSC::Bindings::QtRuntimeMethod::createStructure): + * bridge/runtime_method.h: + (JSC::RuntimeMethod::createStructure): + +2009-10-15 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: introduce test controller with waitUntilDone + on frontend side. + + https://bugs.webkit.org/show_bug.cgi?id=30400 + + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * inspector/front-end/TestController.js: Added. + (WebInspector.TestController): + (WebInspector.TestController.prototype.waitUntilDone): + (WebInspector.TestController.prototype.notifyDone): + (WebInspector.evaluateForTestInFrontend): + * inspector/front-end/WebKit.qrc: + * inspector/front-end/inspector.html: + * inspector/front-end/inspector.js: + +2009-10-15 Daniel Bates <dbates@webkit.org> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=27895 + + Fixes an issue in which injecting an inline event handler whose value ends in a single-line + JavaScript comment can bypass the XSSAuditor. Similarly fixes this issue with respect to + the HTML Base element, HTML Object element, inline and external script tags, and + JavaScript multi-line variants of all of these attacks. + + Tests: http/tests/security/xssAuditor/base-href-comment.html + http/tests/security/xssAuditor/iframe-javascript-url-comment.html + http/tests/security/xssAuditor/img-onerror-HTML-comment.html + http/tests/security/xssAuditor/img-onerror-comment.html + http/tests/security/xssAuditor/object-tag-comment.html + http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html + http/tests/security/xssAuditor/script-tag-comment.html + http/tests/security/xssAuditor/script-tag-with-source-comment.html + + * page/XSSAuditor.cpp: Added constant minAttackLength. + (WebCore::XSSAuditor::canEvaluate): + (WebCore::XSSAuditor::canEvaluateJavaScriptURL): + (WebCore::XSSAuditor::canCreateInlineEventListener): + (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): + (WebCore::XSSAuditor::canLoadObject): + (WebCore::XSSAuditor::canSetBaseElementURL): + (WebCore::XSSAuditor::findInRequest): Added parameter context. Only looks at up + to minAttackLength of script code plus context (if any). + * page/XSSAuditor.h: + +2009-10-08 Adam Langley <agl@google.com> + + Reviewed by Eric Seidel. + + Currently, Skia clip paths are 1-bit. This patch makes our path + clipping anti-aliased for non-canvas drawing. + + http://code.google.com/p/chromium/issues/detail?id=5927 + https://bugs.webkit.org/show_bug.cgi?id=28820 + http://www.imperialviolet.org/2009/09/02/anti-aliased-clipping.html + + Already covered by layout tests. New baselines will be needed in the + Chromium tree. + + (Reland. First landed in r49329, reverted in r49330 due to Windows + build break) + + * html/canvas/CanvasRenderingContext2D.cpp: + (WebCore::CanvasRenderingContext2D::clip): + * platform/graphics/GraphicsContext.h: + * platform/graphics/cairo/GraphicsContextCairo.cpp: + (WebCore::GraphicsContext::canvasClip): + * platform/graphics/cg/GraphicsContextCG.cpp: + (WebCore::GraphicsContext::canvasClip): + * platform/graphics/haiku/GraphicsContextHaiku.cpp: + (WebCore::GraphicsContext::canvasClip): + * platform/graphics/qt/GraphicsContextQt.cpp: + (WebCore::GraphicsContext::canvasClip): + * platform/graphics/skia/GraphicsContextSkia.cpp: + (WebCore::GraphicsContext::addInnerRoundedRectClip): + (WebCore::GraphicsContext::clip): + (WebCore::GraphicsContext::canvasClip): + (WebCore::GraphicsContext::clipPath): + * platform/graphics/skia/PlatformContextSkia.cpp: + (PlatformContextSkia::clipPathAntiAliased): + (PlatformContextSkia::restore): + (PlatformContextSkia::applyAntiAliasedClipPaths): + * platform/graphics/skia/PlatformContextSkia.h: + * platform/graphics/win/GraphicsContextWin.cpp: + (WebCore::GraphicsContext::canvasClip): + * platform/graphics/wince/GraphicsContextWince.cpp: + (WebCore::GraphicsContext::canvasClip): + * platform/graphics/wx/GraphicsContextWx.cpp: + (WebCore::GraphicsContext::canvasClip): + +2009-10-15 Eric Carlson <eric.carlson@apple.com> + + Reviewed by Simon Fraser. + + <rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode + + * WebCore.Video.exp: Export muted and setMute. + +2009-10-15 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dan Bernstein. + + Transitions fail to run sometimes + https://bugs.webkit.org/show_bug.cgi?id=26770 + + Fix an issue where we could attempt to start accelerated animations or transitions on + GraphicsLayer that were not rooted (because of visibility:hidden), which would leave + the AnimationController's m_waitingForResponse flag in a state that killed subsequent + software transitions. + + * page/animation/AnimationController.cpp: + (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): + (WebCore::AnimationControllerPrivate::endAnimationUpdate): + (WebCore::AnimationControllerPrivate::receivedStartTimeResponse): + (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList): + (WebCore::AnimationControllerPrivate::startTimeResponse): + * page/animation/AnimationControllerPrivate.h: + Make some methods non-inline for ease of debugging (these are not hot methods). + Rename m_waitingForAResponse to m_waitingForResponse. + + * platform/graphics/GraphicsLayer.h: + * platform/graphics/GraphicsLayer.cpp: + (WebCore::GraphicsLayer::hasAncestor): + New method to report whether the receiver has the given layer as an ancestor. Used for checking + whether a layer is rooted. + + * rendering/RenderLayerBacking.cpp: + (WebCore::RenderLayerBacking::startAnimation): + (WebCore::RenderLayerBacking::startTransition): + Don't try to start accelerated animations or transitions on non-rooted GraphicsLayers. + +2009-10-15 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Pavel Feldman. + + Refactor ProfilesPanel to support multiple profile types + + Data describing different profile types are now stored in distinct objects. + https://bugs.webkit.org/show_bug.cgi?id=30332 + + * WebCore.vcproj/WebCore.vcproj: + * inspector/front-end/ProfileView.js: + (WebInspector.CPUProfileView.profileCallback): + (WebInspector.CPUProfileView): + (WebInspector.CPUProfileView.prototype._sortData): + (WebInspector.CPUProfileType): + (WebInspector.CPUProfileType.prototype.get buttonTooltip): + (WebInspector.CPUProfileType.prototype.get buttonStyle): + (WebInspector.CPUProfileType.prototype.buttonClicked): + (WebInspector.CPUProfileType.prototype.setRecordingProfile): + (WebInspector.CPUProfile): + (WebInspector.CPUProfile.prototype.get title): + (WebInspector.CPUProfile.prototype.get uid): + (WebInspector.CPUProfile.prototype.get head): + (WebInspector.CPUProfile.prototype.createView): + (WebInspector.CPUProfile.prototype.viewForProfile): + * inspector/front-end/ProfilesPanel.js: + (WebInspector.ProfileType): + (WebInspector.ProfileType.prototype.get buttonTooltip): + (WebInspector.ProfileType.prototype.get buttonStyle): + (WebInspector.ProfileType.prototype.get buttonCaption): + (WebInspector.ProfileType.prototype.get id): + (WebInspector.ProfileType.prototype.get name): + (WebInspector.ProfileType.prototype.buttonClicked): + (WebInspector.ProfilesPanel): + (WebInspector.ProfilesPanel.prototype.get statusBarItems.clickHandler): + (WebInspector.ProfilesPanel.prototype.get statusBarItems): + (WebInspector.ProfilesPanel.prototype.reset): + (WebInspector.ProfilesPanel.prototype.registerProfileType): + (WebInspector.ProfilesPanel.prototype._makeKey): + (WebInspector.ProfilesPanel.prototype.addProfileHeader): + (WebInspector.ProfilesPanel.prototype.showProfile): + (WebInspector.ProfilesPanel.prototype.getProfileType): + (WebInspector.ProfilesPanel.prototype.showProfileForURL): + (WebInspector.ProfilesPanel.prototype.updateProfileTypeButtons): + (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink): + (WebInspector.ProfilesPanel.prototype.get searchableViews): + (WebInspector.ProfilesPanel.prototype._updateInterface): + * inspector/front-end/inspector.js: + (WebInspector._createPanels): + (WebInspector.documentClick.followLink): + (WebInspector.documentClick): + (WebInspector.addProfileHeader): + (WebInspector.setRecordingProfile): + (WebInspector.linkifyStringAsFragment): + (WebInspector.showProfileForURL): + +2009-10-15 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Enable inspector layout tests. + + https://bugs.webkit.org/show_bug.cgi?id=30014 + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::evaluateForTestInFrontend): + +2009-10-15 Philippe Normand <pnormand@igalia.com> + + Reviewed by Gustavo Noronha. + + [GStreamer] READY state doesn't mean "enough data" + https://bugs.webkit.org/show_bug.cgi?id=30003 + + STATE_READY means MediaPlayer::HaveNothing + + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::MediaPlayerPrivate::updateStates): + +2009-10-15 Philippe Normand <pnormand@igalia.com> + + Reviewed by Gustavo Noronha. + + https://bugs.webkit.org/show_bug.cgi?id=30002 + + implement cancelLoad + + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::MediaPlayerPrivate::cancelLoad): + +2009-10-15 Sebastian Dröge <sebastian.droege@collabora.co.uk> + + Reviewed by Gustavo Noronha. + + https://bugs.webkit.org/show_bug.cgi?id=30353 + + Fix race condition, leading to a deadlock + + * platform/graphics/gtk/VideoSinkGStreamer.cpp: + (webkit_video_sink_timeout_func): + (webkit_video_sink_render): + (unlock_buffer_mutex): + (webkit_video_sink_unlock): + (webkit_video_sink_unlock_stop): + (webkit_video_sink_stop): + (webkit_video_sink_start): + (webkit_video_sink_class_init): + Fix race condition in unlock/render that would lead to deadlocks. + +2009-10-15 Sebastian Dröge <sebastian.droege@collabora.co.uk> + + Reviewed by Gustavo Noronha. + + https://bugs.webkit.org/show_bug.cgi?id=30374 + + Check if caps are valid before parsing them + + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::MediaPlayerPrivate::duration): + Check if caps are valid before parsing them in ::naturalSize(). + This prevents assertions if the natural size should be calculated + before the video caps are negotiated. + +2009-10-15 Philippe Normand <pnormand@igalia.com> + + Reviewed by Gustavo Noronha. + + https://bugs.webkit.org/show_bug.cgi?id=30006 + [GStreamer] Unnecessary checks for Messages types in callbacks + + refactored gst message callbacks into a single one + + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::mediaPlayerPrivateMessageCallback): + (WebCore::do_gst_init): + (WebCore::MediaPlayerPrivate::duration): + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: + +2009-10-15 Shu Chang <Chang.Shu@nokia.com> + + Reviewed by Adele Peterson. + + Anchor elements should be mouse focusable regardless isLink flag. + https://bugs.webkit.org/show_bug.cgi?id=26856 + + * html/HTMLAnchorElement.cpp: + * html/HTMLAnchorElement.h: + +2009-10-15 Nikolas Zimmermann <nzimmermann@rim.com> + + Not reviewed. Sort XCode project file. + + * WebCore.xcodeproj/project.pbxproj: + +2009-10-15 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Dave Hyatt. + + Return correct shorthand property name for + background-repeat-x, background-repeat-y, background-position-x, + background-position-y, -webkit-mask-position-x, -webkit-mask-position-y, + -webkit-mask-repeat-x, -webkit-mask-repeat-y. + + https://bugs.webkit.org/show_bug.cgi?id=28972 + + Test: fast/backgrounds/repeat/background-repeat-shorthand.html + + * css/CSSParser.cpp: + (WebCore::CSSParser::parseValue): + +2009-10-14 Mikhail Naganov <mnaganov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: Migrate profiles to the injected script-based schema. + + https://bugs.webkit.org/show_bug.cgi?id=30328 + + * bindings/js/JSInspectorBackendCustom.cpp: + * bindings/v8/custom/V8CustomBinding.h: + * inspector/InspectorBackend.cpp: + (WebCore::InspectorBackend::getProfileHeaders): + (WebCore::InspectorBackend::getProfile): + * inspector/InspectorBackend.h: + * inspector/InspectorBackend.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::addProfile): + (WebCore::InspectorController::getProfileHeaders): + (WebCore::InspectorController::getProfile): + (WebCore::InspectorController::createProfileHeader): + * inspector/InspectorController.h: + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::addProfileHeader): + (WebCore::InspectorFrontend::didGetProfileHeaders): + (WebCore::InspectorFrontend::didGetProfile): + * inspector/InspectorFrontend.h: + * inspector/JavaScriptProfileNode.cpp: + (WebCore::ProfileNodeClass): + * inspector/front-end/ProfileView.js: + (WebInspector.ProfileView.profileCallback): + (WebInspector.ProfileView): + (WebInspector.ProfileView.prototype._mouseDownInDataGrid): + (WebInspector.ProfileView.prototype._assignParentsInProfile): + * inspector/front-end/ProfilesPanel.js: + (WebInspector.ProfilesPanel.prototype.addProfileHeader): + * inspector/front-end/inspector.js: + (WebInspector.addProfileHeader): + +2009-10-14 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Create and update frontend script objects only when + web inspector is visible. + + https://bugs.webkit.org/show_bug.cgi?id=30376 + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::addConsoleMessage): + (WebCore::InspectorController::populateScriptObjects): + (WebCore::InspectorController::pruneResources): + (WebCore::InspectorController::didCommitLoad): + (WebCore::InspectorController::didLoadResourceFromMemoryCache): + (WebCore::InspectorController::identifierForInitialRequest): + (WebCore::InspectorController::mainResourceFiredDOMContentEvent): + (WebCore::InspectorController::mainResourceFiredLoadEvent): + (WebCore::InspectorController::willSendRequest): + (WebCore::InspectorController::didReceiveResponse): + (WebCore::InspectorController::didReceiveContentLength): + (WebCore::InspectorController::didFinishLoading): + (WebCore::InspectorController::didFailLoading): + (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): + (WebCore::InspectorController::scriptImported): + (WebCore::InspectorController::didOpenDatabase): + (WebCore::InspectorController::didUseDOMStorage): + (WebCore::InspectorController::evaluateForTestInFrontend): + +2009-10-15 Joseph Pecoraro <joepeck@webkit.org> + + Fix Windows build. + + * dom/Document.idl: + +2009-10-14 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Adam Barth. + + [HTML5] Add document.head + https://bugs.webkit.org/show_bug.cgi?id=30232 + + Test is fast/dom/document-head.html + + * dom/Document.idl: added readonly attribute head + +2009-10-14 Matt Mueller <mattm@chromium.org> + + Reviewed by Darin Adler. + + Check FNonNeg after the unit switch to avoid valgrind uninitialised conditional reference in WebCore::CSSParser::validUnit. See http://crbug.com/20939. + https://bugs.webkit.org/show_bug.cgi?id=30347 + https://bugs.webkit.org/show_bug.cgi?id=22772 + + Covered by running LayoutTests/fast/css/invalid-percentage-property.html under valgrind. + + * css/CSSParser.cpp: + (WebCore::CSSParser::validUnit): + +2009-10-14 Adam Barth <abarth@webkit.org> + + Reviewed by Sam Weinig. + + Move scrolling code from FrameLoader to FrameView + https://bugs.webkit.org/show_bug.cgi?id=30370 + + This code is about controlling the Frame's view, not about loading + stuff into the frame. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::finishedParsing): + (WebCore::FrameLoader::scrollToAnchor): + * page/FrameView.cpp: + (WebCore::FrameView::scrollToFragment): + (WebCore::FrameView::scrollToAnchor): + * page/FrameView.h: + +2009-10-14 Oliver Hunt <oliver@apple.com> + + Reviewed by Geoff Garen. + + Make typeinfo flags default to false + https://bugs.webkit.org/show_bug.cgi?id=30372 + + Part 1. Reverse the HasStandardGetOwnPropertySlot flag. + + * bindings/js/JSDOMBinding.h: + (WebCore::DOMObjectWithGlobalPointer::createStructure): + (WebCore::DOMConstructorObject::createStructure): + * bindings/js/JSDOMWindowShell.h: + (WebCore::JSDOMWindowShell::createStructure): + * bindings/js/JSHTMLAllCollection.h: + (WebCore::JSHTMLAllCollection::createStructure): + * bindings/js/JSQuarantinedObjectWrapper.h: + (WebCore::JSQuarantinedObjectWrapper::createStructure): + * bindings/scripts/CodeGeneratorJS.pm: + * bridge/objc/objc_runtime.h: + (JSC::Bindings::ObjcFallbackObjectImp::createStructure): + * bridge/runtime_array.h: + (JSC::RuntimeArray::createStructure): + * bridge/runtime_method.h: + (JSC::RuntimeMethod::createStructure): + * bridge/runtime_object.h: + (JSC::RuntimeObjectImp::createStructure): + +2009-10-14 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + [XSSAuditor] Add an exception for local files + https://bugs.webkit.org/show_bug.cgi?id=30352 + + Reduce XSS auditor false positives by always letting pages load scripts + from their own host. We don't actually know of any false positives + that this prevents, but it seems like a good idea. + + One subtly is that we don't add this exception for scripts that have a + query string because (1) URLs with query strings are more apt to + confuse servers and (2) it is much less common to load scripts with a + query string. + + Tests: http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html + http/tests/security/xssAuditor/script-tag-with-source-same-host.html + + * page/XSSAuditor.cpp: + (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): + +2009-10-14 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by George Staikos. + + Kill virtual contextElement() method spread all over SVG code + https://bugs.webkit.org/show_bug.cgi?id=30183 + + Remove virtual contextElement() function from all SVG*Element classes, as all animated properties live in the + SVG*Element classes now instead of the SVGFitToViewBox / SVGURIReference / SVGExternalResourcesRequired + subclasses. This is a first step to working animVal support. More patches will follow that depend on this change. + + Remove "This file is part of the KDE project" from several files, change my old mail adress wildfox -> zimmermann, + and remove vim modelines on all files I touched. No change in functionality, thus no new tests. + + * svg/SVGAElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGAltGlyphElement.h: Remove virtual contextElement() method. + * svg/SVGAnimatedProperty.h: + (WebCore::::synchronize): + (WebCore::::startAnimation): + (WebCore::::stopAnimation): + * svg/SVGAnimationElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGCircleElement.h: Ditto. + * svg/SVGClipPathElement.h: Ditto. + * svg/SVGCursorElement.h: Ditto. + * svg/SVGDefsElement.h: Ditto. + * svg/SVGEllipseElement.h: Ditto. + * svg/SVGExternalResourcesRequired.h: Remove pure-virtual contextElement() method. + * svg/SVGFEImageElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGFELightElement.h: Remove virtual contextElement() method. + * svg/SVGFEMergeNodeElement.h: Ditto. + * svg/SVGFilterElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGFilterPrimitiveStandardAttributes.h: Remove virtual contextElement() method. + * svg/SVGFitToViewBox.cpp: + (WebCore::SVGFitToViewBox::parseViewBox): Add Document* parameter - we used to fetch the Document pointer from the context element. + (WebCore::SVGFitToViewBox::parseMappedAttribute): Ditto. + * svg/SVGFitToViewBox.h: Remove pure-virtual contextElement() method. + * svg/SVGFontElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGForeignObjectElement.h: Ditto. + * svg/SVGGElement.h: Ditto. + * svg/SVGGradientElement.h: Ditto. + * svg/SVGImageElement.h: Ditto. + * svg/SVGLineElement.h: Ditto. + * svg/SVGMPathElement.h: Ditto. Fix license indention. + * svg/SVGMarkerElement.cpp: + (WebCore::SVGMarkerElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute(). + * svg/SVGMarkerElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGMaskElement.h: Ditto. + * svg/SVGPathElement.h: Ditto. + * svg/SVGPatternElement.cpp: + (WebCore::SVGPatternElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute(). + * svg/SVGPatternElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGPolyElement.cpp: + (WebCore::SVGPolyElement::updateAnimatedSVGAttribute): synchronizeProperty<...>() has been renamed to PropertySynchronizer<...>::synchronize(). + * svg/SVGPolyElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGRectElement.h: Ditto. + * svg/SVGSVGElement.cpp: + (WebCore::SVGSVGElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute(). + * svg/SVGSVGElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGScriptElement.h: Ditto. + * svg/SVGSwitchElement.h: Ditto. + * svg/SVGSymbolElement.cpp: + (WebCore::SVGSymbolElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute(). + * svg/SVGSymbolElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGTRefElement.h: Remove virtual contextElement() method. + * svg/SVGTextContentElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGTextPathElement.h: Remove virtual contextElement() method. + * svg/SVGUseElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGViewElement.cpp: + (WebCore::SVGViewElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute(). + * svg/SVGViewElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class. + * svg/SVGViewSpec.cpp: + (WebCore::SVGViewSpec::setViewBoxString): Pass document() to SVGFitToViewBox::parseMappedAttribute(). + (WebCore::SVGViewSpec::parseViewSpec): Ditto. + * svg/SVGViewSpec.h: Devirtualize contextElement() method, it's the only place where contextElement() remains needed. + +2009-10-14 Dirk Schulze <krit@webkit.org> + + Reviewed by Nikolas Zimmermann. + + SVG Masking with wrong offset + [https://bugs.webkit.org/show_bug.cgi?id=30325] + + SVGMaskElement moves the mask image graphics context to the wrong location. + In objectBoundingBoxMode the maskDestRect gets translated. This transformation + is not used in the later calculation. Fix by consistenly calculating the translation + offsets from the final mask destination rect. + + Test: svg/custom/mask-with-default-value.svg + + * svg/SVGMaskElement.cpp: + (WebCore::SVGMaskElement::drawMaskerContent): + +2009-10-14 Kevin Decker <kdecker@apple.com> + + Rubberstamped by Jon Honeycutt. + + Export a few more showSubstituteImage() related methods. + + * WebCore.base.exp: + * WebCore.xcodeproj/project.pbxproj: + +2009-10-14 Evan Martin <evan@chromium.org> + + Reviewed by Darin Adler. + + Stringify CSS units manually (without printf) to make the formatting + locale-insensitive and obey CSS spec with respect to large values. + + https://bugs.webkit.org/show_bug.cgi?id=18994 + + * css/CSSPrimitiveValue.cpp: + (WebCore::appendCSSDouble): + (WebCore::formatWithUnits): + (WebCore::CSSPrimitiveValue::cssText): + +2009-10-14 Mark Seaborn <mseaborn@google.com> + + Reviewed by Darin Adler. + + Check error return value in Perl build script + https://bugs.webkit.org/show_bug.cgi?id=30316 + + * css/makevalues.pl: Die if gperf fails. + +2009-10-14 Dirk Schulze <krit@webkit.org> + + Reviewed by Nikolas Zimmermann. + + SVG wrong filterRegions for userSpaceOnUse and percentage values + [https://bugs.webkit.org/show_bug.cgi?id=30330] + + Some clean-up of the SVG filter calculation code. This clean-up + also fixes the problem with percentage and userSpaceInUse mode. + + Test: svg/filters/subRegion-in-userSpace.svg + + * platform/graphics/filters/FilterEffect.cpp: + (WebCore::FilterEffect::FilterEffect): + * platform/graphics/filters/FilterEffect.h: + * rendering/SVGRenderSupport.cpp: + (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): + * svg/SVGFilterElement.cpp: + (WebCore::SVGFilterElement::buildFilter): + (WebCore::SVGFilterElement::canvasResource): + * svg/SVGFilterElement.h: + * svg/SVGFilterPrimitiveStandardAttributes.cpp: + (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes): + * svg/graphics/SVGResourceFilter.cpp: + (WebCore::SVGResourceFilter::SVGResourceFilter): + (WebCore::SVGResourceFilter::~SVGResourceFilter): + (WebCore::SVGResourceFilter::addFilterEffect): + (WebCore::SVGResourceFilter::prepareFilter): + * svg/graphics/SVGResourceFilter.h: + (WebCore::SVGResourceFilter::create): + * svg/graphics/filters/SVGFilter.cpp: + (WebCore::SVGFilter::SVGFilter): + (WebCore::SVGFilter::calculateEffectSubRegion): + (WebCore::SVGFilter::create): + * svg/graphics/filters/SVGFilter.h: + +2009-10-14 Chris Marrin <cmarrin@apple.com> + + The last change fixed the problem, removing diagnostic printfs. + + * platform/graphics/mac/GraphicsContext3DMac.cpp: + (WebCore::GraphicsContext3D::GraphicsContext3D): + +2009-10-14 Kevin Ollivier <kevino@theolliviers.com> + + CURL build fix for versions < 7.18. + + * platform/network/curl/ResourceHandleCurl.cpp: + (WebCore::ResourceHandle::setDefersLoading): + * platform/network/curl/ResourceHandleManager.cpp: + (WebCore::ResourceHandleManager::initializeHandle): + +2009-10-14 Chris Marrin <cmarrin@apple.com> + + One more round of changes to figure out why the webgl + tests are crashing on the build bot. Here I am trying + to see if we can create a software renderer. I am also + printing the found pixel formats. + + * platform/graphics/mac/GraphicsContext3DMac.cpp: + (WebCore::GraphicsContext3D::GraphicsContext3D): + +2009-10-14 Yael Aharon <yael.aharon@nokia.com> + + Reviewed by Simon Hausmann. + + Enabling NPAPI plugin support on Qt Webkit for S60 platform + https://bugs.webkit.org/show_bug.cgi?id=29302 + + Also implemented by Mahesh Kulkarni<mahesh.kulkarni@nokia.com>, + Rohini Ananth <rohini.ananth@nokia.com> and help from Norbert Lesr + <norbert.leser@nokia.com> + + * WebCore.pro: + Enabling ENABLE_NETSCAPE_PLUGIN_API for S60 and added S60 specific + new plugin files to be compiled under symbian: macro + + * bridge/npapi.h: + Added NPEvent and NPRegion definition for Symbian + + * plugins/PluginPackage.h: + Added S60 specific plugin interface and plugin loader variables + * plugins/PluginPackage.cpp: + (WebCore::PluginPackage::unload): Added !PLATFORM(SYMBIAN) macro. + Default implementation to be used only for non-symbian platform + * plugins/PluginDatabase.cpp: + Macro !SYMBIAN checking + * plugins/PluginView.h: + Add Symbian to platforms that support setNPWindowIfNeeded + * plugins/PluginView.cpp: + (WebCore::PluginView::setFrameRect): Add Symbian to platforms that + call setNPWindowRect from setFrameRect + + Added folder 'symbian' which contains implementation files for S60 + platform-specific NPAPI plugin functionality, under /plugins folder + * plugins/symbian + * plugins/symbian/npinterface.h: + Plugin Interface to be implemented by S60 NPAPI plugins + * plugins/symbian/PluginContainerSymbian.h: + * plugins/symbian/PluginContainerSymbian.cpp: + * plugins/symbian/PluginDatabaseSymbian.cpp: + * plugins/symbian/PluginViewSymbian.cpp: + * plugins/symbian/PluginPackageSymbian.cpp: + +2009-10-14 Chris Marrin <cmarrin@apple.com> + + More changes to figure out why the webgl tests are crashing on the build bot. + + * platform/graphics/mac/GraphicsContext3DMac.cpp: + (WebCore::GraphicsContext3D::GraphicsContext3D): + +2009-10-14 Victor Wang <victorw@chromium.org> + + Reviewed by David Hyatt. + + Round non-integer line height values. + + Change webkit to rounding non-integer line height values + instead of truncating them. This fixes a layout test + failure on Windows and matches the calculation in IE and Firefox. + + https://bugs.webkit.org/show_bug.cgi?id=24434 + + Test: fast/css/line-height-rounding.html + fast/forms/textarea-scrollbar-height.htm + + * css/CSSComputedStyleDeclaration.cpp: + (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::computeLogicalBoxHeights): + * rendering/RenderBR.cpp: + (WebCore::RenderBR::lineHeight): + * rendering/style/RenderStyle.h: + (WebCore::InheritedFlags::computedLineHeight): + +2009-10-13 Kelly Norton <knorton@google.com> + + Reviewed by Pavel Feldman. + + Removes the persistent setting for InspectorTimelineAgent and renames timeline related + interfaces to be more consistent with the JavaScript profiler. + + * inspector/InspectorBackend.cpp: + (WebCore::InspectorBackend::startTimelineProfiler): + (WebCore::InspectorBackend::stopTimelineProfiler): + (WebCore::InspectorBackend::timelineProfilerEnabled): + * inspector/InspectorBackend.h: + * inspector/InspectorBackend.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::setFrontendProxyObject): + (WebCore::InspectorController::startTimelineProfiler): + (WebCore::InspectorController::stopTimelineProfiler): + (WebCore::InspectorController::timelineProfilerEnabled): + * inspector/InspectorController.h: + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::timelineProfilerWasStarted): + (WebCore::InspectorFrontend::timelineProfilerWasStopped): + * inspector/InspectorFrontend.h: + * inspector/front-end/TimelineAgent.js: + (WebInspector.timelineProfilerWasStarted): + (WebInspector.timelineProfilerWasStopped): + +2009-10-01 Yong Li <yong.li@torchmobile.com> + + Reviewed by Adele Peterson. + + Fix crash when loading invalid image data + https://bugs.webkit.org/show_bug.cgi?id=29980 + + * rendering/RenderImage.cpp: + (WebCore::RenderImage::setImageSizeForAltText): + +2009-10-09 Stephen White <senorblanco@chromium.org> + + Reviewed by Eric Seidel. + + Fix for NULL ptr deref in canvas's toDataURL(). + https://bugs.webkit.org/show_bug.cgi?id=30254 + + Test: fast/canvas/canvas-toDataURL-crash.html + + * html/HTMLCanvasElement.cpp: + (WebCore::HTMLCanvasElement::toDataURL): + +2009-10-14 Pavel Feldman <pfeldman@chromium.org> + + Not reviewed, reverting r49558 since it broke profiler tests. + + https://bugs.webkit.org/show_bug.cgi?id=30328 + + * bindings/js/JSInspectorBackendCustom.cpp: + * bindings/v8/custom/V8CustomBinding.h: + * inspector/InspectorBackend.cpp: + (WebCore::InspectorBackend::getProfileHeaders): + (WebCore::InspectorBackend::getProfile): + * inspector/InspectorBackend.h: + * inspector/InspectorBackend.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::addProfile): + (WebCore::InspectorController::getProfileHeaders): + (WebCore::InspectorController::getProfile): + (WebCore::InspectorController::createProfileHeader): + * inspector/InspectorController.h: + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::addProfileHeader): + (WebCore::InspectorFrontend::didGetProfileHeaders): + (WebCore::InspectorFrontend::didGetProfile): + * inspector/InspectorFrontend.h: + * inspector/JavaScriptProfileNode.cpp: + (WebCore::ProfileNodeClass): + * inspector/front-end/ProfileView.js: + (WebInspector.ProfileView.profileCallback): + (WebInspector.ProfileView): + (WebInspector.ProfileView.prototype._mouseDownInDataGrid): + (WebInspector.ProfileView.prototype._assignParentsInProfile): + * inspector/front-end/ProfilesPanel.js: + (WebInspector.ProfilesPanel.prototype.addProfileHeader): + * inspector/front-end/inspector.js: + (WebInspector.addProfileHeader): + +2009-10-13 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Simon Hausmann. + + ImageDecoderQt: Minor tweaks to the decoder + + - Only cache the data when we start to use it. + - Start with a repetition count of none for normal images. + - Do not use canRead as this will trigger parsing of the full image + - Cope with a GIF failing to decode the first frame, do not + set m_failed to true if decoding the first frame failed + - Inform the QImageReader about the format that was detected + - Always create a ImageDecoderQt when when we have more + than four byte. + + + * platform/graphics/qt/ImageDecoderQt.cpp: + (WebCore::ImageDecoder::create): Always create QImageReader for a significant speed up + (WebCore::ImageDecoderQt::ImageDecoderQt): Initialize m_repetitionCount to cAnimationNone + (WebCore::ImageDecoderQt::setData): Only call ImageDecoder::setData when everything has been received + (WebCore::ImageDecoderQt::isSizeAvailable): Do not check m_failed twice. + (WebCore::ImageDecoderQt::filenameExtension): Convert from QByteArray to String + (WebCore::ImageDecoderQt::frameBufferAtIndex): Check for m_failed before trying to decode + (WebCore::ImageDecoderQt::internalDecodeSize): Fail if the size is QSize() + (WebCore::ImageDecoderQt::forceLoadEverything): Handle the case were decoding the first frame fails + * platform/graphics/qt/ImageDecoderQt.h: Change the m_format type + +2009-10-14 Mikhail Naganov <mnaganov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: Migrate profiles to the injected script-based schema. + + https://bugs.webkit.org/show_bug.cgi?id=30328 + + * bindings/js/JSInspectorBackendCustom.cpp: + * bindings/v8/custom/V8CustomBinding.h: + * inspector/InspectorBackend.cpp: + (WebCore::InspectorBackend::getProfileHeaders): + (WebCore::InspectorBackend::getProfile): + * inspector/InspectorBackend.h: + * inspector/InspectorBackend.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::addProfile): + (WebCore::InspectorController::getProfileHeaders): + (WebCore::InspectorController::getProfile): + (WebCore::InspectorController::createProfileHeader): + * inspector/InspectorController.h: + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::addProfileHeader): + (WebCore::InspectorFrontend::didGetProfileHeaders): + (WebCore::InspectorFrontend::didGetProfile): + * inspector/InspectorFrontend.h: + * inspector/JavaScriptProfileNode.cpp: + (WebCore::ProfileNodeClass): + * inspector/front-end/ProfileView.js: + (WebInspector.ProfileView.profileCallback): + (WebInspector.ProfileView): + (WebInspector.ProfileView.prototype._mouseDownInDataGrid): + (WebInspector.ProfileView.prototype._assignParentsInProfile): + * inspector/front-end/ProfilesPanel.js: + (WebInspector.ProfilesPanel.prototype.addProfileHeader): + * inspector/front-end/inspector.js: + (WebInspector.addProfileHeader): + +2009-10-13 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Pavel Feldman. + + Don't collect call frame properties until they're needed for completion. + + https://bugs.webkit.org/show_bug.cgi?id=30334 + + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView.prototype.completions): + * inspector/front-end/InjectedScript.js: + (InjectedScript.getCompletions): if call frame id is specified and the expression is empty collect frame properties. + (InjectedScript.CallFrameProxy.prototype._wrapScopeChain): don't send call frame properties until they're needed. + * inspector/front-end/ScriptsPanel.js: + +2009-10-13 Yongjun Zhang <yongjun.zhang@nokia.com> + + Reviewed by Ariya Hidayat. + + https://bugs.webkit.org/show_bug.cgi?id=29106 + [Qt] make CachedResourceHandle.h compile in winscw Symbian compiler. + + Don't inline constructor CachedResourceHandle<T>(R*) to stop winscw + compiler aggressively resolve inheritance of class R. + + The winscw compiler bug is reported at: + https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812. + + The change should be reverted when the above bug is fixed in winscw compiler. + + * loader/CachedResourceHandle.h: + (WebCore::::CachedResourceHandle): + +2009-10-13 Dimitri Glazkov <dglazkov@chromium.org> + + No review, rolling out r49554, because it broke Win and Chromium builds. + http://trac.webkit.org/changeset/49554 + + * css/CSSPrimitiveValue.cpp: + (WebCore::CSSPrimitiveValue::cssText): + +2009-10-13 Evan Martin <evan@chromium.org> + + Reviewed by Adam Barth. + + Stringify CSS units manually (without printf) to make the formatting + locale-insensitive and obey CSS spec with respect to large values. + + https://bugs.webkit.org/show_bug.cgi?id=18994 + + * css/CSSPrimitiveValue.cpp: + (WebCore::appendCSSDouble): + (WebCore::formatWithUnits): + (WebCore::CSSPrimitiveValue::cssText): + +2009-10-13 Evan Martin <evan@chromium.org> + + Reviewed by David Levin. + + Make grippy lines vertical on horizontal scrollbars in Linux Chrome. + While we're rebaselining scrollbars, fix an off by one in the vertical + scrollbar rendering too. + + https://bugs.webkit.org/show_bug.cgi?id=30319 + + Tests: this is covered by every pixel test involving scrollbars. + + * platform/chromium/ScrollbarThemeChromiumLinux.cpp: + (WebCore::ScrollbarThemeChromiumLinux::paintThumb): + +2009-10-13 Sam Weinig <sam@webkit.org> + + Reviewed by David Hyatt. + + Fix issue where clientX and clientY on MouseEvents were wrong when + the page was zoomed and scrolled. + + Test: fast/events/clientXY-in-zoom-and-scroll.html + + * dom/MouseRelatedEvent.cpp: + (WebCore::contentsX): Take page zoom into account. + (WebCore::contentsY): Ditto. + +2009-10-13 Dave Hyatt <hyatt@apple.com> + + Reviewed by Adam Roben. + + Change the order of arguments on some of the user stylesheet/script functions. Split the removal functions + out into separate ones for scripts and stylesheets. + + * WebCore.base.exp: + * page/PageGroup.cpp: + (WebCore::PageGroup::addUserScriptToWorld): + (WebCore::PageGroup::addUserStyleSheetToWorld): + (WebCore::PageGroup::removeUserScriptFromWorld): + (WebCore::PageGroup::removeUserStyleSheetFromWorld): + (WebCore::PageGroup::removeUserScriptsFromWorld): + (WebCore::PageGroup::removeUserStyleSheetsFromWorld): + * page/PageGroup.h: + (WebCore::PageGroup::userScripts): + (WebCore::PageGroup::userStyleSheets): + +2009-10-13 Evan Martin <evan@chromium.org> + + Reviewed by Dmitry Titov. + + Chrome's "Skia" theme paints select controls backwards in RTL. + + https://bugs.webkit.org/show_bug.cgi?id=30320 + + Test: fast/text/international/bidi-menulist.html + (The test is about something else, but it includes RTL selects.) + + * rendering/RenderThemeChromiumSkia.cpp: + (WebCore::RenderThemeChromiumSkia::paintMenuList): flip the arrow position in RTL case. + +2009-10-13 Dmitry Titov <dimich@chromium.org> + + Reviewed by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=30318 + ScriptExecutionContext is not anymore needed to create an EventListener - remove old code. + It's a followup to r48884. It removed the need to pass the ScritpExecutionContext + into EventListener constructor but did not remove the code pulling ScriptExecutionContext. + + Tests: + Test adds event listener to a DocumentType Node which is created without a document + and then dispatches the event after attaching a node to the tree. Event + should fire when node is attached to the tree. + + * fast/events/add-event-without-document-expected.txt: Added. + * fast/events/add-event-without-document.html: Added. + + All changes in files below are the same - remove the code that calls + EventTarget::scriptExecutionContext and checks it for NULL. + + * bindings/js/JSAbstractWorkerCustom.cpp: + (WebCore::JSAbstractWorker::addEventListener): + (WebCore::JSAbstractWorker::removeEventListener): + * bindings/js/JSDOMApplicationCacheCustom.cpp: + (WebCore::JSDOMApplicationCache::addEventListener): + (WebCore::JSDOMApplicationCache::removeEventListener): + * bindings/js/JSDesktopNotificationsCustom.cpp: + (WebCore::JSNotification::addEventListener): + (WebCore::): + * bindings/js/JSEventSourceCustom.cpp: + (WebCore::JSEventSource::addEventListener): + (WebCore::JSEventSource::removeEventListener): + * bindings/js/JSMessagePortCustom.cpp: + (WebCore::JSMessagePort::addEventListener): + (WebCore::JSMessagePort::removeEventListener): + * bindings/js/JSNodeCustom.cpp: + (WebCore::JSNode::addEventListener): + (WebCore::JSNode::removeEventListener): + * bindings/js/JSSVGElementInstanceCustom.cpp: + (WebCore::JSSVGElementInstance::addEventListener): + (WebCore::JSSVGElementInstance::removeEventListener): + * bindings/js/JSXMLHttpRequestCustom.cpp: + (WebCore::JSXMLHttpRequest::addEventListener): + (WebCore::JSXMLHttpRequest::removeEventListener): + * bindings/js/JSXMLHttpRequestUploadCustom.cpp: + (WebCore::JSXMLHttpRequestUpload::addEventListener): + (WebCore::JSXMLHttpRequestUpload::removeEventListener): + * bindings/js/JSWebSocketCustom.cpp: + (WebCore::JSWebSocket::addEventListener): + (WebCore::JSWebSocket::removeEventListener): + +2009-10-13 Drew Wilson <atwilson@atwilson-macpro.local> + + Reviewed by David Levin. + + Enable SHARED_WORKERS for Chromium + https://bugs.webkit.org/show_bug.cgi?id=30289 + + Cleaned up bitrot in SharedWorker V8 bindings. + + * WebCore.gypi: + Removed default implementation of SharedWorkerRepository so Chromium can provide its own. + * bindings/v8/DerivedSourcesAllInOne.cpp: + Added V8SharedWorkerContext.cpp. + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::getTemplate): + Added case statements for SHAREDWORKER and SHAREDWORKERCONTEXT. + * bindings/v8/V8Index.cpp: + Now includes V8SharedWorkerContext.h to allow supporting SharedWorkers. + * bindings/v8/V8Index.h: + Added definition for SHAREDWORKERCONTEXT wrapper. + * bindings/v8/WorkerContextExecutionProxy.cpp: + Added includes for SharedWorker.h and SharedWorkerContext.h. + * bindings/v8/custom/V8CustomBinding.h: + Reorganized Worker field indexes to be clearer, and fixed mismatch in worker field index. + Also added field indexes for SharedWorkers. + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::ACCESSOR_RUNTIME_ENABLER): + Added runtime enabler for the SharedWorker constructor. + * bindings/v8/custom/V8SharedWorkerCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + Cleaned up bitrot (various APIs have changed since this file was written). + * page/DOMWindow.idl: + Added EnabledAtRuntime flag to window.SharedWorker. + +2009-10-13 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Brady Eidson. + + https://bugs.webkit.org/show_bug.cgi?id=30345 + HTTP tests for credential handling fail on Tiger + + We cannot prevent NSURLConnection from doing its credentil handling on Tiger anyway; so + let it do its work without intervention. Once again, we pass explicitly passed credentials + in URL, fixing regressions from Safari 3. + + * platform/network/mac/ResourceHandleMac.mm: + (WebCore::ResourceHandle::start): + (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): + (WebCore::ResourceHandle::receivedCredential): + +2009-10-13 Roland Steiner <rolandsteiner@google.com> + + Reviewed by Adam Barth. + + Bug 28964 - [Chromium] ChromiumDataObject should have getter/setter interface + + Reworked and added to the getter/setter interface in ChromiumDataObject: + - added contains...() methods to just query the state + - added containsValid...URL() methods for URL data members + - removed takeFileNames() as this was too type-dependent + - changed return type of fileNames() to Vector<String> + - added interface methods to allow appending to and iteration over file names + + No new tests (no functional behavior changed). + + * platform/chromium/ChromiumDataObject.h: + (WebCore::ChromiumDataObject::containsMainURL): + (WebCore::ChromiumDataObject::containsValidMainURL): + (WebCore::ChromiumDataObject::containsMainURLTitle): + (WebCore::ChromiumDataObject::containsTextPlain): + (WebCore::ChromiumDataObject::containsTextHTML): + (WebCore::ChromiumDataObject::containsHTMLBaseURL): + (WebCore::ChromiumDataObject::containsValidHTMLBaseURL): + (WebCore::ChromiumDataObject::containsContent): + (WebCore::ChromiumDataObject::containsContentFileExtension): + (WebCore::ChromiumDataObject::containsContentFileName): + (WebCore::ChromiumDataObject::setContentFileName): + (WebCore::ChromiumDataObject::containsFileNames): + (WebCore::ChromiumDataObject::fileNames): + (WebCore::ChromiumDataObject::clearFileNames): + (WebCore::ChromiumDataObject::countFileNames): + (WebCore::ChromiumDataObject::fileNameAt): + (WebCore::ChromiumDataObject::setFileNames): + (WebCore::ChromiumDataObject::appendToFileNames): + (WebCore::ChromiumDataObject::popFileName): + +2009-10-13 Simon Fraser <simon.fraser@apple.com> + + Temporary debugging changes to figure out why the webgl tests are crashing on the build bot. + + * platform/graphics/mac/GraphicsContext3DMac.cpp: + (WebCore::GraphicsContext3D::GraphicsContext3D): + +2009-10-13 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dan Bernstein. + + Visibility:visible inside a compositing layer doesn't make the element visible + https://bugs.webkit.org/show_bug.cgi?id=30339 + + When deciding if a layer had any renderable content, RenderLayerBacking::paintIntoLayer() + only consulted hasVisibleContent(), which does not take into a account child layers which + may be visible. We also have to consult hasVisibleDescendant() as well. + + Test: compositing/compositing-visible-descendant.html + + * rendering/RenderLayer.h: + (WebCore::RenderLayer::hasVisibleDescendant): + * rendering/RenderLayerBacking.cpp: + (WebCore::RenderLayerBacking::paintIntoLayer): + +2009-10-13 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Simon Hausmann. + + Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH + https://bugs.webkit.org/show_bug.cgi?id=30278 + + Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH + from the make system into common code. + + Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH if NETSCAPE_PLUGIN_API + support is not enabled. + + Remove notImplemented() from PluginPackageNone.cpp and + PluginDataNone.cpp make them just empty functions. + + * GNUmakefile.am: + * WebCore.pro: + * plugins/PluginDataNone.cpp: + (WebCore::PluginData::initPlugins): + (WebCore::PluginData::refresh): + * plugins/PluginPackageNone.cpp: + (WebCore::PluginPackage::determineQuirks): + (WebCore::PluginPackage::fetchInfo): + (WebCore::PluginPackage::load): + +2009-10-13 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=30150 + <rdar://problem/7283540> REGRESSION: Crash when accessing clipboardData.types + + Test: editing/pasteboard/crash-accessing-clipboardData-types.html + + * platform/mac/ClipboardMac.mm: (WebCore::addHTMLClipboardTypesForCocoaType): The String + class doesn't have operator bool, it's operator NSString* that is invoked instead, and it + converts null strings to non-null @"". + +2009-10-13 Drew Wilson <atwilson@atwilson-macpro.local> + + Reviewed by Dimitri Glazkov. + + window attributes (like localStorage) that are disabled at runtime are still visible + https://bugs.webkit.org/show_bug.cgi?id=30240 + + Adding codegen/bindings to support runtime disabling of attributes. + + No new tests (only supported by chrome currently) + + * bindings/scripts/CodeGeneratorV8.pm: + Refactored the guts of GenerateBatchedAttributeData into a separate GenerateSingleBatchedAttribute with a passed-in indentation level to allow generating a single BatchedAttribute struct. + Added support for the EnabledAtRuntime extended attribute, which generates a call to the appropriate XXXXEnabled() API before adding the attribute to the instance. + * bindings/v8/V8Proxy.cpp: + (WebCore::batchConfigureAttributes): + Refactored attribute setting code into a common inline routine. + * bindings/v8/V8Proxy.h: + (WebCore::configureAttribute): + Inline function which configures a single attribute given a BatchedAttribute struct. + * bindings/v8/custom/V8CustomBinding.h: + Added (DECLARE_)ACCESSOR_RUNTIME_ENABLER to allow enabling attributes at runtime. + * bindings/v8/custom/V8DOMWindowCustom.cpp: + Added code to enable window.Audio only if MediaPlayer.isAvailable() == true + * page/DOMWindow.idl: + Added [EnabledAtRuntime] extended attribute to the Audio attribute. + +2009-10-13 Michelangelo De Simone <micdesim@gmail.com> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=27457 + Added support for static validation on type=email input elements as per + HTML5 specs: + http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state + + Test: fast/forms/ValidityState-typeMismatch-email.html + + * html/ValidityState.cpp: + (WebCore::ValidityState::typeMismatch): ValidityState.typeMismatch + performs validation on type=email input elements now. + (WebCore::ValidityState::isValidEmailAddress): simple validation method + * html/ValidityState.h: + +2009-10-13 Dmitry Titov <dimich@chromium.org> + + Reviewed by Adam Barth. + + Event listeners installed on a window object returned from window.open() don't work + https://bugs.webkit.org/show_bug.cgi?id=28716 + + Tests: http/tests/security/window-events-clear-domain.html + http/tests/security/window-events-clear-port.html + http/tests/security/window-events-pass.html + + * dom/Document.cpp: Split code of Document::clear() in a way to avoid removing all + window event handlers when implicitOpen is called. It is called in 2 cases - on + committing loaded content (no need to clean handlers) and on document.open() (needs to remove handlers). + + (WebCore::Document::open): in addition to calling implicitOpen it also removes window + event handlers, to preserve the behavior of document.open(). + + (WebCore::Document::implicitOpen): includes the part of removed Document::clear() that + does not remove window event handlers. + + * dom/Document.h: Removed clear(). + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::stopLoading): add check to avoid removing window event handlers + if we transition from temporary empty document to a loaded one. + + (WebCore::FrameLoader::didOpenURL): Remove closeURL() which was called twice when loading. + (WebCore::FrameLoader::finishedLoadingDocument): add closeURL() to compensate for change above. + +2009-10-13 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Pavel Feldman. + + Fix a leak in the inspector by calling didRemoveNode with + an error code when it fails, instead of returning from the + Backend. + + * inspector/InspectorBackend.cpp: + (WebCore::InspectorBackend::removeNode): + * inspector/front-end/ElementsTreeOutline.js: + +2009-10-13 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <https://bugs.webkit.org/show_bug.cgi?id=30337>. + Web Inspector: Should be able to delete nodes from the Elements Tree. + + When the delete key is pressed and a element is selected in the tree, + the element should be deleted from the Elements Tree and the DOM. + + * inspector/InspectorBackend.cpp: + (WebCore::InspectorBackend::removeNode): + * inspector/InspectorBackend.h: + * inspector/InspectorBackend.idl: + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::didRemoveNode): + * inspector/InspectorFrontend.h: + * inspector/front-end/ElementsPanel.js: + (WebInspector.ElementsPanel.prototype._updateModifiedNodes): + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): + +2009-10-13 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fix REGRESSION(49479): Mouseover on resources graph doesn't show timings. + + Set pointer-events: none on the new overlay so mouseover events are passed + to the resources graph so we can show timings. + + * inspector/front-end/inspector.css: + +2009-10-13 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Simon Hausmann. + + [Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead. + + This is a bug for two reasons: + 1. Everytime we use winId(), we end up creating a native widget. This causes an + unnecessary copy of contents from the backing store to the native widget. + 2. Neither windowed nor windowless plugins require the winId of the QWebView or + QGraphicsView. + + Introduce ownerWidget() which returns a QWidget * without creating a native widget + (as opposed to QWidget::find(winId)). + + https://bugs.webkit.org/show_bug.cgi?id=30170 + + * platform/qt/PlatformScreenQt.cpp: + (WebCore::screenDepthPerComponent): + * platform/qt/PopupMenuQt.cpp: + (WebCore::PopupMenu::show): + * platform/qt/QWebPageClient.h: + * plugins/qt/PluginViewQt.cpp: + (WebCore::setSharedXEventFields): + (WebCore::PluginView::initXEvent): + (WebCore::PluginView::getValue): + (WebCore::PluginView::platformStart): + +2009-10-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Unreviewed build system fix. Typo in a filename. + + * GNUmakefile.am: + +2009-10-12 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Timothy Hatcher. + Alter profile link format to enable multiple profile types + https://bugs.webkit.org/show_bug.cgi?id=30253 + + The new profile URL includes the profile type along with the + profile title and uid. + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::addProfileFinishedMessageToConsole): + (WebCore::InspectorController::addStartProfilingMessageToConsole): + * inspector/front-end/inspector.js: + (WebInspector.documentClick.followLink): + (WebInspector.documentClick): + (WebInspector.linkifyStringAsFragment): + +2009-10-12 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Timothy Hatcher. + + Fix same-named profiles grouping in the Profiles panel. + + The tree node re-parenting while adding a new group node was broken. + + https://bugs.webkit.org/show_bug.cgi?id=30299 + + * inspector/front-end/ProfilesPanel.js: + (WebInspector.ProfilesPanel.prototype.addProfile): + +2009-10-12 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Enforce async interaction between inspector controller and frontend. + + https://bugs.webkit.org/show_bug.cgi?id=30300 + + * inspector/front-end/inspector.js: + (WebInspector.dispatch.delayDispatch): + (WebInspector.dispatch): + +2009-10-12 Xiaomei Ji <xji@chromium.org> + + Reviewed by Sam Weinig. + + Fix issue caretRangeFromPoint() returns wrong result for a zoomed and + scrolled page. + https://bugs.webkit.org/show_bug.cgi?id=30034 + + * dom/Document.cpp: + (WebCore::Document::elementFromPoint): calculate the correct point + relative to document when the page is zoomed and scrolled. + (WebCore::Document::caretRangeFromPoint): calculate the correct point + relative to document when the page is zoomed and scrolled. + +2009-10-12 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by Sam Weinig. + + JavaScript bindings of WebSocket addEventListener/removeEventListener + https://bugs.webkit.org/show_bug.cgi?id=29841 + + Test: fast/websockets/websocket-event-target.html + + * bindings/js/JSWebSocketCustom.cpp: + (WebCore::JSWebSocket::addEventListener): + (WebCore::JSWebSocket::removeEventListener): + * bindings/v8/custom/V8CustomBinding.h: + * bindings/v8/custom/V8WebSocketCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * websockets/WebSocket.idl: + +2009-10-12 Sam Weinig <sam@webkit.org> + + Reviewed by Darin Adler. + + Fix for https://bugs.webkit.org/show_bug.cgi?id=29078 + <rdar://problem/7288221> + + Add a mechanism to blacklist certain codecs. Initially, just blacklist UTF-7 as HTML5 encourages. + + * platform/text/TextEncodingRegistry.cpp: + (WebCore::pruneBlacklistedCodecs): + (WebCore::buildBaseTextCodecMaps): + (WebCore::extendTextCodecMaps): + +2009-10-09 Dave Hyatt <hyatt@apple.com> + + Reviewed by Darin Adler. + + Add support for the beforeload event to frames. Complete support of the beforeload event by making sure + its wrapper gets properly constructed (so that the URL field of the event can be accessed). Add support + for the Objective-C wrapper class as well. + + Added fast/dom/beforeload/frame-before-load.html + + * WebCore.xcodeproj/project.pbxproj: + * bindings/js/JSEventCustom.cpp: + (WebCore::toJS): + * bindings/objc/DOMEvents.mm: + (kitClass): + * dom/BeforeLoadEvent.h: + (WebCore::BeforeLoadEvent::isBeforeLoadEvent): + * dom/Event.cpp: + (WebCore::Event::isBeforeLoadEvent): + * dom/Event.h: + * html/HTMLFrameElementBase.cpp: + (WebCore::HTMLFrameElementBase::parseMappedAttribute): + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::loadWithDocumentLoader): + +2009-10-12 Dan Bernstein <mitz@apple.com> + + Reviewed by Simon Fraser. + + Fix <rdar://problem/7094146> Reproducible crash at + RenderObject::localToAbsolute() + + Test: fast/dynamic/position-absolute-to-fixed-crash.html + + The crash was caused by stale positioned objects lists following an + object transitioning from being absolutely position to being fixed + positioned. + + * rendering/RenderBox.cpp: + (WebCore::RenderBox::styleWillChange): In case of a transition between + absolute and fixed position, mark the parent as having a child needing + layout, so that this object will get inserted into its new container's + positioned objects list. + * rendering/RenderObject.cpp: + (WebCore::RenderObject::styleWillChange): Changed a condition to cover + this transition, so that this object gets removed from its current + container's positioned objects list. + +2009-10-12 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Simon Hausmann. + + Add a palette() method that is needed by our RenderTheme. + + * platform/qt/QWebPageClient.h: + +2009-10-12 Dirk Schulze <krit@webkit.org> + + Reviewed by Nikolas Zimmermann. + + SVG Gradients can't handle percentage values in userSpaceOnUse mode + [https://bugs.webkit.org/show_bug.cgi?id=30286] + + Fixed *GradientAttributes to take SVGLength instead of double. This casues + the problem, that we can't calculate the correct size of a gradient on + userSpaceOnUse mode with percentage values. + + Test: svg/custom/gradient-userSpaceOnUse-with-percentage.svg + + * svg/LinearGradientAttributes.h: + (WebCore::LinearGradientAttributes::LinearGradientAttributes): + (WebCore::LinearGradientAttributes::x1): + (WebCore::LinearGradientAttributes::y1): + (WebCore::LinearGradientAttributes::x2): + (WebCore::LinearGradientAttributes::y2): + (WebCore::LinearGradientAttributes::setX1): + (WebCore::LinearGradientAttributes::setY1): + (WebCore::LinearGradientAttributes::setX2): + (WebCore::LinearGradientAttributes::setY2): + * svg/RadialGradientAttributes.h: + (WebCore::RadialGradientAttributes::RadialGradientAttributes): + (WebCore::RadialGradientAttributes::cx): + (WebCore::RadialGradientAttributes::cy): + (WebCore::RadialGradientAttributes::r): + (WebCore::RadialGradientAttributes::fx): + (WebCore::RadialGradientAttributes::fy): + (WebCore::RadialGradientAttributes::setCx): + (WebCore::RadialGradientAttributes::setCy): + (WebCore::RadialGradientAttributes::setR): + (WebCore::RadialGradientAttributes::setFx): + (WebCore::RadialGradientAttributes::setFy): + * svg/SVGLinearGradientElement.cpp: + (WebCore::SVGLinearGradientElement::buildGradient): + (WebCore::SVGLinearGradientElement::collectGradientProperties): + * svg/SVGRadialGradientElement.cpp: + (WebCore::SVGRadialGradientElement::buildGradient): + (WebCore::SVGRadialGradientElement::collectGradientProperties): + +2009-10-12 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <http://webkit.org/b/30315>. + Web Inspector: DOM Content and Load lines in Resources are unclear what they mean. + + Add tooltip text to the Load event and DOM Content event lines through + a new layer that allows these lines to be on top of the view. + + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): + (WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition): + * inspector/front-end/inspector.css: + +2009-10-12 Dimitri Glazkov <dglazkov@chromium.org> + + No review, rolling out r49429, because it broke layout tests. + http://trac.webkit.org/changeset/49429 + + * bindings/v8/V8AbstractEventListener.cpp: + (WebCore::V8AbstractEventListener::~V8AbstractEventListener): + +2009-10-12 Dirk Schulze <krit@webkit.org> + + Reviewed by Eric Seidel. + + SVG - crash on feMerge when input not available + [https://bugs.webkit.org/show_bug.cgi?id=30297] + + Make a early return in SVGFEMergeElement if the needed + filter effect doesn't exist. + + Test: svg/filters/feMerge-wrong-input.svg + + * svg/SVGFEMergeElement.cpp: + (WebCore::SVGFEMergeElement::build): + +2009-10-12 Chris Marrin <cmarrin@apple.com> + + Reviewed by Oliver Hunt. + + Added automatic flush before compositing + https://bugs.webkit.org/show_bug.cgi?id=30236 + + This causes image to always render correctly. In writing a testcase + I needed to implement readPixels. This exposed a bug in reading back + values from a CanvasArray subclass, so I fixed that as well. Now when + you wrap a CanvasArray in a JSValue it actually wraps the specific + subclass. To do this I need to add virtual methods to each CanvasArray + subclass to determine the type and a custom toJS method for CanvasArray + to create the proper wrapper. + + Test: fast/canvas/webgl/triangle.html + + * WebCore.xcodeproj/project.pbxproj: + * bindings/js/JSCanvasArrayCustom.cpp: + (WebCore::toJS): + * html/canvas/CanvasArray.h: + (WebCore::CanvasArray::isByteArray): + (WebCore::CanvasArray::isUnsignedByteArray): + (WebCore::CanvasArray::isShortArray): + (WebCore::CanvasArray::isUnsignedShortArray): + (WebCore::CanvasArray::isIntArray): + (WebCore::CanvasArray::isUnsignedIntArray): + (WebCore::CanvasArray::isFloatArray): + * html/canvas/CanvasArray.idl: + * html/canvas/CanvasByteArray.h: + (WebCore::CanvasByteArray::isByteArray): + * html/canvas/CanvasFloatArray.h: + (WebCore::CanvasFloatArray::isFloatArray): + * html/canvas/CanvasIntArray.h: + (WebCore::CanvasIntArray::isIntArray): + * html/canvas/CanvasRenderingContext3D.cpp: + (WebCore::CanvasRenderingContext3D::readPixels): + * html/canvas/CanvasRenderingContext3D.h: + * html/canvas/CanvasRenderingContext3D.idl: + * html/canvas/CanvasShortArray.h: + (WebCore::CanvasShortArray::isShortArray): + * html/canvas/CanvasUnsignedByteArray.h: + (WebCore::CanvasUnsignedByteArray::isUnsignedByteArray): + * html/canvas/CanvasUnsignedIntArray.h: + (WebCore::CanvasUnsignedIntArray::isUnsignedIntArray): + * html/canvas/CanvasUnsignedShortArray.h: + (WebCore::CanvasUnsignedShortArray::isUnsignedShortArray): + * platform/graphics/GraphicsContext3D.h: + * platform/graphics/mac/Canvas3DLayer.mm: + (-[Canvas3DLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): + * platform/graphics/mac/GraphicsContext3DMac.cpp: + (WebCore::GraphicsContext3D::readPixels): + +2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk> + + Reviewed by Gustavo Noronha. + + https://bugs.webkit.org/show_bug.cgi?id=30307 + + Fix 0 sentinel for g_object_set() function call. + + * platform/graphics/gtk/DataSourceGStreamer.cpp: + (webkit_data_src_uri_set_uri): + 0 is passed as 32 bit value on x86-64 in vararg functions, but + g_object_set() expects a 64 bit 0. This will cause crashes. + +2009-10-12 Cameron McCormack <cam@mcc.id.au> + + Reviewed by Eric Seidel. + + Drop in="" from <feFlood> + https://bugs.webkit.org/show_bug.cgi?id=29001 + + This makes <feFlood in="bogus"> have an effect, too. + + http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute + + Test: svg/dom/feFlood-no-in1.html + + * svg/SVGFEFloodElement.cpp: + (WebCore::SVGFEFloodElement::SVGFEFloodElement): + (WebCore::SVGFEFloodElement::build): + * svg/SVGFEFloodElement.h: + * svg/SVGFEFloodElement.idl: + * svg/graphics/filters/SVGFEFlood.cpp: + (WebCore::FEFlood::FEFlood): + (WebCore::FEFlood::create): + * svg/graphics/filters/SVGFEFlood.h: + +2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk> + + Reviewed by Gustavo Noronha. + + https://bugs.webkit.org/show_bug.cgi?id=29998 + + Scale video to completely fill the target surface while + keeping the aspect ratio. This fixes displaying of the + YouTube HTML5 sample website. + + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + Scale video to completely fill the target surface, keep + the aspect ratio and center it. + +2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk> + + Reviewed by Gustavo Noronha. + + https://bugs.webkit.org/show_bug.cgi?id=29997 + + Fixes double memcpy of all rendered video frames. + + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::mediaPlayerPrivateRepaintCallback): + (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): + (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): + (WebCore::MediaPlayerPrivate::duration): + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: + * platform/graphics/gtk/VideoSinkGStreamer.cpp: + (webkit_video_sink_timeout_func): + (webkit_video_sink_dispose): + (unlock_buffer_mutex): + (webkit_video_sink_unlock): + (marshal_VOID__MINIOBJECT): + (webkit_video_sink_class_init): + (webkit_video_sink_new): + * platform/graphics/gtk/VideoSinkGStreamer.h: + Directly pass the buffers up to the MediaPlayerPrivate::paint() + method instead of rendering them first to an intermediate cairo + surface. This should increase performance and peak memory usage. + +2009-10-11 Daniel Bates <dbates@webkit.org> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=30242 + + Fixes an issue where JavaScript URLs that are URL-encoded twice can + bypass the XSSAuditor. + + JavaScript URLs that are completed by method Document::completeURL have added + URL-encoded characters such that a direct comparison with the URL-decoded + outgoing HTTP parameters is not sufficient. Instead, the URL-decoded outgoing + HTTP parameters must be URL-decoded before comparison. + + Tests: http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html + http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html + http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html + + * bindings/ScriptControllerBase.cpp: + (WebCore::ScriptController::executeIfJavaScriptURL): Modified to pass XSSAuditor + the URL-decoded source code for the JavaScript URL. + * page/XSSAuditor.cpp: + (WebCore::isIllegalURICharacter): Minor syntactical change to the comment. + (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): Added + parameter decodeURLEscapeSequencesTwice. + (WebCore::XSSAuditor::canEvaluateJavaScriptURL): + (WebCore::XSSAuditor::decodeURL): Ditto. + (WebCore::XSSAuditor::findInRequest): Ditto. + * page/XSSAuditor.h: + (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): Ditto. + +2009-10-11 Dominic Cooney <dominicc@google.com> + + Reviewed by Adam Barth. + + Fixes a build break in the V8 bindings caused by revision 49420. + https://bugs.webkit.org/show_bug.cgi?id=30294 + + Revision 49420 introduces an IDL-defined CanvasActiveInfo + type. This causes a build break in the V8 bindings where + CanvasGraphicsContext3D naively refers to CanvasActiveInfo as a + non-ref type. + + * WebCore.gypi: Include CanvasActiveInfo.idl in build. + * bindings/scripts/CodeGeneratorV8.pm: CanvasActiveInfo is a ref + ptr type. + * bindings/v8/DOMObjectsInclude.h: Include generated + CanvasActiveInfo files. + * bindings/v8/DerivedSourcesAllInOne.cpp: + * bindings/v8/V8Index.cpp: + * bindings/v8/V8Index.h: + +2009-10-11 Collin Jackson <collinj@webkit.org> + + Reviewed by Adam Barth. + + Log mixed content warnings to console + + https://bugs.webkit.org/show_bug.cgi?id=30290 + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::checkIfDisplayInsecureContent): + (WebCore::FrameLoader::checkIfRunInsecureContent): + +2009-10-11 Søren Gjesse <sgjesse@chromium.org> + + Reviewed by Adam Barth. + + [V8] Add a context scope in JS listener destructor. The destructor code uses the cotext. See http://crbug.com/24200. + https://bugs.webkit.org/show_bug.cgi?id=30250 + + * bindings/v8/V8AbstractEventListener.cpp: + (WebCore::V8AbstractEventListener::~V8AbstractEventListener): + +2009-10-11 Lyon Chen <lyon.chen@torchmobile.com> + + Reviewed by Alexey Proskuryakov. + + Correct the position of #endif sentence inside WebCore::Document::finishedParsing(). + + https://bugs.webkit.org/show_bug.cgi?id=30244 + + This change requires no test case as it fix a compiling error. + + * dom/Document.cpp: + (WebCore::Document::finishedParsing): + +2009-10-11 Dominic Cooney <dominicc@google.com> + + Reviewed by Adam Barth. + + Sets a 500K stack limit for JavaScript workers in Chromium. + https://bugs.webkit.org/show_bug.cgi?id=29797 + + Runaway recursion in JavaScript workers crashes the Chromium + worker process on OS X. This is because V8's default stack limit + is 512K on ia32 or 1M on x64, but the worker process runs workers + on a thread with the OS X default stack size--512K. Because there + are already some C+frames on the stack when V8 establishes its + 512K default stack limit, and V8 doesn't precisely enforce the + stack limit, runaway recursion in V8 workers overflows the OS + stack and segfaults, killing the worker process. This is described + in Chromium bug 21653 <http://crbug.com/21653>. + + This patch sets the V8 stack limit for worker JavaScript in + Chromium to a more conservative 500K on all platforms. This allows + some "headroom" for the C+stack in use when the limit is set up, + and some "legroom" for the V8 helper functions which in practice + briefly flout the V8 stack limit. + + Test: LayoutTests/fast/workers/use-machine-stack.html + + * bindings/v8/WorkerContextExecutionProxy.cpp: + (WebCore::WorkerContextExecutionProxy::initV8IfNeeded): + * bindings/v8/WorkerContextExecutionProxy.h: + +2009-10-11 Kevin Ollivier <kevino@theolliviers.com> + + wx build fix for wxMac 2.9, use wxGC API for measuring text. + + * platform/wx/wxcode/mac/carbon/fontprops.cpp: + (GetTextExtent): + +2009-10-10 Cameron McCormack <cam@mcc.id.au> + + Reviewed by Sam Weinig. + + Allow [Reflect] on SVG elements. + https://bugs.webkit.org/show_bug.cgi?id=28936 + + Update the JS binding generators to reference SVGNames instead of + HTMLNames, if [Reflect]ing an attribute on an SVG element. Make + SVGElement::id use [Reflect]. + + Also make [Reflect] on an attribute with a setter exception work in ObjC + bindings. + + Test: svg/dom/id-reflect.html + + * bindings/scripts/CodeGenerator.pm: Add a function to determine the + appropriate C+namespace for attribute name constants. + * bindings/scripts/CodeGeneratorObjC.pm: Generate ExceptionCode handling + code for [Reflect] on an attribute with a setter exception. + * bindings/scripts/CodeGeneratorCOM.pm: Generate "SVGNames" instead of + "HTMLNames" when appropriate. + * bindings/scripts/CodeGeneratorJS.pm: Ditto. + * bindings/scripts/CodeGeneratorV8.pm: Ditto. + * svg/SVGElement.cpp: Remove getter and setter methods for id. + * svg/SVGElement.h: Ditto. + * svg/SVGElement.idl: Add [Reflect] to id. + +2009-10-10 Oliver Hunt <oliver@apple.com> + + Fix paths in xcode. + + * WebCore.xcodeproj/project.pbxproj: + +2009-10-10 Oliver Hunt <oliver@apple.com> + + Reviewed by Eric Carlson. + + Implement getActiveAttrib and getActiveUniform + https://bugs.webkit.org/show_bug.cgi?id=30276 + + Implements the getActiveAttrib and getActiveUniform APIs. + Rather simple patch, adds CanvasActiveInfo definition and implementation + and adds forwarding to the GraphicsContext3D. + + Test: fast/canvas/webgl/getActiveTest.html + + * DerivedSources.make: + * WebCore.xcodeproj/project.pbxproj: + * html/canvas/CanvasActiveInfo.h: Added. + (WebCore::CanvasActiveInfo::create): + (WebCore::CanvasActiveInfo::name): + (WebCore::CanvasActiveInfo::type): + (WebCore::CanvasActiveInfo::size): + (WebCore::CanvasActiveInfo::CanvasActiveInfo): + * html/canvas/CanvasActiveInfo.idl: Added. + * html/canvas/CanvasObject.h: + (WebCore::CanvasObject::context): + Need to make the context public as it is needed to ensure we don't + provide a program from one context as an argument to another. + * html/canvas/CanvasRenderingContext3D.cpp: + (WebCore::CanvasRenderingContext3D::getActiveAttrib): + (WebCore::CanvasRenderingContext3D::getActiveUniform): + * html/canvas/CanvasRenderingContext3D.h: + * html/canvas/CanvasRenderingContext3D.idl: + * platform/graphics/GraphicsContext3D.h: + * platform/graphics/mac/GraphicsContext3DMac.cpp: + (WebCore::GraphicsContext3D::getActiveAttrib): + (WebCore::GraphicsContext3D::getActiveUniform): + +2009-10-10 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Adding new attributes in Element Panel is + counterintuitive. + + https://bugs.webkit.org/show_bug.cgi?id=30057 + + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeOutline.prototype._onmousemove): + (WebInspector.ElementsTreeElement.prototype.set hovered): + (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): + +2009-10-10 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Holger Freyther. + + Build fix if Netscape plugin support is turned off + https://bugs.webkit.org/show_bug.cgi?id=30275 + + In addition to fixing the build break with guards + remove notImplemented() from PluginViewNone.cpp and + make them just just be empty functions. + + * plugins/PluginView.cpp: + (WebCore::PluginView::handleEvent): + (WebCore::PluginView::PluginView): + * plugins/PluginView.h: + * plugins/PluginViewNone.cpp: + (WebCore::PluginView::setFocus): + (WebCore::PluginView::show): + (WebCore::PluginView::hide): + (WebCore::PluginView::paint): + (WebCore::PluginView::handleKeyboardEvent): + (WebCore::PluginView::handleMouseEvent): + (WebCore::PluginView::setParent): + (WebCore::PluginView::setNPWindowRect): + (WebCore::PluginView::handlePostReadFile): + (WebCore::PluginView::getValue): + (WebCore::PluginView::getValueStatic): + (WebCore::PluginView::invalidateRect): + (WebCore::PluginView::invalidateRegion): + (WebCore::PluginView::forceRedraw): + (WebCore::PluginView::platformStart): + (WebCore::PluginView::platformDestroy): + (WebCore::PluginView::setParentVisible): + (WebCore::PluginView::updatePluginWidget): + +2009-10-10 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Unreviewed. + + [Qt] Build fix for QtWebKit after r49415. + + Add HistoryController.cpp to the build. + + * WebCore.pro: + +2009-10-09 Darin Fisher <darin@chromium.org> + + Reviewed by Eric Seidel. + + [Chromium] KURLGoogle's protocolIs barfs on input containing hyphens + https://bugs.webkit.org/show_bug.cgi?id=30262 + + This is not testable from WebKit since WebKit never uses the member + function form of protocolIs with input that can be controlled from a + web page. It always passes string literals lacking hyphens. + + * platform/KURLGoogle.cpp: + (WebCore::lowerCaseEqualsASCII): Only assert if toASCIILower would + transform the input character. + +2009-10-10 Adam Barth <abarth@webkit.org> + + Reviewed by Oliver Hunt. + + Move HistoryController to its own file + https://bugs.webkit.org/show_bug.cgi?id=30272 + + Purely mechanical. + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * WebCoreSources.bkl: + * loader/FrameLoader.cpp: + * loader/FrameLoader.h: + * loader/HistoryController.cpp: Added. + * loader/HistoryController.h: Added. + +2009-10-09 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Eric Seidel. + + ApplyStyleCommand removes presentational tags even when not necessary + https://bugs.webkit.org/show_bug.cgi?id=28091 + + This patch updates implicitlyStyledElementShouldBeRemovedWhenApplyingStyle to return true + (triggering removal of tag) only if the style implicitly added by the element is not present in + the new style to apply. It also changes surroundNodeRangeWithElement so that it merges the + surrounding element when possible. applyTextDecorationStyle is modified so that it does not add + style span when the style attribute is empty. + + Test: editing/execCommand/toggle-style-3.html + + * editing/ApplyStyleCommand.cpp: + (WebCore::ApplyStyleCommand::shouldRemoveTextDecorationTag): Returns true if specified text + decoration is not present in the style to apply + (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): No longer + returns true if the tag is used in new style + (WebCore::ApplyStyleCommand::applyTextDecorationStyle): Does not add style-span when redundant + (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Merges the newly created element + with the surrounding identical elements + * editing/ApplyStyleCommand.h: + +2009-10-09 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Factor HistoryController out of FrameLoader + https://bugs.webkit.org/show_bug.cgi?id=30246 + + HistoryController is in charge of managing the current / previous / + provisional HistoryItems. The split isn't perfect, but it's a place to + start. I'll move HistoryController into its own file in another patch. + + * WebCore.base.exp: + * loader/FrameLoader.cpp: + (WebCore::HistoryController::HistoryController): + (WebCore::HistoryController::~HistoryController): + (WebCore::FrameLoader::FrameLoader): + (WebCore::FrameLoader::closeURL): + (WebCore::FrameLoader::begin): + (WebCore::HistoryController::restoreDocumentState): + (WebCore::HistoryController::setCurrentItem): + (WebCore::HistoryController::setProvisionalItem): + (WebCore::FrameLoader::loadURLIntoChildFrame): + (WebCore::FrameLoader::canCachePageContainingThisFrame): + (WebCore::FrameLoader::logCanCacheFrameDecision): + (WebCore::FrameLoader::scrollToAnchor): + (WebCore::FrameLoader::commitProvisionalLoad): + (WebCore::FrameLoader::transitionToCommitted): + (WebCore::FrameLoader::checkLoadCompleteForThisFrame): + (WebCore::FrameLoader::didFirstLayout): + (WebCore::HistoryController::updateForFrameLoadCompleted): + (WebCore::FrameLoader::frameLoadCompleted): + (WebCore::FrameLoader::detachFromParent): + (WebCore::FrameLoader::receivedMainResourceError): + (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): + (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): + (WebCore::HistoryController::addHistoryItemForFragmentScroll): + (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): + (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): + (WebCore::HistoryController::createHistoryItem): + (WebCore::FrameLoader::checkDidPerformFirstNavigation): + (WebCore::HistoryController::addBackForwardItemClippedAtTarget): + (WebCore::HistoryController::createHistoryItemTree): + (WebCore::HistoryController::saveScrollPositionAndViewStateToItem): + (WebCore::HistoryController::restoreScrollPositionAndViewState): + (WebCore::HistoryController::invalidateCurrentItemCachedPage): + (WebCore::HistoryController::saveDocumentState): + (WebCore::FrameLoader::loadItem): + (WebCore::HistoryController::urlsMatchItem): + (WebCore::HistoryController::goToItem): + (WebCore::HistoryController::recursiveGoToItem): + (WebCore::HistoryController::childFramesMatchItem): + (WebCore::HistoryController::updateForStandardLoad): + (WebCore::HistoryController::updateForClientRedirect): + (WebCore::HistoryController::updateForBackForwardNavigation): + (WebCore::HistoryController::updateForReload): + (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): + (WebCore::HistoryController::updateForCommit): + (WebCore::HistoryController::updateForAnchorScroll): + (WebCore::HistoryController::saveDocumentAndScrollState): + (WebCore::HistoryController::setCurrentItemTitle): + (WebCore::FrameLoader::didChangeTitle): + * loader/FrameLoader.h: + (WebCore::HistoryController::current): + (WebCore::HistoryController::provisional): + (WebCore::FrameLoader::policyChecker): + (WebCore::FrameLoader::history): + (WebCore::FrameLoader::creatingInitialEmptyDocument): + * page/Page.cpp: + (WebCore::Page::goToItem): + +2009-10-09 Alexey Proskuryakov <ap@apple.com> + + Unreviewed - fixing an obvious typo in my previous check-in. + + https://bugs.webkit.org/show_bug.cgi?id=30260 + <rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work + + Fixes existing tests (which I thought I had run the previous time). + + * platform/network/CredentialStorage.cpp: (WebCore::originsWithCredentials): Return the + set by reference. + +2009-10-09 David Levin <levin@chromium.org> + + Reviewed by Eric Seidel. + + [v8] Need change to V8WorkerContextEventListener::reportError signature to match the base class. + https://bugs.webkit.org/show_bug.cgi?id=30264 + + The base class method changed in r48884. + + Test: fast/worker/worker-script-error.html + + * bindings/v8/V8WorkerContextEventListener.cpp: + (WebCore::V8WorkerContextEventListener::reportError): + * bindings/v8/V8WorkerContextEventListener.h: + +2009-10-09 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Brady Eidson. + + https://bugs.webkit.org/show_bug.cgi?id=30260 + <rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work + + Tests: http/tests/xmlhttprequest/logout.html + http/tests/xmlhttprequest/re-login-async.html + http/tests/xmlhttprequest/re-login.html + + Fix several issues with existing credential handling code. + + * platform/network/CredentialStorage.cpp: + (WebCore::pathToDefaultProtectionSpaceMap): Changed the data structure to a simpler one. + (WebCore::originsWithCredentials): The reason for two-stage lookup above was that we didn't + want to iterate paths for origins that never had credentials associated with them. Changed + to use a separate HashSet for this. + (WebCore::pathToDefaultProtectionSpaceMap): The concept of default per-path credentials didn't + match the spec very well. UAs are supposed to deduce protection space from an URL, and then + use whichever credentials are known for this protection space. So, OriginToDefaultBasicCredentialMap + is now PathToDefaultProtectionSpaceMap. + (WebCore::protectionSpaceMapKeyFromURL): Factored out a helper that extracts a directory + URL from a given URL. These directory URLs are what we use as keys in PathToDefaultProtectionSpaceMap. + (WebCore::CredentialStorage::set): Updated for above changes. + (WebCore::findDefaultProtectionSpaceForURL): Factored out code iterating path length to find + a prefix in OriginToDefaultBasicCredentialMap. + (WebCore::CredentialStorage::set): Another version of set() can update credentials for a + URL default protection space. It does nothing if the given URL doesn't correspond to a known + protection space. + (WebCore::CredentialStorage::get): Renamed from getDefaultAuthenticationCredential. + + * platform/network/CredentialStorage.h: Made the distinction between methods that use a known + protection space and those that deduce one from URL more clear. + + * platform/network/mac/ResourceHandleMac.mm: + (WebCore::ResourceHandle::start): Update credentials before starting the request for real. + This makes the following pattern work: + var req = new XMLHttpRequest("GET", "logout.html", "logout", "logout"); // wrong credentials + req.send(""); + req.abort(); + Abort() is used here to avoid having UA present an auth dialog after getting a 401 response. + Note that one cannot log in using the same method, because there isn't a known protection + space for the URL yet in that case, so the added code has no effect. + (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Use a correct persistence for + calling receivedCredential(). This fixes logging in using an async XHR (withut abort(), of + course), and matches sync case. + (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): + Renamed getDefaultAuthenticationCredential() to get(). + + * platform/network/cf/ResourceHandleCFNet.cpp: + (WebCore::ResourceHandle::start): + (WebCore::WebCoreSynchronousLoader::load): + Same changes as in Mac code. + +2009-10-09 Enrica Casucci <enrica@apple.com> + + Reviewed by Adele Peterson. + + Undoing a indent removes text instead of it's formatting. + <rdar://problem/7169206> + https://bugs.webkit.org/show_bug.cgi?id=28722 + Restored the behavior prior to http://trac.webkit.org/changeset/46143. This change implemented the + indent command making simple DOM operation, without using moveParagraph which cause undo to be broken. + + Added editing/undo/undo-indent.html test. + + * editing/IndentOutdentCommand.cpp: + (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Restored. + (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Merged changes. + (WebCore::IndentOutdentCommand::indentIntoBlockquote): Restored. + (WebCore::IndentOutdentCommand::indentRegion): Restored and added call to updateLayout to + ensure TextIterator could correctly calculate the position starting from the index. + * editing/IndentOutdentCommand.h: Restored. + +2009-10-09 Jens Alfke <snej@chromium.org> + + Reviewed by Darin Adler. + + Optimization: Many StringImpl transformations are no-ops and should just return 'this' + https://bugs.webkit.org/show_bug.cgi?id=30186 + + Optimized StringImpl methods lower(), stripWhiteSpace() and simplifyWhiteSpace() to + detect no-ops and return this instead of creating a new instance. + Empirical testing shows that the majority of calls to these methods are no-ops, making + this worthwhile even if (in the case of lower()) the non-no-op case is slightly slowed. + Upper() is very rarely a no-op, so it wasn't worthwhile to optimize it. + + * platform/text/StringImpl.cpp: + (WebCore::StringImpl::lower): + (WebCore::StringImpl::upper): Just add a comment explaining why this wasn't optimized + (WebCore::StringImpl::stripWhiteSpace): + (WebCore::StringImpl::simplifyWhiteSpace): + +2009-10-09 Dirk Schulze <krit@webkit.org> + + Reviewed by Oliver Hunt. + + SVG Filter feGaussianBlur implementation is missing + [https://bugs.webkit.org/show_bug.cgi?id=28141] + + This is the implementation of GaussianBlur filter for SVG. + + There is already a test for feGaussianBlur + Test: svg/W3C-SVG-1.1/filters-gauss-01-b-w3c.svg + + Test: svg/filters/feGaussianBlur.svg + + * platform/graphics/filters/FilterEffect.cpp: + (WebCore::FilterEffect::FilterEffect): + * platform/graphics/filters/FilterEffect.h: + (WebCore::FilterEffect::isAlphaImage): + (WebCore::FilterEffect::setIsAlphaImage): + * platform/graphics/filters/SourceAlpha.cpp: + (WebCore::SourceAlpha::apply): + * svg/graphics/filters/SVGFEGaussianBlur.cpp: + (WebCore::boxBlur): + (WebCore::FEGaussianBlur::apply): + +2009-10-09 Philippe Normand <pnormand@igalia.com> + + Reviewed by Gustavo Noronha. + + [GTK] QoS support in the video sink + https://bugs.webkit.org/show_bug.cgi?id=29959 + + Removed the async buffer queue from the sink. Synchronize the + render method of the sink using a g_timeout_add() combined with a + gcond triggered when the buffer has been rendered. + Also fixed the video sink reference handling in the player, now + that the idle is not there anymore to mess up things. + + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): + (WebCore::MediaPlayerPrivate::createGSTPlayBin): + * platform/graphics/gtk/VideoSinkGStreamer.cpp: + (webkit_video_sink_init): + (webkit_video_sink_timeout_func): + (webkit_video_sink_render): + (webkit_video_sink_dispose): + (unlock_buffer_mutex): + (webkit_video_sink_unlock): + (webkit_video_sink_stop): + (webkit_video_sink_class_init): + +2009-10-09 Dirk Schulze <krit@webkit.org> + + Reviewed by Nikolas Zimmermann. + + feMorphology filter is not implemented + [https://bugs.webkit.org/show_bug.cgi?id=5863] + + Adds SVGFEMorphologyElement, for the SVG filter. It also fixes a bug + with the attribute "operator". It was only accessible via "_operator" + on JavaScript. + + Test: svg/dom/operatorAttribute.xhtml + + * DerivedSources.cpp: + * DerivedSources.make: + * GNUmakefile.am: + * WebCore.SVG.Filters.exp: + * WebCore.gypi: + * WebCore.pro: + * WebCore.xcodeproj/project.pbxproj: + * bindings/objc/DOM.mm: + (WebCore::createElementClassMap): + * bindings/objc/DOMSVG.h: + * bindings/scripts/CodeGeneratorJS.pm: + * bindings/scripts/CodeGeneratorObjC.pm: + * page/DOMWindow.idl: + * svg/SVGAllInOne.cpp: + * svg/SVGFECompositeElement.idl: + * svg/SVGFEMorphologyElement.cpp: Added. + (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement): + (WebCore::SVGFEMorphologyElement::~SVGFEMorphologyElement): + (WebCore::SVGFEMorphologyElement::setRadius): + (WebCore::SVGFEMorphologyElement::parseMappedAttribute): + (WebCore::SVGFEMorphologyElement::build): + * svg/SVGFEMorphologyElement.h: Added. + * svg/SVGFEMorphologyElement.idl: Added. + * svg/graphics/filters/SVGFEMorphology.cpp: + (WebCore::operator<<): + * svg/graphics/filters/SVGFEMorphology.h: + (WebCore::): + * svg/svgtags.in: + +2009-10-09 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Dimitri Glazkov. + + Fix Chromium breakage. + + https://bugs.webkit.org/show_bug.cgi?id=30104 + + * inspector/front-end/inspector.js: + (WebInspector.addCookieDomain): check that Storage panel is present before calling its methods. + 2009-10-09 Joe Ligman <joseph.ligman@nokia.com> Reviewed by Simon Hausmann. @@ -8,6 +8493,1156 @@ * platform/qt/QWebPageClient.h: +2009-10-08 Dave Hyatt <hyatt@apple.com> + + Reviewed by Darin Adler. + + Implement beforeload for images. ImageLoadEventSender has been refactored into a more generic + ImageEventSender that can be used by both load and beforeload events. If the document has any + beforeload listeners, then the installation of images onto the renderer becomes asynchronous + and will be held up until the beforeload event can fire at a later date. + + Both beforeload and load events now fire at the end of the tokenizer write() methods, so that + in the typical parsing case we don't have to put off the beforeload/load events until after + a layout or paint might already have happened. This lets beforeload/load not cause extra + layouts and repaints. + + * dom/ContainerNode.cpp: + (WebCore::ContainerNode::dispatchBeforeLoadEvent): + * dom/Document.cpp: + (WebCore::Document::implicitClose): + (WebCore::Document::addListenerTypeIfNeeded): + * dom/Document.h: + (WebCore::Document::): + * dom/XMLTokenizer.cpp: + (WebCore::XMLTokenizer::write): + * html/HTMLImageElement.cpp: + (WebCore::HTMLImageElement::attach): + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::attach): + * html/HTMLTokenizer.cpp: + (WebCore::HTMLTokenizer::write): + * loader/ImageLoader.cpp: + (WebCore::ImageBeforeLoadEventSender::ImageBeforeLoadEventSender): + (WebCore::ImageLoadEventSender::ImageLoadEventSender): + (WebCore::beforeLoadEventSender): + (WebCore::ImageLoader::ImageLoader): + (WebCore::ImageLoader::~ImageLoader): + (WebCore::ImageLoader::setImage): + (WebCore::ImageLoader::setLoadingImage): + (WebCore::ImageLoader::updateFromElement): + (WebCore::ImageLoader::notifyFinished): + (WebCore::ImageLoader::dispatchPendingBeforeLoadEvent): + (WebCore::ImageLoader::dispatchPendingEvents): + (WebCore::ImageEventSender::ImageEventSender): + (WebCore::ImageEventSender::dispatchEventSoon): + (WebCore::ImageEventSender::cancelEvent): + (WebCore::ImageEventSender::dispatchPendingEvents): + (WebCore::ImageEventSender::timerFired): + * loader/ImageLoader.h: + (WebCore::ImageLoader::haveFiredBeforeLoadEvent): + * wml/WMLImageElement.cpp: + (WebCore::WMLImageElement::attach): + +2009-10-09 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Dimitri Glazkov. + + Web Inspector: Wrap Database into ScriptObject in v8 bindings. + + https://bugs.webkit.org/show_bug.cgi?id=30174 + + No tests due to no Script* test infrastructure. + + * bindings/v8/ScriptObjectQuarantine.cpp: + (WebCore::getQuarantinedScriptObject): + +2009-10-09 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Simon Hausmann. + + [Qt] Windowless Plugins : Fix crash when using QWebPage without QWebView. + + 'client' is 0 when we have no view. + + https://bugs.webkit.org/show_bug.cgi?id=30251 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::paint): + +2009-10-09 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Simon Hausmann. + + [Qt] Plugins : Add missing setCurrentPlugin(0) + + https://bugs.webkit.org/show_bug.cgi?id=30248 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::dispatchNPEvent): + +2009-10-09 Jakub Wieczorek <faw217@gmail.com> + + Reviewed by Simon Hausmann. + + [Qt] beforeload event does not fire on script elements in XML + https://bugs.webkit.org/show_bug.cgi?id=30235 + + r49194 was lacking a change to XMLTokenizerQt.cpp, equivalent to the one + made in XMLTokenizerLibxml2.cpp. + + * dom/XMLTokenizerQt.cpp: + (WebCore::XMLTokenizer::parseEndElement): + +2009-10-09 Zoltan Horvath <zoltan@webkit.org> + + Reviewed by Darin Adler. + + Allow custom memory allocation control for WebCore's CSSParserValueList + https://bugs.webkit.org/show_bug.cgi?id=30249 + + Inherits CSSParserValueList class from FastAllocBase because it has + been instantiated by 'new' in WebCore/css/CSSGrammar.y:1271. + + * css/CSSParserValues.h: + +2009-10-09 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Simon Hausmann. + + [Qt] Windowless Plugins : Create Pixmap only when size changes. + + https://bugs.webkit.org/show_bug.cgi?id=30214 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::updatePluginWidget): + +2009-10-08 Jon Honeycutt <jhoneycutt@apple.com> + + Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking + for the existence of a PluginHalterDelegate. + + This fixes a leak of WebPluginHalterClients: + https://bugs.webkit.org/show_bug.cgi?id=30119. + + Reviewed by Dan Bernstein. + + * WebCore.base.exp: + Removed the export of WebCore::Settings::setPluginHalterEnabled(). + + * loader/EmptyClients.h: + (WebCore::EmptyPluginHalterClient::enabled): + + * page/Page.cpp: + (WebCore::Page::Page): + Remove initialization of m_pluginHalterClient, which was removed. If a + non-null PluginHalterClient was passed, create the PluginHalter, and + set its allowed run time. + + * page/Page.h: + Removed pluginHalterEnabledStateChanged() and m_pluginHalterClient. + + * page/PluginHalter.cpp: + (WebCore::PluginHalter::didStartPlugin): + Check whether the PluginHalterClient is enabled. + (WebCore::PluginHalter::didStopPlugin): + Ditto. + + * page/PluginHalter.h: + Made m_client an OwnPtr. + + * page/PluginHalterClient.h: + Added a function to return the enabled state. + + * page/Settings.cpp: + (WebCore::Settings::Settings): + Remove initialization of removed member. + + * page/Settings.h: + Removed settings for the enabled state of the PluginHalter; we now use + the existence of a WebPluginHalterDelegate to determine whether the + PluginHalter is enabled. + +2009-10-08 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Move executeScript from FrameLoader to ScriptController + https://bugs.webkit.org/show_bug.cgi?id=30200 + + These methods have virtually no interaction with FrameLoader. They + really seem like they ought to belong to ScriptController. + + * WebCore.base.exp: + * bindings/js/ScheduledAction.cpp: + (WebCore::ScheduledAction::execute): + * bindings/js/ScriptController.cpp: + (WebCore::ScriptController::ScriptController): + (WebCore::ScriptController::executeScript): + (WebCore::ScriptController::executeIfJavaScriptURL): + (WebCore::ScriptController::evaluate): + * bindings/js/ScriptController.h: + * bindings/v8/ScriptController.cpp: + (WebCore::ScriptController::ScriptController): + (WebCore::ScriptController::executeScript): + (WebCore::ScriptController::executeIfJavaScriptURL): + * bindings/v8/ScriptController.h: + * dom/XMLTokenizer.cpp: + (WebCore::XMLTokenizer::notifyFinished): + * dom/XMLTokenizerLibxml2.cpp: + (WebCore::XMLTokenizer::endElementNs): + * dom/XMLTokenizerQt.cpp: + (WebCore::XMLTokenizer::parseEndElement): + * html/HTMLTokenizer.cpp: + (WebCore::HTMLTokenizer::scriptExecution): + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::changeLocation): + (WebCore::FrameLoader::urlSelected): + (WebCore::FrameLoader::requestFrame): + (WebCore::FrameLoader::submitForm): + (WebCore::FrameLoader::replaceDocument): + * loader/FrameLoader.h: + * plugins/PluginView.cpp: + (WebCore::PluginView::performRequest): + +2009-10-08 Geoffrey Garen <ggaren@apple.com> + + Windows build fix: added missing #include. + + * ForwardingHeaders/runtime/StructureChain.h: Copied from WebCore/ForwardingHeaders/runtime/PropertyNameArray.h. + +2009-10-08 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <https://bugs.webkit.org/show_bug.cgi?id=30237>. + DOM Content and Load lines aren't shown if a page is loaded when the inspector is up. + + Make sure to call update script object if we have an InspectorFrontend to + call it on when we get one of the new events. + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::mainResourceFiredDOMContentEvent): + (WebCore::InspectorController::mainResourceFiredLoadEvent): + +2009-10-08 Geoffrey Garen <ggaren@apple.com> + + Build fix: updated for removal of Structure::markAggregate(). + + * bindings/js/JSDOMGlobalObject.cpp: + (WebCore::JSDOMGlobalObject::markChildren): + +2009-10-08 Jens Alfke <snej@chromium.org> + + Reviewed by Darin Adler. + + Make AtomicString create its StringImpl via create(), not the constructor, + so it gets allocated in a single heap block, saving memory and CPU cycles. + This eliminates two StringImpl constructors, making the remaining ones + unambiguous, so the "AdoptBuffer" parameter is no longer needed. + Added const attribute to UChar* in StringImpl constructor, eliminating the + need for several const_casts in calls to it. + StringImpl also unfriends AtomicString (OMG drama!!!) + https://bugs.webkit.org/show_bug.cgi?id=30141 + + * platform/text/AtomicString.cpp: + (WebCore::CStringTranslator::translate): Call StringImpl::create(). + (WebCore::UCharBufferTranslator::translate): Ditto. + (WebCore::HashAndCharactersTranslator::translate): Ditto. + * platform/text/StringImpl.cpp: + (WebCore::StringImpl::StringImpl): Remove unnecessary AdoptBuffer param. + (WebCore::StringImpl::adopt): Ditto. + (WebCore::StringImpl::createUninitialized): Ditto. + (WebCore::StringImpl::create): Ditto. + (WebCore::StringImpl::crossThreadString): Ditto. + * platform/text/StringImpl.h: + (WebCore::StringImpl::setHash): Used by AtomicString when creating StringImpls. + +2009-10-08 Anders Carlsson <andersca@apple.com> + + Reviewed by Sam Weinig. + + Remove the shouldLoadMediaElementURL frame loader client function. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::willLoadMediaElementURL): + +2009-10-08 John Gregg <johnnyg@google.com> + + Reviewed by Dimitri Glazkov. + + SVGURIReference Build problem for V8. An additional stale reference to SVGURIReference bindings + which wasn't exposed until a clean build. + https://bugs.webkit.org/show_bug.cgi?id=30217 + + No new tests, just a build fix. + + * bindings/v8/V8Index.cpp: + +2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com> + + Not reviewed. Sort XCode project file. + + * WebCore.xcodeproj/project.pbxproj: + +2009-10-08 Patrick Mueller <Patrick_Mueller@us.ibm.com> + + Reviewed by Timothy Hatcher. + + unselectable resources in resource panel + https://bugs.webkit.org/show_bug.cgi?id=30079 + + manual test added + + Also changed the way DnD for resources in the Resources panel is + handled. + + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourceSidebarTreeElement.prototype.onattach): + (WebInspector.ResourceSidebarTreeElement.prototype.ondragstart): + * manual-tests/inspector/duplicate-resource-urls.html: Added. + +2009-10-08 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <http://webkit.org/b/30233> + Local Storage and Cookies show Blank Titles on Local Files. + + If a local storage or cookies sidebar item has no domain, set the + title to "Local Files", because that is what it represents. + + * English.lproj/localizedStrings.js: + * inspector/front-end/StoragePanel.js: + (WebInspector.DOMStorageSidebarTreeElement.prototype.get mainTitle): + (WebInspector.CookieSidebarTreeElement.prototype.get mainTitle): + (WebInspector.CookieSidebarTreeElement.prototype.set mainTitle): + +2009-10-08 Dave Hyatt <hyatt@apple.com> + + Reviewed by Oliver Hunt. + + Fix failing media layout tests. Don't make beforeload block loads of objects that aren't in the + document, since video/audio (and images eventually too) can load when not in the document yet. + + * dom/ContainerNode.cpp: + (WebCore::ContainerNode::dispatchBeforeLoadEvent): + +2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Eric Seidel. + + Move SVGFitToViewBox ANIMATED_* macros in classes that inherit from it + https://bugs.webkit.org/show_bug.cgi?id=30230 + + This patch also devirtualizes viewBoxToViewTransform(), is it's superflous. + viewBoxToViewTransform() is now a simple static heper function in SVGFitToViewBox. + As a result, the SVGSVGElement::viewBoxToViewTransform() function now resuses the same logic. + + As side-effect this patch fixes svg/custom/linking-a-03-b-transform.svg, the return + statement in SVGSVGElement::viewBoxToViewTransform() was clearly wrong. + + * svg/SVGFitToViewBox.cpp: + (WebCore::SVGFitToViewBox::SVGFitToViewBox): + (WebCore::SVGFitToViewBox::viewBoxToViewTransform): + * svg/SVGFitToViewBox.h: + * svg/SVGMarkerElement.cpp: + (WebCore::SVGMarkerElement::SVGMarkerElement): + (WebCore::SVGMarkerElement::viewBoxToViewTransform): + * svg/SVGMarkerElement.h: + * svg/SVGPatternElement.cpp: + (WebCore::SVGPatternElement::SVGPatternElement): + (WebCore::SVGPatternElement::buildPattern): + * svg/SVGPatternElement.h: + * svg/SVGSVGElement.cpp: + (WebCore::SVGSVGElement::SVGSVGElement): + (WebCore::SVGSVGElement::viewBoxToViewTransform): + * svg/SVGSVGElement.h: + * svg/SVGSymbolElement.cpp: + (WebCore::SVGSymbolElement::SVGSymbolElement): + * svg/SVGSymbolElement.h: + * svg/SVGViewElement.cpp: + (WebCore::SVGViewElement::SVGViewElement): + * svg/SVGViewElement.h: + * svg/SVGViewSpec.cpp: + (WebCore::SVGViewSpec::SVGViewSpec): + * svg/SVGViewSpec.h: + +2009-10-08 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Jon Honeycutt. + + Correct a typo that fixes the resizing of columns in Cookie view when you + resize the Inspector window. + + * inspector/front-end/CookieItemsView.js: + (WebInspector.CookieItemsView.prototype.resize): + +2009-10-08 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Adam Roben. + + Fixes <https://bugs.webkit.org/show_bug.cgi?id=29811> + Text in Inspector's Styles gear menu is invisible. + + Adds a style rule for the option text and hr's in the gear menu, + to prevent them from being transparent. + + * inspector/front-end/inspector.css: + +2009-10-08 John Gregg <johnnyg@google.com> + + Reviewed by David Levin. + + Fix build problem with SVGURIReference in V8. + https://bugs.webkit.org/show_bug.cgi?id=30217 + + No new tests, just a build fix. + + * WebCore.gypi: + * bindings/v8/DerivedSourcesAllInOne.cpp: + +2009-10-07 Dave Hyatt <hyatt@apple.com> + + Reviewed by Eric Carlson. + + Make beforeload work on <video>/<audio> elements. + + Added fast/dom/beforeload/video-before-load.html + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::parseMappedAttribute): + (WebCore::HTMLMediaElement::selectMediaResource): + (WebCore::HTMLMediaElement::selectNextSourceChild): + +2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Eric Seidel. + + Move SVGExternalResourcesRequired ANIMATED_* macros in classes that inherit from it + https://bugs.webkit.org/show_bug.cgi?id=30218 + + The long term goal is to kill the need for the virtual contextElement() function in SVG code. + No change in functionality, thus no new tests. + + * svg/SVGAElement.cpp: + (WebCore::SVGAElement::SVGAElement): + * svg/SVGAElement.h: + * svg/SVGAnimationElement.cpp: + (WebCore::SVGAnimationElement::SVGAnimationElement): + * svg/SVGAnimationElement.h: + * svg/SVGCircleElement.cpp: + (WebCore::SVGCircleElement::SVGCircleElement): + * svg/SVGCircleElement.h: + * svg/SVGClipPathElement.cpp: + (WebCore::SVGClipPathElement::SVGClipPathElement): + * svg/SVGClipPathElement.h: + * svg/SVGCursorElement.cpp: + (WebCore::SVGCursorElement::SVGCursorElement): + * svg/SVGCursorElement.h: + * svg/SVGDefsElement.cpp: + (WebCore::SVGDefsElement::SVGDefsElement): + * svg/SVGDefsElement.h: + * svg/SVGEllipseElement.cpp: + (WebCore::SVGEllipseElement::SVGEllipseElement): + * svg/SVGEllipseElement.h: + * svg/SVGExternalResourcesRequired.cpp: + (WebCore::SVGExternalResourcesRequired::SVGExternalResourcesRequired): + * svg/SVGExternalResourcesRequired.h: + * svg/SVGFEImageElement.cpp: + (WebCore::SVGFEImageElement::SVGFEImageElement): + * svg/SVGFEImageElement.h: + * svg/SVGFilterElement.cpp: + (WebCore::SVGFilterElement::SVGFilterElement): + * svg/SVGFilterElement.h: + * svg/SVGFontElement.cpp: + (WebCore::SVGFontElement::SVGFontElement): + * svg/SVGFontElement.h: + * svg/SVGForeignObjectElement.cpp: + (WebCore::SVGForeignObjectElement::SVGForeignObjectElement): + * svg/SVGForeignObjectElement.h: + * svg/SVGGElement.cpp: + (WebCore::SVGGElement::SVGGElement): + * svg/SVGGElement.h: + * svg/SVGGradientElement.cpp: + (WebCore::SVGGradientElement::SVGGradientElement): + * svg/SVGGradientElement.h: + * svg/SVGImageElement.cpp: + (WebCore::SVGImageElement::SVGImageElement): + * svg/SVGImageElement.h: + * svg/SVGLineElement.cpp: + (WebCore::SVGLineElement::SVGLineElement): + * svg/SVGLineElement.h: + * svg/SVGMPathElement.cpp: + (WebCore::SVGMPathElement::SVGMPathElement): + * svg/SVGMPathElement.h: + * svg/SVGMarkerElement.cpp: + (WebCore::SVGMarkerElement::SVGMarkerElement): + * svg/SVGMarkerElement.h: + * svg/SVGMaskElement.cpp: + (WebCore::SVGMaskElement::SVGMaskElement): + * svg/SVGMaskElement.h: + * svg/SVGPathElement.cpp: + (WebCore::SVGPathElement::SVGPathElement): + * svg/SVGPathElement.h: + * svg/SVGPatternElement.cpp: + (WebCore::SVGPatternElement::SVGPatternElement): + * svg/SVGPatternElement.h: + * svg/SVGPolyElement.cpp: + (WebCore::SVGPolyElement::SVGPolyElement): + * svg/SVGPolyElement.h: + * svg/SVGRectElement.cpp: + (WebCore::SVGRectElement::SVGRectElement): + * svg/SVGRectElement.h: + * svg/SVGSVGElement.cpp: + (WebCore::SVGSVGElement::SVGSVGElement): + * svg/SVGSVGElement.h: + * svg/SVGScriptElement.cpp: + (WebCore::SVGScriptElement::SVGScriptElement): + * svg/SVGScriptElement.h: + * svg/SVGSwitchElement.cpp: + (WebCore::SVGSwitchElement::SVGSwitchElement): + * svg/SVGSwitchElement.h: + * svg/SVGSymbolElement.cpp: + (WebCore::SVGSymbolElement::SVGSymbolElement): + * svg/SVGSymbolElement.h: + * svg/SVGTextContentElement.cpp: + (WebCore::SVGTextContentElement::SVGTextContentElement): + * svg/SVGTextContentElement.h: + * svg/SVGUseElement.cpp: + (WebCore::SVGUseElement::SVGUseElement): + * svg/SVGUseElement.h: + * svg/SVGViewElement.cpp: + (WebCore::SVGViewElement::SVGViewElement): + * svg/SVGViewElement.h: + +2009-10-08 Dirk Schulze <krit@webkit.org> + + Reviewed by Darin Adler. + + SVG feComposite: operator over mixes up inputs + [https://bugs.webkit.org/show_bug.cgi?id=30205] + + SVG feComposite operator over mixed up the inputs. + The pixel-test svg/filters/feComposite.svg can already test this. + No new test result is needed as long as filters are disabled. + + * platform/graphics/filters/FEComposite.cpp: + (WebCore::FEComposite::apply): + +2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by George Staikos. + + Move SVGURIReference ANIMATED_* macros in classes that inherit from it + https://bugs.webkit.org/show_bug.cgi?id=30184 + + The long term goal is to kill the need for the virtual contextElement() function in SVG code. + No change in functionality, thus no new tests. + + * svg/SVGAElement.cpp: + (WebCore::SVGAElement::SVGAElement): + * svg/SVGAElement.h: + * svg/SVGAltGlyphElement.cpp: + (WebCore::SVGAltGlyphElement::SVGAltGlyphElement): + * svg/SVGAltGlyphElement.h: + * svg/SVGCursorElement.cpp: + (WebCore::SVGCursorElement::SVGCursorElement): + * svg/SVGCursorElement.h: + * svg/SVGFEImageElement.cpp: + (WebCore::SVGFEImageElement::SVGFEImageElement): + * svg/SVGFEImageElement.h: + * svg/SVGFilterElement.cpp: + (WebCore::SVGFilterElement::SVGFilterElement): + * svg/SVGFilterElement.h: + * svg/SVGForeignObjectElement.cpp: + (WebCore::SVGForeignObjectElement::SVGForeignObjectElement): + * svg/SVGForeignObjectElement.h: + * svg/SVGGradientElement.cpp: + (WebCore::SVGGradientElement::SVGGradientElement): + * svg/SVGGradientElement.h: + * svg/SVGImageElement.cpp: + (WebCore::SVGImageElement::SVGImageElement): + * svg/SVGImageElement.h: + * svg/SVGMPathElement.cpp: + (WebCore::SVGMPathElement::SVGMPathElement): + (WebCore::SVGMPathElement::pathElement): + * svg/SVGMPathElement.h: + * svg/SVGMaskElement.cpp: + (WebCore::SVGMaskElement::SVGMaskElement): + * svg/SVGMaskElement.h: + * svg/SVGPatternElement.cpp: + (WebCore::SVGPatternElement::SVGPatternElement): + * svg/SVGPatternElement.h: + * svg/SVGScriptElement.cpp: + (WebCore::SVGScriptElement::SVGScriptElement): + * svg/SVGScriptElement.h: + * svg/SVGTRefElement.cpp: + (WebCore::SVGTRefElement::SVGTRefElement): + * svg/SVGTRefElement.h: + * svg/SVGTextPathElement.cpp: + (WebCore::SVGTextPathElement::SVGTextPathElement): + * svg/SVGTextPathElement.h: + * svg/SVGURIReference.cpp: + (WebCore::SVGURIReference::SVGURIReference): + * svg/SVGURIReference.h: + * svg/SVGUseElement.cpp: + (WebCore::SVGUseElement::SVGUseElement): + * svg/SVGUseElement.h: + +2009-10-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] Re-add the QApplication::syncX() line for plugin windows removed + by r49169. Also changed the location of the sync just after the + creation instead of just before sending it to the plugin. + https://bugs.webkit.org/show_bug.cgi?id=25053 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::platformStart): + +2009-10-08 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + Inspector: NodeLists Don't Display Well in the Console + https://bugs.webkit.org/show_bug.cgi?id=28061 + + * inspector/front-end/InjectedScript.js: + (Object.type): + +2009-10-08 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Simon Hausmann. + + [Qt] Windowless plugins: Remove unnecessary XSync for opaque mode. + + The reason for the XSync was that the plugin would not know about the + Drawable. It turns out that the real reason behind this is that even + though XCreatePixmap returns a handle, this id is unknown to the server + until we flush the connection. + + So, move the XSync to right after we create the Pixmap. + + https://bugs.webkit.org/show_bug.cgi?id=30207 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::updatePluginWidget): + (WebCore::PluginView::paint): + +2009-10-07 Daniel Bates <dbates@webkit.org> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=30188 + + Fixes an issue where performing a non DHTML drag-and-drop operation + does not work as expected. For instance, dragging some selected text + to an external application, such as TextEdit. + + This issue was a regression that arose from patching bug #30107. + + This change is covered by the manual test: + drag-out-of-background-window.html + + * page/DragController.cpp: + (WebCore::DragController::startDrag): When performing a non-DHTML drag + operation then default to drag operations DragOperationGeneric and + DragOperationCopy according to similar functionality removed when fixing + bug #30107, see: + http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebHTMLView.mm?rev=48526#L3430 + +2009-10-07 Xan Lopez <xlopez@igalia.com> + + Fix more breakage in the GTKbuild. + + * GNUmakefile.am: + +2009-10-07 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Move PolicyChecker to it's own file + https://bugs.webkit.org/show_bug.cgi?id=30193 + + This is just moving code around and re-naming things. + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * loader/FrameLoader.cpp: + * loader/FrameLoader.h: + * loader/PolicyCallback.cpp: Added. + (WebCore::PolicyCallback::PolicyCallback): + (WebCore::PolicyCallback::~PolicyCallback): + (WebCore::PolicyCallback::clear): + (WebCore::PolicyCallback::set): + (WebCore::PolicyCallback::call): + (WebCore::PolicyCallback::clearRequest): + (WebCore::PolicyCallback::cancel): + * loader/PolicyCallback.h: Added. + (WebCore::PolicyCallback::request): + * loader/PolicyCheck.cpp: Removed. + * loader/PolicyCheck.h: Removed. + +2009-10-07 Joel Stanley <joel@jms.id.au> + + Reviewed by Mark Rowe. + + Include <limits> for std::numeric_limits. Required by gcc-4.4 + https://bugs.webkit.org/show_bug.cgi?id=30197 + + * html/canvas/CanvasByteArray.h: + * html/canvas/CanvasIntArray.h: + * html/canvas/CanvasShortArray.h: + * html/canvas/CanvasUnsignedByteArray.h: + * html/canvas/CanvasUnsignedIntArray.h: + * html/canvas/CanvasUnsignedShortArray.h: + +2009-10-07 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Factor PolicyChecker out of FrameLoader + https://bugs.webkit.org/show_bug.cgi?id=30155 + + This patch separates PolicyChecker from FrameLoader. Loader policy is + in change of managing the FrameLoaderClient callbacks. Ideally, it + shouldn't know anything about FrameLoader, but I couldn't quite remove + all knowledge (although we might be able to do more later). In a + future patch, I'll move PolicyChecker into a separate file. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::FrameLoader): + (WebCore::FrameLoader::loadURL): + (WebCore::FrameLoader::load): + (WebCore::FrameLoader::loadWithDocumentLoader): + (WebCore::PolicyChecker::handleUnimplementablePolicy): + (WebCore::PolicyChecker::cannotShowMIMEType): + (WebCore::PolicyChecker::PolicyChecker): + (WebCore::PolicyChecker::checkNavigationPolicy): + (WebCore::PolicyChecker::checkContentPolicy): + (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): + (WebCore::FrameLoader::stopAllLoaders): + (WebCore::PolicyChecker::cancelCheck): + (WebCore::PolicyChecker::stopCheck): + (WebCore::PolicyChecker::continueAfterContentPolicy): + (WebCore::PolicyChecker::continueLoadAfterWillSubmitForm): + (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): + (WebCore::FrameLoader::loadPostRequest): + (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): + (WebCore::PolicyChecker::checkNewWindowPolicy): + (WebCore::PolicyChecker::continueAfterNewWindowPolicy): + (WebCore::PolicyChecker::continueAfterNavigationPolicy): + (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): + * loader/FrameLoader.h: + (WebCore::PolicyChecker::loadType): + (WebCore::PolicyChecker::setLoadType): + (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy): + (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy): + (WebCore::FrameLoader::policy): + * loader/FrameLoaderClient.h: + * loader/MainResourceLoader.cpp: + (WebCore::MainResourceLoader::didCancel): + (WebCore::MainResourceLoader::willSendRequest): + (WebCore::MainResourceLoader::continueAfterContentPolicy): + (WebCore::MainResourceLoader::didReceiveResponse): + * svg/graphics/SVGImage.cpp: + (WebCore::SVGImage::dataChanged): + +2009-10-07 Geoffrey Garen <ggaren@apple.com> + + Reviewed by Oliver Hunt. + + Fixed <rdar://problem/5751979> Database code takes JSLock on secondary + thread, permanently slowing down JavaScript + + Changed callback objects to use a standard helper object. The helper + object ASSERTs that it is deleted on the main thread, so no lock is + required when unprotecting its members. It also centralizes some previously + duplicated code. + + Callback objects that might be deleted on a secondary thread use + callOnMainThread to delete their helper objects on the main thread. + + * WebCore.xcodeproj/project.pbxproj: + * bindings/js/JSCallbackData.cpp: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp. + (WebCore::JSCallbackData::deleteData): + (WebCore::JSCallbackData::invokeCallback): + * bindings/js/JSCallbackData.h: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp. + (WebCore::JSCallbackData::JSCallbackData): + (WebCore::JSCallbackData::~JSCallbackData): + (WebCore::JSCallbackData::callback): + * bindings/js/JSCustomPositionCallback.cpp: + (WebCore::JSCustomPositionCallback::JSCustomPositionCallback): + (WebCore::JSCustomPositionCallback::handleEvent): + * bindings/js/JSCustomPositionCallback.h: + * bindings/js/JSCustomPositionErrorCallback.cpp: + (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback): + (WebCore::JSCustomPositionErrorCallback::handleEvent): + * bindings/js/JSCustomPositionErrorCallback.h: + * bindings/js/JSCustomSQLStatementCallback.cpp: + (WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback): + (WebCore::JSCustomSQLStatementCallback::~JSCustomSQLStatementCallback): + (WebCore::JSCustomSQLStatementCallback::handleEvent): + * bindings/js/JSCustomSQLStatementCallback.h: + * bindings/js/JSCustomSQLStatementErrorCallback.cpp: + (WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback): + (WebCore::JSCustomSQLStatementErrorCallback::~JSCustomSQLStatementErrorCallback): + (WebCore::JSCustomSQLStatementErrorCallback::handleEvent): + * bindings/js/JSCustomSQLStatementErrorCallback.h: + * bindings/js/JSCustomSQLTransactionCallback.cpp: + (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): + (WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback): + (WebCore::JSCustomSQLTransactionCallback::handleEvent): + * bindings/js/JSCustomSQLTransactionCallback.h: + * bindings/js/JSCustomSQLTransactionErrorCallback.cpp: + (WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback): + (WebCore::JSCustomSQLTransactionErrorCallback::~JSCustomSQLTransactionErrorCallback): + (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent): + * bindings/js/JSCustomSQLTransactionErrorCallback.h: + * bindings/js/JSCustomVoidCallback.cpp: + (WebCore::JSCustomVoidCallback::JSCustomVoidCallback): + (WebCore::JSCustomVoidCallback::~JSCustomVoidCallback): + (WebCore::JSCustomVoidCallback::handleEvent): + * bindings/js/JSCustomVoidCallback.h: + * storage/Database.cpp: + (WebCore::Database::Database): + +2009-10-07 Jens Alfke <snej@chromium.org> + + Reviewed by Dave Levin. + + Fix StringImpl::m_buffer + https://bugs.webkit.org/show_bug.cgi?id=30189 + + Fix my previous StringImpl patch to avoid using an indefinite-length array member, + since MSVC doesn't like it. Instead, go back to offsetting by sizeof(StringImpl). + + * platform/text/StringImpl.cpp: + (WebCore::StringImpl::StringImpl): + (WebCore::StringImpl::createUninitialized): + * platform/text/StringImpl.h: + (WebCore::StringImpl::bufferIsInternal): + +2009-10-07 Aaron Boodman <aa@chromium.org> + + Reviewed by Adam Barth. + + Update isolated worlds under v8 to support world reuse. + https://bugs.webkit.org/show_bug.cgi?id=30145 + + * bindings/v8/ScriptController.cpp: + Replace evaluateInNewIsolatedWorld() withe evaluateInIsolatedWorld(id). + (WebCore::ScriptController::evaluateInIsolatedWorld): + * bindings/v8/ScriptController.h: Ditto. + * bindings/v8/V8Proxy.cpp: Ditto. + (WebCore::V8Proxy::~V8Proxy): Dittio. + (WebCore::V8Proxy::evaluateInIsolatedWorld): Ditto. + * bindings/v8/V8Proxy.h: Ditto. + * bindings/v8/V8IsolatedWorld.cpp: + Add support for controlling lifetime of a world, rather than relying on GC. + (WebCore::V8IsolatedWorld::contextWeakReferenceCallback): Ditto. + (WebCore::V8IsolatedWorld::V8IsolatedWorld): Ditto. + (WebCore::V8IsolatedWorld::destroy): Ditto. + * bindings/v8/V8IsolatedWorld.h: Ditto. + +2009-10-07 Jeremy Orlow <jorlow@chromium.org> + + Build fix for http://trac.webkit.org/changeset/49272 on Windows + + * platform/text/StringImpl.h: + +2009-10-07 Jens Alfke <snej@chromium.org> + + Reviewed by Darin Adler. + + Optimization of StringImpl: + - Remove unnecessary m_bufferIsInternal member (saves 4 bytes). Instead, check whether + m_data points to just past the end of the object's members. + - copy() and createWithTerminatingNullCharacter() create the string in a single malloc + block instead of 2 (saves ~20 bytes and considerable CPU cycles, increases locality). + - Move m_length next to m_hash to save 4 bytes of padding in 64-bit builds. + + https://bugs.webkit.org/show_bug.cgi?id=29500 + + * platform/text/StringImpl.cpp: + (WebCore::StringImpl::StringImpl): Re-ordered members. + (WebCore::StringImpl::~StringImpl): Change to is-buffer-internal check. + (WebCore::StringImpl::createUninitialized): Use new m_buffer member instead of sizeof() + to ensure chars are copied to correct location. + (WebCore::StringImpl::createWithTerminatingNullCharacter): Make sure copy is created + in a single malloc block. + (WebCore::StringImpl::threadsafeCopy): Make sure copy is created in a single malloc block. + (WebCore::StringImpl::crossThreadString): Make sure copy is created in a single malloc block. + (WebCore::StringImpl::sharedBuffer): Change to is-buffer-internal check. + * platform/text/StringImpl.h: + (WebCore::StringImpl::startsWith): Just fixed a confusing param name. + (WebCore::StringImpl::bufferIsInternal): Changed member var into accessor method. + (WebCore::StringImpl::m_data): Repositioned for optimal member packing in 64-bit. + (WebCore::StringImpl::m_buffer): Added to provide an explicit location for where internal buffer goes. + +2009-10-07 Daniel Bates <dbates@webkit.org> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=30102 + And + <rdar://problem/5015957> + + Manual test to confirm that the not-allowed cursor is shown for an + invalid drag-and-drop operation. + + We cannot test this using DRT because of a discrepancy between the Windows + API-based drop effect and the WebKit drop effect. See bug #24731 for more + details. + + * manual-tests/drag-cursor-notallowed.html: Added. + +2009-10-07 Mark Rowe <mrowe@apple.com> + + Fix the build. + + * WebCore.xcodeproj/project.pbxproj: + +2009-10-07 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <http://webkit.org/b/30104>. + Inspector should show cookies of sub-resources on the page. + + This function implements showing cookies for all sub-resources of a page. + When the page is loaded, it populates the Storage Panel with a list of all + domains that were loaded as part of the full page load (iframes, ads, etc). + When the user selects one of the domains, the inspector calls back into the + controller, and the controller combines all of the cookies from that domain + into a list, and sends that list is sent back to the controller to render. + + A domain now needs to be passed into CookieItemsView, and CookieSidebarTreeElement. + + As a result of a previous patch, we now have detailed cookie information for + both Windows on CFNetwork and Mac. Additionally, this patch provides deleteCookie + support on Windows. + + * bindings/js/ScriptObject.cpp: + (WebCore::ScriptObject::set): + * bindings/js/ScriptObject.h: + * inspector/InspectorBackend.cpp: + (WebCore::InspectorBackend::getCookies): + (WebCore::InspectorBackend::deleteCookie): + * inspector/InspectorBackend.h: + * inspector/InspectorBackend.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::populateScriptObjects): + (WebCore::InspectorController::didFinishLoading): + (WebCore::InspectorController::getCookies): + (WebCore::InspectorController::buildArrayForCookies): + (WebCore::InspectorController::buildObjectForCookie): + (WebCore::InspectorController::deleteCookie): + * inspector/InspectorController.h: + * inspector/InspectorDOMAgent.cpp: + * inspector/InspectorDOMAgent.h: + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::addCookieDomainForDocument): + * inspector/InspectorFrontend.h: + * inspector/front-end/CookieItemsView.js: + (WebInspector.CookieItemsView): + (WebInspector.CookieItemsView.prototype.update): + (WebInspector.CookieItemsView.prototype._deleteButtonClicked): + * inspector/front-end/DOMAgent.js: + (WebInspector.Cookies.getCookiesAsync): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel): + (WebInspector.StoragePanel.prototype.reset): + (WebInspector.StoragePanel.prototype.addCookieDomain): + (WebInspector.StoragePanel.prototype.showCookies): + (WebInspector.CookieSidebarTreeElement): + (WebInspector.CookieSidebarTreeElement.prototype.onselect): + * inspector/front-end/inspector.js: + (WebInspector.addCookieDomain): + * platform/Cookie.h: + (WebCore::CookieHash::hash): + (WebCore::CookieHash::equal): + (WTF::): + * platform/network/win/CookieJarCFNetWin.cpp: + (WebCore::deleteCookie): + +2009-10-07 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Add ScriptObject::set(const char*, unsigned). + + https://bugs.webkit.org/show_bug.cgi?id=30104 + + * bindings/v8/ScriptObject.cpp: + (WebCore::ScriptObject::set): + * bindings/v8/ScriptObject.h: + +2009-10-07 Brent Fulgham <bfulgham@webkit.org> + + Unreviewed build fix for Windows (Cairo). + + Provide implementation of new BitmapImage::create that was + added in @r49060. + + * platform/graphics/win/ImageCairoWin.cpp: + +2009-10-07 Andrew Scherkus <scherkus@chromium.org> + + Reviewed by Eric Carlson. + + Refactor RenderThemeChromiumMac and RenderThemeChromiumSkia to render media controls using GraphicsContext. + + Design was based on existing RenderMediaControls.cpp used by RenderThemeSafari/Win. + + https://bugs.webkit.org/show_bug.cgi?id=29987 + + Covered by existing layout tests as no new functionality was introduced. + + * WebCore.gypi: Added RenderMediaControlsChromium.cpp/h. + * css/mediaControlsChromium.css: Tweaked media slider position and border style. + * rendering/MediaControlElements.cpp: + (WebCore::toParentMediaElement): Taken from RenderMediaControls. + (WebCore::MediaControlElement::rendererIsNeeded): Don't call shouldRenderMediaControlPart() if element has no appearance. + (WebCore::MediaControlInputElement::rendererIsNeeded): Ditto. + * rendering/RenderMediaControls.cpp: Moved parentMediaElement() to MediaControlElements. + * rendering/RenderMediaControlsChromium.cpp: Added. + (WebCore::platformResource): Helper to load and cache media control image resources. + (WebCore::mediaSliderThumbImage): Implementation refactored from RenderThemeChromiumMac/Skia. + (WebCore::mediaVolumeSliderThumbImage): Ditto. + (WebCore::paintMediaButton): Ditto. + (WebCore::paintMediaMuteButton): Ditto. + (WebCore::paintMediaPlayButton): Ditto. + (WebCore::paintMediaSlider): Ditto. + (WebCore::paintMediaSliderThumb): Ditto. + (WebCore::paintMediaVolumeSlider): Ditto. + (WebCore::paintMediaVolumeSliderThumb): Ditto. + (WebCore::paintMediaTimelineContainer): Ditto. + (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Ditto. + (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Same + (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize): + * rendering/RenderMediaControlsChromium.h: Added. + * rendering/RenderThemeChromiumMac.h: + * rendering/RenderThemeChromiumMac.mm: + (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): Implementation delegated to RenderMediaControlsChromium. + (WebCore::RenderThemeChromiumMac::shouldRenderMediaControlPart): Ditto. + (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): Ditto. + (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): Ditto. + (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): Ditto. + (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): Ditto. + (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): Ditto. + (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): Ditto. + (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): Ditto. + * rendering/RenderThemeChromiumSkia.cpp: + (WebCore::RenderThemeChromiumSkia::paintMediaControlsBackground): Implementation delegated to RenderMediaControlsChromium. + (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack): Ditto. + (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): Ditto. + (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize): Ditto. + (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): Ditto. + (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): Ditto. + (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): Ditto. + (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): Ditto. + (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Ditto. + +2009-10-07 Dave Hyatt <hyatt@apple.com> + + Reviewed by Adam Roben. + + Make plugins work with beforeload. + + Added fast/dom/beforeload/flash-before-load.html + + * html/HTMLObjectElement.cpp: + (WebCore::HTMLObjectElement::parseMappedAttribute): + * rendering/RenderPartObject.cpp: + (WebCore::RenderPartObject::updateWidget): + +2009-10-07 Vitaly Repeshko <vitalyr@chromium.org> + + Reviewed by Adam Barth. + + [V8] Protect JS listener object from GC while clearing a property on it. + See http://crbug.com/23780. + https://bugs.webkit.org/show_bug.cgi?id=30137 + + * bindings/v8/V8AbstractEventListener.cpp: + (WebCore::V8AbstractEventListener::~V8AbstractEventListener): + +2009-10-07 Zoltan Horvath <zoltan@webkit.org> + + Rubber-stamped by Eric Seidel. + + Allow custom memory allocation control for WebCore's CachedResourceClient class + https://bugs.webkit.org/show_bug.cgi?id=30165 + + Inherits CachedResourceClient class from FastAllocBase because (its + child class) CSSFontFaceSource has been instantiated by 'new' in WebCore/css/CSSFontFaceSource.h:46. + + * loader/CachedResourceClient.h: + +2009-10-07 Zoltan Horvath <zoltan@webkit.org> + + Reviewed by Darin Adler. + + Allow custom memory allocation control for WebCore's IdentifierRep + https://bugs.webkit.org/show_bug.cgi?id=30159 + + Inherits IdentifierRep class from FastAllocBase because it has been + instantiated by 'new' in WebCore/bridge/IdentifierRep.cpp:61. + + * bridge/IdentifierRep.h: + +2009-10-07 Anton Muhin <antonm@chromium.org> + + Reviewed by Adam Barth. + + Fetch pointers to C+DOM window immediately from holder + object (do not search prototype chain for proper JS wrapper). + https://bugs.webkit.org/show_bug.cgi?id=29031 + + * bindings/scripts/CodeGeneratorV8.pm: + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::getTemplate): + * bindings/v8/V8Proxy.cpp: + (WebCore::V8Proxy::createNewContext): + (WebCore::V8Proxy::installDOMWindow): + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::ACCESSOR_GETTER): + (WebCore::ACCESSOR_SETTER): + (WebCore::INDEXED_PROPERTY_GETTER): + (WebCore::NAMED_PROPERTY_GETTER): + (WebCore::NAMED_ACCESS_CHECK): + (WebCore::INDEXED_ACCESS_CHECK): +2009-10-07 Adam Roben <aroben@apple.com> + + Fix typo in PluginView::load that was causing cross-origin loads to + be allowed + + This typo was introduced in the build fix in r49213. + + Fixes <http://webkit.org/b/30168> REGRESSION (r49213): + http/tests/plugins/local-geturl-from-remote.html is failing on Windows + + Reviewed by Sam Weinig. + + * plugins/PluginView.cpp: + (WebCore::PluginView::load): Removed a comma operator that was making + a condition always evaluate to true. + +2009-10-07 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Simon Hausmann. + + Do not create valid QColor's for invalid WebCore::Color's. + + * platform/graphics/qt/ColorQt.cpp: + (WebCore::Color::operator QColor): + 2009-10-07 Janne Koskinen <janne.p.koskinen@digia.com> Reviewed by Simon Hausmann. @@ -20,6 +9655,3817 @@ * WebCore.pro: +2009-10-07 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Migrate database inspection to the injected script-based schema. + + https://bugs.webkit.org/show_bug.cgi?id=29788 + + * bindings/js/JSInspectorBackendCustom.cpp: + (WebCore::JSInspectorBackend::databaseForId): + * bindings/v8/custom/V8CustomBinding.h: + * bindings/v8/custom/V8InspectorBackendCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * inspector/InspectorBackend.cpp: + (WebCore::InspectorBackend::dispatchOnInjectedScript): + (WebCore::InspectorBackend::databaseForId): + (WebCore::InspectorBackend::selectDatabase): + (WebCore::InspectorBackend::getDatabaseTableNames): + (WebCore::InspectorBackend::reportDidDispatchOnInjectedScript): + * inspector/InspectorBackend.h: + * inspector/InspectorBackend.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::populateScriptObjects): + (WebCore::InspectorController::resetScriptObjects): + (WebCore::InspectorController::selectDatabase): + (WebCore::InspectorController::databaseForId): + (WebCore::InspectorController::didOpenDatabase): + (WebCore::InspectorController::didUseDOMStorage): + (WebCore::InspectorController::selectDOMStorage): + (WebCore::InspectorController::getDOMStorageResourceForId): + * inspector/InspectorController.h: + * inspector/InspectorDatabaseResource.cpp: + (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): + (WebCore::InspectorDatabaseResource::bind): + * inspector/InspectorDatabaseResource.h: + (WebCore::InspectorDatabaseResource::database): + (WebCore::InspectorDatabaseResource::id): + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::addDatabase): + (WebCore::InspectorFrontend::selectDatabase): + (WebCore::InspectorFrontend::didGetDatabaseTableNames): + (WebCore::InspectorFrontend::addDOMStorage): + * inspector/InspectorFrontend.h: + * inspector/front-end/Database.js: + (WebInspector.Database): + (WebInspector.Database.prototype.get id): + (WebInspector.Database.prototype.set name): + (WebInspector.Database.prototype.set version): + (WebInspector.Database.prototype.set domain): + (WebInspector.Database.prototype.getTableNames): + (WebInspector.Database.prototype.executeSql): + * inspector/front-end/InjectedScript.js: + (InjectedScript.dispatch): + (InjectedScript.executeSql): + (InjectedScript.executeSql.errorCallback): + (InjectedScript.executeSql.queryTransaction): + * inspector/front-end/InjectedScriptAccess.js: + (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): + (InjectedScriptAccess._installHandler): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel.prototype.selectDatabase): + (WebInspector.StoragePanel.prototype.dataGridForResult): + * inspector/front-end/inspector.js: + (WebInspector.addDatabase): + +2009-10-07 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Simon Hausmann. + + [Qt] Windowless Plugins: Disable content propagation for QGraphicsView items + + We cannot support content propagation for items in QGraphicsView because + the contents of the backing store might be transformed. So turn it off + if we are not painting on QWidget. + + Note that this check will not work for a QWebView in a + QGraphicsProxyWidget, but I guess it's fine. Alternative is to do an + even uglier cast: static_cast painter's paintDevice() to QWidget and + check if it is the viewport() of QGraphicsView. + + https://bugs.webkit.org/show_bug.cgi?id=30149 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::paint): + +2009-10-07 Simon Hausmann <simon.hausmann@nokia.com> + + Fix the Qt build by adding the missing files to the build. + + * WebCore.pro: + +2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Reviewed by Xan Lopez. + + Fix incorrect convertion of double into int while assigning it to + a float. + + * platform/graphics/gtk/SimpleFontDataGtk.cpp: + (WebCore::SimpleFontData::platformInit): + * platform/graphics/gtk/SimpleFontDataPango.cpp: + (WebCore::SimpleFontData::platformInit): + +2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Reviewed by Xan Lopez. + + Fix rounding error issues in height calculation in 64 bits. + + Already covered by existing tests. + + * platform/graphics/gtk/SimpleFontDataGtk.cpp: + (WebCore::SimpleFontData::platformInit): + * platform/graphics/gtk/SimpleFontDataPango.cpp: + (WebCore::SimpleFontData::platformInit): + +2009-10-07 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by Eric Seidel. + + Dual lines in css2.1 layout tests do not match: + https://bugs.webkit.org/show_bug.cgi?id=23262 + + Now we can put a counter node as the next sibling of a reset node. + Re-layout the counter content when the count is updated. + + Tests: fast/css/counters/t1204-increment-00-c-o.html + fast/css/counters/t1204-increment-01-c-o.html + + * rendering/CounterNode.cpp: + (WebCore::CounterNode::recount): + * rendering/RenderCounter.cpp: + (WebCore::findPlaceForCounter): + +2009-10-06 Xan Lopez <xlopez@igalia.com> + + Try to fix the GTKbuild. + + * GNUmakefile.am: + +2009-10-06 Adam Barth <abarth@webkit.org> + + Reviewed by Adam Barth. + + Removed unused member variable from FrameLoader + https://bugs.webkit.org/show_bug.cgi?id=30146 + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::FrameLoader): + * loader/FrameLoader.h: + +2009-10-06 David Levin <levin@chromium.org> + + Reviewed by NOBODY (build fix). + + A few small/trivial tweaks to the last build fix. + + * bindings/scripts/CodeGeneratorV8.pm: + +2009-10-06 David Levin <levin@chromium.org> + + Reviewed by Dimitri Glazkov. + + [Chromium] Need to adjust MessagePort, etc. code for the post clone work done. + https://bugs.webkit.org/show_bug.cgi?id=30147 + + No change in functionality so no new tests. + + * WebCore.gypi: + * bindings/scripts/CodeGeneratorV8.pm: + * bindings/v8/SerializedScriptValue.h: Added. + A very simple implementation of SerializedScriptValue + that only works for strings. + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8MessageEventCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8MessagePortCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8WorkerCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + +2009-10-06 Sam Weinig <sam@webkit.org> + + Reviewed by Brady Eidson. + + Fix for <rdar://problem/7271202> + Dispatch resource load delegate functions for the media element. + Since we don't get the required callbacks from the media engine, + just fake the parameters to the delegate functions as best as possible. + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::loadResource): + (WebCore::HTMLMediaElement::isSafeToLoadURL): + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::willLoadMediaElementURL): + * loader/FrameLoader.h: + +2009-10-06 Oliver Hunt <oliver@apple.com> + + Reviewed by NOBODY (Build fix). + + More build fixes. + + * bindings/js/SerializedScriptValue.cpp: + (WebCore::DeserializingTreeWalker::getProperty): + (WebCore::TeardownTreeWalker::getProperty): + * bindings/js/SerializedScriptValue.h: + (WebCore::SerializedScriptValue::SerializedScriptValue): + +2009-10-06 Oliver Hunt <oliver@apple.com> + + Reviewed by NOBODY (Build fix). + + Build and formatting fix. + + * ForwardingHeaders/runtime/ExceptionHelpers.h: Added. + * bindings/js/SerializedScriptValue.cpp: + * bindings/js/SerializedScriptValue.h: + (WebCore::SerializedScriptValueData::operator bool): + (WebCore::SerializedScriptValueData::release): + (WebCore::SerializedScriptValue::release): + (WebCore::SerializedScriptValue::toString): + (WebCore::SerializedScriptValue::~SerializedScriptValue): + (WebCore::SerializedScriptValue::SerializedScriptValue): + +2009-10-05 Oliver Hunt <oliver@apple.com> + + Reviewed by Gavin Barraclough. + + It should be possible to post (clone) built-in JS objects to Workers + https://bugs.webkit.org/show_bug.cgi?id=22878 + + Implement object cloning semantics for postMessage. Currently only + a partial implementation of the spec -- cloning of File, FileList, + ImageData, and RegExp were left out as they would have significantly + increased patch size. + + Cloning requires multiple tree walks so we use a templated tree + walk function, allowing us to share a single implementation for + serialization, deserialization, and eventual destruction of the + serialized object tree. + + Test: fast/dom/Window/window-postmessage-clone.html + + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * bindings/js/JSDOMWindowCustom.cpp: + (WebCore::JSDOMWindow::postMessage): + * bindings/js/JSMessageEventCustom.cpp: + (WebCore::JSMessageEvent::initMessageEvent): + * bindings/js/JSMessagePortCustom.h: + (WebCore::handlePostMessage): + * bindings/js/SerializedScriptValue.cpp: Added. + (WebCore::SerializedObject::set): + (WebCore::SerializedObject::names): + (WebCore::SerializedObject::values): + (WebCore::SerializedObject::create): + (WebCore::SerializedObject::clear): + (WebCore::SerializedObject::SerializedObject): + (WebCore::SerializedArray::setIndex): + (WebCore::SerializedArray::canDoFastRead): + (WebCore::SerializedArray::getIndex): + (WebCore::SerializedArray::getSparseIndex): + (WebCore::SerializedArray::length): + (WebCore::SerializedArray::create): + (WebCore::SerializedArray::clear): + (WebCore::SerializedArray::SerializedArray): + (WebCore::SerializedScriptValueData::SerializedScriptValueData): + (WebCore::SharedSerializedData::asArray): + (WebCore::SharedSerializedData::asObject): + (WebCore::): + (WebCore::walk): + (WebCore::BaseWalker::BaseWalker): + (WebCore::BaseWalker::shouldTerminate): + (WebCore::BaseWalker::ticksUntilNextCheck): + (WebCore::BaseWalker::didTimeOut): + (WebCore::BaseWalker::throwStackOverflow): + (WebCore::BaseWalker::throwInterruptedException): + (WebCore::SerializingTreeWalker::SerializingTreeWalker): + (WebCore::SerializingTreeWalker::null): + (WebCore::SerializingTreeWalker::isArray): + (WebCore::SerializingTreeWalker::isObject): + (WebCore::SerializingTreeWalker::asInputArray): + (WebCore::SerializingTreeWalker::asInputObject): + (WebCore::SerializingTreeWalker::createOutputArray): + (WebCore::SerializingTreeWalker::createOutputObject): + (WebCore::SerializingTreeWalker::length): + (WebCore::SerializingTreeWalker::canDoFastRead): + (WebCore::SerializingTreeWalker::getIndex): + (WebCore::SerializingTreeWalker::getSparseIndex): + (WebCore::SerializingTreeWalker::getProperty): + (WebCore::SerializingTreeWalker::convertIfTerminal): + (WebCore::SerializingTreeWalker::getPropertyNames): + (WebCore::SerializingTreeWalker::putIndex): + (WebCore::SerializingTreeWalker::putProperty): + (WebCore::SerializingTreeWalker::startArray): + (WebCore::SerializingTreeWalker::endArray): + (WebCore::SerializingTreeWalker::startObject): + (WebCore::SerializingTreeWalker::endObject): + (WebCore::SerializedScriptValueData::serialize): + (WebCore::DeserializingTreeWalker::DeserializingTreeWalker): + (WebCore::DeserializingTreeWalker::null): + (WebCore::DeserializingTreeWalker::isArray): + (WebCore::DeserializingTreeWalker::isObject): + (WebCore::DeserializingTreeWalker::asInputArray): + (WebCore::DeserializingTreeWalker::asInputObject): + (WebCore::DeserializingTreeWalker::createOutputArray): + (WebCore::DeserializingTreeWalker::createOutputObject): + (WebCore::DeserializingTreeWalker::length): + (WebCore::DeserializingTreeWalker::canDoFastRead): + (WebCore::DeserializingTreeWalker::getIndex): + (WebCore::DeserializingTreeWalker::getSparseIndex): + (WebCore::DeserializingTreeWalker::getProperty): + (WebCore::DeserializingTreeWalker::convertIfTerminal): + (WebCore::DeserializingTreeWalker::getPropertyNames): + (WebCore::DeserializingTreeWalker::putIndex): + (WebCore::DeserializingTreeWalker::putProperty): + (WebCore::DeserializingTreeWalker::startArray): + (WebCore::DeserializingTreeWalker::endArray): + (WebCore::DeserializingTreeWalker::startObject): + (WebCore::DeserializingTreeWalker::endObject): + (WebCore::SerializedScriptValueData::deserialize): + (WebCore::TeardownTreeWalker::shouldTerminate): + (WebCore::TeardownTreeWalker::ticksUntilNextCheck): + (WebCore::TeardownTreeWalker::didTimeOut): + (WebCore::TeardownTreeWalker::throwStackOverflow): + (WebCore::TeardownTreeWalker::throwInterruptedException): + (WebCore::TeardownTreeWalker::null): + (WebCore::TeardownTreeWalker::isArray): + (WebCore::TeardownTreeWalker::isObject): + (WebCore::TeardownTreeWalker::asInputArray): + (WebCore::TeardownTreeWalker::asInputObject): + (WebCore::TeardownTreeWalker::createOutputArray): + (WebCore::TeardownTreeWalker::createOutputObject): + (WebCore::TeardownTreeWalker::length): + (WebCore::TeardownTreeWalker::canDoFastRead): + (WebCore::TeardownTreeWalker::getIndex): + (WebCore::TeardownTreeWalker::getSparseIndex): + (WebCore::TeardownTreeWalker::getProperty): + (WebCore::TeardownTreeWalker::convertIfTerminal): + (WebCore::TeardownTreeWalker::getPropertyNames): + (WebCore::TeardownTreeWalker::putIndex): + (WebCore::TeardownTreeWalker::putProperty): + (WebCore::TeardownTreeWalker::startArray): + (WebCore::TeardownTreeWalker::endArray): + (WebCore::TeardownTreeWalker::startObject): + (WebCore::TeardownTreeWalker::endObject): + (WebCore::SerializedScriptValueData::tearDownSerializedData): + * bindings/js/SerializedScriptValue.h: Added. + (WebCore::SharedSerializedData::~SharedSerializedData): + (WebCore::SerializedScriptValueData::): + (WebCore::SerializedScriptValueData::type): + (WebCore::SerializedScriptValueData::~SerializedScriptValueData): + (WebCore::SerializedScriptValueData::SerializedScriptValueData): + (WebCore::SerializedScriptValueData::asImmediate): + (WebCore::SerializedScriptValueData::asDouble): + (WebCore::SerializedScriptValueData::asString): + (WebCore::SerializedScriptValueData::asObject): + (WebCore::SerializedScriptValueData::asArray): + (WebCore::SerializedScriptValueData::operator bool ): + (WebCore::SerializedScriptValueData::release): + (WebCore::SerializedScriptValue::create): + (WebCore::SerializedScriptValue::release): + (WebCore::SerializedScriptValue::toString): + (WebCore::SerializedScriptValue::deserialize): + (WebCore::SerializedScriptValue::~SerializedScriptValue): + (WebCore::SerializedScriptValue::SerializedScriptValue): + * bindings/scripts/CodeGeneratorJS.pm: + * bindings/scripts/CodeGeneratorObjC.pm: + * dom/MessageEvent.cpp: + (WebCore::MessageEvent::MessageEvent): + (WebCore::MessageEvent::initMessageEvent): + * dom/MessageEvent.h: + (WebCore::MessageEvent::create): + (WebCore::MessageEvent::data): + * dom/MessageEvent.idl: + * dom/MessagePort.cpp: + (WebCore::MessagePort::postMessage): + * dom/MessagePort.h: + * dom/MessagePortChannel.cpp: + (WebCore::MessagePortChannel::EventData::create): + (WebCore::MessagePortChannel::EventData::EventData): + * dom/MessagePortChannel.h: + (WebCore::MessagePortChannel::EventData::message): + * page/DOMWindow.cpp: + (WebCore::PostMessageTimer::PostMessageTimer): + (WebCore::DOMWindow::postMessage): + * page/DOMWindow.h: + * page/DOMWindow.idl: + * page/EventSource.cpp: + (WebCore::EventSource::createMessageEvent): + * websockets/WebSocket.cpp: + (WebCore::WebSocket::didReceiveMessage): + * workers/DedicatedWorkerContext.cpp: + (WebCore::DedicatedWorkerContext::postMessage): + * workers/DedicatedWorkerContext.h: + * workers/DedicatedWorkerContext.idl: + * workers/Worker.cpp: + (WebCore::Worker::postMessage): + * workers/Worker.h: + * workers/Worker.idl: + * workers/WorkerContextProxy.h: + * workers/WorkerMessagingProxy.cpp: + (WebCore::MessageWorkerContextTask::create): + (WebCore::MessageWorkerContextTask::MessageWorkerContextTask): + (WebCore::MessageWorkerTask::create): + (WebCore::MessageWorkerTask::MessageWorkerTask): + (WebCore::WorkerMessagingProxy::postMessageToWorkerObject): + (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): + * workers/WorkerMessagingProxy.h: + * workers/WorkerObjectProxy.h: + +2009-10-06 Adam Barth <abarth@webkit.org> + + Unreviewed build fix for Windows. + + * plugins/PluginView.cpp: + (WebCore::PluginView::load): + +2009-10-06 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Move FrameLoader::canLoad to SecurityOrigin + https://bugs.webkit.org/show_bug.cgi?id=30111 + + * WebCore.base.exp: + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::isSafeToLoadURL): + * loader/Cache.cpp: + (WebCore::Cache::requestResource): + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::loadSubframe): + (WebCore::FrameLoader::loadPlugin): + (WebCore::FrameLoader::loadFrameRequest): + (WebCore::FrameLoader::loadResourceSynchronously): + (WebCore::FrameLoader::createJavaAppletWidget): + * loader/FrameLoader.h: + * loader/SubresourceLoader.cpp: + (WebCore::SubresourceLoader::create): + * page/SecurityOrigin.cpp: + (WebCore::SecurityOrigin::canLoad): + (WebCore::SecurityOrigin::shouldHideReferrer): + * page/SecurityOrigin.h: + +2009-10-06 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Move setLocalLoadPolicy and friends to SecurityOrigin + https://bugs.webkit.org/show_bug.cgi?id=30110 + + These have more to do with security policies than with loading frames. + + * WebCore.base.exp: + * dom/Document.cpp: + (WebCore::Document::initSecurityContext): + * loader/Cache.cpp: + (WebCore::Cache::requestResource): + * loader/FrameLoader.cpp: + * loader/FrameLoader.h: + * loader/SubresourceLoader.cpp: + (WebCore::SubresourceLoader::create): + * page/SecurityOrigin.cpp: + (WebCore::SecurityOrigin::setLocalLoadPolicy): + (WebCore::SecurityOrigin::restrictAccessToLocal): + (WebCore::SecurityOrigin::allowSubstituteDataAccessToLocal): + * page/SecurityOrigin.h: + (WebCore::SecurityOrigin::): + +2009-10-06 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Brady Eidson. + + Preparation for <http://webkit.org/b/30104>. + Inspector should show cookies of sub-resources on the page. + + Implement getRawCookies for CFNetwork for Windows, so we can see more + than just a key/value pair for Cookies when we are on Windows. + + * platform/network/win/CookieJarCFNetWin.cpp: + (WebCore::getRawCookies): + +2009-10-06 Dave Hyatt <hyatt@apple.com> + + Reviewed by Adam Roben. + + https://bugs.webkit.org/show_bug.cgi?id=30132, make beforeload work with <link> elements and + XML processing instructions. + + Fix up ProcessingInstruction's setData call so that it actually updates a stylesheet when the + data gets changed. + + Move dispatchBeforeLoadedEvent to ContainerNode so all Elements (and ProcessingInstruction) can + access it. + + Added fast/dom/beforeload/link-before-load.html + + * dom/ContainerNode.cpp: + (WebCore::ContainerNode::dispatchBeforeLoadEvent): + * dom/ContainerNode.h: + * dom/ProcessingInstruction.cpp: + (WebCore::ProcessingInstruction::checkStyleSheet): + (WebCore::ProcessingInstruction::setData): + * dom/ScriptElement.cpp: + (WebCore::ScriptElementData::requestScript): + * dom/ScriptElement.h: + * dom/XMLTokenizerLibxml2.cpp: + (WebCore::XMLTokenizer::endElementNs): + * html/HTMLLinkElement.cpp: + (WebCore::HTMLLinkElement::parseMappedAttribute): + (WebCore::HTMLLinkElement::process): + * html/HTMLScriptElement.cpp: + (WebCore::HTMLScriptElement::forAttributeValue): + * html/HTMLScriptElement.h: + * svg/SVGScriptElement.cpp: + * svg/SVGScriptElement.h: + +2009-10-06 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Mark Rowe. + + accessibility/media-element.html crashes (and has incorrect result) + https://bugs.webkit.org/show_bug.cgi?id=30108 + + Fix up the accessibilty label for the newly added fullscreen button, + and update the test result accordingly. + + * accessibility/AccessibilityMediaControls.cpp: + (WebCore::AccessibilityMediaControl::controlTypeName): + +2009-10-06 Kelly Norton <knorton@google.com> + + Reviewed by Timothy Hatcher. + + Fixes <https://bugs.webkit.org/show_bug.cgi?id=30028> + Multiple calls to SetFrontendProxyObject can leave an InspectorTimelineAgent with an invalid + InspectorFrontend. + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::setFrontendProxyObject): Adds a check for an existing timeline agent. + +2009-10-06 Antti Koivisto <antti@apple.com> + + Reviewed by Dave Kilzer. + + Move textRects to the right category in DOM.mm. Include DOMPrivate.h to ensure that the interfaces match. + + * bindings/objc/DOM.mm: + (-[DOMNode textRects]): + +2009-10-06 Benjamin C Meyer <bmeyer@rim.com> + + Reviewed by Ariya Hidayat. + + Match the behavior of other WebKit browser and have the first url of the drag data be the url passed in declareAndWriteDragImage and set the text of the drag data to be the title argument. + + Manual test: Drag the readability js link from http://lab.arc90.com/experiments/readability/ + + * platform/qt/ClipboardQt.cpp: + (WebCore::ClipboardQt::declareAndWriteDragImage): + +2009-10-06 Kent Tamura <tkent@chromium.org> + + Reviewed by Darin Adler. + + Implement min/max attributes, ValidityState.rangeUnderflow and + ValidityState.rangeOverflow for <input type=number> and <input type=range> + https://bugs.webkit.org/show_bug.cgi?id=29069 + + HTMLInputElement::max and min are not defined for COM because they + conflict with the standard min() and max() macros. + + Tests: fast/forms/ValidityState-rangeOverflow-number.html + fast/forms/ValidityState-rangeOverflow-range.html + fast/forms/ValidityState-rangeUnderflow-number.html + fast/forms/ValidityState-rangeUnderflow-range.html + fast/forms/input-minmax.html + + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::rangeUnderflow): + (WebCore::HTMLInputElement::rangeOverflow): + (WebCore::HTMLInputElement::rangeMinimum): + (WebCore::HTMLInputElement::rangeMaximum): + * html/HTMLInputElement.h: + * html/HTMLInputElement.idl: + * html/ValidityState.cpp: + (WebCore::ValidityState::rangeUnderflow): + (WebCore::ValidityState::rangeOverflow): + * html/ValidityState.h: + * rendering/RenderSlider.cpp: + (WebCore::SliderRange::SliderRange): + (WebCore::SliderRange::valueFromElement): + +2009-10-06 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Move m_openedByDOM to Page + https://bugs.webkit.org/show_bug.cgi?id=30109 + + We only need one instance of m_openedByDOM per page, we should move it + to a page-scoped object. Notice that it's only ever touched for the + main frame. + + * bindings/js/JSDOMWindowCustom.cpp: + (WebCore::createWindow): + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::createWindow): + * loader/FrameLoader.cpp: + * loader/FrameLoader.h: + * page/DOMWindow.cpp: + (WebCore::DOMWindow::close): + * page/Page.cpp: + (WebCore::Page::Page): + (WebCore::Page::openedByDOM): + (WebCore::Page::setOpenedByDOM): + * page/Page.h: + +2009-10-06 Carol Szabo <carol.szabo@nokia.com> + + Reviewed by Ariya Hidayat. + + [Qt] Some functions in GraphicsContext do not work + as expected if the associated painter has no clipping. + https://bugs.webkit.org/show_bug.cgi?id=29691 + + No new tests are associated with this because DumpRenderTree + always sets clipping on the painter, thus it would never hit + the test case, but fast/box-shadow/basic-shadows.html is a + good example of what happens if the clipping is not set by + the user of QtWebKit. + + * platform/graphics/qt/GraphicsContextQt.cpp: + (WebCore::GraphicsContext::clipOut): + (WebCore::GraphicsContext::clipOutEllipseInRect): + Fixed to handle the case that there is no clipping + before the call. + +2009-10-06 Dave Hyatt <hyatt@apple.com> + + Reviewed by Adam Roben. + + https://bugs.webkit.org/show_bug.cgi?id=30131, make beforeload fire on script elements. + + Added tests in fast/dom/beforeload/. + + * dom/ScriptElement.cpp: + (WebCore::ScriptElementData::requestScript): + * dom/ScriptElement.h: + * dom/XMLTokenizerLibxml2.cpp: + (WebCore::XMLTokenizer::endElementNs): + * html/HTMLAttributeNames.in: + * html/HTMLScriptElement.cpp: + (WebCore::HTMLScriptElement::parseMappedAttribute): + (WebCore::HTMLScriptElement::dispatchBeforeLoadEvent): + * html/HTMLScriptElement.h: + * html/HTMLTokenizer.cpp: + (WebCore::HTMLTokenizer::scriptHandler): + * svg/SVGScriptElement.cpp: + (WebCore::SVGScriptElement::dispatchBeforeLoadEvent): + * svg/SVGScriptElement.h: + +2009-10-06 Xan Lopez <xlopez@igalia.com> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=25526 + [Gtk] Additional support is needed for caret browsing + + Enable caret movement commands also when caret browsing setting is + enabled. + + * editing/EditorCommand.cpp: + (WebCore::caretBrowsingEnabled): + (WebCore::enabledVisibleSelectionOrCaretBrowsing): + (WebCore::enabledInEditableTextOrCaretBrowsing): + (WebCore::CommandEntry::): + * manual-tests/gtk/caret-browsing.html: Added. + +2009-10-06 Anton Muhin <antonm@chromium> + + Reviewed by Dimitri Glazkov. + + Non standard, but popular exetension allows automagically + turn a function into a namespace resolver. Support that in + Chromium as well. + + Adjust CodeGeneratorV8 to treat XPathNSResolver in a special way. + https://bugs.webkit.org/show_bug.cgi?id=30128 + + * bindings/scripts/CodeGeneratorV8.pm: + * bindings/v8/V8DOMWrapper.h: + (WebCore::V8DOMWrapper::getXPathNSResolver): + * bindings/v8/custom/V8DocumentCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + +2009-10-06 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: close inspector client view on + InspectorController::close API call. + + In order to run batch web inspector layout tests (and not affect + subsequent tests) we should close inspector client's view upon + InspectorController::close API call. + + https://bugs.webkit.org/show_bug.cgi?id=30009 + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::inspectedPageDestroyed): + (WebCore::InspectorController::close): + +2009-10-06 Simon Hausmann <simon.hausmann@nokia.com> + + Reviewed by Tor Arne Vestbø. + + Fix the Qt/Windows build by stubbing out the still image + support for halted plugins for the Qt build. + + Bugzilla entry https://bugs.webkit.org/show_bug.cgi?id=30130 + tracks removing this by implementing Frame::nodeImage(). + + * plugins/win/PluginViewWin.cpp: + (WebCore::PluginView::halt): + +2009-10-05 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Simon Hausmann. + + [Qt] Change QImageReader usage in ImageDecoderQt + https://bugs.webkit.org/show_bug.cgi?id=27538 + + Replace the ReadContext with another appoach to + reading the image. Attempt to only read meta information + like the image size and number of frames (for animations) + first and then when the page is getting drawn decode + the image with the QImageReader. + + This is a huge benefit on pages with many images and saves + ~2GB of memory on the szeged image test page. + + * platform/graphics/qt/ImageDecoderQt.cpp: + (WebCore::ImageDecoderQt::ImageDecoderQt): + (WebCore::ImageDecoderQt::setData): + (WebCore::ImageDecoderQt::isSizeAvailable): + (WebCore::ImageDecoderQt::frameCount): + (WebCore::ImageDecoderQt::repetitionCount): + (WebCore::ImageDecoderQt::filenameExtension): + (WebCore::ImageDecoderQt::frameBufferAtIndex): + (WebCore::ImageDecoderQt::clearFrameBufferCache): + (WebCore::ImageDecoderQt::internalDecodeSize): + (WebCore::ImageDecoderQt::internalReadImage): + (WebCore::ImageDecoderQt::internalHandleCurrentImage): + (WebCore::ImageDecoderQt::forceLoadEverything): + (WebCore::ImageDecoderQt::failRead): + * platform/graphics/qt/ImageDecoderQt.h: + +2009-10-05 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Simon Hausmann. + + [Qt] Make use of RGBA32Buffer in ImageDecoderQt + https://bugs.webkit.org/show_bug.cgi?id=27538 + + Use the RGBA32Buffer instead of the internal ImageData + to be able to use support of the base class, optionally + support WebCore decoders for Qt and most importantly + separate metadata and image data for better cache control. + + Remove ImageSourceQt as everything is now shared with + the normal ImageSource. + + Change the ownership of the NativeImagePtr/QPixmap in + ImageQt.cpp to delete the m_frame to be subject to cache + control. + + * WebCore.pro: + * platform/graphics/ImageSource.cpp: + * platform/graphics/qt/ImageDecoderQt.cpp: + (WebCore::ImageDecoderQt::ReadContext::ReadContext): + (WebCore::ImageDecoderQt::ReadContext::read): + (WebCore::ImageDecoderQt::ReadContext::readImageLines): + (WebCore::ImageDecoderQt::ImageDecoderQt): + (WebCore::ImageDecoderQt::setData): + (WebCore::ImageDecoderQt::frameCount): + (WebCore::ImageDecoderQt::frameBufferAtIndex): + (WebCore::ImageDecoderQt::clearFrameBufferCache): + * platform/graphics/qt/ImageDecoderQt.h: + * platform/graphics/qt/ImageSourceQt.cpp: Removed. + * platform/image-decoders/ImageDecoder.h: + (WebCore::RGBA32Buffer::decodedImage): + (WebCore::RGBA32Buffer::getAddr): + * platform/image-decoders/qt/RGBA32BufferQt.cpp: Added. + (WebCore::RGBA32Buffer::RGBA32Buffer): + (WebCore::RGBA32Buffer::setDecodedImage): + (WebCore::RGBA32Buffer::clear): + (WebCore::RGBA32Buffer::zeroFill): + (WebCore::RGBA32Buffer::copyBitmapData): + (WebCore::RGBA32Buffer::setSize): + (WebCore::RGBA32Buffer::asNewNativeImage): + (WebCore::RGBA32Buffer::hasAlpha): + (WebCore::RGBA32Buffer::setHasAlpha): + (WebCore::RGBA32Buffer::setStatus): + (WebCore::RGBA32Buffer::operator=): + (WebCore::RGBA32Buffer::width): + (WebCore::RGBA32Buffer::height): + +2009-10-05 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Simon Hausmann. + + [Qt] ImageDecoderQt avoid QString creation. + https://bugs.webkit.org/show_bug.cgi?id=27538 + + Avoid going from CString to QString to String + and go directly from CString to String. Also + avoid going to lower case to avoid an extra + memory allocation. + + * platform/graphics/qt/ImageDecoderQt.cpp: + (WebCore::ImageDecoder::create): + (WebCore::ImageDecoderQt::ImageDecoderQt): + * platform/graphics/qt/ImageDecoderQt.h: + +2009-10-05 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Simon Hausmann. + + [Qt] Cleanup the ImageDecoder of Qt. + https://bugs.webkit.org/show_bug.cgi?id=27538 + + Remove the various enums for partial load. The fact is + that this image decoder will decode everything that is + in the file at once. Make it look like it behaves to + ease fixing this core problem. + + * platform/graphics/qt/ImageDecoderQt.cpp: + (WebCore::ImageDecoderQt::ImageData::ImageData): + (WebCore::ImageDecoderQt::ReadContext::ReadContext): + (WebCore::ImageDecoderQt::ReadContext::read): + (WebCore::ImageDecoderQt::ReadContext::readImageLines): + (WebCore::ImageDecoderQt::hasFirstImageHeader): + (WebCore::ImageDecoderQt::setData): + * platform/graphics/qt/ImageDecoderQt.h: + +2009-10-04 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Simon Hausmann. + + [Qt] Reimplement instead of overload frameCount in ImageDecoderQt.cpp + https://bugs.webkit.org/show_bug.cgi?id=27538 + + Reimplement frameCount instead of overloading it. + + * platform/graphics/qt/ImageDecoderQt.cpp: + (WebCore::ImageDecoderQt::frameCount): + * platform/graphics/qt/ImageDecoderQt.h: + +2009-10-04 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Simon Hausmann. + + [Qt] QImageReader does not support progressive reading + https://bugs.webkit.org/show_bug.cgi?id=27538 + + Change the ImageDecoderQt::setData to store the encoded + data in ImageDecoder. + + Only call ReadContext when the whole Resource has been + loaded to avoid needless calls to reset and the + ReadContext as progressive loading is not supported. + + * platform/graphics/qt/ImageDecoderQt.cpp: + (WebCore::ImageDecoderQt::setData): + * platform/graphics/qt/ImageDecoderQt.h: + +2009-10-04 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Simon Hausmann. + + [Qt] Remove dead code from ImageDecoderQt + https://bugs.webkit.org/show_bug.cgi?id=27538 + + Remove unused variables and debugging code. The debug + code has never been used and does not provide anything + useful. + + * platform/graphics/qt/ImageDecoderQt.cpp: + (WebCore::ImageDecoderQt::ReadContext::read): + (WebCore::ImageDecoderQt::ReadContext::readImageLines): + (WebCore::ImageDecoderQt::setData): + (WebCore::ImageDecoderQt::isSizeAvailable): + (WebCore::ImageDecoderQt::frameCount): + (WebCore::ImageDecoderQt::repetitionCount): + (WebCore::ImageDecoderQt::filenameExtension): + (WebCore::ImageDecoderQt::imageAtIndex): + +2009-10-06 Philippe Normand <pnormand@igalia.com> + + Reviewed by Xan Lopez. + + [GTK] segfault when calling gst_video_format_parse_caps in the video sink + https://bugs.webkit.org/show_bug.cgi?id=30120 + + Fix use of gst_video_format_parse_caps() + + * platform/graphics/gtk/VideoSinkGStreamer.cpp: + (webkit_video_sink_idle_func): + +2009-10-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] Update mediaControls CSS + + * css/mediaControlsQt.css: + +2009-10-06 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Get rid of Preferences.ignoreWhitespace. + + https://bugs.webkit.org/show_bug.cgi?id=30092 + + * inspector/front-end/DOMAgent.js: + (WebInspector.DOMAgent): + (WebInspector.DOMAgent.prototype._childNodeCountUpdated): + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeOutline.prototype.update): + (WebInspector.ElementsTreeElement): + (WebInspector.ElementsTreeElement.prototype.onpopulate): + (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): + (WebInspector.ElementsTreeElement.prototype._updateChildren): + * inspector/front-end/TextPrompt.js: + (WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt): + * inspector/front-end/inspector.js: + * inspector/front-end/utilities.js: + (Node.prototype.rangeOfWord): + (traverseNextNode): + (traversePreviousNode): + (onlyTextChild): + +2009-10-06 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Do not call nodeTitleInfo twice + + followup fixes for r49101. + + https://bugs.webkit.org/show_bug.cgi?id=30087 + + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeElement): + +2009-10-06 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Simon Hausmann. + + [Qt] Windowless plugins: Enable painting on printer. + + The print preview dialog crashed because the depth of the drawable + changed owing to a bug in Qt - if you draw onto a 32-bit pixmap, + and set a 24-bit pixmap as source, it will convert the source to + 32-bit. + + 1210fa5b2d65895ad2be1f9ca7cae586e3b29dc1 is the bug fix in Qt. + + https://bugs.webkit.org/show_bug.cgi?id=20081 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::paint): + +2009-10-06 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Simon Hausmann. + + [Qt] Windowless plugins: Make painting and events work when page is zoomed. + + The element gets resized when zoomed. So, we have to make sure that we resize + the drawable and do a setwindow call. Multiple calls to setwindow do not + crash plugin in windowless mode (unlike in windowed mode). + + For mouse events we have to convert the pos to post-zoom position. + + https://bugs.webkit.org/show_bug.cgi?id=20081 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::setXButtonEventSpecificFields): + (WebCore::setXMotionEventSpecificFields): + (WebCore::setXCrossingEventSpecificFields): + (WebCore::PluginView::handleMouseEvent): + (WebCore::PluginView::setNPWindowIfNeeded): + +2009-10-06 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Simon Hausmann. + + [Qt] Windowless plugins: Add PluginQuirkRequiresDefaultScreenDepth quirk for Flash. + + Flash does not use the visual provided by us to draw into the drawable. + It instead uses the system default visual (as returned by XDefaultVisual). + This means that if the screen default visual is 24-bit, Flash won't be + able to draw on 32-bit drawable created by us. This is a bug in Flash + and for the moment, the above quirk is only set for Flash. + + Our strategy to create the drawable: + 1. Create a 32-bit drawable if the default screen depth is 32 or the + quirk is not set (i.e not flash) + 2. If we didn't create a 32-bit drawable (maybe the Display has no such + visual), we create a drawable with default screen depth. + + As a result of the above changes, content propagation behavior changes as: + 1. Content propagation is possible only if the drawable we create and + Qt's backing store are of the same depth. + 2. If we created a 32-bit drawable, there is no need for content + propagation (Qt will take care of it). + + https://bugs.webkit.org/show_bug.cgi?id=20081 + + * plugins/PluginPackage.cpp: + (WebCore::PluginPackage::determineQuirks): + * plugins/PluginQuirkSet.h: + (WebCore::): + * plugins/PluginView.cpp: + (WebCore::PluginView::PluginView): + * plugins/PluginView.h: + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::updatePluginWidget): + (WebCore::PluginView::paint): + (WebCore::getVisualAndColormap): + (WebCore::PluginView::platformStart): + (WebCore::PluginView::platformDestroy): + +2009-10-06 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by Ariya Hidayat. + + Qt build fix. + https://bugs.webkit.org/show_bug.cgi?id=29362. + + In Qt 4.5, a new function QPainter::fillRect(QRect, QColor) is + introduced to avoid the expensive construction of QBrush. + By casting WebCore::Color to QColor, we can compile on Qt 4.4 + and use optimization for solid color fill in Qt 4.5. + + * platform/graphics/qt/GraphicsContextQt.cpp: + (WebCore::GraphicsContext::drawRect): + (WebCore::GraphicsContext::drawLine): + (WebCore::drawBorderlessRectShadow): + +2009-10-05 Andrei Popescu <andreip@google.com> + + Reviewed by Eric Carlson. + + Allow the platform media player to know the <video> poster URL. + Add MediaPlayerPrivate::prepareToPlay() to support media engines + that do not buffer video data automatically. This method allows + such media engines to start the buffering just before starting + playback. + https://bugs.webkit.org/show_bug.cgi?id=29133 + + All platforms that currently implement <video> return false + in MediaPlayerPrivate::canLoadPoster() and do nothing in + MediaPlayerPrivate::prepareToPlay() their behavior is + unchanged. The current set of media test should then be + sufficient to guarantee that this patch does not break anything. + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::loadResource): + After the MediaPlayer is created, inform it what the poster URL is. + (WebCore::HTMLMediaElement::updatePlayState): + Add another case where prepareToPlay is called for the platforms + that do not buffer video content automatically. + (WebCore::HTMLMediaElement::couldPlayIfEnoughData) + Same as potentiallyPlaying, except that we don't check for + the readyState being at least HAVE_FUTURE_DATA. + * platform/graphics/MediaPlayer.cpp: + (WebCore::NullMediaPlayerPrivate::canLoadPoster): + Empty implementation for the NullMediaPlayerPrivate. + (WebCore::NullMediaPlayerPrivate::setPoster): + Empty implementation for the NullMediaPlayerPrivate. + (WebCore::MediaPlayer::canLoadPoster): + Proxy to the m_private. + (WebCore::MediaPlayer::setPoster): + Proxy to m_private. + * platform/graphics/MediaPlayer.h: + * platform/graphics/MediaPlayerPrivate.h: + (WebCore::MediaPlayerPrivateInterface::canLoadPoster): + (WebCore::MediaPlayerPrivateInterface::setPoster): + Add new methods that allow the platform player to receive the poster URL. + (WebCore::MediaPlayerPrivateInterface::prepareToPlay): + Notifies the media engine that playback should start. The media engine + should start preparing (e.g. by initializing the player and starting to buffer) + and call back when the state is changed to HAVE_FUTURE_DATA. + +2009-10-06 David Levin <levin@chromium.org> + + Reviewed by Oliver Hunt. + + StringImpl needs a method to get an instance for another thread which doesn't copy the underlying buffer. + https://bugs.webkit.org/show_bug.cgi?id=30095 + + All String::copy methods were changed to call either threadsafeCopy or crossThreadString. The method + call was made threadsafeCopy unless I could show that threadsafety wasn't needed. + + No visible change in functionality so no new tests. + + * dom/MessagePortChannel.cpp: + (WebCore::MessagePortChannel::EventData::EventData): + * loader/WorkerThreadableLoader.cpp: + (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): + * loader/icon/IconDatabase.cpp: + (WebCore::IconDatabase::open): + (WebCore::IconDatabase::iconForPageURL): + (WebCore::IconDatabase::iconURLForPageURL): + (WebCore::IconDatabase::retainIconForPageURL): + (WebCore::IconDatabase::releaseIconForPageURL): + (WebCore::IconDatabase::setIconDataForIconURL): + (WebCore::IconDatabase::setIconURLForPageURL): + (WebCore::IconDatabase::databasePath): + (WebCore::IconDatabase::defaultDatabaseFilename): + * page/SecurityOrigin.cpp: + (WebCore::SecurityOrigin::SecurityOrigin): Since this is used by SecurityOrigin::threadsafeCopy, + it makes threadsafe calls. + (WebCore::SecurityOrigin::threadsafeCopy): The only place that called this + needed a threadsafe method. + * page/SecurityOrigin.h: + * platform/CrossThreadCopier.cpp: + (WebCore::::copy): + * platform/KURL.cpp: + (WebCore::KURL::copy): + * platform/network/HTTPHeaderMap.cpp: + (WebCore::HTTPHeaderMap::copyData): + * platform/network/ResourceErrorBase.cpp: + (WebCore::ResourceErrorBase::copy): + * platform/network/ResourceRequestBase.cpp: + (WebCore::ResourceRequestBase::copyData): + * platform/network/ResourceResponseBase.cpp: + (WebCore::ResourceResponseBase::copyData): + * platform/sql/SQLValue.cpp: + (WebCore::SQLValue::SQLValue): + (WebCore::SQLValue::string): + * platform/sql/SQLValue.h: + (WebCore::SQLValue::SQLValue): + All constructors now initialize the m_number which is a double. Failure to + do so can result in unexpected crashes when it is copied in the copy constructor. + See http://blogs.msdn.com/oldnewthing/archive/2008/07/02/8679191.aspx, I was that colleague. + * platform/text/PlatformString.h: + * platform/text/String.cpp: + (WebCore::String::threadsafeCopy): + (WebCore::String::crossThreadString): + * platform/text/StringImpl.cpp: + Removed StringImpl::substringCopy which was no longer being used anywhere. + (WebCore::StringImpl::threadsafeCopy): Changed the name to indicate that + it is threadsafe. + (WebCore::StringImpl::crossThreadString): The way to get strings for + another thread which is not threadsafe. This shares the underlying buffer + with both strings and gives them a way to do threadsafe refcounting for it. + * platform/text/StringImpl.h: + * storage/ChangeVersionWrapper.cpp: + (WebCore::ChangeVersionWrapper::ChangeVersionWrapper): + * storage/Database.cpp: + (WebCore::updateGuidVersionMap): + (WebCore::Database::Database): + (WebCore::Database::getVersionFromDatabase): + (WebCore::Database::setVersionInDatabase): + (WebCore::Database::version): + (WebCore::Database::setExpectedVersion): + (WebCore::Database::securityOriginCopy): + (WebCore::Database::stringIdentifier): + * storage/DatabaseTracker.cpp: + (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): + * storage/OriginQuotaManager.cpp: + (WebCore::OriginQuotaManager::addDatabase): + * storage/SQLError.h: + (WebCore::SQLError::message): + (WebCore::SQLError::SQLError): + * storage/SQLStatement.cpp: + (WebCore::SQLStatement::SQLStatement): + * storage/StorageAreaSync.cpp: + (WebCore::StorageAreaSync::syncTimerFired): + * storage/StorageMap.cpp: + (WebCore::StorageMap::importItem): + * storage/StorageNamespaceImpl.cpp: + (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): + * storage/StorageSyncManager.cpp: + (WebCore::StorageSyncManager::StorageSyncManager): + * workers/DefaultSharedWorkerRepository.cpp: + (WebCore::SharedWorkerProxy::url): Do the copy of the url in a way that is threadsafe. + (WebCore::SharedWorkerProxy::name): + (WebCore::SharedWorkerProxy::SharedWorkerProxy): + (WebCore::DefaultSharedWorkerRepository::getProxy): Do the copy of the url in a way that is threadsafe. + * workers/SharedWorkerThread.cpp: + (WebCore::SharedWorkerThread::SharedWorkerThread): + * workers/WorkerMessagingProxy.cpp: + (WebCore::MessageWorkerContextTask::MessageWorkerContextTask): + (WebCore::MessageWorkerTask::MessageWorkerTask): + (WebCore::WorkerExceptionTask::WorkerExceptionTask): + * workers/WorkerRunLoop.cpp: + (WebCore::WorkerRunLoop::Task::Task): + (WebCore::WorkerRunLoop::postTaskForMode): + * workers/WorkerThread.cpp: + (WebCore::WorkerThreadStartupData::WorkerThreadStartupData): + +2009-10-06 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Simon Hausmann. + + [Qt] Windowless plugins: Use X Pixmap instead of QPixmap. + + This has the following advantages: + 1. Allows more sharing of code between gtk and Qt ports in the future + 2. QPixmap creates 24-bit by default. We have to later 'upgrade' it to 32-bit. + 3. QPixmap may sometime change depth behind our back! This will require us to + update the plugin about the new visual and colormap. + 4. We cannot ensure that QPixmap is backed by a X Drawable. For example, with + -graphicssystem raster, QPixmap uses the raster (image) backend. + + https://bugs.webkit.org/show_bug.cgi?id=20081 + + * plugins/PluginView.cpp: + (WebCore::PluginView::PluginView): + * plugins/PluginView.h: + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::updatePluginWidget): + (WebCore::PluginView::paint): + (WebCore::PluginView::platformDestroy): + +2009-10-06 Girish Ramakrishnan <girish@forwardbias.in> + + Reviewed by Simon Hausmann. + + [Qt] Add support for windowless NPAPI plugins + + https://bugs.webkit.org/show_bug.cgi?id=20081 + + * plugins/PluginView.cpp: + (WebCore::PluginView::setFrameRect): + (WebCore::PluginView::handleEvent): + (WebCore::PluginView::PluginView): + * plugins/PluginView.h: + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::updatePluginWidget): + (WebCore::PluginView::paint): + (WebCore::PluginView::dispatchNPEvent): + (WebCore::setSharedXEventFields): + (WebCore::PluginView::initXEvent): + (WebCore::setXKeyEventSpecificFields): + (WebCore::PluginView::handleKeyboardEvent): + (WebCore::inputEventState): + (WebCore::setXButtonEventSpecificFields): + (WebCore::setXMotionEventSpecificFields): + (WebCore::setXCrossingEventSpecificFields): + (WebCore::PluginView::handleMouseEvent): + (WebCore::PluginView::handleFocusInEvent): + (WebCore::PluginView::handleFocusOutEvent): + (WebCore::PluginView::setNPWindowRect): + (WebCore::PluginView::setNPWindowIfNeeded): + (WebCore::PluginView::getValueStatic): + (WebCore::PluginView::invalidateRect): + (WebCore::PluginView::invalidateRegion): + (WebCore::PluginView::forceRedraw): + (WebCore::getPluginDisplay): + (WebCore::PluginView::platformStart): + +2009-10-05 Dirk Schulze <krit@webkit.org> + + Reviewed by Nikolas Zimmermann. + + SVG Filters do not support source images besides "sourceGraphic" + [https://bugs.webkit.org/show_bug.cgi?id=6022] + + Add support for SourceAlpha to SVG filters. + + Test: svg/filters/sourceAlpha.svg + + * platform/graphics/filters/SourceAlpha.cpp: + (WebCore::SourceAlpha::calculateEffectRect): + (WebCore::SourceAlpha::apply): + * platform/graphics/filters/SourceAlpha.h: + +2009-10-05 John Abd-El-Malek <jam@chromium.org> + + Reviewed by Adam Barth. + + Fix reliablity bot crash in DateExtension. + https://bugs.webkit.org/show_bug.cgi?id=30033 + + There were a few problems using the weak persistent pointers because no one else had a + handle to them. The new approach stores them as a hidden value on the Date constructor. + + * bindings/v8/DateExtension.cpp: + (WebCore::DateExtension::setAllowSleep): + (WebCore::DateExtension::GetNativeFunction): + (WebCore::DateExtension::Setup): + (WebCore::DateExtension::OnSleepDetected): + * bindings/v8/DateExtension.h: + * bindings/v8/V8HiddenPropertyName.cpp: + (WebCore::V8HiddenPropertyName::sleepFunction): + * bindings/v8/V8HiddenPropertyName.h: + +2009-10-05 Stephanie Lewis <slewis@apple.com> + + Reviewed by Dan Bernstein. + + Crash when trying to load a null stylesheet for a site specific hack. + https://bugs.webkit.org/show_bug.cgi?id=30105 + + Created a testcase and tested in browser. DRT doesn't test + site specific hacks. + + * html/HTMLLinkElement.cpp: + (WebCore::HTMLLinkElement::setCSSStyleSheet): + +2009-10-05 James Robinson <jamesr@google.com> + + Reviewed by Darin Adler. + + Fix forward declaration (struct vs class mismatch) + + https://bugs.webkit.org/show_bug.cgi?id=30094 + + * loader/RedirectScheduler.h: + +2009-10-05 Julie Parent <jparent@chromium.org> + + Unreviewed, last Chromium build fix corresponding to revision 49113. + Add include for BeforeLoadEvent to DOMObjectsInclude.h. + + * bindings/v8/DOMObjectsInclude.h: + +2009-10-05 Simon Fraser <simon.fraser@apple.com> + + Fix Windows build. + + * html/HTMLMediaElement.cpp: + +2009-10-05 Simon Fraser <simon.fraser@apple.com> + + Fix the build: MediaControllerThemeQT was renamed to MediaControllerThemeQuickTime. + + * rendering/RenderThemeMac.mm: + (WebCore::RenderThemeMac::shouldRenderMediaControlPart): + +2009-10-05 Pierre d'Herbemont <pdherbemont@webkit.org> + + Reviewed by Simon Fraser + + Support fullscreen in MediaPlayer (Mac) + https://bugs.webkit.org/show_bug.cgi?id=26742 + + Add a fullscreen button to the <video> controller if the media engine, + and the theme have support for fullscreen, and can show appropriate controls. + Clicking the button calls through the ChromeClient to the WebVideoFullscreenController + in WebKit to do a nice animation to fullscreen, with a custom controller. + + * DerivedSources.make: + * WebCore.Video.exp: Added. + New export file for when VIDEO is enabled. + + * WebCore.base.exp: Export WebCore::HTMLNames::videoTag + * WebCore.xcodeproj/project.pbxproj: New files + + * html/HTMLMediaElement.h: + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::HTMLMediaElement): + (WebCore::HTMLMediaElement::willRemove): + (WebCore::HTMLMediaElement::screenRect): + (WebCore::HTMLMediaElement::enterFullscreen): + (WebCore::HTMLMediaElement::exitFullscreen): + (WebCore::HTMLMediaElement::platformMedia): + Add fullscreen logic. platformMedia returns a pointer to platform-specific playback data + used for fullscreen. + + * html/HTMLVideoElement.h: + * html/HTMLVideoElement.cpp: + (WebCore::HTMLVideoElement::supportsFullscreen): Check with both the player and the ChromeClient + to see if it's possile to enter fullscreen for this element. + + * page/ChromeClient.h: + (WebCore::ChromeClient::supportsFullscreenForNode): + (WebCore::ChromeClient::enterFullscreenForNode): + (WebCore::ChromeClient::exitFullscreenForNode): + New methods + + * platform/graphics/MediaPlayer.h: + * platform/graphics/MediaPlayer.cpp: + (WebCore::NullMediaPlayerPrivate::platformMedia): + (WebCore::MediaPlayer::platformMedia): + * platform/graphics/MediaPlayerPrivate.h: + (WebCore::MediaPlayerPrivateInterface::platformMedia): + * platform/graphics/mac/MediaPlayerPrivateQTKit.h: + * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: + (WebCore::MediaPlayerPrivate::platformMedia): + (WebCore::MediaPlayerPrivate::supportsFullscreen): + New methods to return platform-specific playback data for fullscreen. + + * rendering/MediaControlElements.cpp: + (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): + Hook up the fullscreen button. + * rendering/RenderThemeMac.h: + * rendering/RenderThemeMac.mm: + (WebCore::RenderThemeMac::shouldRenderMediaControlPart): + Allow the RenderThemeMac to make a decision about the availability of fullscreen based + on the QuickTime version, since this affects what controls are availabl.e + +2009-10-05 Kevin Decker <kdecker@apple.com> + + Export a few more methods from Settings.h + + Rubberstamped by Jon Honeycutt. + + * WebCore.base.exp: + +2009-10-05 Dmitry Titov <dimich@chromium.org> + + Reviewed by Darin Adler. + + 1-char fix for obviously reverse condition. + https://bugs.webkit.org/show_bug.cgi?id=30100 + No test since the only difference is a timing of GC. + + * bindings/js/ScriptCachedFrameData.cpp: + (WebCore::ScriptCachedFrameData::clear): Revert condition. Almost a typo. + +2009-09-30 Kenneth Russell <kbr@google.com> + + Reviewed by Darin Fisher. + + Update platform-specific #ifdefs in GraphicsContext3D.h for the + Chromium port. + https://bugs.webkit.org/show_bug.cgi?id=29936 + + * platform/graphics/GraphicsContext3D.h: + Changed #if PLATFORM(SKIA) to #if PLATFORM(CHROMIUM). + +2009-10-05 Dan Bernstein <mitz@apple.com> + + Reviewed by Darin Adler. + + REGRESSION (r47440): Inserting text in the middle of content in a scrolled textfield results in painting bugs + <rdar://problem/7269108> + https://bugs.webkit.org/show_bug.cgi?id=29982 + + Test: fast/repaint/line-in-scrolled-clipped-block.html + + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::layoutBlock): Use the unclipped overflow rect + (including layout overflow) for the repaint rect calculation. + +2009-10-05 Drew Wilson <atwilson@google.com> + + Reviewed by David Levin. + + Chromium wants to turn off SharedWorkers at runtime + https://bugs.webkit.org/show_bug.cgi?id=29757 + + * bindings/js/JSDOMWindowCustom.cpp: + (WebCore::JSDOMWindow::sharedWorker): + Now returns jsUndefined if isAvailable() returns false, to allow SharedWorkers to be disabled at runtime. + * workers/DefaultSharedWorkerRepository.cpp: + (WebCore::SharedWorkerRepository::isAvailable): + Made SharedWorkers available by default. + * workers/SharedWorkerRepository.h: + Added definition for SharedWorkerRepository::isAvailable(). + +2009-10-05 Hironori Bono <hbono@chromium.org> + + Reviewed by Eric Seidel. + + A super quick fix for Bug 28710. + + https://bugs.webkit.org/show_bug.cgi?id=28710 + + This change just resets the style sent to addStyleMarkup() to avoid an assertion error + and creates an empty style when computedStyleAtPosition is 0 to avoid a crash. + (This change is nothing but a better-than-crash change.) + + Tests: editing/selection/select-crash-001.html + editing/selection/select-crash-002.html + + * editing/ApplyStyleCommand.cpp: + (WebCore::editingStyleAtPosition): Resets the style sent to addStyleMarkup() if it is not valid. + * editing/markup.cpp: + (WebCore::createMarkup): Creates an empty style if computedStyleAtPosition is 0. + +2009-10-05 Sam Weinig <sam@webkit.org> + + Reviewed by Mark Rowe. + + Silence duplicate errors logged for missing getComputedStyle + implementations. Improves the error message as well. + + * css/CSSComputedStyleDeclaration.cpp: + (WebCore::logUnimplementedPropertyID): + (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): + +2009-10-05 Julie Parent <jparent@chromium.org> + + Unreviewed, Chromium build fix #3. Add V8BeforeLoadEvent.[cc|h] to derived sources. + + * bindings/v8/DerivedSourcesAllInOne.cpp: + * bindings/v8/V8Index.cpp: + +2009-10-05 Mark Rowe <mrowe@apple.com> + + Try and fix the GTK build. + + * GNUmakefile.am: + +2009-10-05 Julie Parent <jparent@chromium.org> + + Unreviewed, Chromium build fix #2. Add new BEFORELOADEVENT to V8ClassIndex. + + * bindings/v8/V8Index.h: + +2009-10-05 Julie Parent <jparent@chromium.org> + + Unreviewed, Chromium build fix. Missing "," after entry for BeforeLoadEvent.idl. + + * WebCore.gypi: + +2009-10-05 Dave Hyatt <hyatt@apple.com> + + Reviewed by Sam Weinig. + + Add a beforeload event that will be fired before subresources load. (It isn't fired yet.) The event + has one field, the URL that is going to be requested. Setting preventDefault will stop the load + from occurring. + + * DerivedSources.cpp: + * DerivedSources.make: + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * dom/BeforeLoadEvent.h: Added. + (WebCore::BeforeLoadEvent::create): + (WebCore::BeforeLoadEvent::initBeforeLoadEvent): + (WebCore::BeforeLoadEvent::url): + (WebCore::BeforeLoadEvent::BeforeLoadEvent): + * dom/BeforeLoadEvent.idl: Added. + * dom/EventNames.h: + * page/DOMWindow.idl: + +2009-10-05 Priit Laes <plaes@plaes.org> + + Reviewed by Gustavo Noronha. + + Add Gentoo-specific paths for searching browser plugins. + https://bugs.webkit.org/show_bug.cgi?id=30088 + + * plugins/PluginDatabase.cpp: + (WebCore::PluginDatabase::defaultPluginDirectories): + +2009-10-02 Chris Marrin <cmarrin@apple.com> + + Reviewed by Adele Peterson. + + Add functionality to pause/throttle CSS transitions/animations in a WebView + https://bugs.webkit.org/show_bug.cgi?id=29942 + + Exporting call from AnimationController + + * WebCore.base.exp: + +2009-10-05 Kevin Decker <kdecker@apple.com> + + Rubberstamped by Anders Carlsson. + + * WebCore.base.exp: Update export of HaltablePlugin/PluginHalterClient. + * WebCore.xcodeproj/project.pbxproj: Likewise. + +2009-10-05 Eric Seidel <eric@webkit.org> + + No review, rolling out r49104. + http://trac.webkit.org/changeset/49104 + + * html/HTMLInputElement.cpp: + * html/HTMLInputElement.h: + * html/HTMLInputElement.idl: + * html/ValidityState.cpp: + * html/ValidityState.h: + (WebCore::ValidityState::rangeUnderflow): + (WebCore::ValidityState::rangeOverflow): + * rendering/RenderSlider.cpp: + (WebCore::SliderRange::SliderRange): + (WebCore::SliderRange::valueFromElement): + +2009-10-05 Kent Tamura <tkent@chromium.org> + + Reviewed by Eric Seidel. + + Update style immediately when validation-related values are updated. + https://bugs.webkit.org/show_bug.cgi?id=28868 + + In order to apply :valid, :invalid, :optional or :required lively, + - call setNeedsStyleRecalc() when properties which can change + willValidate state are updated, and + (Parent form element, name, disabled, readonly) + - call updateValidity() when properties which can change validity + state are updated. (value, pattern, required) + + Tests: fast/forms/input-live-pseudo-selectors.html + fast/forms/textarea-live-pseudo-selectors.html + + * html/HTMLFormControlElement.cpp: + (WebCore::HTMLFormControlElement::HTMLFormControlElement): + (WebCore::HTMLFormControlElement::parseMappedAttribute): + (WebCore::HTMLFormControlElement::required): + (WebCore::HTMLFormControlElement::updateValidity): + * html/HTMLFormControlElement.h: + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::setInputType): + (WebCore::HTMLInputElement::parseMappedAttribute): + (WebCore::HTMLInputElement::setValue): + (WebCore::HTMLInputElement::setValueFromRenderer): + (WebCore::HTMLInputElement::setFileListFromRenderer): + * html/HTMLTextAreaElement.cpp: + (WebCore::HTMLTextAreaElement::setValue): + * rendering/RenderTextControlMultiLine.cpp: + (WebCore::RenderTextControlMultiLine::subtreeHasChanged): + +2009-10-05 Kent Tamura <tkent@chromium.org> + + Reviewed by Darin Adler. + + Implement min/max attributes, ValidityState.rangeUnderflow and + ValidityState.rangeOverflow for <input type=number> and <input type=range> + https://bugs.webkit.org/show_bug.cgi?id=29069 + + Tests: fast/forms/ValidityState-rangeOverflow-number.html + fast/forms/ValidityState-rangeOverflow-range.html + fast/forms/ValidityState-rangeUnderflow-number.html + fast/forms/ValidityState-rangeUnderflow-range.html + fast/forms/input-minmax.html + + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::rangeUnderflow): + (WebCore::HTMLInputElement::rangeOverflow): + (WebCore::HTMLInputElement::rangeMinimum): + (WebCore::HTMLInputElement::rangeMaximum): + * html/HTMLInputElement.h: + * html/HTMLInputElement.idl: + * html/ValidityState.cpp: + (WebCore::ValidityState::rangeUnderflow): + (WebCore::ValidityState::rangeOverflow): + * html/ValidityState.h: + * rendering/RenderSlider.cpp: + (WebCore::SliderRange::SliderRange): + (WebCore::SliderRange::valueFromElement): + +2009-10-05 Kent Tamura <tkent@chromium.org> + + Reviewed by Eric Seidel. + + Introduces + - new CSS pseudo selector: "-webkit-input-list-button" + - new CSS apperance type: "list-button" + - new ControlPart value: "ListButtonPart" + for the UI of the list attribute of the input element, and adds + implementation to draw ListButtonPart on Mac. + The code is guarded by ENABLE(DATALIST). + + https://bugs.webkit.org/show_bug.cgi?id=27794 + + Test: platform/mac/fast/forms/input-list-button-size.html + + * css/CSSPrimitiveValueMappings.h: + (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): + * css/CSSSelector.cpp: + (WebCore::CSSSelector::extractPseudoType): + * css/CSSSelector.h: + (WebCore::CSSSelector::): + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): + * css/CSSValueKeywords.in: + * css/html.css: + * html/HTMLInputElement.cpp: + * platform/ThemeTypes.h: + (WebCore::): + * platform/mac/ThemeMac.mm: + (WebCore::listButtonSizes): + (WebCore::button): + (WebCore::paintButton): + (WebCore::ThemeMac::controlSize): + (WebCore::ThemeMac::minimumControlSize): + (WebCore::ThemeMac::controlBorder): + (WebCore::ThemeMac::paint): + * rendering/RenderTheme.cpp: + (WebCore::RenderTheme::adjustStyle): + (WebCore::RenderTheme::paint): + (WebCore::RenderTheme::paintBorderOnly): + (WebCore::RenderTheme::paintDecorations): + * rendering/RenderThemeMac.mm: + (WebCore::RenderThemeMac::adjustRepaintRect): + * rendering/style/RenderStyleConstants.h: + (WebCore::): + +2009-10-05 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <https://bugs.webkit.org/show_bug.cgi?id=30065> + nodeTitleInfo should be placed in ElementsTreeOutline. + + Move nodeTitleInfo into ElementsTreeOutline.js from utilities.js. + + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeElement): + (WebInspector.ElementsTreeElement.prototype._updateTitle): + (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo): + * inspector/front-end/utilities.js: + +2009-10-02 Yael Aharon <yael.aharon@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] Inform the application when a new request is created + https://bugs.webkit.org/show_bug.cgi?id=29975 + + Emit a signal each time a request is created, with the request and the frame + that created it. + + * platform/network/qt/QNetworkReplyHandler.cpp: + (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): + (WebCore::QNetworkReplyHandler::start): + +2009-10-05 Ben Murdoch <benm@google.com> + + Reviewed by Darin Adler. + + Add an ASSERT in updateGuidVersionMap. + https://bugs.webkit.org/show_bug.cgi?id=30077 + + * storage/Database.cpp: + (WebCore::updateGuidVersionMap): ASSERT that the guidMutex() is locked. + +2009-10-05 Nate Chapin <japhet@chromium.org> + + Reviewed by Eric Seidel. + + Allow V8 to throw an exception in _NPN_SetException without worrying about context + if we don't have enough information to find the correct context. + + https://bugs.webkit.org/show_bug.cgi?id=30026 + + Part of the fix for Chromium's failure of LayouTests/plugins/netscape-throw-exception.html. + + * bindings/v8/NPV8Object.cpp: + (_NPN_SetException): Don't suppress the exception if we can't find the relevant context. + +2009-10-05 Mikhail Naganov <mnaganov@chromium.org> + + Reviewed by Timothy Hatcher. + + Place "Close" button in docked mode on the same side as the window "Close" button in detached mode. + + https://bugs.webkit.org/show_bug.cgi?id=29961 + + * inspector/front-end/inspector.css: + * inspector/front-end/inspector.html: + * inspector/front-end/inspector.js: + (WebInspector.loaded): + +2009-10-05 J-P Nurmi <jpnurmi@gmail.com> + + Reviewed by Simon Hausmann. + + [Qt] Added pure virtual QWebPageClient::pluginParent() + + https://bugs.webkit.org/show_bug.cgi?id=29710 + + * platform/qt/QWebPageClient.h: + +2009-10-05 Jakub Wieczorek <faw217@gmail.com> + + Reviewed by Tor Arne Vestbø. + + [Qt] windowsKeyCodeForKeyEvent() returns a wrong value for the F10 key. + https://bugs.webkit.org/show_bug.cgi?id=30042 + + * platform/qt/PlatformKeyboardEventQt.cpp: + (WebCore::windowsKeyCodeForKeyEvent): + +2009-10-05 Fumitoshi Ukai <ukai@chromium.org> + + Unreviewed build fix for ENABLE(WEB_SOCKETS) and v8. + + V8ObjectEventListener.h has been removed at r48978 + + * bindings/v8/custom/V8WebSocketCustom.cpp: + +2009-10-04 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector console stops working while JS in IFRAME is paused. + + https://bugs.webkit.org/show_bug.cgi?id=29958 + + * inspector/front-end/InjectedScript.js: + (InjectedScript._evaluateOn): + (InjectedScript.addInspectedNode): + (InjectedScript._ensureCommandLineAPIInstalled): + +2009-10-04 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Introduce inspected object groups for console + and watch evaluation results so that they could be released + explicitly. + + https://bugs.webkit.org/show_bug.cgi?id=29891 + + * bindings/js/JSInspectorBackendCustom.cpp: + (WebCore::JSInspectorBackend::wrapObject): + * bindings/v8/custom/V8InspectorBackendCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * inspector/InspectorBackend.cpp: + (WebCore::InspectorBackend::wrapObject): + (WebCore::InspectorBackend::releaseWrapperObjectGroup): + * inspector/InspectorBackend.h: + * inspector/InspectorBackend.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::clearConsoleMessages): + (WebCore::InspectorController::resetScriptObjects): + (WebCore::InspectorController::wrapObject): + (WebCore::InspectorController::unwrapObject): + (WebCore::InspectorController::releaseWrapperObjectGroup): + * inspector/InspectorController.h: + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::addMessageToConsole): + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView.prototype.evalInInspectedWindow): + (WebInspector.ConsoleView.prototype.doEvalInWindow): + (WebInspector.ConsoleView.prototype._enterKeyPressed): + * inspector/front-end/InjectedScript.js: + (InjectedScript.evaluate): + (InjectedScript._evaluateAndWrap): + (InjectedScript.evaluateInCallFrame): + * inspector/front-end/ScriptsPanel.js: + (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): + (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame): + * inspector/front-end/WatchExpressionsSidebarPane.js: + (WebInspector.WatchExpressionsSidebarPane): + (WebInspector.WatchExpressionsSection.prototype.update): + +2009-10-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Eric Carlson. + + Move mediaControls extras for the Qt port into WebCore/css like other ports + + https://bugs.webkit.org/show_bug.cgi?id=30013 + + * WebCore.pro: + * WebCore.qrc: + * css/mediaControlsQt.css: Renamed from WebCore/css/qt/mediaControls-extras.css. + * platform/qt/RenderThemeQt.cpp: + (WebCore::RenderThemeQt::extraMediaControlsStyleSheet): + +2009-10-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Eric Carlson. + + Rename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT + + https://bugs.webkit.org/show_bug.cgi?id=30013 + + The QT suffix has been expanded to QuickTime, to not cause confusion + and name-crashes with similar files in the Qt port. + + * DerivedSources.make: + * WebCore.xcodeproj/project.pbxproj: + * css/mediaControlsQuickTime.css: Renamed from WebCore/css/mediaControlsQT.css. + * rendering/RenderThemeMac.mm: + (WebCore::): + (WebCore::mediaControllerTheme): + (WebCore::RenderThemeMac::adjustSliderThumbSize): + (WebCore::getUnzoomedRectAndAdjustCurrentContext): + (WebCore::RenderThemeMac::extraMediaControlsStyleSheet): + +2009-10-04 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <https://bugs.webkit.org/show_bug.cgi?id=30064> + Syntax Highlighting CSS shouldn't be duplicated. + + Refactor syntax highlighting CSS into a new file, add it to the + projects, and have SourceFrame.js and inspector.html include the + new CSS file. + + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * inspector/front-end/SourceFrame.js: + (WebInspector.SourceFrame.prototype._loaded): + * inspector/front-end/inspector.css: + * inspector/front-end/inspector.html: + * inspector/front-end/inspectorSyntaxHighlight.css: Added. + * inspector/front-end/WebKit.qrc: + +2009-10-04 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <https://bugs.webkit.org/show_bug.cgi?id=30062> + Inspector should syntax highlight JS/CSS in elements view. + + Add syntax highlighting of CSS and JavaScript tags to the elements panel. + Copied CSS rules from SourceFrame.js to inspector.css, and have the text nodes + in utilities.js call the CSS or JS Syntax highlighters if their parent is a script + or style tag. + + * inspector/front-end/inspector.css: + * inspector/front-end/utilities.js: + +2009-10-04 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by Eric Seidel + + Enable Web Sockets in chromium build. + https://bugs.webkit.org/show_bug.cgi?id=29917 + + * WebCore.gyp/WebCore.gyp: + +2009-10-04 Xan Lopez <xlopez@igalia.com> + + Reviewed by Gustova Noronha. + + [GTK] performs a POST when refreshing a view that was obtained with a GET + https://bugs.webkit.org/show_bug.cgi?id=29761 + + Update the HTTP method in the request stored by willSendRequest + after a redirect, since it could have changed. + + Test: http/tests/navigation/postredirect-reload.html + + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::restartedCallback): + +2009-10-04 Xan Lopez <xlopez@igalia.com> + + Revert previous patch, as the newly added test breaks other tests. + + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::restartedCallback): + +2009-10-04 Xan Lopez <xlopez@igalia.com> + + Reviewed by Gustova Noronha. + + [GTK] performs a POST when refreshing a view that was obtained with a GET + https://bugs.webkit.org/show_bug.cgi?id=29761 + + Update the HTTP method in the request stored by willSendRequest + after a redirect, since it could have changed. + + Test: http/tests/navigation/postredirect-reload.html + + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::restartedCallback): + +2009-10-04 Vitaly Repeshko <vitalyr@chromium.org> + + Reviewed by Adam Barth. + + [V8] Fixed Function leak in V8LazyEventListener. + (Should fix the remaning leak in + https://bugs.webkit.org/show_bug.cgi?id=29093). + V8LazyEventListeners used to create FunctionTemplates for each + wrapped listener which in turn created Functions that were cached + forever in V8 Context. Now there is at most one such Function per + Context. + https://bugs.webkit.org/show_bug.cgi?id=30060 + + Added new hidden property name to store toString result: + * bindings/v8/V8HiddenPropertyName.cpp: + * bindings/v8/V8HiddenPropertyName.h: + + Switched to static FunctionTemplate: + * bindings/v8/V8LazyEventListener.cpp: + (WebCore::V8LazyEventListenerToString): + (WebCore::V8LazyEventListener::prepareListenerObject): + +2009-10-03 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + CSS Source View Should be Syntax Highlighted + https://bugs.webkit.org/show_bug.cgi?id=14359 + + Support for WebKit's CSS Variables @variables and var() + + * inspector/front-end/SourceFrame.js: + (WebInspector.CSSSourceSyntaxHighligher): + +2009-10-03 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + Inspector should remember preferences for docked/undocked etc + https://bugs.webkit.org/show_bug.cgi?id=29089 + + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel.prototype._toggleLargerResources): toggle the preference + * inspector/front-end/inspector.js: + (WebInspector._loadPreferences): factored out loading preferences + (WebInspector.loaded): + +2009-10-03 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + CSS Source View Should be Syntax Highlighted + https://bugs.webkit.org/show_bug.cgi?id=14359 + + Trigger the Syntax Highlighter for CSS files. + + * inspector/front-end/SourceFrame.js: + (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): + (WebInspector.SourceFrame.prototype.syntaxHighlightCSS): + * inspector/front-end/SourceView.js: + (WebInspector.SourceView.prototype._contentLoaded): + + Factored out the Syntax Highlighting procedure into a "Class" + Added CSSSourceSyntaxHighlighter and JavaScriptSourceSyntaxHighlighter + + (WebInspector.SourceSyntaxHighligher): + (WebInspector.SourceSyntaxHighligher.prototype.createSpan): + (WebInspector.SourceSyntaxHighligher.prototype.process.processChunk): + (WebInspector.SourceSyntaxHighligher.prototype.process): + (WebInspector.CSSSourceSyntaxHighligher): the CSS Highlighter + (WebInspector.JavaScriptSourceSyntaxHighligher): the JS Highlighter + +2009-10-03 Adam Barth <abarth@webkit.org> + + Reviewed by Sam Weinig. + + Factor back-forward list methods out of FrameLoader + https://bugs.webkit.org/show_bug.cgi?id=30037 + + This change moves these back-forward related methods from FrameLoader + to Page. It's possible we should move these methods into some kind of + "page controller" object, but we can figure that out in a future patch. + + * loader/FrameLoader.cpp: + * loader/FrameLoader.h: + * loader/RedirectScheduler.cpp: + (WebCore::RedirectScheduler::timerFired): + * page/ContextMenuController.cpp: + (WebCore::ContextMenuController::contextMenuItemSelected): + * page/DOMWindow.cpp: + (WebCore::DOMWindow::close): + * page/History.cpp: + (WebCore::History::length): + * page/Page.cpp: + (WebCore::Page::canGoBackOrForward): + (WebCore::Page::goBackOrForward): + (WebCore::Page::getHistoryLength): + * page/Page.h: + * platform/ContextMenu.cpp: + (WebCore::ContextMenu::populate): + (WebCore::ContextMenu::checkOrEnableIfNeeded): + +2009-10-02 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: prepare InspectorController for being used from layout tests. + This change adds evaluateForTestInFrontend method with the callback that + allows evaluating arbitrary code in the frontend context. + + https://bugs.webkit.org/show_bug.cgi?id=30008 + + * WebCore.Inspector.exp: + * WebCore.order: + * inspector/InspectorBackend.cpp: + (WebCore::InspectorBackend::didEvaluateForTestInFrontend): + * inspector/InspectorBackend.h: + * inspector/InspectorBackend.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::populateScriptObjects): + (WebCore::InspectorController::evaluateForTestInFrontend): + (WebCore::InspectorController::didEvaluateForTestInFrontend): + * inspector/InspectorController.h: + * inspector/InspectorFrontend.cpp: + (WebCore::InspectorFrontend::evaluateForTestInFrontend): + * inspector/InspectorFrontend.h: + * inspector/front-end/inspector.js: + (WebInspector.evaluateForTestInFrontend): + +2009-10-02 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: Node search mode is not getting reset on element selection. + + https://bugs.webkit.org/show_bug.cgi?id=30016 + + * inspector/front-end/ElementsPanel.js: + (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): + +2009-10-02 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <https://bugs.webkit.org/show_bug.cgi?id=30036> + Should be able to resize Cookie Columns. + + * inspector/front-end/CookieItemsView.js: + (WebInspector.CookieItemsView.prototype.update.callback): + (WebInspector.CookieItemsView.prototype.update): + (WebInspector.CookieItemsView.prototype.resize): + +2009-09-25 Jon Honeycutt <jhoneycutt@apple.com> + + Make WebCore::PluginView participate in plug-in halting. + + Reviewed by Sam Weinig. + + * platform/graphics/BitmapImage.h: + Declare a create() function that takes an HBITMAP. + + * platform/graphics/win/ImageCGWin.cpp: + (WebCore::BitmapImage::create): + Use GetObject() to fill out a DIBSECTION structure for the given + HBITMAP. Call CGBitmapContextCreate() to create a CG context from the + bits of the bitmap. Create a CG image from the context, and pass this + when creating a new BitmapImage. + + * plugins/PluginView.cpp: + (WebCore::PluginView::start): + If we successfully started, tell our parent frame's Page. + (WebCore::PluginView::stop): + Tell our parent frame's Page that we stopped. + (WebCore::PluginView::node): + + * plugins/PluginView.h: + Inherit from HaltablePlugin. + (WebCore::PluginView::setPlatformPluginWidget): + On platforms where the platform plug-in widget is the WebCore::Widget's + platform widget, have setPlatformPluginWidget() call + setPlatformWidget(). + + * plugins/PluginViewNone.cpp: + (WebCore::PluginView::halt): + Stubbed. + (WebCore::PluginView::restart): + Stubbed. + + * plugins/gtk/PluginViewGtk.cpp: + (WebCore::PluginView::halt): + Stubbed. + (WebCore::PluginView::restart): + Stubbed. + + * plugins/mac/PluginViewMac.cpp: + (WebCore::PluginView::halt): + Stubbed. + (WebCore::PluginView::restart): + Stubbed. + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::halt): + Stubbed. + (WebCore::PluginView::restart): + Stubbed. + + * plugins/win/PluginViewWin.cpp: + (WebCore::PluginView::platformDestroy): + After destroying the window, set the platform plug-in widget to 0 to + ensure that Widget isn't holding a stale handle. + (WebCore::PluginView::halt): + Have our element's RenderWidget display a screenshot of the plug-in, + then stop the plug-in and destroy it. + (WebCore::PluginView::restart): + Clear the RenderWidget's substitute image, then start the plug-in. + + * rendering/RenderWidget.cpp: + (WebCore::RenderWidget::showSubstituteImage): + Set m_substituteImage to the passed image, and repaint. + (WebCore::RenderWidget::paint): + If we have a substitute image, paint that instead of allowing the + widget to paint itself. + + * rendering/RenderWidget.h: + Declare showSubstituteImage(). Added a member to store the substitute + image. + +2009-10-02 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Move PolicyCheck out of FrameLoader.{h,cpp} + https://bugs.webkit.org/show_bug.cgi?id=30035 + + Purely code motion (and adding a destructor). + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * loader/FrameLoader.cpp: + * loader/FrameLoader.h: + * loader/PolicyCheck.cpp: + * loader/PolicyCheck.h: + +2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Tor Arne Vestbø. + + [Qt] Add NPNVToolkit value quirk in plugins for nspluginwrapper. + Plugin error message was: + ERROR: failed to initialize brower-side RPC events listener + https://bugs.webkit.org/show_bug.cgi?id=25053 + + (WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue): + (WebCore::PluginPackage::load): + +2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Tor Arne Vestbø. + + [Qt] X sync our XEmbed container window creation before sending the + xid to plugins. + https://bugs.webkit.org/show_bug.cgi?id=25053 + + * plugins/qt/PluginViewQt.cpp: + (WebCore::PluginView::setNPWindowIfNeeded): + +2009-10-02 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dan Bernstein. + + Setting zero size on a container of a video element doesn't hide the controller + https://bugs.webkit.org/show_bug.cgi?id=30031 + + Fix a logic error in enclosingCompositingLayer() when mixing normal flow and + positioned layers. This resulted in enclosingCompositingLayer() giving back a different + answer to the logic used to actually parent compositing layers, so layer positions + and layer hierarchy would be out of agreement. + + Test: compositing/geometry/clipped-video-controller.html + + * rendering/RenderLayer.cpp: + (WebCore::compositingContainer): + (WebCore::RenderLayer::enclosingCompositingLayer): + * rendering/RenderLayerCompositor.cpp: + (WebCore::RenderLayerCompositor::setCompositingParent): + +2009-10-02 Kent Tamura <tkent@chromium.org> + + Reviewed by Eric Seidel. + + - Move the following methods of HTMLInputElement and HTMLTextAreaElement + to HTMLTextFormControlElement. + setSelectionStart() + setSelectionEnd() + select() + setSelectionRange() + selectionStart() + selectionEnd() + selection() + + - Introduce cachedSelectionStart() and cachedSelectionEnd(). + + - Unify HTMLInputElement::isTextFieldWithRenderer() and + HTMLTextAreaElement::rendererAfterUpdateLayout() into textRendererAfterUpdateLayout(). + + - Unify a part of parseMappedAttribute() of HTMLInputElement and HTMLTextAreaElement. + + https://bugs.webkit.org/show_bug.cgi?id=29782 + + * html/HTMLFormControlElement.cpp: + (WebCore::HTMLTextFormControlElement::textRendererAfterUpdateLayout): + (WebCore::HTMLTextFormControlElement::setSelectionStart): + (WebCore::HTMLTextFormControlElement::setSelectionEnd): + (WebCore::HTMLTextFormControlElement::select): + (WebCore::HTMLTextFormControlElement::setSelectionRange): + (WebCore::HTMLTextFormControlElement::selectionStart): + (WebCore::HTMLTextFormControlElement::selectionEnd): + (WebCore::HTMLTextFormControlElement::selection): + (WebCore::HTMLTextFormControlElement::parseMappedAttribute): + * html/HTMLFormControlElement.h: + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::parseMappedAttribute): + * html/HTMLInputElement.h: + (WebCore::HTMLInputElement::select): + (WebCore::HTMLInputElement::cachedSelectionStart): + (WebCore::HTMLInputElement::cachedSelectionEnd): + * html/HTMLTextAreaElement.cpp: + (WebCore::HTMLTextAreaElement::parseMappedAttribute): + * html/HTMLTextAreaElement.h: + (WebCore::HTMLTextAreaElement::cachedSelectionStart): + (WebCore::HTMLTextAreaElement::cachedSelectionEnd): + +2009-10-02 Vitaly Repeshko <vitalyr@chromium.org> + + Reviewed by Dimitri Glazkov. + + [V8] Disconnect event listeners on navigation. + Fixes http://crbug.com/23597. + https://bugs.webkit.org/show_bug.cgi?id=30027 + + Added V8ListenerGuard that is shared by listeners and proxy. On + navigation proxy sets a flag in the guard turning off listeners. + + * bindings/v8/V8AbstractEventListener.cpp: + (WebCore::V8AbstractEventListener::V8AbstractEventListener): + * bindings/v8/V8AbstractEventListener.h: + (WebCore::V8ListenerGuard::create): + (WebCore::V8ListenerGuard::isDisconnected): + (WebCore::V8ListenerGuard::disconnectListeners): + (WebCore::V8ListenerGuard::V8ListenerGuard): + (WebCore::V8AbstractEventListener::disconnected): + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::getEventListener): + * bindings/v8/V8EventListenerList.h: + (WebCore::V8EventListenerList::findOrCreateWrapper): + * bindings/v8/V8LazyEventListener.cpp: + (WebCore::V8LazyEventListener::V8LazyEventListener): + * bindings/v8/V8Proxy.cpp: + (WebCore::V8Proxy::V8Proxy): + (WebCore::V8Proxy::disconnectFrame): + (WebCore::V8Proxy::disconnectEventListeners): + (WebCore::V8Proxy::clearForNavigation): + * bindings/v8/V8Proxy.h: + (WebCore::V8Proxy::listenerGuard): + * bindings/v8/V8WorkerContextEventListener.cpp: + (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): + * bindings/v8/V8WorkerContextEventListener.h: + (WebCore::V8WorkerContextEventListener::create): + * bindings/v8/WorkerContextExecutionProxy.cpp: + (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): + (WebCore::WorkerContextExecutionProxy::dispose): + (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener): + * bindings/v8/WorkerContextExecutionProxy.h: + * bindings/v8/custom/V8CustomEventListener.cpp: + (WebCore::V8EventListener::V8EventListener): + * bindings/v8/custom/V8CustomEventListener.h: + (WebCore::V8EventListener::create): + +2009-10-02 Kenneth Russell <kbr@google.com> + + Reviewed by Dimitri Glazkov. + + [chromium] Fix WebGL build after CustomGetter constructor changes + https://bugs.webkit.org/show_bug.cgi?id=30020 + + * page/DOMWindow.idl: + Changed CustomGetter to JSCCustomGetter for CanvasArray constructors. + +2009-10-02 Patrick Mueller <Patrick_Mueller@us.ibm.com> + + Reviewed by Timothy Hatcher. + + Web Inspector: text in a "Request Payload" section disappears on selection + https://bugs.webkit.org/show_bug.cgi?id=29967 + + No new tests. + + * inspector/front-end/ResourceView.js: + (WebInspector.ResourceView.prototype._refreshRequestPayload): + +2009-10-02 Vitaly Repeshko <vitalyr@chromium.org> + + Reviewed by Dimitri Glazkov. + + [V8] Recursion guard for V8Proxy::callFunction. + Fixes http://crbug.com/23278. + https://bugs.webkit.org/show_bug.cgi?id=29974 + + Test: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html + + * bindings/v8/V8Proxy.cpp: + (WebCore::V8Proxy::callFunction): + +2009-10-02 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Jon Honeycutt. + + Fix test breakages by adding null checks, and putting inspector code in + ENABLE(INSPECTOR). + + * dom/Document.cpp: + (WebCore::Document::finishedParsing): + * page/DOMWindow.cpp: + (WebCore::DOMWindow::dispatchLoadEvent): + +2009-10-02 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Simon Hausmann. + + Clean up the QNetworkReplyHandler to only apply HTTP headers + for protocols in the HTTP family. + + * platform/network/qt/QNetworkReplyHandler.cpp: + (WebCore::QNetworkReplyHandler::finish): + (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): + +2009-10-02 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Simon Hausmann. + + Move error check into sendResponseIfNeeded() as suggested + by Eric Seidel. Also, remove some dead code. + + * platform/network/qt/QNetworkReplyHandler.cpp: + (WebCore::QNetworkReplyHandler::finish): + (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): + +2009-10-02 Enrica Casucci <enrica@apple.com> + + Reviewed by Adele Peterson. + + Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting. + <rdar://problem/7148712> + https://bugs.webkit.org/show_bug.cgi?id=28992 + + Test: editing/selection/replace-selection-crash.html + + * editing/ReplaceSelectionCommand.cpp: + (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Handle properly the case of + the destination position matching the end of the paragraph to move. + +2009-10-02 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Dimitri Glazkov. + + Implement per-storage-area quotas for LocalStorage + https://bugs.webkit.org/show_bug.cgi?id=29991 + + I put 90% of the code in StorageMap since the decision to allow an update is + closely tied to quota tracking. The quota is set via a page's Settings class. + Like with the local storage path and whether it's enabled, it's assumed that + all pages in the same group will have the same settings. The setting defaults + to 5mb which is what the spec suggests, but it can easily be changed to + anything else--including StorageMap::noQuota. Any values in LocalStorage are + grandfathered in regarudless of quota, so importItem only tracks (and will + never block) imports. + + I believe this change is a good transition to more complex quota management. + For example, if we wanted to track quotas in the SQLite DB, then we'd just add + a function to the StorageMap that sets the quota. This would be fine since all + use of LocalStorage is blocked on the import completing, so you'd never hit a + quota error in the mean time. Also, if embedders wanted to ask the user + whether to expand the quota whenever it's hit (before deciding whether or not + to raise an exception), a callback via the chrome client should be fairly easy. + That said, I think it's best to add these features in steps rather than one + huge patch. (Both of these are on my TODO list, btw.) + + Included is a layout test that verifies the behavior. It assumes the default + quota is 5mb (since that's what Settings defaults to). + + Test: storage/domstorage/localstorage/quota.html + + * page/PageGroup.cpp: + (WebCore::PageGroup::localStorage): + * page/Settings.cpp: + (WebCore::Settings::Settings): + (WebCore::Settings::setLocalStorageQuota): + * page/Settings.h: + (WebCore::Settings::localStorageQuota): + * storage/StorageAreaImpl.cpp: + (WebCore::StorageAreaImpl::create): + (WebCore::StorageAreaImpl::StorageAreaImpl): + (WebCore::StorageAreaImpl::setItem): + (WebCore::StorageAreaImpl::clear): + * storage/StorageAreaImpl.h: + * storage/StorageMap.cpp: + (WebCore::StorageMap::create): + (WebCore::StorageMap::StorageMap): + (WebCore::StorageMap::copy): + (WebCore::StorageMap::setItem): + (WebCore::StorageMap::removeItem): + (WebCore::StorageMap::importItem): + * storage/StorageMap.h: + (WebCore::StorageMap::quota): + * storage/StorageNamespace.cpp: + (WebCore::StorageNamespace::localStorageNamespace): + * storage/StorageNamespace.h: + * storage/StorageNamespaceImpl.cpp: + (WebCore::StorageNamespaceImpl::localStorageNamespace): + (WebCore::StorageNamespaceImpl::sessionStorageNamespace): + (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): + (WebCore::StorageNamespaceImpl::copy): + (WebCore::StorageNamespaceImpl::storageArea): + * storage/StorageNamespaceImpl.h: + +2009-10-02 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Timothy Hatcher. + + Database Inspector crashes Safari when table has more than 21 columns + https://bugs.webkit.org/show_bug.cgi?id=29924 + + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel.prototype.dataGridForResult): adjust the minimum column width percentage to be flexible for many columns. + +2009-10-02 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Timothy Hatcher. + + Fixes <http://webkit.org/b/14370>. + Inspector's timeline should record when certain DOM events fired. + + This patch adds calls into the Web Inspector when the main frame + fires an load event, and when the document fires its DOMContent + event. Once these values are passed in, they are sent to the Web Inspector + as a timing change, and these are denoted by vertical lines in the resources + panel (blue for DOM Content, red for load event). + + * English.lproj/localizedStrings.js: Added tooltip text. + * dom/Document.cpp: + (WebCore::Document::finishedParsing): Added an Inspector callback for DOM Content. + * inspector/InspectorController.cpp: + (WebCore::InspectorController::mainResourceFiredDOMContentEvent): Tell the main resource it got the event. + (WebCore::InspectorController::mainResourceFiredLoadEvent): Ditto. + * inspector/InspectorController.h: + * inspector/InspectorResource.cpp: + (WebCore::InspectorResource::InspectorResource): Added new variables. + (WebCore::InspectorResource::updateScriptObject): Send new variables to inspector.js. + (WebCore::InspectorResource::markDOMContentEventTime): Send a TimingChange event. + (WebCore::InspectorResource::markLoadEventTime): Ditto. + * inspector/InspectorResource.h: + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel.prototype.get mainResourceLoadTime): + (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): + (WebInspector.ResourcesPanel.prototype.get mainResourceDOMContentTime): + (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): + (WebInspector.ResourcesPanel.prototype.reset): + (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Draw dividers for event timings. + (WebInspector.ResourceTimeCalculator.prototype.computePercentageFromEventTime): + * inspector/front-end/inspector.css: + * inspector/front-end/inspector.js: + (WebInspector.updateResource): + * page/DOMWindow.cpp: + (WebCore::DOMWindow::dispatchLoadEvent): Add an Inspector callback for the Load event. + +2009-10-02 Dave Hyatt <hyatt@apple.com> + + Reviewed by Adam Roben. + + Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns. + + * WebCore.base.exp: + * dom/Document.cpp: + (WebCore::Document::pageGroupUserSheets): + * page/Frame.cpp: + (WebCore::Frame::injectUserScriptsForWorld): + * page/PageGroup.cpp: + (WebCore::PageGroup::addUserScript): + (WebCore::PageGroup::addUserStyleSheet): + (WebCore::PageGroup::removeUserContentWithURLForWorld): + (WebCore::PageGroup::removeUserContentForWorld): + * page/PageGroup.h: + * page/UserContentURLPattern.cpp: + (WebCore::UserContentURLPattern::matchesPatterns): + * page/UserContentURLPattern.h: + * page/UserScript.h: + (WebCore::UserScript::UserScript): + (WebCore::UserScript::whitelist): + (WebCore::UserScript::blacklist): + * page/UserStyleSheet.h: + (WebCore::UserStyleSheet::UserStyleSheet): + (WebCore::UserStyleSheet::whitelist): + (WebCore::UserStyleSheet::blacklist): + +2009-10-02 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Darin Adler. + + Build fix when SVG is not enabled + https://bugs.webkit.org/show_bug.cgi?id=30011 + + Move TextRenderingMode related functions out from + the ENABLE(SVG) guard. + + * css/CSSPrimitiveValueMappings.h: + (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): + (WebCore::CSSPrimitiveValue::operator TextRenderingMode): + +2009-10-02 Kenneth Russell <kbr@google.com> + + Reviewed by Oliver Hunt. + + WebGL crashes with recent CanvasArray change + https://bugs.webkit.org/show_bug.cgi?id=30018 + + Test: fast/canvas/webgl/array-unit-tests.html + + * html/canvas/CanvasArray.cpp: + (WebCore::CanvasArray::CanvasArray): + Fix bug where PassRefPtr was tested after transferring value to RefPtr. + +2009-10-02 Steve Falkenburg <sfalken@apple.com> + + Reviewed by Mark Rowe. + + <https://bugs.webkit.org/show_bug.cgi?id=29989> + Safari version number shouldn't be exposed in WebKit code + + For a WebKit version of 532.3.4: + Product version is: 5.32.3.4 (was 4.0.3.0) + File version is: 5.32.3.4 (was 4.532.3.4) + + * WebCore.vcproj/QTMovieWin.rc: + +2009-10-02 Stephen White <senorblanco@chromium.org> + + Reviewed by Dimitri Glazkov. + + Enable two point radial gradients in Chromium/Skia. + + https://bugs.webkit.org/show_bug.cgi?id=30017 + + Covered by the following tests: + + LayoutTests/svg/W3C-SVG-1.1/pservers-grad-13-b.svg + LayoutTests/fast/backgrounds/svg-as-background-3.html + LayoutTests/fast/gradients/generated-gradients.html + LayoutTests/fast/gradients/simple-gradients.html + + * platform/graphics/skia/GradientSkia.cpp: + (WebCore::Gradient::platformGradient): + +2009-10-02 Norbert Leser <norbert.leser@nokia.com> + + Reviewed by Simon Hausmann. + + Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR. + Otherwise, it is inconsistent with class declaration of QCursor. + + No new tests. + + * platform/qt/QWebPageClient.h: + +2009-10-02 Philippe Normand <pnormand@igalia.com> + + Reviewed by Gustavo Noronha. + + [GTK] missing support for anamorphic PAR video size + https://bugs.webkit.org/show_bug.cgi?id=29717 + + cleanup of caps handling in the video sink + + * platform/graphics/gtk/VideoSinkGStreamer.cpp: + (webkit_video_sink_set_caps): + +2009-10-02 Prasanth Ullattil <prasanth.ullattil@nokia.com> + + Reviewed by Simon Hausmann. + + Fix compiler warnings about unused function arguments. + + * bridge/qt/qt_class.h: + * bridge/qt/qt_runtime.cpp: + (JSC::Bindings::QtRuntimeMetaMethod::call): + (JSC::Bindings::QtRuntimeConnectionMethod::call): + * dom/XMLTokenizerQt.cpp: + (WebCore::XMLTokenizer::initializeParserContext): + * platform/graphics/qt/FontCacheQt.cpp: + (WebCore::FontCache::getTraitsInFamily): + (WebCore::FontCache::getCachedFontPlatformData): + * platform/graphics/qt/FontFallbackListQt.cpp: + (WebCore::FontFallbackList::setPlatformFont): + * platform/graphics/qt/FontQt.cpp: + (WebCore::Font::offsetForPositionForComplexText): + * platform/graphics/qt/GraphicsContextQt.cpp: + (WebCore::GraphicsContext::drawLineForText): + (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): + (WebCore::GraphicsContext::setPlatformShadow): + (WebCore::GraphicsContext::setURLForRect): + * platform/graphics/qt/IconQt.cpp: + (WebCore::Icon::createIconForFiles): + * platform/graphics/qt/ImageBufferQt.cpp: + (WebCore::ImageBuffer::ImageBuffer): + * platform/graphics/qt/ImageDecoderQt.cpp: + (WebCore::ImageDecoderQt::frameBufferAtIndex): + * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: + (WebCore::MediaPlayerPrivate::supportsType): + (WebCore::MediaPlayerPrivate::setEndTime): + * platform/graphics/qt/SimpleFontDataQt.cpp: + (WebCore::SimpleFontData::containsCharacters): + * platform/graphics/qt/StillImageQt.h: + (WebCore::StillImage::destroyDecodedData): + * platform/network/qt/DnsPrefetchHelper.h: + (WebCore::DnsPrefetchHelper::lookedUp): + * platform/qt/ContextMenuQt.cpp: + (WebCore::ContextMenu::setPlatformDescription): + * platform/qt/DragDataQt.cpp: + (WebCore::DragData::asURL): + * platform/qt/PopupMenuQt.cpp: + (WebCore::PopupMenu::populate): + * platform/qt/RenderThemeQt.cpp: + (WebCore::RenderThemeQt::supportsFocusRing): + (WebCore::RenderThemeQt::systemFont): + (WebCore::RenderThemeQt::adjustButtonStyle): + (WebCore::RenderThemeQt::adjustMenuListButtonStyle): + (WebCore::RenderThemeQt::paintMediaSeekBackButton): + (WebCore::RenderThemeQt::paintMediaSeekForwardButton): + * platform/qt/ScrollViewQt.cpp: + (WebCore::ScrollView::platformAddChild): + * platform/qt/SearchPopupMenuQt.cpp: + (WebCore::SearchPopupMenu::saveRecentSearches): + (WebCore::SearchPopupMenu::loadRecentSearches): + * platform/qt/TemporaryLinkStubs.cpp: + (WebCore::signedPublicKeyAndChallengeString): + * platform/qt/WidgetQt.cpp: + (WebCore::Widget::paint): + * xml/XSLStyleSheetQt.cpp: + (WebCore::XSLStyleSheet::loadChildSheet): + (WebCore::XSLStyleSheet::setParentStyleSheet): + * xml/XSLTProcessorQt.cpp: + (WebCore::XSLTMessageHandler::handleMessage): + (WebCore::XSLTProcessor::transformToString): + +2009-10-02 Philippe Normand <pnormand@igalia.com> + + Reviewed by Gustavo Noronha. + + [GTK] missing support for anamorphic PAR video size + https://bugs.webkit.org/show_bug.cgi?id=29717 + + Scale the cairo surface of the video sink depending on the + pixel-aspect-ratio of the video buffer to paint. Also + destruct/re-create the surface when setSize() is called with a new + size. + + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::MediaPlayerPrivate::naturalSize): + (WebCore::MediaPlayerPrivate::setSize): + (WebCore::MediaPlayerPrivate::paint): + * platform/graphics/gtk/VideoSinkGStreamer.cpp: + (webkit_video_sink_idle_func): + +2009-10-02 Ben Murdoch <benm@google.com> + + Reviewed by David Kilzer. + + Stale database version persists through browser refresh (changeVersion doesn't work) + https://bugs.webkit.org/show_bug.cgi?id=27836 + + Tests: storage/change-version-handle-reuse.html + storage/change-version.html + + * bindings/v8/custom/V8DatabaseCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): Implement the V8 binding for database.changeVersion(). + (WebCore::createTransaction): Fix a bug that was checking the wrong argument index to save the success callback. + * storage/Database.cpp: + (WebCore::updateGuidVersionMap): Safely update the Guid/version hash map. + (WebCore::Database::~Database): Remove code that removes the database from the guid->database and guid->version maps. + (WebCore::Database::setVersionInDatabase): Add a comment to explain some behaviour. + (WebCore::Database::close): Move the code that updates the maps from the destructor to here. + (WebCore::Database::performOpenAndVerify): Call updateGuidVersionMap instead of setting the hash map directly. + (WebCore::Database::setExpectedVersion): Update the in memory guid->version map when we want to update the database version. + +2009-10-02 Janne Koskinen <janne.p.koskinen@digia.com> + + Reviewed by Simon Hausmann. + + Partial WINSCW build fix. + + Add parentheses around the function pointer declaration, similar to the + second hunk in r48825. + + * loader/CachedResourceHandle.h: + +2009-10-02 Adam Barth <abarth@webkit.org> + + Unreviewed attempted build fix by Xcode magic. + + * WebCore.xcodeproj/project.pbxproj: + +2009-10-02 Adam Barth <abarth@webkit.org> + + Unreviewed build fix. Actually add the new files. + + * loader/RedirectScheduler.cpp: Added. + (WebCore::ScheduledRedirection::): + (WebCore::ScheduledRedirection::ScheduledRedirection): + (WebCore::RedirectScheduler::RedirectScheduler): + (WebCore::RedirectScheduler::~RedirectScheduler): + (WebCore::RedirectScheduler::redirectScheduledDuringLoad): + (WebCore::RedirectScheduler::clear): + (WebCore::RedirectScheduler::scheduleRedirect): + (WebCore::RedirectScheduler::mustLockBackForwardList): + (WebCore::RedirectScheduler::scheduleLocationChange): + (WebCore::RedirectScheduler::scheduleFormSubmission): + (WebCore::RedirectScheduler::scheduleRefresh): + (WebCore::RedirectScheduler::locationChangePending): + (WebCore::RedirectScheduler::scheduleHistoryNavigation): + (WebCore::RedirectScheduler::timerFired): + (WebCore::RedirectScheduler::schedule): + (WebCore::RedirectScheduler::startTimer): + (WebCore::RedirectScheduler::cancel): + * loader/RedirectScheduler.h: Added. + +2009-10-01 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Move RedirectScheduler to its own file + https://bugs.webkit.org/show_bug.cgi?id=29952 + + This change is purely code motion. + + No behavior change. + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * WebCoreSources.bkl: + * loader/FrameLoader.cpp: + * loader/FrameLoader.h: + * loader/RedirectScheduler.cpp: Added. + (WebCore::ScheduledRedirection::): + (WebCore::ScheduledRedirection::ScheduledRedirection): + (WebCore::RedirectScheduler::RedirectScheduler): + (WebCore::RedirectScheduler::~RedirectScheduler): + (WebCore::RedirectScheduler::redirectScheduledDuringLoad): + (WebCore::RedirectScheduler::clear): + (WebCore::RedirectScheduler::scheduleRedirect): + (WebCore::RedirectScheduler::mustLockBackForwardList): + (WebCore::RedirectScheduler::scheduleLocationChange): + (WebCore::RedirectScheduler::scheduleFormSubmission): + (WebCore::RedirectScheduler::scheduleRefresh): + (WebCore::RedirectScheduler::locationChangePending): + (WebCore::RedirectScheduler::scheduleHistoryNavigation): + (WebCore::RedirectScheduler::timerFired): + (WebCore::RedirectScheduler::schedule): + (WebCore::RedirectScheduler::startTimer): + (WebCore::RedirectScheduler::cancel): + * loader/RedirectScheduler.h: Added. + +2009-10-02 Dave MacLachlan <dmaclach@gmail.com> + + Reviewed by David Levin. + + Clean up warnings in WebCore/bindings/v8/npruntime.cpp + https://bugs.webkit.org/show_bug.cgi?id=29971 + + Gets rid of warnings on gcc about using anonymous namespaces + warning: 'StringKeyHashTraits' has a base + 'WTF::GenericHashTraits<<unnamed>::StringKey>' + whose type uses the anonymous namespace + and + warning: 'WTF::PairHashTraits<StringKeyHashTraits, + WTF::HashTraits<PrivateIdentifier*> >' has a base + 'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey, + PrivateIdentifier*> >' whose type uses the anonymous namespace + + No tests required. + + * bindings/v8/npruntime.cpp: + +2009-10-01 Mark Rowe <mrowe@apple.com> + + Fix the Tiger build. Don't unconditionally enable 3D canvas as it is not supported on Tiger. + + * Configurations/FeatureDefines.xcconfig: + +2009-10-01 Chris Marrin <cmarrin@apple.com> + + Reviewed by Oliver Hunt. + + Turn on ENABLE_3D_CANVAS in TOT + https://bugs.webkit.org/show_bug.cgi?id=29906 + + Fixed a bug found when running tests with flag on + + * Configurations/FeatureDefines.xcconfig: + * WebCore.base.exp: + * bindings/js/JSCanvasArrayBufferConstructor.h: + (WebCore::construct): + * html/HTMLCanvasElement.cpp: + (WebCore::HTMLCanvasElement::getContext): + * html/canvas/CanvasArray.cpp: + (WebCore::CanvasArray::CanvasArray): + * html/canvas/CanvasByteArray.cpp: + (WebCore::CanvasByteArray::create): + * html/canvas/CanvasFloatArray.cpp: + (WebCore::CanvasFloatArray::create): + * html/canvas/CanvasIntArray.cpp: + (WebCore::CanvasIntArray::create): + * html/canvas/CanvasShortArray.cpp: + (WebCore::CanvasShortArray::create): + * html/canvas/CanvasUnsignedByteArray.cpp: + (WebCore::CanvasUnsignedByteArray::create): + * html/canvas/CanvasUnsignedIntArray.cpp: + (WebCore::CanvasUnsignedIntArray::create): + * html/canvas/CanvasUnsignedShortArray.cpp: + (WebCore::CanvasUnsignedShortArray::create): + * page/Settings.cpp: + (WebCore::Settings::Settings): + (WebCore::Settings::setWebGLEnabled): + * page/Settings.h: + (WebCore::Settings::webGLEnabled): + +2009-10-01 Beth Dakin <bdakin@apple.com> + + Reviewed by Dan Bernstein. + + Fix for <rdar://problem/7264725> Re-add a vendor prefix to box- + shadow (29927) + -and corresponding- + https://bugs.webkit.org/show_bug.cgi?id=29927 + + * css/CSSComputedStyleDeclaration.cpp: + (WebCore::): + (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): + * css/CSSParser.cpp: + (WebCore::CSSParser::parseValue): + (WebCore::ShadowParseContext::ShadowParseContext): + (WebCore::ShadowParseContext::commitValue): + (WebCore::ShadowParseContext::commitLength): + (WebCore::ShadowParseContext::commitColor): + (WebCore::cssPropertyID): + * css/CSSPropertyNames.in: + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::applyProperty): + * page/animation/AnimationBase.cpp: + (WebCore::ensurePropertyMap): + +2009-10-01 Beth Dakin <bdakin@apple.com> + + Rubber-stamped by Sam Weinig. + + At bad merge at some point in the development of my patch must have + put TextRenderMode.h in a weird spot in the xcodeproj. Moving it + back where it belongs! + + * WebCore.xcodeproj/project.pbxproj: + +2009-09-30 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Remove FrameLoader::schedule* APIs + https://bugs.webkit.org/show_bug.cgi?id=29950 + + Change clients of FrameLoader::schedule* to call redirectScheduler + directly. + + No behavior change. + + * bindings/js/JSDOMWindowCustom.cpp: + (WebCore::JSDOMWindow::setLocation): + (WebCore::createWindow): + (WebCore::JSDOMWindow::open): + * bindings/js/JSDocumentCustom.cpp: + (WebCore::JSDocument::setLocation): + * bindings/js/JSLocationCustom.cpp: + (WebCore::navigateIfAllowed): + (WebCore::JSLocation::reload): + * bindings/v8/V8Utilities.cpp: + (WebCore::navigateIfAllowed): + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::createWindow): + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8LocationCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * dom/Document.cpp: + (WebCore::Document::implicitClose): + (WebCore::Document::processHttpEquiv): + * html/HTMLTokenizer.cpp: + (WebCore::HTMLTokenizer::write): + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::requestFrame): + (WebCore::FrameLoader::submitForm): + (WebCore::FrameLoader::receivedFirstData): + * loader/FrameLoader.h: + * loader/appcache/ApplicationCacheGroup.cpp: + (WebCore::ApplicationCacheGroup::selectCache): + * page/History.cpp: + (WebCore::History::back): + (WebCore::History::forward): + (WebCore::History::go): + +2009-10-01 Beth Dakin <bdakin@apple.com> + + Just removing a comment I accidentally committed earlier. + + * platform/graphics/mac/SimpleFontDataMac.mm: + (WebCore::SimpleFontData::getCFStringAttributes): + +2009-09-30 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Darin Adler. + + Clean up use of const and mutable in StorageMap + https://bugs.webkit.org/show_bug.cgi?id=29933 + + What's the point of having every single member variable be mutable and nearly + every method be const? Let's clean it up. + + * storage/StorageMap.cpp: + (WebCore::StorageMap::setIteratorToIndex): + (WebCore::StorageMap::key): + (WebCore::StorageMap::importItem): + * storage/StorageMap.h: + +2009-10-01 Beth Dakin <bdakin@apple.com> + + Reviewed by Dave Hyatt. + + Fix for <rdar://problem/6934421> Support CSS for Text Kerning and + ligature + -and corresponding- + https://bugs.webkit.org/show_bug.cgi?id=6136 + + This patch makes the SVG CSS property text-rendering work with any + HTML, much like it does in Firefox. It accepts four possible input + values: auto, optimizeSpeed, optimizeLegibility, and + geometricPrecision. Right now, in this implementation, here is what + those values correspond to: + + auto = optimizeSpeed = what we normally when the value's not set + optimizeLegibility = geometricPrecision = ligatures kerning + + Add new file TextRenderingMode.h to the project files. + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + + CSS support for the new CSSPropertyTextRendering + * css/CSSComputedStyleDeclaration.cpp: + (WebCore::): + (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): + * css/CSSParser.cpp: + (WebCore::CSSParser::parseValue): + * css/CSSPrimitiveValueMappings.h: + (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): + (WebCore::CSSPrimitiveValue::operator TextRenderingMode): + * css/CSSPropertyNames.in: + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::applyProperty): + * css/CSSValueKeywords.in: + + All the old SVG CSS support for this property can go away. When + it's used in SVG, it will just fall into the normal HTML case. + * css/SVGCSSComputedStyleDeclaration.cpp: + (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): + * css/SVGCSSParser.cpp: + (WebCore::CSSParser::parseSVGValue): + * css/SVGCSSPropertyNames.in: + * css/SVGCSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::applySVGProperty): + * css/SVGCSSValueKeywords.in: + + FontDescription stores the m_textRendering bit. + * platform/graphics/FontDescription.h: + (WebCore::FontDescription::FontDescription): + (WebCore::FontDescription::textRenderingMode): + (WebCore::FontDescription::setTextRenderingMode): + (WebCore::FontDescription::operator==): + + We want to fall into the complex text rendering code path if + kerning and ligatures have been enabled with this property. + * platform/graphics/FontFastPath.cpp: + (WebCore::Font::canUseGlyphCache): + + Now takes a TextRenderingMode as a parameter. + * platform/graphics/SimpleFontData.h: + + New header for the enum. + * platform/graphics/TextRenderingMode.h: Added. + (WebCore::): + + getCFStringAttributes() now takes a TextRenderingMode as an + attribute. + * platform/graphics/mac/CoreTextController.cpp: + (WebCore::CoreTextController::collectCoreTextRunsForCharacters): + + Enable kerning and ligatures whenever the TextRenderingMode is + OptimizeLegibility or GeometricPrecision + * platform/graphics/mac/FontMacATSUI.mm: + (WebCore::disableLigatures): + (WebCore::initializeATSUStyle): + (WebCore::ATSULayoutParameters::initialize): + * platform/graphics/mac/SimpleFontDataMac.mm: + (WebCore::SimpleFontData::getCFStringAttributes): + + More SVG CSS stuff that isn't needed anymore since SVG will use the + new HTML CSS implementation. + * rendering/style/SVGRenderStyle.h: + (WebCore::SVGRenderStyle::InheritedFlags::operator==): + (WebCore::SVGRenderStyle::setBitDefaults): + * rendering/style/SVGRenderStyleDefs.h: + +2009-10-01 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Timothy Hatcher. + + Use isClosure property of scope proxy to decide whether the + scope is a closure. + + https://bugs.webkit.org/show_bug.cgi?id=29965 + + * inspector/front-end/ScopeChainSidebarPane.js: + (WebInspector.ScopeChainSidebarPane.prototype.update): + +2009-10-01 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dave Hyatt. + + Odd color transitions on anchors with transition-property: all + https://bugs.webkit.org/show_bug.cgi?id=29911 + + When transitioning maybe-invalid colors, if the source and destination + color are both invalid, then don't animate. + + This fixes an issue where a child element of an element running a color + transition, with -webkit-transition-property:all, would show a color change. + This happened because the "maybe invalid color" logic copied the color style + into -webkit-text-fill-color for both endpoints, causing -webkit-text-fill-color + to animate while the transition ran, and to then to disappear when the transition + finished. + + Test: transitions/color-transition-all.html + + * page/animation/AnimationBase.cpp: + (WebCore::PropertyWrapperMaybeInvalidColor::equals): + (WebCore::PropertyWrapperMaybeInvalidColor::blend): + +2009-10-01 Victor Wang <victorw@chromium.org> + + Reviewed by Oliver Hunt. + + Allow dragging a node who has child nodes. + + https://bugs.webkit.org/show_bug.cgi?id=28632 + + Test: fast/events/drag-parent-node.html + + * page/EventHandler.cpp: + (WebCore::EventHandler::shouldDragAutoNode): + +2009-10-01 Philippe Normand <pnormand@igalia.com> + + Reviewed by Gustavo Noronha. + + [GTK] media player: better mute support + https://bugs.webkit.org/show_bug.cgi?id=29960 + + Handle volume and mute state with the two corresponding properties + of playbin2. + + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::MediaPlayerPrivate::setMuted): + (WebCore::MediaPlayerPrivate::setVolume): + +2009-10-01 Philippe Normand <pnormand@igalia.com> + + Reviewed by Gustavo Noronha. + + [GTK] video sink pad template colorspace is wrong + https://bugs.webkit.org/show_bug.cgi?id=29953 + + Set sink pad template colorspace depending on byte order. + + * platform/graphics/gtk/VideoSinkGStreamer.cpp: + (webkit_video_sink_idle_func): + +2009-10-01 Vitaly Repeshko <vitalyr@chromium.org> + + Reviewed by Dimitri Glazkov. + + [V8] Refactored V8 event listeners: + (This change should fix http://crbug.com/21079 and + https://bugs.webkit.org/show_bug.cgi?id=29093.) + o All listeners use weak handles to JS objects to avoid creating + cycles and leaking memory. + o "Object" variants of listeners removed. + o All event accessor callbacks are generated. + o Custom event accessors removed. + o All wrappers have hidden dependencies on their listeners to + prevent listeners from being collected. + o All variats of getEventListener function grouped in V8DOMWrapper. + o Pointers to C+EventListener wrappers are stored in JS objects + instead of event listener lists. + https://bugs.webkit.org/show_bug.cgi?id=29825 + + * WebCore.gypi: Removed "Object" listeners. + * bindings/scripts/CodeGeneratorV8.pm: Now handles event accessors. + * bindings/v8/DOMObjectsInclude.h: + + V8AbstractEventListener manages weak JS handle: + * bindings/v8/V8AbstractEventListener.cpp: + (WebCore::weakEventListenerCallback): + (WebCore::V8AbstractEventListener::V8AbstractEventListener): + (WebCore::V8AbstractEventListener::~V8AbstractEventListener): + (WebCore::V8AbstractEventListener::handleEvent): + (WebCore::V8AbstractEventListener::disposeListenerObject): + (WebCore::V8AbstractEventListener::setListenerObject): + * bindings/v8/V8AbstractEventListener.h: + (WebCore::V8AbstractEventListener::cast): + (WebCore::V8AbstractEventListener::isLazy): + (WebCore::V8AbstractEventListener::getListenerObject): + (WebCore::V8AbstractEventListener::getExistingListenerObject): + (WebCore::V8AbstractEventListener::hasExistingListenerObject): + (WebCore::V8AbstractEventListener::disconnectFrame): + (WebCore::V8AbstractEventListener::disconnected): + (WebCore::V8AbstractEventListener::prepareListenerObject): + (WebCore::V8AbstractEventListener::lineNumber): + (WebCore::V8AbstractEventListener::virtualisAttribute): + + Grouped getEventListener functions: + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::getTemplate): + (WebCore::V8DOMWrapper::getEventListener): + * bindings/v8/V8DOMWrapper.h: + + Removed most event listener objects bookkeeping: + * bindings/v8/V8EventListenerList.cpp: + * bindings/v8/V8EventListenerList.h: + (WebCore::V8EventListenerList::findWrapper): + (WebCore::V8EventListenerList::clearWrapper): + (WebCore::V8EventListenerList::doFindWrapper): + (WebCore::V8EventListenerList::getHiddenProperty): + (WebCore::V8EventListenerList::findOrCreateWrapper): + + Added hidden properties for storing EventListener wrappers: + * bindings/v8/V8HiddenPropertyName.cpp: + (WebCore::V8HiddenPropertyName::listener): + (WebCore::V8HiddenPropertyName::attributeListener): + * bindings/v8/V8HiddenPropertyName.h: + + * bindings/v8/V8LazyEventListener.cpp: + (WebCore::V8LazyEventListener::V8LazyEventListener): + (WebCore::V8LazyEventListener::callListenerFunction): + (WebCore::V8LazyEventListener::prepareListenerObject): + * bindings/v8/V8LazyEventListener.h: + (WebCore::V8LazyEventListener::isLazy): + * bindings/v8/V8ObjectEventListener.cpp: Removed. + * bindings/v8/V8ObjectEventListener.h: Removed. + * bindings/v8/V8Proxy.cpp: + (WebCore::V8Proxy::disconnectFrame): + (WebCore::V8Proxy::disconnectEventListeners): + * bindings/v8/V8Proxy.h: + * bindings/v8/V8WorkerContextEventListener.cpp: + (WebCore::V8WorkerContextEventListener::reportError): + (WebCore::V8WorkerContextEventListener::getReceiverObject): + * bindings/v8/V8WorkerContextEventListener.h: + * bindings/v8/V8WorkerContextObjectEventListener.cpp: Removed. + * bindings/v8/V8WorkerContextObjectEventListener.h: Removed. + * bindings/v8/WorkerContextExecutionProxy.cpp: + (WebCore::WorkerContextExecutionProxy::dispose): + (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): + (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener): + * bindings/v8/WorkerContextExecutionProxy.h: + * bindings/v8/custom/V8AbstractWorkerCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8CustomBinding.h: + * bindings/v8/custom/V8CustomEventListener.cpp: + (WebCore::V8EventListener::V8EventListener): + (WebCore::V8EventListener::getListenerFunction): + (WebCore::V8EventListener::callListenerFunction): + * bindings/v8/custom/V8CustomEventListener.h: + * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: + * bindings/v8/custom/V8MessagePortCustom.cpp: + (WebCore::getEventListener): + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8NodeCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8NotificationCenterCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8SVGElementInstanceCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8WebSocketCustom.cpp: + * bindings/v8/custom/V8WorkerContextCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8WorkerCustom.cpp: + * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: + * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: + +2009-10-01 Alexis Menard <alexis.menard@nokia.com> + + Reviewed by Tor Arne Vestbø. + + Rename QWebGraphicsItem to QGraphicsWebView + + * WebCore.pro: + +2009-10-01 Dumitru Daniliuc <dumi@chromium.org> + + Reviewed by Dimitri Glazkov. + + Read-only transactions do not change file sizes and therefore + should not trigger quota updates. + + https://bugs.webkit.org/show_bug.cgi?id=29945 + + * storage/SQLTransaction.cpp: + (WebCore::SQLTransaction::openTransactionAndPreflight): + (WebCore::SQLTransaction::runStatements): + +2009-09-30 Timothy Hatcher <timothy@apple.com> + + Fix list box scrolling by correctly overriding the scroll() + function on RenderBox. + + <rdar://problem/7255440> REGRESSION (r48683): Mousewheel scrolling + of listboxes is broken (29756) + + Reviewed by Dan Bernstein. + + * rendering/RenderListBox.cpp: + (WebCore::RenderListBox::scroll): + * rendering/RenderListBox.h: + * rendering/RenderTextControlSingleLine.cpp: + (WebCore::RenderTextControlSingleLine::scroll): + * rendering/RenderTextControlSingleLine.h: + +2009-10-01 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Timothy Hatcher. + + Make a copy of listeners array before dispatching an event in + WebInspector.Object.prototype.dispatchEventToListeners. Otherwise if current + listener removes itself from the array next listener will be skipped. + + https://bugs.webkit.org/show_bug.cgi?id=29920 + + * inspector/front-end/Object.js: + (WebInspector.Object.prototype.dispatchEventToListeners): make a copy of listeners array before dispatching an event + +2009-10-01 Martin Robinson <martin.james.robinson@gmail.com> + + Reviewed by Xan Lopez. + + [GTK] GtkIMContext filtering interferes with DOM key events + https://bugs.webkit.org/show_bug.cgi?id=28733 + + Ensure that keyboard events filtered by the GtkIMContext still create + the proper DOM events. + + No tests added. Instead previously skipped tests have been enabled. + + * platform/gtk/KeyEventGtk.cpp: + (WebCore::keyIdentifierForGdkKeyCode): + (WebCore::singleCharacterString): + +2009-10-01 Philippe Normand <pnormand@igalia.com> + + Reviewed by Xan Lopez. + + [GTK] data: uri support in media player + https://bugs.webkit.org/show_bug.cgi?id=29842 + + New GStreamer element to handle data: uris. For now only base64 + encoded data is supported. Decoded data is handed over to + giostreamsrc. + + * GNUmakefile.am: + * platform/graphics/gtk/DataSourceGStreamer.cpp: Added. + (_do_init): + (webkit_data_src_base_init): + (webkit_data_src_class_init): + (webkit_data_src_reset): + (webkit_data_src_init): + (webkit_data_src_finalize): + (webkit_data_src_uri_get_type): + (webkit_data_src_uri_get_protocols): + (webkit_data_src_uri_get_uri): + (webkit_data_src_uri_set_uri): + (webkit_data_src_uri_handler_init): + * platform/graphics/gtk/DataSourceGStreamer.h: Added. + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: + (WebCore::do_gst_init): + (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): + (WebCore::MediaPlayerPrivate::mimeTypeCache): + +2009-09-30 Daniel Bates <dbates@webkit.org> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=29944 + + Reduces false positives in the XSSAuditor by explicitly allowing requests + that do not contain illegal URI characters. + + As a side effect of this change, the tests property-inject.html, + property-escape-noquotes.html, and property-escape-noquotes-tab-slash-chars.html + fail because these attacks do not contain any illegal URI characters and + thus are now allowed by the XSSAuditor, where previously they weren't. A future + change may reinstate this functionality. + + Tests: http/tests/security/xssAuditor/script-tag-safe2.html + http/tests/security/xssAuditor/script-tag-safe3.html + + * page/XSSAuditor.cpp: + (WebCore::isIllegalURICharacter): Added method. + (WebCore::XSSAuditor::canEvaluate): + (WebCore::XSSAuditor::canCreateInlineEventListener): + (WebCore::XSSAuditor::findInRequest): Added parameter + allowRequestIfNoIllegalURICharacters. + * page/XSSAuditor.h: + +2009-09-30 Oliver Hunt <oliver@apple.com> + + Reviewed by Maciej Stachowiak. + + reproducible freeze and crash on closing form popup at bosch-home.nl + https://bugs.webkit.org/show_bug.cgi?id=28948 + + showModalDialog calls getDirect on what is actually a window shell, + so ends up not getting a value (since no value can ever be placed + directly on the shell), which leads to incorrect behaviour. + + We use a manual test rather than automatic as it was not + possible to get a modal run loop to work inside DRT. + + * bindings/js/JSDOMWindowCustom.cpp: + (WebCore::JSDOMWindow::showModalDialog): + * manual-tests/showModalDialog-returnValue.html: manual testcase. + +2009-09-30 Kent Tamura <tkent@chromium.org> + + Reviewed by Darin Adler. + + Adds ValidityState.tooLong support for <input> and <textarea>. + + Introduces tooLong() in HTMLFormControlElement and it always returns false. + HTMLInputElement and HTMLTextAreaElement overrides it and checks the text + length and maxLength. tooLong() should work only for `dirty' values. + So, introduces m_isDirty flag for HTMLTextAreaElement, and + !m_data.value().isNull() works as a dirty flag for HTMLInputElement. + + Renames parameter names of setMaxLength(). + + https://bugs.webkit.org/show_bug.cgi?id=27454 + + Tests: fast/forms/ValidityState-tooLong-input.html + fast/forms/ValidityState-tooLong-textarea.html + + * html/HTMLFormControlElement.h: + (WebCore::HTMLFormControlElement::tooLong): + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::tooLong): + (WebCore::HTMLInputElement::setMaxLength): + * html/HTMLInputElement.h: + * html/HTMLTextAreaElement.cpp: + (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): + (WebCore::HTMLTextAreaElement::reset): + (WebCore::HTMLTextAreaElement::updateValue): + (WebCore::HTMLTextAreaElement::setMaxLength): + (WebCore::HTMLTextAreaElement::tooLong): + * html/HTMLTextAreaElement.h: + * html/ValidityState.h: + (WebCore::ValidityState::tooLong): + +2009-09-30 Adam Barth <abarth@webkit.org> + + Reviewed by Maciej Stachowiak. + + Factor RedirectScheduler out of FrameLoader + https://bugs.webkit.org/show_bug.cgi?id=29948 + + This change introduces a new sub-object of Frame, redirectScheduler. + The redirectScheduler is responsible for scheduling redirects. + + This change leaves the code for the redirectScheduler in + FrameLoader.cpp. A future change will move the class into its own + file. + + No behavior change (hopefully!). + + * loader/FrameLoader.cpp: + (WebCore::RedirectScheduler::RedirectScheduler): + (WebCore::RedirectScheduler::~RedirectScheduler): + (WebCore::RedirectScheduler::redirectScheduledDuringLoad): + (WebCore::RedirectScheduler::clear): + (WebCore::FrameLoader::FrameLoader): + (WebCore::FrameLoader::setDefersLoading): + (WebCore::FrameLoader::stopLoading): + (WebCore::FrameLoader::didOpenURL): + (WebCore::FrameLoader::didExplicitOpen): + (WebCore::FrameLoader::cancelAndClear): + (WebCore::FrameLoader::clear): + (WebCore::FrameLoader::checkCompleted): + (WebCore::FrameLoader::isScheduledLocationChangePending): + (WebCore::FrameLoader::scheduleHTTPRedirection): + (WebCore::RedirectScheduler::scheduleRedirect): + (WebCore::RedirectScheduler::mustLockBackForwardList): + (WebCore::FrameLoader::scheduleLocationChange): + (WebCore::RedirectScheduler::scheduleLocationChange): + (WebCore::FrameLoader::scheduleFormSubmission): + (WebCore::RedirectScheduler::scheduleFormSubmission): + (WebCore::FrameLoader::scheduleRefresh): + (WebCore::RedirectScheduler::scheduleRefresh): + (WebCore::RedirectScheduler::locationChangePending): + (WebCore::FrameLoader::scheduleHistoryNavigation): + (WebCore::RedirectScheduler::scheduleHistoryNavigation): + (WebCore::RedirectScheduler::timerFired): + (WebCore::FrameLoader::provisionalLoadStarted): + (WebCore::RedirectScheduler::schedule): + (WebCore::RedirectScheduler::startTimer): + (WebCore::RedirectScheduler::cancel): + (WebCore::FrameLoader::completed): + (WebCore::FrameLoader::open): + * loader/FrameLoader.h: + (WebCore::FrameLoader::committedFirstRealDocumentLoad): + * page/Frame.cpp: + (WebCore::Frame::Frame): + (WebCore::Frame::redirectScheduler): + * page/Frame.h: + +2009-09-30 Maciej Stachowiak <mjs@apple.com> + + Build fix, not reviewed. + + More Windows build fixes for https://bugs.webkit.org/show_bug.cgi?id=29943 + + * platform/network/cf/ResourceHandleCFNet.cpp: + (WebCore::willSendRequest): + +2009-09-30 Maciej Stachowiak <mjs@apple.com> + + Build fix, not reviewed. + + Fix windows build for fix for https://bugs.webkit.org/show_bug.cgi?id=29943 + + * platform/network/cf/ResourceHandleCFNet.cpp: + (WebCore::willSendRequest): + +2009-09-30 Dimitri Glazkov <dglazkov@chromium.org> + + Reviewed by Darin Fisher. + + [V8] HTMLAudioElement, HTMLImageElement, and HTMLOptionElement are constructable, but they shouldn't be. + Only Audio, Image, and Option should be constructable. + https://bugs.webkit.org/show_bug.cgi?id=29940 + + Test: fast/dom/dom-constructor.html + + * WebCore.gypi: Added new files to project. + * bindings/scripts/CodeGeneratorV8.pm: Modified to generate custom constructors. + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::getTemplate): Removed handling of HTMLImageElement, HTMLOptionElement + and HTMLAudioElement construction. + * bindings/v8/V8HTMLAudioElementConstructor.h: Added. + * bindings/v8/V8HTMLImageElementConstructor.h: Added. + * bindings/v8/V8HTMLOptionElementConstructor.h: Added. + * bindings/v8/V8Index.cpp: Added new headers. + * bindings/v8/V8Index.h: Added Audio, Image and Option decls. + * bindings/v8/custom/V8CustomBinding.h: Ditto. + * bindings/v8/custom/V8DOMWindowCustom.cpp: + (WebCore::ACCESSOR_GETTER): Added custom constructors. + * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: + (WebCore::V8HTMLImageElementConstructor::GetTemplate): Added custom template creator. + * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: + (WebCore::V8HTMLOptionElementConstructor::GetTemplate): Ditto. + * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: + (WebCore::V8HTMLImageElementConstructor::GetTemplate): Ditto. + +2009-09-30 Maciej Stachowiak <mjs@apple.com> + + Reviewed by Brady Eidson. + + 307 redirects should pass along http body and Content-Type header + https://bugs.webkit.org/show_bug.cgi?id=29943 + + Follow-up fix for: + <rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET + + Test: http/tests/loading/resources/redirect-methods-result.php + + * platform/network/cf/ResourceHandleCFNet.cpp: + (WebCore::willSendRequest): Pass along http body and Content-Type header. + * platform/network/mac/ResourceHandleMac.mm: + (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): ditto + +2009-09-30 Geoffrey Garen <ggaren@apple.com> + + Reviewed by Mark Rowe. + + Fixed https://bugs.webkit.org/show_bug.cgi?id=29941 + REGRESSION (r48882-r48888): Many memory leaks on SnowLeopard leaks bot + + Forgot to implement a destructor for JSDOMWindowBaseData, so it was + leaking its RefPtr data member. + + * bindings/js/JSDOMWindowBase.cpp: + (WebCore::JSDOMWindowBase::destroyJSDOMWindowBaseData): + * bindings/js/JSDOMWindowBase.h: + (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData::JSDOMWindowBaseData): + +2009-09-30 Dave Hyatt <hyatt@apple.com> + + Reviewed by Tim Hatcher. + + Make sure the removal of user stylesheets results in all of the WebViews being updated to + reflect the changes. + + * page/PageGroup.cpp: + (WebCore::PageGroup::removeUserContentWithURLForWorld): + (WebCore::PageGroup::removeUserContentForWorld): + +2009-09-30 Dan Bernstein <mitz@apple.com> + + Reviewed by Sam Weinig. + + REGRESSION(r47440): drop down menus at americanexpress.com disappear on mouse out + https://bugs.webkit.org/show_bug.cgi?id=29209 + + Test: fast/inline/relative-positioned-overflow.html + + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::computeVerticalOverflow): Add self-painting + inlines to overflow to ensure that they are included in hit-testing. + +2009-09-30 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Mark Rowe. + + transforms/3d tests are not run in Release builds + https://bugs.webkit.org/show_bug.cgi?id=29827 + + Make sure we export the WebCoreHas3DRendering symbol in Release builds, + because this symbols is used by run-webkit-tests (via 'nm') to detect whether + WebCore was built with ENABLE_3D_RENDERING turned on. + + * DerivedSources.make: + * WebCore.3DRendering.exp: Added. + * WebCore.xcodeproj/project.pbxproj: + +2009-09-30 Jeremy Orlow <jorlow@chromium.org> + + Build fix for QT. Didn't know WebCore.pro existed. + + * WebCore.pro: + +2009-09-30 Dave Hyatt <hyatt@apple.com> + + Reviewed by Adam Roben. + + Add a method for removal of user scripts and stylesheets by URL from a specific world. + + * page/PageGroup.cpp: + (WebCore::PageGroup::removeUserContentURLForWorld): + * page/PageGroup.h: + +2009-09-30 Chris Hawk <hawk@chromium.org> + + Reviewed by Dimitri Glazkov. + + Fix for conditionals in the WebCore gyp file, which contained two separate + 'conditions' values for the webcore target. The first entry was ignored, + resulting in some missine defines. + https://bugs.webkit.org/show_bug.cgi?id=29907 + + * WebCore.gyp/WebCore.gyp: + +2009-09-21 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Adam Barth. + + DOM Storage needs to be more careful about where "ThreadSafe" objects are destroyed. + https://bugs.webkit.org/show_bug.cgi?id=29265 + + DOM Storage needs to be more careful about where "ThreadSafe" objects are + destroyed. With the current code, there actually isn't a race condition, but + it sure would be easy for someone to introduce one. A bunch of + ThreadSafeShared objects have RefPtrs to objects that are NOT ThreadSafeShared + objects. If it were possible any of these objects' destructors to be fired off + the main thread, then the you'd have a race condition. The code should be more + clear and self-documenting about how things related to each other. + + Since the lifetime of a LocalStorageTask is bounded by the LocalStorageThread + which is bounded by the StorageSyncManager, StorageAreaImpl, and + StorageAreaSync, there's no reason for LocalStorageTask to store anything other + than pointers. By breaking this dependency, we can eliminate the risk. + + Note that we _could_ have LocalStorageThread's task queue just store + LocalStorageTask*'s rather than RefPtr<LocalStorageTask>s but then we'd need to + manually take care of deleting. It'd probably also be possible to change + LocalStorageThread around so that it needn't hold onto a reference of itself + and have a more deterministic shutdown, but my initial attempts to do so + failed, and I decided it wasn't worth changing. The queue is killed before + hand, so the thread is 100% impotent before the main thread continues anyway. + + The constructors and destructors of StorageSyncManager, StorageAreaImpl, and + StorageAreaSync now have ASSERTs to verify they're running on the main thread. + I'm fairly positive that it'd be impossible to hit these asserts and the fact + that these classes are no longer ThreadSafeShared should make it clear how + they're meant to be used, but I think it's worth it to be extra sure. Of + course, ideally, we'd have such an assert every time a ref is incremented or + decremented. + + Behavior should be unchanged and this is just an internal code cleanup, so no + new tests. + + * storage/LocalStorageTask.cpp: + (WebCore::LocalStorageTask::LocalStorageTask): + (WebCore::LocalStorageTask::performTask): + * storage/LocalStorageTask.h: + (WebCore::LocalStorageTask::createImport): + (WebCore::LocalStorageTask::createSync): + (WebCore::LocalStorageTask::createTerminate): + * storage/LocalStorageThread.cpp: + (WebCore::LocalStorageThread::scheduleImport): + (WebCore::LocalStorageThread::scheduleSync): + * storage/LocalStorageThread.h: + * storage/StorageArea.h: + * storage/StorageAreaImpl.cpp: + (WebCore::StorageAreaImpl::~StorageAreaImpl): + (WebCore::StorageAreaImpl::StorageAreaImpl): + * storage/StorageAreaSync.cpp: + (WebCore::StorageAreaSync::StorageAreaSync): + (WebCore::StorageAreaSync::~StorageAreaSync): + * storage/StorageSyncManager.cpp: + (WebCore::StorageSyncManager::StorageSyncManager): + (WebCore::StorageSyncManager::~StorageSyncManager): + (WebCore::StorageSyncManager::scheduleImport): + (WebCore::StorageSyncManager::scheduleSync): + * storage/StorageSyncManager.h: + +2009-09-28 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Darin Fisher. + + Chromium needs to be able to override the way storage events are delivered + https://bugs.webkit.org/show_bug.cgi?id=29655 + + Chromium needs to be able to override the way storage events are delivered. + This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be + faster (no vtables and extra allocation) and somewhat cleaner (no dependency + injection). This is necessary because Chromium needs to transport events across + a process barrier and then dispatch them without use of a Frame*. + + Behavior should not change with this, so no updates to tests. + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * WebCoreSources.bkl: + * storage/StorageAreaImpl.cpp: + (WebCore::StorageAreaImpl::setItem): + (WebCore::StorageAreaImpl::removeItem): + (WebCore::StorageAreaImpl::clear): + * storage/StorageAreaImpl.h: + * storage/StorageEventDispatcher.cpp: Copied from WebCore/storage/StorageAreaImpl.cpp. + (WebCore::StorageEventDispatcher::dispatch): + * storage/StorageEventDispatcher.h: Added. (Well, technically in the other half of this patch.) + +2009-09-30 Jian Li <jianli@chromium.org> + + Reviewed by Darin Adler. + + Need to check NULL frame in EventHandler::updateDragAndDrop. + https://bugs.webkit.org/show_bug.cgi?id=29929 + + Test: http/tests/misc/drag-over-iframe-invalid-source-crash.html + + * page/EventHandler.cpp: + (WebCore::EventHandler::updateDragAndDrop): + +2009-09-29 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dan Bernstein. + + ASSERTION FAILED: !repaintContainer || repaintContainer == this + https://bugs.webkit.org/show_bug.cgi?id=29755 + + Generalize the fix for this bug to account for cases where there may be multiple + containing blocks between the repaint container, and the container of the element + being repainted. + + Test: compositing/repaint/opacity-between-absolute2.html + + * rendering/RenderBox.cpp: + (WebCore::RenderBox::mapLocalToContainer): + Call offsetFromAncestorContainer() to get the correct offset. + + (WebCore::RenderBox::computeRectForRepaint): Ditto + * rendering/RenderInline.cpp: + (WebCore::RenderInline::computeRectForRepaint): Ditto. + + * rendering/RenderObject.h: + * rendering/RenderObject.cpp: + (WebCore::RenderObject::offsetFromAncestorContainer): + New method that computes an offset from some object in the ancestor container() chain. + +2009-09-30 Andras Becsi <becsi.andras@stud.u-szeged.hu> + + Reviewed by Simon Hausmann. + + [Qt] Fix TextCodecQt::decode method after r48752 to return a non-null string if the length of the input is 0. + This fixes https://bugs.webkit.org/show_bug.cgi?id=29736. + + * platform/text/qt/TextCodecQt.cpp: + (WebCore::TextCodecQt::decode): + 2009-09-29 Dave Hyatt <hyatt@apple.com> Reviewed by Jon Honeycutt. @@ -582,7 +14028,7 @@ * platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish): -009-09-29 Pavel Feldman <pfeldman@chromium.org> +2009-09-29 Pavel Feldman <pfeldman@chromium.org> Reviewed by Timothy Hatcher. @@ -1655,7 +15101,7 @@ can't happen when working with JavaScript since the Element will be kept alive due to the change above. (WebCore::NamedNodeMap::addAttribute): Fix function name in comment. - (WebCore::NamedNodeMap::removeAttribute): Removed unneeded "+ 1" and added + (WebCore::NamedNodeMap::removeAttribute): Removed unneeded "1" and added missing braces. * dom/NamedAttrMap.h: Made the element function public so it can be used by @@ -1778,7 +15224,7 @@ 1. if the insertion node has a non opaque background color and one of the parent element did have a solid background color the new paragraph did not have the element with the solid color in the tree. 2. in some circumstances it generated more markup than the original paragraph had (a span with bold, italic, - background color and some font attribute was being reproduced as span + bold + italic + font as separate tags. + background color and some font attribute was being reproduced as span bold italic font as separate tags. The new approach is to recreate in the new paragraph the same hierarchy of nodes found in the paragraph where the insertion point is. @@ -2114,7 +15560,7 @@ Reviewed by Oliver Hunt. - Implement correct horizontal scrollbar behavior for GTK+ also on + Implement correct horizontal scrollbar behavior for GTKalso on styled scrollbars. https://bugs.webkit.org/show_bug.cgi?id=29348 @@ -3988,7 +17434,7 @@ 2009-09-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> - Unreviewed build fix for GTK+ and a blind one for Qt after r48566. + Unreviewed build fix for GTKand a blind one for Qt after r48566. * GNUmakefile.am: * WebCore.pro: @@ -4742,7 +18188,7 @@ Reviewed by Oliver Hunt. <rdar://problem/7007541> - CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator... + CrashTracer: 4800crashes in Safari at com.apple.WebKit • WTF::HashTableIterator... Make RuntimeObjectImp more robust against m_instance being a null (which can happen if an OOP plug-in crashes while we're calling into it). @@ -6024,7 +19470,7 @@ Reviewed by Dan Bernstein. - <rdar://problem/7047282> Safari crashes at WebCore::RenderMenuList::adjustInnerStyle() + 436 + <rdar://problem/7047282> Safari crashes at WebCore::RenderMenuList::adjustInnerStyle() 436 Avoid a crash when a mouse event handler on a <select> changes the select from a popup to a list (by setting the 'size' property) inside the event handler. @@ -7040,7 +20486,7 @@ Reviewed by Gustavo Noronha. - Build fix for GTK+ after r48267. + Build fix for GTKafter r48267. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::buffered): @@ -8081,7 +21527,7 @@ 2009-09-08 Xan Lopez <xlopez@igalia.com> - Unreviewed attempt to fix the GTK+ build. + Unreviewed attempt to fix the GTKbuild. * GNUmakefile.am: @@ -13747,7 +27193,7 @@ do not set playbin's audio sink. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: * platform/graphics/gtk/VideoSinkGStreamer.cpp: - (webkit_video_sink_idle_func): Use C++ casts, decrease reference count of async + (webkit_video_sink_idle_func): Use C+casts, decrease reference count of async queue at the end of the idle function. (webkit_video_sink_render): Increase reference count of async queue. (webkit_video_sink_stop): Remove any idle functions with the sink as data. @@ -15508,7 +28954,7 @@ Reviewed by Eric Seidel. - Add 'icu::' qualifier when refering to ICU C++ names to the other + Add 'icu::' qualifier when refering to ICU C+names to the other file with this issue missed in the previous check-in. https://bugs.webkit.org/show_bug.cgi?id=28410 @@ -15791,7 +29237,7 @@ Reviewed by Eric Seidel - Add 'icu::' qualifier when refering to ICU C++ names. + Add 'icu::' qualifier when refering to ICU C+names. https://bugs.webkit.org/show_bug.cgi?id=28410 @@ -19969,7 +33415,7 @@ form controls that have different validity states. Reviewed by Sam Weinig. <rdar://problem/6952336> - CrashTracer: [USER] 3 crashes in Safari at com.apple.WebCore • WebCore::SecurityOrigin::canAccess const + 27 + CrashTracer: [USER] 3 crashes in Safari at com.apple.WebCore • WebCore::SecurityOrigin::canAccess const 27 Make sure to set the security origin before calling dispatchWindowObjectAvailable. @@ -20293,11 +33739,11 @@ form controls that have different validity states. Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=28204 - Allow C++ exceptions to be disabled in WebCore's V8 Mac build. + Allow C+exceptions to be disabled in WebCore's V8 Mac build. * WebCorePrefix.h: Only undefine |try| and |catch| when building Objective-C[++], - leaving the C++ library definitions intact for C++. + leaving the C+library definitions intact for C++. 2009-08-12 Nate Chapin <japhet@chromium.org> @@ -21347,7 +34793,7 @@ form controls that have different validity states. Reviewed by Darin Fisher. - Cleanup DOM Storage namespace shutdown code + usage of security origin. + Cleanup DOM Storage namespace shutdown code usage of security origin. https://bugs.webkit.org/show_bug.cgi?id=28094 If a storage namespace is not explicitly closed, be sure to do so on @@ -21454,7 +34900,7 @@ form controls that have different validity states. 2009-08-10 Xan Lopez <xlopez@igalia.com> - Fix GTK+ build. + Fix GTKbuild. * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::): @@ -21468,7 +34914,7 @@ form controls that have different validity states. * platform/graphics/GlyphBuffer.h: Removed advanceData(). * platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::drawText): Changed to use advances(from) - instead of advanceData() + from. + instead of advanceData() from. 2009-08-10 Xan Lopez <xlopez@igalia.com> @@ -21781,7 +35227,7 @@ form controls that have different validity states. Modify FrameLoadType enum to match the order of WebFrameLoadType in WebFramePrivate.h / IWebFramePrivate.idl. The mac/win public API exposes the old 'FrameLoadTypeReloadAllowingStaleData' value, which resides between - 'FrameLoadTypeReload' and 'FrameLoadTypeSame'. Work around this problem, by assigning 'FrameLoadTypeSame = FrameLoadTypeReload + 2'. + 'FrameLoadTypeReload' and 'FrameLoadTypeSame'. Work around this problem, by assigning 'FrameLoadTypeSame = FrameLoadTypeReload 2'. Add a note to the FrameLoadType enum to keep it in sync with WebFramePrivate.h & IWebFramePrivate.idl. @@ -29091,7 +42537,7 @@ form controls that have different validity states. I decided to change these to Base:: instead of DOMObjectWithGlobal:: for future-proofing. All autogenerated classes use a typedef Base - to avoid bugs like these. Sadly C++ does not have a built-in super:: we could use. + to avoid bugs like these. Sadly C+does not have a built-in super:: we could use. * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSAbstractWorkerCustom.cpp: @@ -29959,7 +43405,7 @@ form controls that have different validity states. 2009-07-22 Xan Lopez <xlopez@igalia.com> - Attempt to fix the GTK+ build. + Attempt to fix the GTKbuild. * GNUmakefile.am: @@ -36020,7 +49466,7 @@ form controls that have different validity states. Crash in RenderMedia::styleDidChange. <rdar://problem/7044313> CrashTracer: quicklook crashed generating thumbnail for page with - media element (RenderMedia::styleDidChange + 115) + media element (RenderMedia::styleDidChange 115) Speculative fix for crash in styleDidChange. Null check controller elements before tell them to update style. @@ -37138,7 +50584,7 @@ form controls that have different validity states. Not reviewed, Chromium build fix. - Add in missing header + fix syntax issue that crept into last patch. + Add in missing header fix syntax issue that crept into last patch. https://bugs.webkit.org/show_bug.cgi?id=27027 * rendering/RenderThemeChromiumMac.mm: @@ -37969,7 +51415,7 @@ form controls that have different validity states. Report the caret offset from the end of the selection, otherwise we'll report the same offset when moving the caret while - modififying the selection (eg, with Shift + Right). + modififying the selection (eg, with Shift Right). * editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange): @@ -39238,7 +52684,7 @@ form controls that have different validity states. Reviewed by Geoff Garen. - <rdar://problem/6960286> CrashTracer: [REGRESSION] 1120 crashes in Safari at com.apple.WebCore WebCore::JSLazyEventListener::parseCode const + 62 + <rdar://problem/6960286> CrashTracer: [REGRESSION] 1120 crashes in Safari at com.apple.WebCore WebCore::JSLazyEventListener::parseCode const 62 <select> elements and other elements the produce popups can keep their popups live across a page load. If this occurs and the <select> element has an @@ -39894,7 +53340,7 @@ form controls that have different validity states. Reviewed by Jan Alonzo. - [GTK] Don't use deprecated GTK+ symbols. + [GTK] Don't use deprecated GTKsymbols. https://bugs.webkit.org/show_bug.cgi?id=26583 * plugins/gtk/gtk2xtbin.c: @@ -45387,7 +58833,7 @@ form controls that have different validity states. Reviewed by Brady Eidson. - <rdar://problem/6660037> CrashTracer: [USER] 46 crashes in Safari at com.apple.WebCore • WebCore::CachedCSSStyleSheet::addClient + 53 + <rdar://problem/6660037> CrashTracer: [USER] 46 crashes in Safari at com.apple.WebCore • WebCore::CachedCSSStyleSheet::addClient 53 When revalidating a resource, calling addClient() on one client might cause another to get removed. @@ -45449,7 +58895,7 @@ form controls that have different validity states. Update of https://bugs.webkit.org/show_bug.cgi?id=26353. Provide an assignment operator to avoid improper reference counts on the Cairo font objects. This brings the Windows - Cairo port in line with the GTK+ port. + Cairo port in line with the GTKport. * platform/graphics/win/FontPlatformData.h: * platform/graphics/win/FontPlatformDataCairoWin.cpp: |