| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Change copyrights and license headers from Nokia to Digia
Change-Id: I9f5c8a9135271161e2bce50bc413ea01a08c3a76
Reviewed-by: Akseli Salovaara <akseli.salovaara@digia.com>
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
|
|
|
|
|
|
| |
This backport part of the commit 480b395bd652a4ac6e3f2
Task-number: QTBUG-6416
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
|
|
|
| |
The functionality is broken, since pointers can be released by a
QSharedPointer tracking a pointer of different type, which would leave
behind pointers in the hash.
The fix requires Qt 4.6 because of a new symbol being added.
|
|
|
|
|
|
|
|
|
|
| |
during application desctruction globalEngineCache is deleted as part
of Q_GLOBAL_STATIC macro. Other instances of code that happen to use
QRegex after the cache destruction will subsequently crash. Most common
reason are other Q_GLOBAL_STATIC instances which happen to use QRegExp
as part of their destructor.
Reviewed-by: Rhys Weatherley
|
|
|
|
| |
Reviewed-by: trustme
|
|
|
|
|
|
|
| |
This is related to the following fix:
70137e0601549af1056082cdfbb4f141c70befab
Reviewed-by: trustme
|
|
|
|
|
|
|
|
|
| |
enabled.
This allows mixing of debug and non-debug code (possible on Unix
systems) without causing assertion failures.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
|
|
|
|
|
|
| |
Two strings are only equal if they have the same size.
Task-number: 256763
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In 4.4 QRectF handled flat rectangles in the same fashion as QRect does,
but that changed with Lars' and Jo's optmizations done in the falcon
branch. The difference is that the optimized version only checks whether
the width or height is 0, whereas in 4.4 both had to be 0 (isNull()) before
we bailed out.
This regression also introduced a regression in
QGraphicsItem::childrenBoundingRect().
Auto-test included.
Task-number: 254995
Reviewed-by: Lars
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Task-number: 245501
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
|
|
| |
I tested it with 32 bits compilation and there is no warning any more.
Task-number: 247325
Reviewed-by: ogoffart
|
|
|
|
| |
Reviewed-by: David Boddie
|
|
|
|
| |
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's wrong to assume that static_cast<> is allowed everywhere where
dynamic_cast<> is allowed. For example, if class C derives from both A
and B, then you can dynamic_cast<B *>(ptr_to_A), but you can't
static_cast.
So introduce a helper for dynamic casts that doesn't do
static_cast.
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
| |
Usually, "the the" is not proper English
Reviewed-By: Thiago Macieira
|
|
|
|
|
|
|
|
| |
Highlight part of the general description in QTimeLine
Task-number: 218487
Rev-by: Geir Vattekar
|
| |
|
| |
|
|
|
|
|
|
|
| |
Clearifying details about bit size of the wchar_t input and the way they are handled.
Task-number:227709
Rev-by: Marius Storm-Olsen
|
| |
|
| |
|
|
|
|
|
|
| |
The d->capacity could be modified even if ref was more than 1
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
|
| |
Added a comment about the use of negative indexes.
Task-number: 249344
Rev-by: Marius Storm-Olsen
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Copy constructor and assignment operator lose data: pointer to content
and the length of content also need to be copied over.
QByteArrayMatcher::pattern() would return a null byte array if instance
was initialized with c-string.
Changed default constructor to explicitly initialize pattern length to
zero.
The bug in the assignment operator is a regression against 4.4.3.
Task-number: 251958
Reviewed-by: MariusSO
Reviewed-by: paul
|
|
|
|
| |
Signed-off-by: Thiago Macieira <thiago.macieira@nokia.com>
|
|
|
|
|
|
|
|
|
|
| |
When QString::replace was optimized, this specific overload missed out
on sanity checking of the arguments.
Task-number: 249517
Reviewed-by: Joao
Reviewed-by: hjk
BT: yes
|
|
|
|
| |
Reviewed-by: hjk <qtc-committer@nokia.com>
|
|
|
|
| |
Reviewed-by: Trust me
|
|
|
|
|
|
| |
qWarning and qFatal should be in Latin1.
Reviewed-by: Thiago
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to our documentation we should ignore leading and trailing
whitespaces when converting a string to number with QLocale::toInt and
similar functions. However that didn't work for some locales - for
those ones that declare groupseparator as 0xa0 (which looks similar to
space) since we provide a workaround to accept space as a group
separator for those locales. And since the workaround was there for a
long time it doesn't make sense to change the behavior and the fix is
to explicitely remove leading and trailing whitespaces before doing
any conversion.
Reviewed-by: mariusSO
|
|
|
|
|
|
|
|
|
|
|
|
| |
application.
If it's used as a static, then the order of destruction is
ill-defined. The QSharedPointer object may be destroyed after our
Q_GLOBAL_STATIC knownPointers has been deleted, thus causing a
null-pointer dereference.
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
Task-number: 246843
|
|
|