From 0246abe1b029a59d804182bd9496f1c2c5ee7d7f Mon Sep 17 00:00:00 2001 From: Rohan McGovern Date: Fri, 5 Oct 2012 16:05:33 +1000 Subject: tst_qfiledialog: fixed typo causing semi-random completer() failure completer_data() was attempting to find the first folder which did not begin with a '.' character under QDir::root() for usage during the test. However, a typo caused it to find the first folder even if it _did_ begin with a '.'; unless the first folder returned by entryList() was ".", in which case no folder would be found. (cherry picked from qtbase commit 0776746d47c9b0d575b6190b1882c571a76ee086) Change-Id: I1d98afa071ea4300e4e2f0aa324e8c1fd8a0728e Reviewed-by: Sergio Ahumada Reviewed-by: Marc Mutz --- tests/auto/qfiledialog/tst_qfiledialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/auto/qfiledialog/tst_qfiledialog.cpp b/tests/auto/qfiledialog/tst_qfiledialog.cpp index 8342b5fbc5..8e69b3c3da 100644 --- a/tests/auto/qfiledialog/tst_qfiledialog.cpp +++ b/tests/auto/qfiledialog/tst_qfiledialog.cpp @@ -430,7 +430,7 @@ void tst_QFiledialog::completer_data() QStringList list = root.entryList(); QString folder; for (int i = 0; i < list.count(); ++i) { - if (list.at(0) == QChar('.')) + if (list[i].at(0) == QChar('.')) continue; QFileInfo info(QDir::rootPath() + list[i]); if (info.isDir()) { -- cgit v1.2.3