diff options
| author | Paul Lemire <paul.lemire@kdab.com> | 2020-07-07 09:13:03 +0200 |
|---|---|---|
| committer | Paul Lemire <paul.lemire@kdab.com> | 2020-07-09 08:02:15 +0200 |
| commit | 80519df3768404e658614b882e320aded90d6030 (patch) | |
| tree | 9a72d9b18b44d85bfa6028291d0eed8e941c89fc | |
| parent | e8a6190d781da8ba4d11dcf5962d21055f2bcce8 (diff) | |
rhi/renderer: small tidies
Change-Id: I794a8c205e576b01eceb0d8b117aa643bec29fdc
Reviewed-by: Mike Krus <mike.krus@kdab.com>
Reviewed-by: Jean-Michaël Celerier <jean-michael.celerier@kdab.com>
| -rw-r--r-- | src/plugins/renderers/rhi/renderer/renderer.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/plugins/renderers/rhi/renderer/renderer.cpp b/src/plugins/renderers/rhi/renderer/renderer.cpp index 06b1924d3..a8cd0a161 100644 --- a/src/plugins/renderers/rhi/renderer/renderer.cpp +++ b/src/plugins/renderers/rhi/renderer/renderer.cpp @@ -1297,7 +1297,7 @@ std::vector<Renderer::RHIPassInfo> Renderer::prepareCommandsSubmission(const std::vector<RenderView *> &renderViews) { // TO DO: Find a central place to initialize RHI resources - const int renderViewCount = renderViews.size(); + const size_t renderViewCount = renderViews.size(); // We need to have a single RHI RenderPass per RenderTarget // as creating the pass clears the buffers @@ -1305,14 +1305,14 @@ Renderer::prepareCommandsSubmission(const std::vector<RenderView *> &renderViews // and submit all of these as part of the same RHI pass std::vector<RHIPassInfo> rhiPassesInfo; - for (int i = 0; i < renderViewCount;) { + for (size_t i = 0; i < renderViewCount;) { std::vector<RenderView *> sameRenderTargetRVs; std::vector<QRhiBuffer *> rvUbos; RenderView *refRV = renderViews.at(i); sameRenderTargetRVs.push_back(refRV); for (i = i + 1; i < renderViewCount; ++i) { - RenderView *curRV = renderViews.at(i); + RenderView *curRV = renderViews[i]; if (refRV->renderTargetId() == curRV->renderTargetId()) { sameRenderTargetRVs.push_back(curRV); } else @@ -1327,8 +1327,8 @@ Renderer::prepareCommandsSubmission(const std::vector<RenderView *> &renderViews rhiPassesInfo.push_back(bucket); } - for (int i = 0; i < renderViewCount; ++i) { - RenderView *rv = renderViews.at(i); + for (size_t i = 0; i < renderViewCount; ++i) { + RenderView *rv = renderViews[i]; rv->forEachCommand([&] (RenderCommand &command) { // Update/Create GraphicsPipelines if (command.m_type == RenderCommand::Draw) { |