summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Lemire <paul.lemire@kdab.com>2020-08-21 13:04:26 +0200
committerPaul Lemire <paul.lemire@kdab.com>2021-06-04 04:36:40 +0000
commitdc45c599304dfb61b44646773a3d23507c4fbe1f (patch)
tree1724a166f4629517f19042b607974fba070df1f6
parent6704dfddcb6630809abc55b420dd125aa292922e (diff)
ClearBuffers: fix member initialization from uninitialized value
Change-Id: I7f1b2f3bca78f16abac49fa8686522aebf393d7c Reviewed-by: Mike Krus <mike.krus@kdab.com> (cherry picked from commit 312890f18b77cd898ca2ab1f93331e2f56d5cd80) Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
-rw-r--r--src/render/framegraph/clearbuffers.cpp2
-rw-r--r--src/render/framegraph/clearbuffers_p.h2
2 files changed, 3 insertions, 1 deletions
diff --git a/src/render/framegraph/clearbuffers.cpp b/src/render/framegraph/clearbuffers.cpp
index d730123c3..caea121aa 100644
--- a/src/render/framegraph/clearbuffers.cpp
+++ b/src/render/framegraph/clearbuffers.cpp
@@ -56,6 +56,8 @@ static QVector4D vec4dFromColor(const QColor &color)
ClearBuffers::ClearBuffers()
: FrameGraphNode(FrameGraphNode::ClearBuffers)
, m_type(QClearBuffers::None)
+ , m_clearColorAsColor(Qt::black)
+ , m_clearColor(vec4dFromColor(m_clearColorAsColor))
, m_clearDepthValue(1.f)
, m_clearStencilValue(0)
{
diff --git a/src/render/framegraph/clearbuffers_p.h b/src/render/framegraph/clearbuffers_p.h
index e3c56c165..e84290093 100644
--- a/src/render/framegraph/clearbuffers_p.h
+++ b/src/render/framegraph/clearbuffers_p.h
@@ -90,8 +90,8 @@ private:
void initializeFromPeer(const Qt3DCore::QNodeCreatedChangeBasePtr &change) final;
QClearBuffers::BufferType m_type;
- QVector4D m_clearColor;
QColor m_clearColorAsColor;
+ QVector4D m_clearColor;
float m_clearDepthValue;
int m_clearStencilValue;
Qt3DCore::QNodeId m_colorBufferId;