summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Lemire <paul.lemire@kdab.com>2021-10-18 11:23:33 +0200
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2021-11-03 13:28:41 +0000
commit34d219ce0214978ca405194cce91c225e914098c (patch)
tree245cb54d185966685ff7534e0a426edd737681e8
parent1252b7f50db344a93d4924fd617b77a82eaaa703 (diff)
ObjectPicker: markDirty(AllDirty) when we change the enabled property
Otherwise we would simply change it internally but this wouldn't lead to any actual changes in how we handle pick events. Change-Id: I71aedc74db538978a939620d053af3167fd67dc4 Reviewed-by: Sean Harmer <sean.harmer@kdab.com> (cherry picked from commit d32ff6b43b92474de495c88783a67b0b30211a7c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
-rw-r--r--src/render/picking/objectpicker.cpp9
1 files changed, 7 insertions, 2 deletions
diff --git a/src/render/picking/objectpicker.cpp b/src/render/picking/objectpicker.cpp
index 35b5455d7..5c81aedb9 100644
--- a/src/render/picking/objectpicker.cpp
+++ b/src/render/picking/objectpicker.cpp
@@ -80,13 +80,16 @@ void ObjectPicker::syncFromFrontEnd(const Qt3DCore::QNode *frontEnd, bool firstT
if (!node)
return;
- BackendNode::syncFromFrontEnd(frontEnd, firstTime);
-
if (firstTime) {
markDirty(AbstractRenderer::AllDirty);
notifyJob();
}
+ if (isEnabled() != node->isEnabled()) {
+ markDirty(AbstractRenderer::AllDirty);
+ // We let QBackendNode::syncFromFrontEnd change the enabled property
+ }
+
if (node->isHoverEnabled() != m_hoverEnabled) {
m_hoverEnabled = node->isHoverEnabled();
markDirty(AbstractRenderer::AllDirty);
@@ -104,6 +107,8 @@ void ObjectPicker::syncFromFrontEnd(const Qt3DCore::QNode *frontEnd, bool firstT
markDirty(AbstractRenderer::AllDirty);
notifyJob();
}
+
+ BackendNode::syncFromFrontEnd(frontEnd, firstTime);
}
void ObjectPicker::notifyJob()