Scene3DItem: fix assert when changing window

In Scene3DItem::updatePaintNode(), in the Render thread, we try to set
the parent of the aspect engine being deleted to nullptr. This was
triggering an assert in QCoreApplication::sendEvent(), since the aspect
engine lives in a different thread, the Main thread.

Don't trigger this assert by avoiding to send ChildAdded/ChildRemoved
events when reparenting the aspect manager, thanks to the
QQml_setParent_noEvent utility.

Change-Id: Ic816701ee65654f7b18b4998c54feb4840af0a14
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
(cherry picked from commit 63a9c3e314364765437f641454637611c2479672)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>

1 files changed, 6 insertions, 1 deletions

diff --git a/src/quick3d/imports/scene3d/scene3ditem.cpp b/src/quick3d/imports/scene3d/scene3ditem.cpp
index eb960a8dc..d1f1cea72 100644
--- a/src/quick3d/imports/scene3d/scene3ditem.cpp
+++ b/src/quick3d/imports/scene3d/scene3ditem.cpp
@@ -26,6 +26,7 @@
 
 #include <QtGui/qguiapplication.h>
 #include <QtGui/qoffscreensurface.h>
+#include <QtQml/private/qqmlglobal_p.h>
 #include <QtQuick/qquickwindow.h>
 #include <QtQuick/qquickrendercontrol.h>
 
@@ -742,9 +743,13 @@ QSGNode *Scene3DItem::updatePaintNode(QSGNode *node, QQuickItem::UpdatePaintNode
             qCWarning(Scene3D) << "Renderer for Scene3DItem has requested a reset due to the item "
                                   "moving to another window";
             QObject::disconnect(m_windowConnection);
+            // We are in the Render thread, and the m_aspectEngineDestroyer lives in the Main
+            // thread, so we must avoid sending ChildRemoved or ChildAdded events to it with a
+            // QObject::setParent(). QCoreApplication::sendEvent() would fail with "Cannot
+            // send events to objects owned by a different thread."
+            QQml_setParent_noEvent(m_aspectEngine, nullptr);
             // Note: AspectEngine can only be deleted once we have set the root
             // entity on the new instance
-            m_aspectEngine->setParent(nullptr);
             m_aspectToDelete = m_aspectEngine;
             m_aspectEngine = nullptr;
         }