GLTexture: don't assert on empty image data contentv5.11.1

Having empty image data is possible under these circumstances:
- invalid url in the generator
- generator not yet initialized
- empty QTextureImage created

These are therefore valid use cases where we should rather help user diagnose
the issue (e.g warn invalid path) rather than forcefully asserting.

Change-Id: I14b705dddf775136ec1a719ba2d9ec995368e62e
Task-Id: QTBUG-68805
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>

1 files changed, 8 insertions, 1 deletions

diff --git a/src/render/renderers/opengl/textures/gltexture.cpp b/src/render/renderers/opengl/textures/gltexture.cpp
index 4286a69b6..63b354a14 100644
--- a/src/render/renderers/opengl/textures/gltexture.cpp
+++ b/src/render/renderers/opengl/textures/gltexture.cpp
@@ -151,8 +151,15 @@ QOpenGLTexture* GLTexture::getOrCreateGLTexture()
         int maxMipLevel = 0;
         for (const Image &img : qAsConst(m_images)) {
             const QTextureImageDataPtr imgData = m_textureImageDataManager->getData(img.generator);
+            // imgData may be null in the following cases:
+            // - Texture is created with TextureImages which have yet to be
+            // loaded (skybox where you don't yet know the path, source set by
+            // a property binding, queued connection ...)
+            // - TextureImage whose generator failed to return a valid data
+            // (invalid url, error opening file...)
+            if (imgData.isNull())
+                continue;
 
-            Q_ASSERT(imgData);
             m_imageData.push_back(imgData);
             maxMipLevel = qMax(maxMipLevel, img.mipLevel);